)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b6d5dcd5f50962a167d5619ee8b342183bbf9b5b","unresolved":true,"context_lines":[{"line_number":14,"context_line":"DhcpAgentNotification option to be False by default and enables it only"},{"line_number":15,"context_line":"when neutron-dhcp-agent is going to be deployed."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #1937035"},{"line_number":18,"context_line":"Change-Id: I5f8ad32a9fa888dec6b26c0185f8b506521bd6e3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"12265975_4a43e92b","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":10},"updated":"2021-07-22 11:20:51.000000000","message":"the change makes sense as described here, I am just concerned about switching the default like this as this type of change has always been a source of problems for us in the past).\n\nFYI as far as i can see there was exactly one example of that so far https://bugs.launchpad.net/tripleo/+bug/1937035/comments/4 then we had 2 green runs so the job is \u0027fixed\u0027 somehow. \n\nhttps://review.rdoproject.org/zuul/builds?job_name\u003dperiodic-tripleo-ci-centos-8-ovb-1ctlr_1comp-featureset002-wallaby","commit_id":"cbbcefef3d3ace72142dac0b2388edbf053f4674"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"17bdaea2fdf7f3d2b24837bd606055d08bbc66b3","unresolved":true,"context_lines":[{"line_number":14,"context_line":"DhcpAgentNotification option to be False by default and enables it only"},{"line_number":15,"context_line":"when neutron-dhcp-agent is going to be deployed."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #1937035"},{"line_number":18,"context_line":"Change-Id: I5f8ad32a9fa888dec6b26c0185f8b506521bd6e3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"33c72295_5b9ba950","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":10},"in_reply_to":"12265975_4a43e92b","updated":"2021-08-31 10:35:48.000000000","message":"I saw similar issues in other jobs too. Maybe not always it is causing CI failures but for sure it is slowing down Neutron when it is trying to connect to rabbitmq server while it\u0027s not necessary.","commit_id":"cbbcefef3d3ace72142dac0b2388edbf053f4674"}],"deployment/neutron/neutron-dhcp-container-puppet.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5744ed3c60147f6d68973eff9b1e8c90cc01807b","unresolved":true,"context_lines":[{"line_number":144,"context_line":"                 certificate for this service"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"parameter_defaults:"},{"line_number":147,"context_line":"  DhcpAgentNotification: true"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"conditions:"},{"line_number":150,"context_line":"  dhcp_ovs_intergation_bridge_set:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fecf4b88_6035b5cd","line":147,"updated":"2021-07-22 15:09:57.000000000","message":"ok, this causes failure of some jobs, like https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_fe1/801761/1/check/tripleo-ci-centos-8-containers-multinode/fe11d30/logs/undercloud/home/zuul/undercloud_install.log\nI think I will need help from some OOO experts on how to do it properly then 😊","commit_id":"cbbcefef3d3ace72142dac0b2388edbf053f4674"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2abe458ddda7f48a176a35fbdebac58b383473cc","unresolved":true,"context_lines":[{"line_number":144,"context_line":"                 certificate for this service"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"parameter_defaults:"},{"line_number":147,"context_line":"  DhcpAgentNotification: true"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"conditions:"},{"line_number":150,"context_line":"  dhcp_ovs_intergation_bridge_set:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d8438ee8_e1c99334","line":147,"in_reply_to":"2c7355e1_d849ffb2","updated":"2021-08-09 14:42:43.000000000","message":"parameter_defaults don\u0027t go in these service files as the default would be from deploment/neutron/neutron-base.yaml. So yes you need to put this in an environment file that pulls in this service.  A grep shows:\n\nci/environments/scenario007-standalone.yaml:  OS::TripleO::Services::NeutronDhcpAgent: ../../deployment/neutron/neutron-dhcp-container-puppet.yaml\nci/environments/scenario012-standalone.yaml:  OS::TripleO::Services::NeutronDhcpAgent: ../../deployment/neutron/neutron-dhcp-container-puppet.yaml\nci/environments/scenario007-multinode-containers.yaml:  OS::TripleO::Services::NeutronDhcpAgent: ../../deployment/neutron/neutron-dhcp-container-puppet.yaml\nenvironments/neutron-ovs-dvr.yaml:  OS::TripleO::Services::NeutronDhcpAgent: ../deployment/neutron/neutron-dhcp-container-puppet.yaml\nenvironments/undercloud.yaml:  OS::TripleO::Services::NeutronDhcpAgent: ../deployment/neutron/neutron-dhcp-container-puppet.yaml\nenvironments/services/ironic-overcloud.yaml:  OS::TripleO::Services::NeutronDhcpAgent: ../../deployment/neutron/neutron-dhcp-container-puppet.yaml\nenvironments/services/neutron-ovs-dvr.yaml:  OS::TripleO::Services::NeutronDhcpAgent: ../../deployment/neutron/neutron-dhcp-container-puppet.yaml\nenvironments/services/neutron-ovs.yaml:  OS::TripleO::Services::NeutronDhcpAgent: ../../deployment/neutron/neutron-dhcp-container-puppet.yaml\nsample-env-generator/enable-services.yaml:      deployment/neutron/neutron-dhcp-container-puppet.yaml:","commit_id":"cbbcefef3d3ace72142dac0b2388edbf053f4674"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"77aa8d4f751bfb091254890baa295c890c37b912","unresolved":true,"context_lines":[{"line_number":144,"context_line":"                 certificate for this service"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"parameter_defaults:"},{"line_number":147,"context_line":"  DhcpAgentNotification: true"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"conditions:"},{"line_number":150,"context_line":"  dhcp_ovs_intergation_bridge_set:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2c7355e1_d849ffb2","line":147,"in_reply_to":"5013af34_fa2d39a3","updated":"2021-08-03 10:19:58.000000000","message":"I changed it. Please let me know if that makes sense or if I should change it in the \"parameter_defaults\" section in all neutron related environment files.","commit_id":"cbbcefef3d3ace72142dac0b2388edbf053f4674"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"17bdaea2fdf7f3d2b24837bd606055d08bbc66b3","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                 certificate for this service"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"parameter_defaults:"},{"line_number":147,"context_line":"  DhcpAgentNotification: true"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"conditions:"},{"line_number":150,"context_line":"  dhcp_ovs_intergation_bridge_set:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5c8a118c_21ff018e","line":147,"in_reply_to":"d8438ee8_e1c99334","updated":"2021-08-31 10:35:48.000000000","message":"Thx, I did it like that now.","commit_id":"cbbcefef3d3ace72142dac0b2388edbf053f4674"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1f1fc973f5e185d70a20e161030ba4a528203607","unresolved":true,"context_lines":[{"line_number":144,"context_line":"                 certificate for this service"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"parameter_defaults:"},{"line_number":147,"context_line":"  DhcpAgentNotification: true"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"conditions:"},{"line_number":150,"context_line":"  dhcp_ovs_intergation_bridge_set:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5013af34_fa2d39a3","line":147,"in_reply_to":"fecf4b88_6035b5cd","updated":"2021-07-22 15:12:45.000000000","message":"this should go in an environment file and not in a service definition.","commit_id":"cbbcefef3d3ace72142dac0b2388edbf053f4674"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"db2fbf4ebbacfa728943bafb8574d5bf408f184d","unresolved":true,"context_lines":[{"line_number":6,"context_line":"parameters:"},{"line_number":7,"context_line":"  DhcpAgentNotification:"},{"line_number":8,"context_line":"    default: true"},{"line_number":9,"context_line":"    description: Whether or not to enable DHCP agent notifications."},{"line_number":10,"context_line":"    type: boolean"},{"line_number":11,"context_line":"  ContainerNeutronDHCPImage:"},{"line_number":12,"context_line":"    description: image"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"455dde09_81ef9db7","line":9,"updated":"2021-08-26 12:36:48.000000000","message":"You\u0027ll find that you can mix values for defaults. If you want to do this automagically, something that might work for you is to change the heat template to follow a set/unset pattern and in the OVN plugin template (deployment/neutron/neutron-plugin-ml2-ovn.yaml) set the hiera to neutron::dhcp_agent_notification to false if the heat parameter remains unset or the value of the parameter if it is set. In the ML2/OVS plugin case you would have neutron::dhcp_agent_notification have true as the default or use the value of the DhcpAgentNotification parameter. The problem you might run into there is if there are still situations where you need a DHCP agent in an ML2/OVN deployment. Doing something automagically then might be a little trickier - but chances are that is something that can easily be handled by setting DhcpAgentNotification in the environment file where the value of OS::TripleO::NeutronDhcpAgent is actually set to the dhcp agent template.\n\n*But* you could just do the easy thing: change DhcpAgentNotification\u0027s value to false in neutron-base.yaml and in the environment files for enabling ML2/OVS, set it to true and you\u0027re done.","commit_id":"6bc40cb2d46c67a49bf845ee290bfa778760f7cc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"17bdaea2fdf7f3d2b24837bd606055d08bbc66b3","unresolved":true,"context_lines":[{"line_number":6,"context_line":"parameters:"},{"line_number":7,"context_line":"  DhcpAgentNotification:"},{"line_number":8,"context_line":"    default: true"},{"line_number":9,"context_line":"    description: Whether or not to enable DHCP agent notifications."},{"line_number":10,"context_line":"    type: boolean"},{"line_number":11,"context_line":"  ContainerNeutronDHCPImage:"},{"line_number":12,"context_line":"    description: image"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0a3da05b_a939fc8a","line":9,"in_reply_to":"455dde09_81ef9db7","updated":"2021-08-31 10:35:48.000000000","message":"Thx. As I don\u0027t know how to do boolean value to be \"True\", \"False\" or \"unset\" in templates, I made this easy thing :)","commit_id":"6bc40cb2d46c67a49bf845ee290bfa778760f7cc"}]}