)]}'
{"deployment/haproxy/haproxy-public-tls-inject.yaml":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"8f5957dfe884ec43900e90272e8431c83786b221","unresolved":true,"context_lines":[{"line_number":185,"context_line":"                    fi"},{"line_number":186,"context_line":"                    {{ container_cli }} exec --user root {{ item }} chgrp haproxy {{ cert_path }}"},{"line_number":187,"context_line":"                    {{ container_cli }} kill --signal\u003dHUP {{ item }}"},{"line_number":188,"context_line":"                  register: container_kill_result"},{"line_number":189,"context_line":"                  failed_when:"},{"line_number":190,"context_line":"                    - (\"no such container\" not in container_kill_result.stderr)"},{"line_number":191,"context_line":"                    - (\"container state improper\" not in container_kill_result.stderr)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"605be652_841a8a31","line":188,"updated":"2021-08-21 05:21:17.000000000","message":"Why NOT in? Seems like having \u0027no such container\u0027 or \u0027container state improper\u0027 in container_kill_result WOULD be a reason to fail? This causes my overcloud deployment to fail every time on master because stderr from that script is:\nstderr_lines\": [\"tar: Removing leading `/\u0027 from member names\"]\n\nWhich obviously doesn\u0027t contain either of the strings, so the task fails. It seems like this change would require an error to not raise an error.\n\nCan we just double check that this works on an existing Train deployment before we merge this. After removing the not\u0027s, my deployment on master is able to proceed.","commit_id":"d4897b07e19a2824d9498cc97e91cdcd0bddb6ef"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"841907f036cc38160a0d2ef9e8a2c18b9bec82b8","unresolved":true,"context_lines":[{"line_number":185,"context_line":"                    fi"},{"line_number":186,"context_line":"                    {{ container_cli }} exec --user root {{ item }} chgrp haproxy {{ cert_path }}"},{"line_number":187,"context_line":"                    {{ container_cli }} kill --signal\u003dHUP {{ item }}"},{"line_number":188,"context_line":"                  register: container_kill_result"},{"line_number":189,"context_line":"                  failed_when:"},{"line_number":190,"context_line":"                    - (\"no such container\" not in container_kill_result.stderr)"},{"line_number":191,"context_line":"                    - (\"container state improper\" not in container_kill_result.stderr)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b0d50fc7_1eaa59a9","line":188,"in_reply_to":"605be652_841a8a31","updated":"2021-09-01 15:55:37.000000000","message":"I think the issue was the missing rc !\u003d 0 condition. I could fix that in master and this backport... But I see you\u0027ve changed approach. LGTM if it works as well (just adds an extra reloading for containers)","commit_id":"d4897b07e19a2824d9498cc97e91cdcd0bddb6ef"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8dd868e03e8c91a14410ca0691bbae6de463384c","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                    fi"},{"line_number":186,"context_line":"                    {{ container_cli }} exec --user root {{ item }} chgrp haproxy {{ cert_path }}"},{"line_number":187,"context_line":"                    {{ container_cli }} kill --signal\u003dHUP {{ item }}"},{"line_number":188,"context_line":"                  register: container_kill_result"},{"line_number":189,"context_line":"                  failed_when:"},{"line_number":190,"context_line":"                    - (\"no such container\" not in container_kill_result.stderr)"},{"line_number":191,"context_line":"                    - (\"container state improper\" not in container_kill_result.stderr)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8523e761_49a45a4d","line":188,"in_reply_to":"b0d50fc7_1eaa59a9","updated":"2021-09-23 11:43:52.000000000","message":"Done","commit_id":"d4897b07e19a2824d9498cc97e91cdcd0bddb6ef"}]}