)]}'
{"deployment/pacemaker/pacemaker-baremetal-puppet.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"71e4b24443b7b2cee4183cc407ae485db5260cbb","unresolved":true,"context_lines":[{"line_number":108,"context_line":"    type: boolean"},{"line_number":109,"context_line":"  PacemakerBundleOperationTimeout:"},{"line_number":110,"context_line":"    type: string"},{"line_number":111,"context_line":"    default: \u0027\u0027"},{"line_number":112,"context_line":"    description: The timeout for start, monitor and stop operations"},{"line_number":113,"context_line":"                 run by the container resource agent, in seconds."},{"line_number":114,"context_line":"                 When set to default \u0027\u0027, the timeout comes from"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8810c415_e40de2ee","line":111,"range":{"start_line":111,"start_character":3,"end_line":111,"end_character":15},"updated":"2021-07-28 13:16:56.000000000","message":"We should have 120 here and remove pcmk_bundle_op_timeout_set condition as it\u0027s confusing. It does not seem to have a default in puppet[1]\n\n[1] https://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/base/pacemaker.pp#L114","commit_id":"566405fe894e697f32bdb4f4d5aed2b4647fbd2d"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"d6ae9415010574feee14a15243549893659a35f9","unresolved":true,"context_lines":[{"line_number":108,"context_line":"    type: boolean"},{"line_number":109,"context_line":"  PacemakerBundleOperationTimeout:"},{"line_number":110,"context_line":"    type: string"},{"line_number":111,"context_line":"    default: \u0027\u0027"},{"line_number":112,"context_line":"    description: The timeout for start, monitor and stop operations"},{"line_number":113,"context_line":"                 run by the container resource agent, in seconds."},{"line_number":114,"context_line":"                 When set to default \u0027\u0027, the timeout comes from"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a51c552d_12781d40","line":111,"range":{"start_line":111,"start_character":3,"end_line":111,"end_character":15},"in_reply_to":"5203af80_e168c5ad","updated":"2021-07-28 14:06:24.000000000","message":"I don\u0027t know why would one set to empty string, just seen that as a valid case and shared. But ok will update if issue is not seen with that case, yes for not empty values it should work fine. Ok will also cleanup container_cli.","commit_id":"566405fe894e697f32bdb4f4d5aed2b4647fbd2d"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"23f20f20436ad1207b8c541f19f9bf56ea9d67cc","unresolved":true,"context_lines":[{"line_number":108,"context_line":"    type: boolean"},{"line_number":109,"context_line":"  PacemakerBundleOperationTimeout:"},{"line_number":110,"context_line":"    type: string"},{"line_number":111,"context_line":"    default: \u0027\u0027"},{"line_number":112,"context_line":"    description: The timeout for start, monitor and stop operations"},{"line_number":113,"context_line":"                 run by the container resource agent, in seconds."},{"line_number":114,"context_line":"                 When set to default \u0027\u0027, the timeout comes from"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b6e00f99_3510d964","line":111,"range":{"start_line":111,"start_character":3,"end_line":111,"end_character":15},"in_reply_to":"8810c415_e40de2ee","updated":"2021-07-28 13:42:58.000000000","message":"If we just changed the default here and remove the condition, seems there will be issue in upgrade for the cases where PacemakerBundleOperationTimeout: \u0027\u0027 set during original deployment? as in that case bundle timeout value will be \u0027\u0027 with the upgrade as compared to 120s in original deploy. or would need to update regex as well to not allow \u0027\u0027 and hard fail during upgrade, can u please check and suggest.","commit_id":"566405fe894e697f32bdb4f4d5aed2b4647fbd2d"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"6e2c71355fe157d2780469b5ff091caebc18c70c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    type: boolean"},{"line_number":109,"context_line":"  PacemakerBundleOperationTimeout:"},{"line_number":110,"context_line":"    type: string"},{"line_number":111,"context_line":"    default: \u0027\u0027"},{"line_number":112,"context_line":"    description: The timeout for start, monitor and stop operations"},{"line_number":113,"context_line":"                 run by the container resource agent, in seconds."},{"line_number":114,"context_line":"                 When set to default \u0027\u0027, the timeout comes from"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b654a33e_fba50329","line":111,"range":{"start_line":111,"start_character":3,"end_line":111,"end_character":15},"in_reply_to":"a51c552d_12781d40","updated":"2021-07-28 14:36:52.000000000","message":"Done","commit_id":"566405fe894e697f32bdb4f4d5aed2b4647fbd2d"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"971a87b3a55d196974f6237e9d38f65b5bb46358","unresolved":true,"context_lines":[{"line_number":108,"context_line":"    type: boolean"},{"line_number":109,"context_line":"  PacemakerBundleOperationTimeout:"},{"line_number":110,"context_line":"    type: string"},{"line_number":111,"context_line":"    default: \u0027\u0027"},{"line_number":112,"context_line":"    description: The timeout for start, monitor and stop operations"},{"line_number":113,"context_line":"                 run by the container resource agent, in seconds."},{"line_number":114,"context_line":"                 When set to default \u0027\u0027, the timeout comes from"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5203af80_e168c5ad","line":111,"range":{"start_line":111,"start_character":3,"end_line":111,"end_character":15},"in_reply_to":"b6e00f99_3510d964","updated":"2021-07-28 13:57:29.000000000","message":"Why would someone specify PacemakerBundleOperationTimeout as an empty string?\n\nI don\u0027t see any issue with upgrade. If it\u0027s already set to something other than 120 that would be used, else 120 would be used for podman. I think we can also get rid of podman_enabled condition (leftover). We don\u0027t support anything other than podman as container_cli.","commit_id":"566405fe894e697f32bdb4f4d5aed2b4647fbd2d"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"8bdb79d5c9c94264d2d70c1b60b2607e79c70d3e","unresolved":true,"context_lines":[{"line_number":178,"context_line":"            - pcmk_tls_priorities_set"},{"line_number":179,"context_line":"            - {get_param: PacemakerTLSPriorities}"},{"line_number":180,"context_line":"        tripleo::profile::base::pacemaker::resource_op_defaults:"},{"line_number":181,"context_line":"            bundle:"},{"line_number":182,"context_line":"              name: timeout"},{"line_number":183,"context_line":"              value: {get_param: PacemakerBundleOperationTimeout}"},{"line_number":184,"context_line":"      service_config_settings:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8aa49751_0cfa6173","line":181,"range":{"start_line":181,"start_character":12,"end_line":181,"end_character":19},"updated":"2021-07-29 02:47:35.000000000","message":"inconsistent indentation","commit_id":"74ae036024b83f198c24a863dce51c948f2364eb"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"2aab6ad3e945271aeebf6170d23fa562dd4fb888","unresolved":true,"context_lines":[{"line_number":178,"context_line":"            - pcmk_tls_priorities_set"},{"line_number":179,"context_line":"            - {get_param: PacemakerTLSPriorities}"},{"line_number":180,"context_line":"        tripleo::profile::base::pacemaker::resource_op_defaults:"},{"line_number":181,"context_line":"            bundle:"},{"line_number":182,"context_line":"              name: timeout"},{"line_number":183,"context_line":"              value: {get_param: PacemakerBundleOperationTimeout}"},{"line_number":184,"context_line":"      service_config_settings:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ae546bcf_1f9fab7d","line":181,"range":{"start_line":181,"start_character":12,"end_line":181,"end_character":19},"in_reply_to":"8aa49751_0cfa6173","updated":"2021-07-29 05:15:45.000000000","message":"Thanks fixing with https://review.opendev.org/c/openstack/tripleo-heat-templates/+/802825","commit_id":"74ae036024b83f198c24a863dce51c948f2364eb"}]}