)]}'
{"deployment/openvswitch/openvswitch-dpdk-baremetal-ansible.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"855a8525750b96542fe38816e54336ba24fbc499","unresolved":true,"context_lines":[{"line_number":180,"context_line":"      - role_specific"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"conditions:"},{"line_number":183,"context_line":"  reserved_huge_pages_set:"},{"line_number":184,"context_line":"    not:"},{"line_number":185,"context_line":"      and:"},{"line_number":186,"context_line":"      - equals: [{get_param: [RoleParameters, NovaReservedHugePages]}, \"\"]"},{"line_number":187,"context_line":"      - equals: [{get_param: NovaReservedHugePages}, []]"},{"line_number":188,"context_line":"  live_migration_optimization_set:"},{"line_number":189,"context_line":"    and:"},{"line_number":190,"context_line":"      - not: {equals: [{get_param: [RoleParameters, TunedProfileName]}, \u0027realtime-virtual-host\u0027]}"},{"line_number":191,"context_line":"      - reserved_huge_pages_set"},{"line_number":192,"context_line":"  permit_post_copy_set:"},{"line_number":193,"context_line":"    or:"},{"line_number":194,"context_line":"      - not: {equals: [{get_param: [RoleParameters, NovaLiveMigrationPermitPostCopy]}, \u0027\u0027]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"48e05614_f605c2bb","line":191,"range":{"start_line":183,"start_character":0,"end_line":191,"end_character":31},"updated":"2021-07-28 17:29:44.000000000","message":"lest remove the reserved_huge_pages_set logic\nand replace this with \n  live_migration_optimization_set:\n    and:\n      - not: {equals: [{get_param: [RoleParameters, TunedProfileName]}, \u0027realtime-virtual-host\u0027]}\n      - not: OvsPmdCoreList","commit_id":"28323dfc26bd738c86edd695fcfe55e4790d8e55"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"d336a014bf88368baa42a053a53eb6c4ba683e81","unresolved":false,"context_lines":[{"line_number":180,"context_line":"      - role_specific"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"conditions:"},{"line_number":183,"context_line":"  reserved_huge_pages_set:"},{"line_number":184,"context_line":"    not:"},{"line_number":185,"context_line":"      and:"},{"line_number":186,"context_line":"      - equals: [{get_param: [RoleParameters, NovaReservedHugePages]}, \"\"]"},{"line_number":187,"context_line":"      - equals: [{get_param: NovaReservedHugePages}, []]"},{"line_number":188,"context_line":"  live_migration_optimization_set:"},{"line_number":189,"context_line":"    and:"},{"line_number":190,"context_line":"      - not: {equals: [{get_param: [RoleParameters, TunedProfileName]}, \u0027realtime-virtual-host\u0027]}"},{"line_number":191,"context_line":"      - reserved_huge_pages_set"},{"line_number":192,"context_line":"  permit_post_copy_set:"},{"line_number":193,"context_line":"    or:"},{"line_number":194,"context_line":"      - not: {equals: [{get_param: [RoleParameters, NovaLiveMigrationPermitPostCopy]}, \u0027\u0027]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b3b9810b_51faef82","line":191,"range":{"start_line":183,"start_character":0,"end_line":191,"end_character":31},"in_reply_to":"48e05614_f605c2bb","updated":"2021-07-28 17:43:15.000000000","message":"Done","commit_id":"28323dfc26bd738c86edd695fcfe55e4790d8e55"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"dd5cbdf35091c5b7db0d7a73d05258750cd60558","unresolved":true,"context_lines":[{"line_number":259,"context_line":"                - {get_param: OvsDisableEMC}"},{"line_number":260,"context_line":"                - 0"},{"line_number":261,"context_line":"              tripleo_ovs_dpdk_enable_tso: {get_attr: [RoleParametersDpdk, value, enable_tso]}"},{"line_number":262,"context_line":"              tripleo_ovs_dpdk_vhost_postconfig_support:"},{"line_number":263,"context_line":"                if:"},{"line_number":264,"context_line":"                  - vhost_postcopy_support_set"},{"line_number":265,"context_line":"                  - {get_attr: [RoleParametersDpdk, value, vhost_postconfig_support}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f704852d_8d95e9d7","line":262,"updated":"2021-07-28 17:48:14.000000000","message":"So the logic here:\n- If operators forcefully enables this, we just enable it.\n- If operators forcefully enable PermitPostCopy in nova for this role, we enable this.\n- Otherwise, we enable this when we know this is DPDK and that the host is not a RT host.","commit_id":"8bed6b14d36e5548225533efecfafa8b8d46ec02"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"69cd79f63505b9126560ec37708bfa489aec17d1","unresolved":true,"context_lines":[{"line_number":169,"context_line":"      - role_specific"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"conditions:"},{"line_number":172,"context_line":"  live_migration_optimization_set:"},{"line_number":173,"context_line":"    and:"},{"line_number":174,"context_line":"      - not: {equals: [{get_param: [RoleParameters, TunedProfileName]}, \u0027realtime-virtual-host\u0027]}"},{"line_number":175,"context_line":"      - not: {equals: [{get_param: [RoleParameters, OvsPmdCoreList]}, \u0027\u0027]}"},{"line_number":176,"context_line":"  permit_post_copy_set:"},{"line_number":177,"context_line":"    or:"},{"line_number":178,"context_line":"      - not: {equals: [{get_param: [RoleParameters, NovaLiveMigrationPermitPostCopy]}, \u0027\u0027]}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4addb623_eb1f23dd","line":175,"range":{"start_line":172,"start_character":0,"end_line":175,"end_character":74},"updated":"2021-07-29 06:09:02.000000000","message":"shouldn\u0027t the live_migration_optimization_set condition be kept in sync here and in nova-compute-container-puppet.yaml [1]?\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/nova/nova-compute-container-puppet.yaml#L841-L844","commit_id":"bcdad21075defc26f505d154bf614920e8961811"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"32c2177029eebaa4fff6182e22a6752458dde480","unresolved":true,"context_lines":[{"line_number":169,"context_line":"      - role_specific"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"conditions:"},{"line_number":172,"context_line":"  live_migration_optimization_set:"},{"line_number":173,"context_line":"    and:"},{"line_number":174,"context_line":"      - not: {equals: [{get_param: [RoleParameters, TunedProfileName]}, \u0027realtime-virtual-host\u0027]}"},{"line_number":175,"context_line":"      - not: {equals: [{get_param: [RoleParameters, OvsPmdCoreList]}, \u0027\u0027]}"},{"line_number":176,"context_line":"  permit_post_copy_set:"},{"line_number":177,"context_line":"    or:"},{"line_number":178,"context_line":"      - not: {equals: [{get_param: [RoleParameters, NovaLiveMigrationPermitPostCopy]}, \u0027\u0027]}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"79aae16a_2fd26e88","line":175,"range":{"start_line":172,"start_character":0,"end_line":175,"end_character":74},"in_reply_to":"4addb623_eb1f23dd","updated":"2021-07-29 12:16:04.000000000","message":"yes and no the other one should be updated to not use hugepages either.\n\nthe original proposal was to enable in all cases when not using real-time.\nso the orginal hugepage check was not correct.\n\nim not sure addign a diffintion for OvsPmdCoreList makes sense in that file.\n\nthis definiton is alos not corret\n\n  - not: {equals: [{get_param: [RoleParameters, OvsPmdCoreList]}, \u0027\u0027]}\n\nshoudl be \n  - equals: [{get_param: [RoleParameters, OvsPmdCoreList]}, \u0027\u0027]\n\nwe want to enable the optimisation when its not realtime and OvsPmdCoreList is empty or its undefined.","commit_id":"bcdad21075defc26f505d154bf614920e8961811"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"000e7ee92c0d8c7070ba554985fde4edb766aebf","unresolved":true,"context_lines":[{"line_number":169,"context_line":"      - role_specific"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"conditions:"},{"line_number":172,"context_line":"  live_migration_optimization_set:"},{"line_number":173,"context_line":"    and:"},{"line_number":174,"context_line":"      - not: {equals: [{get_param: [RoleParameters, TunedProfileName]}, \u0027realtime-virtual-host\u0027]}"},{"line_number":175,"context_line":"      - not: {equals: [{get_param: [RoleParameters, OvsPmdCoreList]}, \u0027\u0027]}"},{"line_number":176,"context_line":"  permit_post_copy_set:"},{"line_number":177,"context_line":"    or:"},{"line_number":178,"context_line":"      - not: {equals: [{get_param: [RoleParameters, NovaLiveMigrationPermitPostCopy]}, \u0027\u0027]}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"51b93197_2f0179f3","line":175,"range":{"start_line":172,"start_character":0,"end_line":175,"end_character":74},"in_reply_to":"594cb1e9_04d08797","updated":"2021-07-29 18:53:01.000000000","message":"actully this one did not change i was getting it confusted with \nhttps://review.opendev.org/c/openstack/tripleo-heat-templates/+/802614\n\nif we are proceedign with this change can we abandon ^","commit_id":"bcdad21075defc26f505d154bf614920e8961811"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"15c9e662d91fde1bcf6accd26e3128daae43b1cd","unresolved":true,"context_lines":[{"line_number":169,"context_line":"      - role_specific"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"conditions:"},{"line_number":172,"context_line":"  live_migration_optimization_set:"},{"line_number":173,"context_line":"    and:"},{"line_number":174,"context_line":"      - not: {equals: [{get_param: [RoleParameters, TunedProfileName]}, \u0027realtime-virtual-host\u0027]}"},{"line_number":175,"context_line":"      - not: {equals: [{get_param: [RoleParameters, OvsPmdCoreList]}, \u0027\u0027]}"},{"line_number":176,"context_line":"  permit_post_copy_set:"},{"line_number":177,"context_line":"    or:"},{"line_number":178,"context_line":"      - not: {equals: [{get_param: [RoleParameters, NovaLiveMigrationPermitPostCopy]}, \u0027\u0027]}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"594cb1e9_04d08797","line":175,"range":{"start_line":172,"start_character":0,"end_line":175,"end_character":74},"in_reply_to":"79aae16a_2fd26e88","updated":"2021-07-29 18:50:43.000000000","message":"ok we spoke on irce and the intent change since PS1\n\nthe intent of the patch currently is ti enabel \n\nvhost_postcopy_support_set in ovs whenever NovaLiveMigrationPermitPostCopy is enabled and we are using dpdk.\nand NovaLiveMigrationPermitPostCopy should be enabled when its not realtime\n\n\nso the hugepage check should be remvoed form https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/nova/nova-compute-container-puppet.yaml#L841-L844\n\nand \n\nvhost_postcopy_support_set: shoudl jsut be somethign like\n\nvhost_postcopy_support_set:\n    and:\n      - {get_param: [RoleParameters, NovaLiveMigrationPermitPostCopy]}\n      - not: {equals: [{get_param: [RoleParameters, OvsPmdCoreList]}, \u0027\u0027]}\n\n\npermit_post_copy_set and live_migration_optimization_set proably are not needed","commit_id":"bcdad21075defc26f505d154bf614920e8961811"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"f7365cdf258ed25fefe128e218fbb627e6c1ee39","unresolved":true,"context_lines":[{"line_number":165,"context_line":"      Enable Libvirt\u0027s PostCopy support for vhost interfaces in OVS."},{"line_number":166,"context_line":"      It\u0027s not recommended to enable this for realtime compute nodes."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"      This will get automatically enabled when NovaLiveMigrationPermitPostCopy"},{"line_number":169,"context_line":"      is enabled unless explicitely disabled here or unless host is having its"},{"line_number":170,"context_line":"      TunedProfileName set to realtime."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"      Changing the value of this setting will require an OVS restart to be"},{"line_number":173,"context_line":"      effective. This restart is not automatic and has to be scheduled."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"d339a0e9_d489a434","line":170,"range":{"start_line":168,"start_character":6,"end_line":170,"end_character":39},"updated":"2021-07-30 06:32:02.000000000","message":"Do we need to have a separate parameter for DPDK? IIUC, both nova and ovs need to have the configuration enabled. I don\u0027t know if there is any benefit in enabling only in ovs and not in nova. If there is none, then it is better to stick with only nova parameter only.","commit_id":"51f485c20868558c0c2ea976542beb15f6b1c663"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5654bfecfb5174463730247d565c28aa96b2b253","unresolved":false,"context_lines":[{"line_number":165,"context_line":"      Enable Libvirt\u0027s PostCopy support for vhost interfaces in OVS."},{"line_number":166,"context_line":"      It\u0027s not recommended to enable this for realtime compute nodes."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"      This will get automatically enabled when NovaLiveMigrationPermitPostCopy"},{"line_number":169,"context_line":"      is enabled unless explicitely disabled here or unless host is having its"},{"line_number":170,"context_line":"      TunedProfileName set to realtime."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"      Changing the value of this setting will require an OVS restart to be"},{"line_number":173,"context_line":"      effective. This restart is not automatic and has to be scheduled."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fdf219b6_47038c88","line":170,"range":{"start_line":168,"start_character":6,"end_line":170,"end_character":39},"in_reply_to":"3d438cb6_8d1adf29","updated":"2021-08-03 11:54:02.000000000","message":"the only think that was a little odd with useing \n\nNovaLiveMigrationPermitPostCopy to contol this is really just the name\n\ni.e. it contains Nova\n\nLiveMigrationPermitPostCopy  would have been more reusabel between ovs and dpdk.\n\nbut i agree we dont really need 2 parmaters \n\nwe just dont want to have to set teh parmater in ovsdb if its not dpdk as that is extra work\n\nNovaLiveMigrationPermitPostCopy will be suffint to contol things.","commit_id":"51f485c20868558c0c2ea976542beb15f6b1c663"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"f54d13ac3b2d0151b4b00dc49cbfbb69a8601b4d","unresolved":false,"context_lines":[{"line_number":165,"context_line":"      Enable Libvirt\u0027s PostCopy support for vhost interfaces in OVS."},{"line_number":166,"context_line":"      It\u0027s not recommended to enable this for realtime compute nodes."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"      This will get automatically enabled when NovaLiveMigrationPermitPostCopy"},{"line_number":169,"context_line":"      is enabled unless explicitely disabled here or unless host is having its"},{"line_number":170,"context_line":"      TunedProfileName set to realtime."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"      Changing the value of this setting will require an OVS restart to be"},{"line_number":173,"context_line":"      effective. This restart is not automatic and has to be scheduled."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3d438cb6_8d1adf29","line":170,"range":{"start_line":168,"start_character":6,"end_line":170,"end_character":39},"in_reply_to":"7fb462d0_ca5c7714","updated":"2021-07-30 12:57:44.000000000","message":"Y\u0027all are totally right, removed the parameter.","commit_id":"51f485c20868558c0c2ea976542beb15f6b1c663"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"6df11f66591df516db27b82d925ae1353d504b40","unresolved":true,"context_lines":[{"line_number":165,"context_line":"      Enable Libvirt\u0027s PostCopy support for vhost interfaces in OVS."},{"line_number":166,"context_line":"      It\u0027s not recommended to enable this for realtime compute nodes."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"      This will get automatically enabled when NovaLiveMigrationPermitPostCopy"},{"line_number":169,"context_line":"      is enabled unless explicitely disabled here or unless host is having its"},{"line_number":170,"context_line":"      TunedProfileName set to realtime."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"      Changing the value of this setting will require an OVS restart to be"},{"line_number":173,"context_line":"      effective. This restart is not automatic and has to be scheduled."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7fb462d0_ca5c7714","line":170,"range":{"start_line":168,"start_character":6,"end_line":170,"end_character":39},"in_reply_to":"d339a0e9_d489a434","updated":"2021-07-30 07:37:41.000000000","message":"I agree, I am not sure if this is really needed. iiuc we want to:\n- not enable postcopy on RT nodes\n- for everything else we want it enabled\n- and if dpdk we need to configure vhost-postcopy-support\n\nIsn\u0027t it enough to have NovaLiveMigrationPermitPostCopy to be able to overwrite any post copy related automation? Or did I miss a scenario?","commit_id":"51f485c20868558c0c2ea976542beb15f6b1c663"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"ea957f4d516ca1cff9f00cafe2a4f80a119a20dd","unresolved":true,"context_lines":[{"line_number":243,"context_line":"                if:"},{"line_number":244,"context_line":"                  - is_realtime"},{"line_number":245,"context_line":"                  - false"},{"line_number":246,"context_line":"                  - {get_attr: [RoleParametersDpdk, value, nova_postcopy]}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"e5a452ba_fdad547a","line":246,"updated":"2021-07-30 13:12:26.000000000","message":"as discussed on irc with the default of the param being false, this gets only enabled when the param is explicitely set, not like intended enable it also per default when it is not a realtime node","commit_id":"eb3a6b0d43952e34b150af8b67a515b603f9f2ca"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"074f9fa1423d9bc56b4e4bb6d583680287d46ecc","unresolved":true,"context_lines":[{"line_number":250,"context_line":"                  - if:"},{"line_number":251,"context_line":"                      - nova_postcopy_set"},{"line_number":252,"context_line":"                      - {get_attr: [RoleParametersDpdk, value, nova_postcopy]}"},{"line_number":253,"context_line":"                      - true"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"f140c098_1630e4bd","line":253,"updated":"2021-08-02 06:28:11.000000000","message":"The requirement is to set ovs value to true if NovaLiveMigrationPermitPostCopy is true. Here even if the NovaLiveMigrationPermitPostCopy is false, then ovs value is enabled. Why?","commit_id":"135360cc818261a8edd01384019f57281f244a4f"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"dbdfcc6576d299aacb8f019d9cc25ae87b60b700","unresolved":true,"context_lines":[{"line_number":250,"context_line":"                  - if:"},{"line_number":251,"context_line":"                      - nova_postcopy_set"},{"line_number":252,"context_line":"                      - {get_attr: [RoleParametersDpdk, value, nova_postcopy]}"},{"line_number":253,"context_line":"                      - true"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"dbfb0d92_069422f4","line":253,"in_reply_to":"70314cf0_44c2feeb","updated":"2021-08-02 07:19:38.000000000","message":"This is not captured well, can you add some comments to specific that it is enabled implicitly (if not specified). The best approach would have been to mark the default value NovaLiveMigrationPermitPostCopy to true. I dont know reason why it was not used that way. Having a parameter to enable it (which is disabled by default), but the feature gets enabled if the parameter not true.","commit_id":"135360cc818261a8edd01384019f57281f244a4f"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"2db5997098f574916011e6d3875925433a9304c1","unresolved":true,"context_lines":[{"line_number":250,"context_line":"                  - if:"},{"line_number":251,"context_line":"                      - nova_postcopy_set"},{"line_number":252,"context_line":"                      - {get_attr: [RoleParametersDpdk, value, nova_postcopy]}"},{"line_number":253,"context_line":"                      - true"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"70314cf0_44c2feeb","line":253,"in_reply_to":"f140c098_1630e4bd","updated":"2021-08-02 07:00:20.000000000","message":"The requirement is that postcopy gets enabled if it is not a realtime node and if not explicitly set to false.","commit_id":"135360cc818261a8edd01384019f57281f244a4f"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"fdf096057055d67aeb1746d45e1067a685e928a0","unresolved":true,"context_lines":[{"line_number":249,"context_line":"                if:"},{"line_number":250,"context_line":"                  - is_realtime"},{"line_number":251,"context_line":"                  - false"},{"line_number":252,"context_line":"                  - if:"},{"line_number":253,"context_line":"                      - nova_postcopy_set"},{"line_number":254,"context_line":"                      - {get_attr: [RoleParametersDpdk, value, nova_postcopy]}"},{"line_number":255,"context_line":"                      - true"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"4804a4f8_fe30a8c9","line":255,"range":{"start_line":252,"start_character":20,"end_line":255,"end_character":28},"updated":"2021-08-02 09:14:06.000000000","message":"Can this condition be replaced with \"{get_attr: [RoleParametersDpdk, value, nova_postcopy]}\"? As it is bool, we apply what is provided. Only scenario to be false is when user disables it.","commit_id":"f0f301d38895f19900ea253f5a50c0811f0cf752"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"0d97801f86cc93c0a6d9e20c014bca6c36592bf5","unresolved":true,"context_lines":[{"line_number":249,"context_line":"                if:"},{"line_number":250,"context_line":"                  - is_realtime"},{"line_number":251,"context_line":"                  - false"},{"line_number":252,"context_line":"                  - if:"},{"line_number":253,"context_line":"                      - nova_postcopy_set"},{"line_number":254,"context_line":"                      - {get_attr: [RoleParametersDpdk, value, nova_postcopy]}"},{"line_number":255,"context_line":"                      - true"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"25da87da_3cfe5748","line":255,"range":{"start_line":252,"start_character":20,"end_line":255,"end_character":28},"in_reply_to":"4804a4f8_fe30a8c9","updated":"2021-08-02 09:38:58.000000000","message":"right, that makes sense, I also updated the compute file to have the same condition name used. should make it easier to understand the relation","commit_id":"f0f301d38895f19900ea253f5a50c0811f0cf752"}]}