)]}'
{"deployment/ironic/ironic-api-container-puppet.yaml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"1d53a36e992cba83c414a9f61fe11694af6fc122","unresolved":true,"context_lines":[{"line_number":85,"context_line":"    default: \u0027oslo\u0027"},{"line_number":86,"context_line":"    type: string"},{"line_number":87,"context_line":"    constraints:"},{"line_number":88,"context_line":"      - allowed_values: [ \u0027oslo\u0027, \u0027json-rpc\u0027]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"conditions:"},{"line_number":91,"context_line":"  cors_allowed_origin_set:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5640ab30_54e8e6ce","line":88,"range":{"start_line":88,"start_character":25,"end_line":88,"end_character":26},"updated":"2021-07-29 14:42:21.000000000","message":"nit","commit_id":"b26169e7a9fdf5aa600cd5f5908d0b05a1e8e78b"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"9faa5e3b97bdc989d5ffd07f5ae72ff3d59b6992","unresolved":true,"context_lines":[{"line_number":211,"context_line":"            ironic::cors::expose_headers: \u0027Content-Type,Cache-Control,Content-Language,Expires,Last-Modified,Pragma\u0027"},{"line_number":212,"context_line":"            apache::default_vhost: false"},{"line_number":213,"context_line":"          - if:"},{"line_number":214,"context_line":"              - rpc_transport_json_rpc"},{"line_number":215,"context_line":"              - ironic::json_rpc::auth_type:"},{"line_number":216,"context_line":"                  if:"},{"line_number":217,"context_line":"                    - auth_strategy_non_default"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3c55c767_780c2282","line":214,"updated":"2021-07-30 11:45:44.000000000","message":"this restricts \u0027noauth\u0027, \u0027http_basic\u0027 use to become only subcases of json_rpc","commit_id":"4a8ba9e0e3b75ca775db2ac45584df27348c5487"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"c25729df131cc7a4f59389c14df7529382fccf9b","unresolved":true,"context_lines":[{"line_number":211,"context_line":"            ironic::cors::expose_headers: \u0027Content-Type,Cache-Control,Content-Language,Expires,Last-Modified,Pragma\u0027"},{"line_number":212,"context_line":"            apache::default_vhost: false"},{"line_number":213,"context_line":"          - if:"},{"line_number":214,"context_line":"              - rpc_transport_json_rpc"},{"line_number":215,"context_line":"              - ironic::json_rpc::auth_type:"},{"line_number":216,"context_line":"                  if:"},{"line_number":217,"context_line":"                    - auth_strategy_non_default"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"575f1091_f9f0a392","line":214,"in_reply_to":"3c55c767_780c2282","updated":"2021-07-30 11:48:49.000000000","message":"Why it would? L222/L223 are not using auth_strategy_non_default condition.","commit_id":"4a8ba9e0e3b75ca775db2ac45584df27348c5487"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"647dc2a95d420b09c29a216e13c3098d4db372ac","unresolved":true,"context_lines":[{"line_number":211,"context_line":"            ironic::cors::expose_headers: \u0027Content-Type,Cache-Control,Content-Language,Expires,Last-Modified,Pragma\u0027"},{"line_number":212,"context_line":"            apache::default_vhost: false"},{"line_number":213,"context_line":"          - if:"},{"line_number":214,"context_line":"              - rpc_transport_json_rpc"},{"line_number":215,"context_line":"              - ironic::json_rpc::auth_type:"},{"line_number":216,"context_line":"                  if:"},{"line_number":217,"context_line":"                    - auth_strategy_non_default"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6c82b2f8_71384a30","line":214,"in_reply_to":"575f1091_f9f0a392","updated":"2021-07-30 11:50:22.000000000","message":"meant to say that one can only chose noauth and http_basic, if json_rpc selected.\nI hope that\u0027s expected.","commit_id":"4a8ba9e0e3b75ca775db2ac45584df27348c5487"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"5e337a18283532926021c50f5f2706c1cce20223","unresolved":true,"context_lines":[{"line_number":211,"context_line":"            ironic::cors::expose_headers: \u0027Content-Type,Cache-Control,Content-Language,Expires,Last-Modified,Pragma\u0027"},{"line_number":212,"context_line":"            apache::default_vhost: false"},{"line_number":213,"context_line":"          - if:"},{"line_number":214,"context_line":"              - rpc_transport_json_rpc"},{"line_number":215,"context_line":"              - ironic::json_rpc::auth_type:"},{"line_number":216,"context_line":"                  if:"},{"line_number":217,"context_line":"                    - auth_strategy_non_default"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ee2796b2_58ff3ce3","line":214,"in_reply_to":"6c82b2f8_71384a30","updated":"2021-07-30 11:57:06.000000000","message":"we don\u0027t set auth_type (uses the default, keystone) if it\u0027s http_basic or noauth. We still set the password and auth_url.\n\nIt\u0027s now enabled for undercloud to without \u0027keystone\u0027 auth_type. you can check the configs/logs.","commit_id":"4a8ba9e0e3b75ca775db2ac45584df27348c5487"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"4851d89eeae8a7d47db0b6d4e5e0435474be178a","unresolved":true,"context_lines":[{"line_number":211,"context_line":"            ironic::cors::expose_headers: \u0027Content-Type,Cache-Control,Content-Language,Expires,Last-Modified,Pragma\u0027"},{"line_number":212,"context_line":"            apache::default_vhost: false"},{"line_number":213,"context_line":"          - if:"},{"line_number":214,"context_line":"              - rpc_transport_json_rpc"},{"line_number":215,"context_line":"              - ironic::json_rpc::auth_type:"},{"line_number":216,"context_line":"                  if:"},{"line_number":217,"context_line":"                    - auth_strategy_non_default"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f123cbd3_9bc9b93b","line":214,"in_reply_to":"ee2796b2_58ff3ce3","updated":"2021-07-30 12:01:25.000000000","message":"default auth_type is \u0027password\u0027 and not \u0027keystone\u0027 to authenticate with keystone.","commit_id":"4a8ba9e0e3b75ca775db2ac45584df27348c5487"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"53b5d309d7c89ee49999ba5b2de09f3bb0d162ba","unresolved":true,"context_lines":[{"line_number":211,"context_line":"            ironic::cors::expose_headers: \u0027Content-Type,Cache-Control,Content-Language,Expires,Last-Modified,Pragma\u0027"},{"line_number":212,"context_line":"            apache::default_vhost: false"},{"line_number":213,"context_line":"          - if:"},{"line_number":214,"context_line":"              - rpc_transport_json_rpc"},{"line_number":215,"context_line":"              - ironic::json_rpc::auth_type:"},{"line_number":216,"context_line":"                  if:"},{"line_number":217,"context_line":"                    - auth_strategy_non_default"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"574fb643_58501745","line":214,"in_reply_to":"f123cbd3_9bc9b93b","updated":"2021-07-30 12:07:36.000000000","message":"ack ,thanks!","commit_id":"4a8ba9e0e3b75ca775db2ac45584df27348c5487"}],"deployment/ironic/ironic-base-puppet.yaml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"1d53a36e992cba83c414a9f61fe11694af6fc122","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    default: \u0027oslo\u0027"},{"line_number":55,"context_line":"    type: string"},{"line_number":56,"context_line":"    constraints:"},{"line_number":57,"context_line":"      - allowed_values: [ \u0027oslo\u0027, \u0027json-rpc\u0027]"},{"line_number":58,"context_line":"  IronicRpcResponseTimeout:"},{"line_number":59,"context_line":"    default: 60"},{"line_number":60,"context_line":"    description: Ironic\u0027s RPC response timeout, in seconds."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"aa62b0b3_6df3f996","line":57,"range":{"start_line":57,"start_character":25,"end_line":57,"end_character":26},"updated":"2021-07-29 14:42:21.000000000","message":"nit","commit_id":"b26169e7a9fdf5aa600cd5f5908d0b05a1e8e78b"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"bdbdad44e4d00a7d94505b672062c648bc3ce77e","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    default: \u0027oslo\u0027"},{"line_number":55,"context_line":"    type: string"},{"line_number":56,"context_line":"    constraints:"},{"line_number":57,"context_line":"      - allowed_values: [ \u0027oslo\u0027, \u0027json-rpc\u0027]"},{"line_number":58,"context_line":"  IronicRpcResponseTimeout:"},{"line_number":59,"context_line":"    default: 60"},{"line_number":60,"context_line":"    description: Ironic\u0027s RPC response timeout, in seconds."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ef71d29d_1fa25f83","line":57,"range":{"start_line":57,"start_character":25,"end_line":57,"end_character":26},"in_reply_to":"aa62b0b3_6df3f996","updated":"2021-07-30 04:03:39.000000000","message":"Those extra spaces were there before and not added in this patch. But I\u0027ll clean it up.","commit_id":"b26169e7a9fdf5aa600cd5f5908d0b05a1e8e78b"}],"deployment/ironic/ironic-conductor-container-puppet.yaml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"1d53a36e992cba83c414a9f61fe11694af6fc122","unresolved":true,"context_lines":[{"line_number":271,"context_line":"    default: \u0027oslo\u0027"},{"line_number":272,"context_line":"    type: string"},{"line_number":273,"context_line":"    constraints:"},{"line_number":274,"context_line":"      - allowed_values: [ \u0027oslo\u0027, \u0027json-rpc\u0027]"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"parameter_groups:"},{"line_number":277,"context_line":"- label: deprecated"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f1c14b05_6a692ae0","line":274,"range":{"start_line":274,"start_character":25,"end_line":274,"end_character":26},"updated":"2021-07-29 14:42:21.000000000","message":"nit","commit_id":"b26169e7a9fdf5aa600cd5f5908d0b05a1e8e78b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"1d53a36e992cba83c414a9f61fe11694af6fc122","unresolved":true,"context_lines":[{"line_number":383,"context_line":"            - ironic::json_rpc::auth_strategy: {get_param: IronicAuthStrategy}"},{"line_number":384,"context_line":"              ironic::api::authtoken::password: {get_param: IronicPassword}"},{"line_number":385,"context_line":"              ironic::api::authtoken::project_name: \u0027service\u0027"},{"line_number":386,"context_line":"              ironic::api::authtoken::www_authenticate_uri: {get_param: [EndpointMap, KeystoneInternal, uri_no_suffix] }"},{"line_number":387,"context_line":"              ironic::api::authtoken::auth_url: {get_param: [EndpointMap, KeystoneInternal, uri_no_suffix]}"},{"line_number":388,"context_line":"              ironic::api::authtoken::region_name: {get_param: KeystoneRegion }"},{"line_number":389,"context_line":"              ironic::api::authtoken::interface: \u0027internal\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"2cc79cc9_74b32599","line":386,"range":{"start_line":386,"start_character":118,"end_line":386,"end_character":119},"updated":"2021-07-29 14:42:21.000000000","message":"nit","commit_id":"b26169e7a9fdf5aa600cd5f5908d0b05a1e8e78b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"1d53a36e992cba83c414a9f61fe11694af6fc122","unresolved":true,"context_lines":[{"line_number":385,"context_line":"              ironic::api::authtoken::project_name: \u0027service\u0027"},{"line_number":386,"context_line":"              ironic::api::authtoken::www_authenticate_uri: {get_param: [EndpointMap, KeystoneInternal, uri_no_suffix] }"},{"line_number":387,"context_line":"              ironic::api::authtoken::auth_url: {get_param: [EndpointMap, KeystoneInternal, uri_no_suffix]}"},{"line_number":388,"context_line":"              ironic::api::authtoken::region_name: {get_param: KeystoneRegion }"},{"line_number":389,"context_line":"              ironic::api::authtoken::interface: \u0027internal\u0027"},{"line_number":390,"context_line":"          - ironic::conductor::cleaning_disk_erase: {get_param: IronicCleaningDiskErase}"},{"line_number":391,"context_line":"            ironic::conductor::default_boot_option: {get_param: IronicDefaultBootOption}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ec04cb6d_50e33135","line":388,"range":{"start_line":388,"start_character":77,"end_line":388,"end_character":78},"updated":"2021-07-29 14:42:21.000000000","message":"nit","commit_id":"b26169e7a9fdf5aa600cd5f5908d0b05a1e8e78b"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"cd3aeb5a5b8db9d30622357d6dddb7035c03d948","unresolved":true,"context_lines":[{"line_number":629,"context_line":"                    - /run:/run #shared?"},{"line_number":630,"context_line":"                    - /var/lib/ironic:/var/lib/ironic:z"},{"line_number":631,"context_line":"                    - /var/log/containers/ironic:/var/log/ironic:z"},{"line_number":632,"context_line":"                  - if:"},{"line_number":633,"context_line":"                      - json_rpc_with_http_basic"},{"line_number":634,"context_line":"                      - - /etc/ironic_conductor_passwd:/etc/ironic/htpasswd-json-rpc:z"},{"line_number":635,"context_line":"              environment:"},{"line_number":636,"context_line":"                KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"},{"line_number":637,"context_line":"      host_prep_tasks:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"d5fb57ea_f2876a3c","line":634,"range":{"start_line":632,"start_character":0,"end_line":634,"end_character":86},"updated":"2021-07-30 11:49:08.000000000","message":"don\u0027t we need this as well for json_rpc + http_basic for Ironic API bind-mounts?","commit_id":"4a8ba9e0e3b75ca775db2ac45584df27348c5487"}]}