)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"a7fd02e680b9b14c4238a15e6095b2cf82f4d823","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"53e040c5_61010b22","updated":"2022-03-30 16:05:54.000000000","message":"recheck","commit_id":"4bc3011184c997e9db217426ce12359b6a3d86ca"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"e630c04365f5161ff38c6e45636cbdccb36addb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"aeff0115_773012eb","updated":"2022-02-24 00:02:54.000000000","message":"recheck","commit_id":"4bc3011184c997e9db217426ce12359b6a3d86ca"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9be97966ac6b913ddbcf9ee0fa1835d7024f319c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b0fbe40c_c392c4ea","updated":"2021-12-21 09:20:40.000000000","message":"recheck","commit_id":"4bc3011184c997e9db217426ce12359b6a3d86ca"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"f12847e1a0989bad5987ed7e1a2e1b83e68d9fc6","unresolved":true,"context_lines":[{"line_number":1167,"context_line":"                - \u00271.0\u0027"},{"line_number":1168,"context_line":"                - {get_attr: [RoleParametersValue, value, ram_allocation_ratio]}"},{"line_number":1169,"context_line":"              nova::initial_disk_allocation_ratio: {get_attr: [RoleParametersValue, value, disk_allocation_ratio]}"},{"line_number":1170,"context_line":"            - nova::cpu_allocation_ratio: {get_attr: [RoleParametersValue, value, cpu_allocation_ratio]}"},{"line_number":1171,"context_line":"              # if libvirt_file_backed_memory_enabled we have to set ram allocation ratio to 1.0"},{"line_number":1172,"context_line":"              nova::initial_ram_allocation_ratio:"},{"line_number":1173,"context_line":"                if:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8391d535_7584feeb","line":1170,"updated":"2021-08-03 00:27:11.000000000","message":"Does this need to be default if the initial_cpu_allocation_ratio config option is used? Or can the two be set independently?","commit_id":"9df7a257be4df88b10023e1b4fa57606b8566866"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9be97966ac6b913ddbcf9ee0fa1835d7024f319c","unresolved":false,"context_lines":[{"line_number":1167,"context_line":"                - \u00271.0\u0027"},{"line_number":1168,"context_line":"                - {get_attr: [RoleParametersValue, value, ram_allocation_ratio]}"},{"line_number":1169,"context_line":"              nova::initial_disk_allocation_ratio: {get_attr: [RoleParametersValue, value, disk_allocation_ratio]}"},{"line_number":1170,"context_line":"            - nova::cpu_allocation_ratio: {get_attr: [RoleParametersValue, value, cpu_allocation_ratio]}"},{"line_number":1171,"context_line":"              # if libvirt_file_backed_memory_enabled we have to set ram allocation ratio to 1.0"},{"line_number":1172,"context_line":"              nova::initial_ram_allocation_ratio:"},{"line_number":1173,"context_line":"                if:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0bf10426_4d92911d","line":1170,"in_reply_to":"2b9a03e8_81e85931","updated":"2021-12-21 09:20:40.000000000","message":"Done","commit_id":"9df7a257be4df88b10023e1b4fa57606b8566866"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"17f4a6b5e8871481a39e2dde271ba650c674cb14","unresolved":true,"context_lines":[{"line_number":1167,"context_line":"                - \u00271.0\u0027"},{"line_number":1168,"context_line":"                - {get_attr: [RoleParametersValue, value, ram_allocation_ratio]}"},{"line_number":1169,"context_line":"              nova::initial_disk_allocation_ratio: {get_attr: [RoleParametersValue, value, disk_allocation_ratio]}"},{"line_number":1170,"context_line":"            - nova::cpu_allocation_ratio: {get_attr: [RoleParametersValue, value, cpu_allocation_ratio]}"},{"line_number":1171,"context_line":"              # if libvirt_file_backed_memory_enabled we have to set ram allocation ratio to 1.0"},{"line_number":1172,"context_line":"              nova::initial_ram_allocation_ratio:"},{"line_number":1173,"context_line":"                if:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2b9a03e8_81e85931","line":1170,"in_reply_to":"8391d535_7584feeb","updated":"2021-08-03 00:36:24.000000000","message":"We don\u0027t need to explicitly define default. If the parameter is not defined in tht then it is not defined in hieradata, and puppet-nova should use its own default which means $::os_service_default.","commit_id":"9df7a257be4df88b10023e1b4fa57606b8566866"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"f929442d320eaf0b6ceac8300b581b89059bff68","unresolved":true,"context_lines":[{"line_number":1169,"context_line":"              nova::initial_disk_allocation_ratio: {get_attr: [RoleParametersValue, value, disk_allocation_ratio]}"},{"line_number":1170,"context_line":"            - nova::cpu_allocation_ratio: {get_attr: [RoleParametersValue, value, cpu_allocation_ratio]}"},{"line_number":1171,"context_line":"              # if libvirt_file_backed_memory_enabled we have to set ram allocation ratio to 1.0"},{"line_number":1172,"context_line":"              nova::initial_ram_allocation_ratio:"},{"line_number":1173,"context_line":"                if:"},{"line_number":1174,"context_line":"                - libvirt_file_backed_memory_enabled"},{"line_number":1175,"context_line":"                - \u00271.0\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d1e78960_a0fdf456","line":1172,"updated":"2021-08-12 09:25:08.000000000","message":"should be nova::ram_allocation_ratio, right?","commit_id":"9df7a257be4df88b10023e1b4fa57606b8566866"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9be97966ac6b913ddbcf9ee0fa1835d7024f319c","unresolved":false,"context_lines":[{"line_number":1169,"context_line":"              nova::initial_disk_allocation_ratio: {get_attr: [RoleParametersValue, value, disk_allocation_ratio]}"},{"line_number":1170,"context_line":"            - nova::cpu_allocation_ratio: {get_attr: [RoleParametersValue, value, cpu_allocation_ratio]}"},{"line_number":1171,"context_line":"              # if libvirt_file_backed_memory_enabled we have to set ram allocation ratio to 1.0"},{"line_number":1172,"context_line":"              nova::initial_ram_allocation_ratio:"},{"line_number":1173,"context_line":"                if:"},{"line_number":1174,"context_line":"                - libvirt_file_backed_memory_enabled"},{"line_number":1175,"context_line":"                - \u00271.0\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0bbfd212_db67931e","line":1172,"in_reply_to":"80785b93_287a67f5","updated":"2021-12-21 09:20:40.000000000","message":"Done","commit_id":"9df7a257be4df88b10023e1b4fa57606b8566866"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2439c165768c8900c8b8d2e806d130e45319523b","unresolved":true,"context_lines":[{"line_number":1169,"context_line":"              nova::initial_disk_allocation_ratio: {get_attr: [RoleParametersValue, value, disk_allocation_ratio]}"},{"line_number":1170,"context_line":"            - nova::cpu_allocation_ratio: {get_attr: [RoleParametersValue, value, cpu_allocation_ratio]}"},{"line_number":1171,"context_line":"              # if libvirt_file_backed_memory_enabled we have to set ram allocation ratio to 1.0"},{"line_number":1172,"context_line":"              nova::initial_ram_allocation_ratio:"},{"line_number":1173,"context_line":"                if:"},{"line_number":1174,"context_line":"                - libvirt_file_backed_memory_enabled"},{"line_number":1175,"context_line":"                - \u00271.0\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"80785b93_287a67f5","line":1172,"in_reply_to":"d1e78960_a0fdf456","updated":"2021-08-12 10:11:14.000000000","message":"Thanks. That is totally correct. I\u0027ll fix it asap.","commit_id":"9df7a257be4df88b10023e1b4fa57606b8566866"}]}