)]}'
{"deployment/ironic/ironic-api-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0bf3171398a2b144b60d19165940bd2dccffa389","unresolved":true,"context_lines":[{"line_number":233,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":234,"context_line":"      puppet_config:"},{"line_number":235,"context_line":"        config_volume: ironic_api"},{"line_number":236,"context_line":"        puppet_tags: ironic_config,ironic_api_paste_ini"},{"line_number":237,"context_line":"        step_config:"},{"line_number":238,"context_line":"          list_join:"},{"line_number":239,"context_line":"            - \"\\n\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"61f67b41_9be5fada","line":236,"range":{"start_line":236,"start_character":35,"end_line":236,"end_character":55},"updated":"2021-08-11 03:32:36.000000000","message":"I nocied that ironic doesn\u0027t use api-paste.ini and this is useless.\n\nWe should deprecate this useless resource from puppet-ironic...","commit_id":"28c0462762e90e1bd19b20247ca7cbcc18f9c651"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9090e2125d1a94b26312d1053936c010f469e0ae","unresolved":false,"context_lines":[{"line_number":233,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":234,"context_line":"      puppet_config:"},{"line_number":235,"context_line":"        config_volume: ironic_api"},{"line_number":236,"context_line":"        puppet_tags: ironic_config,ironic_api_paste_ini"},{"line_number":237,"context_line":"        step_config:"},{"line_number":238,"context_line":"          list_join:"},{"line_number":239,"context_line":"            - \"\\n\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"63828c51_83145dd6","line":236,"range":{"start_line":236,"start_character":35,"end_line":236,"end_character":55},"in_reply_to":"61f67b41_9be5fada","updated":"2021-08-11 03:34:15.000000000","message":"Done","commit_id":"28c0462762e90e1bd19b20247ca7cbcc18f9c651"}],"deployment/neutron/neutron-api-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0d9b70d85dd785d3a7fe3c5fe5855619526a1b07","unresolved":true,"context_lines":[{"line_number":410,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":411,"context_line":"      puppet_config:"},{"line_number":412,"context_line":"        config_volume: neutron"},{"line_number":413,"context_line":"        puppet_tags: neutron_config,neutron_api_config,neutron_api_paste_ini"},{"line_number":414,"context_line":"        step_config:"},{"line_number":415,"context_line":"          list_join:"},{"line_number":416,"context_line":"            - \"\\n\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f4333b3_58ae0d9f","line":413,"range":{"start_line":413,"start_character":36,"end_line":413,"end_character":54},"updated":"2021-08-11 02:06:34.000000000","message":"neutron_api_config was deprecated because it is duplicate of neutron_api_paste_ini, so can be removed.","commit_id":"8b7d1e4270a17c09b28cd26eb34c23ba0614597e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0bf3171398a2b144b60d19165940bd2dccffa389","unresolved":false,"context_lines":[{"line_number":410,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":411,"context_line":"      puppet_config:"},{"line_number":412,"context_line":"        config_volume: neutron"},{"line_number":413,"context_line":"        puppet_tags: neutron_config,neutron_api_config,neutron_api_paste_ini"},{"line_number":414,"context_line":"        step_config:"},{"line_number":415,"context_line":"          list_join:"},{"line_number":416,"context_line":"            - \"\\n\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b97c2806_3165a7c9","line":413,"range":{"start_line":413,"start_character":36,"end_line":413,"end_character":54},"in_reply_to":"9f4333b3_58ae0d9f","updated":"2021-08-11 03:32:36.000000000","message":"Done","commit_id":"8b7d1e4270a17c09b28cd26eb34c23ba0614597e"}],"deployment/nova/nova-api-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"69e4e4cb332d68bb60830872e257c0ec51e60b4f","unresolved":true,"context_lines":[{"line_number":419,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":420,"context_line":"      puppet_config:"},{"line_number":421,"context_line":"        config_volume: nova"},{"line_number":422,"context_line":"        puppet_tags: nova_config,nova_paste_api_ini,nova_api_paste_ini"},{"line_number":423,"context_line":"        step_config:"},{"line_number":424,"context_line":"          list_join:"},{"line_number":425,"context_line":"            - \"\\n\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f97b9aa4_50399579","line":422,"range":{"start_line":422,"start_character":33,"end_line":422,"end_character":51},"updated":"2021-08-11 02:07:31.000000000","message":"nova_paste_api_ini was deprecated because it is duplicate of nova_api_paste_ini, so can be removed.","commit_id":"8b7d1e4270a17c09b28cd26eb34c23ba0614597e"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"3854f9de3e4692c5b2e096817fb9655f484a47b7","unresolved":true,"context_lines":[{"line_number":419,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":420,"context_line":"      puppet_config:"},{"line_number":421,"context_line":"        config_volume: nova"},{"line_number":422,"context_line":"        puppet_tags: nova_config,nova_paste_api_ini,nova_api_paste_ini"},{"line_number":423,"context_line":"        step_config:"},{"line_number":424,"context_line":"          list_join:"},{"line_number":425,"context_line":"            - \"\\n\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c350573a_c13dc087","line":422,"range":{"start_line":422,"start_character":33,"end_line":422,"end_character":51},"in_reply_to":"b2de2189_d632ff77","updated":"2021-08-11 03:12:50.000000000","message":"I did not remove the deprecated tags as they still have precedence over the new params[1]\n\n[1] https://github.com/openstack/puppet-nova/blob/master/manifests/config.pp#L51","commit_id":"8b7d1e4270a17c09b28cd26eb34c23ba0614597e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0bf3171398a2b144b60d19165940bd2dccffa389","unresolved":false,"context_lines":[{"line_number":419,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":420,"context_line":"      puppet_config:"},{"line_number":421,"context_line":"        config_volume: nova"},{"line_number":422,"context_line":"        puppet_tags: nova_config,nova_paste_api_ini,nova_api_paste_ini"},{"line_number":423,"context_line":"        step_config:"},{"line_number":424,"context_line":"          list_join:"},{"line_number":425,"context_line":"            - \"\\n\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ab9bda3f_fc57e147","line":422,"range":{"start_line":422,"start_character":33,"end_line":422,"end_character":51},"in_reply_to":"b3c483c1_c193ef51","updated":"2021-08-11 03:32:36.000000000","message":"Done","commit_id":"8b7d1e4270a17c09b28cd26eb34c23ba0614597e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"94585bac0b7a578a0d1c882eb9322c1ba0cf1cec","unresolved":true,"context_lines":[{"line_number":419,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":420,"context_line":"      puppet_config:"},{"line_number":421,"context_line":"        config_volume: nova"},{"line_number":422,"context_line":"        puppet_tags: nova_config,nova_paste_api_ini,nova_api_paste_ini"},{"line_number":423,"context_line":"        step_config:"},{"line_number":424,"context_line":"          list_join:"},{"line_number":425,"context_line":"            - \"\\n\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b3c483c1_c193ef51","line":422,"range":{"start_line":422,"start_character":33,"end_line":422,"end_character":51},"in_reply_to":"c350573a_c13dc087","updated":"2021-08-11 03:28:53.000000000","message":"As we discussed locally, the old parameter is still valid but it is calling the new resource instead of the deprecated one. So the tag should be updated to enable the new resource.[1]\n\nhttps://github.com/openstack/puppet-nova/blob/2d9bde4b3c0e237b3e82c8749c6682f2f2b534eb/manifests/config.pp#L60","commit_id":"8b7d1e4270a17c09b28cd26eb34c23ba0614597e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8f915d6111b9d0a184f4eb776eb3f99a4b9c55b9","unresolved":true,"context_lines":[{"line_number":419,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":420,"context_line":"      puppet_config:"},{"line_number":421,"context_line":"        config_volume: nova"},{"line_number":422,"context_line":"        puppet_tags: nova_config,nova_paste_api_ini,nova_api_paste_ini"},{"line_number":423,"context_line":"        step_config:"},{"line_number":424,"context_line":"          list_join:"},{"line_number":425,"context_line":"            - \"\\n\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b2de2189_d632ff77","line":422,"range":{"start_line":422,"start_character":33,"end_line":422,"end_character":51},"in_reply_to":"f97b9aa4_50399579","updated":"2021-08-11 02:18:35.000000000","message":"Also, nova_api_paste_ini is used by nova-metadata-api thus should be added to its template as well.","commit_id":"8b7d1e4270a17c09b28cd26eb34c23ba0614597e"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ae43f9d1ba59b2e17b26a90f37ef67cf84ec0bb3","unresolved":true,"context_lines":[{"line_number":1196,"context_line":"          collectd::plugin::virt::connection: \u0027qemu:///system\u0027"},{"line_number":1197,"context_line":"      puppet_config:"},{"line_number":1198,"context_line":"        config_volume: nova_libvirt"},{"line_number":1199,"context_line":"        puppet_tags: nova_config,nova_paste_api_ini"},{"line_number":1200,"context_line":"        step_config: |"},{"line_number":1201,"context_line":"          # TODO(emilien): figure how to deal with libvirt profile."},{"line_number":1202,"context_line":"          # We\u0027ll probably treat it like we do with Neutron plugins."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"2924a941_9cb6a9dd","side":"PARENT","line":1199,"updated":"2021-08-11 14:49:10.000000000","message":"are you sure we don\u0027t need it on computes?","commit_id":"087a703fe136dbe351d2cff3da8041e7a9775bb9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f212d96fbb0d30288aaf786dc8cbcd657b9ac35d","unresolved":true,"context_lines":[{"line_number":1196,"context_line":"          collectd::plugin::virt::connection: \u0027qemu:///system\u0027"},{"line_number":1197,"context_line":"      puppet_config:"},{"line_number":1198,"context_line":"        config_volume: nova_libvirt"},{"line_number":1199,"context_line":"        puppet_tags: nova_config,nova_paste_api_ini"},{"line_number":1200,"context_line":"        step_config: |"},{"line_number":1201,"context_line":"          # TODO(emilien): figure how to deal with libvirt profile."},{"line_number":1202,"context_line":"          # We\u0027ll probably treat it like we do with Neutron plugins."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"f6cfe15c_2d95f591","side":"PARENT","line":1199,"in_reply_to":"2924a941_9cb6a9dd","updated":"2021-08-11 14:57:22.000000000","message":"api-pate.ini defines filters and pipelines for api services using paste-deploy mechanism, and I don\u0027t see any reason it can be used by nova-compute service.\n\nAFAIR we used to include nova::metadata in compute and that might be the reason why this was added here. However that inclusion was already removed.","commit_id":"087a703fe136dbe351d2cff3da8041e7a9775bb9"}],"deployment/nova/nova-ironic-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9090e2125d1a94b26312d1053936c010f469e0ae","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                - get_param: IronicApiMaxRetries"},{"line_number":109,"context_line":"      puppet_config:"},{"line_number":110,"context_line":"        config_volume: nova"},{"line_number":111,"context_line":"        puppet_tags: nova_config,nova_api_paste_ini"},{"line_number":112,"context_line":"        step_config: |"},{"line_number":113,"context_line":"          include tripleo::profile::base::nova::compute::ironic"},{"line_number":114,"context_line":"        config_image: {get_param: ContainerNovaConfigImage}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"87c53ece_fb60d992","line":111,"range":{"start_line":111,"start_character":32,"end_line":111,"end_character":51},"updated":"2021-08-11 03:34:15.000000000","message":"This can be removed because this is for nova-compute maintaining ironic baremetal nodes.","commit_id":"8b7d1e4270a17c09b28cd26eb34c23ba0614597e"}]}