)]}'
{"deployment/deprecated/nova/nova-libvirt-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4616924fb3b7cb110ac8081610487e485eec3164","unresolved":true,"context_lines":[{"line_number":354,"context_line":"    type: OS::TripleO::Services::Logging::NovaLibvirt"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"  NovaBase:"},{"line_number":357,"context_line":"    type: ./nova-base-puppet.yaml"},{"line_number":358,"context_line":"    properties:"},{"line_number":359,"context_line":"      ServiceData: {get_param: ServiceData}"},{"line_number":360,"context_line":"      ServiceNetMap: {get_param: ServiceNetMap}"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1b22132a_f5b97a49","line":357,"range":{"start_line":357,"start_character":10,"end_line":357,"end_character":33},"updated":"2021-09-07 14:56:18.000000000","message":"to make pep8 passing, it should point ../../nova/nova-base-puppet.yaml","commit_id":"9c6c47558b301cf0b82c37be48a1da8ef827ddbe"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"257fbf6774abacf4d6686c1fff382332366a17c5","unresolved":false,"context_lines":[{"line_number":354,"context_line":"    type: OS::TripleO::Services::Logging::NovaLibvirt"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"  NovaBase:"},{"line_number":357,"context_line":"    type: ./nova-base-puppet.yaml"},{"line_number":358,"context_line":"    properties:"},{"line_number":359,"context_line":"      ServiceData: {get_param: ServiceData}"},{"line_number":360,"context_line":"      ServiceNetMap: {get_param: ServiceNetMap}"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"97e278fa_05d77e71","line":357,"range":{"start_line":357,"start_character":10,"end_line":357,"end_character":33},"in_reply_to":"1b22132a_f5b97a49","updated":"2021-09-07 18:26:52.000000000","message":"Done","commit_id":"9c6c47558b301cf0b82c37be48a1da8ef827ddbe"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1b1dc13ef88982624e8a35888278fe71b87ad55f","unresolved":true,"context_lines":[{"line_number":536,"context_line":"                    - \u0027\u0027"},{"line_number":537,"context_line":"        nova_libvirt_init_secret.sh:"},{"line_number":538,"context_line":"          mode: \"0755\""},{"line_number":539,"context_line":"          content: { get_file: ../../container_config_scripts/nova_libvirt_init_secret.sh }"},{"line_number":540,"context_line":"      docker_config:"},{"line_number":541,"context_line":"        step_2:"},{"line_number":542,"context_line":"          create_virtlogd_wrapper:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"649a912d_f8e76f73","line":539,"updated":"2021-09-08 12:32:07.000000000","message":"so the path needs to go a level upper ../../../container_...","commit_id":"fc5dc9821fad217e9832adb84e2ad9f0d2d321ce"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"86f0099086927da20df579d505fb1048e8afbeaa","unresolved":false,"context_lines":[{"line_number":536,"context_line":"                    - \u0027\u0027"},{"line_number":537,"context_line":"        nova_libvirt_init_secret.sh:"},{"line_number":538,"context_line":"          mode: \"0755\""},{"line_number":539,"context_line":"          content: { get_file: ../../container_config_scripts/nova_libvirt_init_secret.sh }"},{"line_number":540,"context_line":"      docker_config:"},{"line_number":541,"context_line":"        step_2:"},{"line_number":542,"context_line":"          create_virtlogd_wrapper:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"d03e77c0_9f447fab","line":539,"in_reply_to":"649a912d_f8e76f73","updated":"2021-09-09 11:14:45.000000000","message":"Done","commit_id":"fc5dc9821fad217e9832adb84e2ad9f0d2d321ce"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"4e8689f9572c5f1d2ff504c23bdc21c344b73896","unresolved":true,"context_lines":[{"line_number":267,"context_line":"      Disk cachemodes for RBD backend."},{"line_number":268,"context_line":"  # DEPRECATED: the following options are deprecated and are currently maintained"},{"line_number":269,"context_line":"  # for backwards compatibility. They will be removed in future release."},{"line_number":270,"context_line":"  NovaModularLibvirtDaemons:"},{"line_number":271,"context_line":"    type: boolean"},{"line_number":272,"context_line":"    default: false"},{"line_number":273,"context_line":"    description: \u003e"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"364ed2e0_fea1a325","line":270,"updated":"2021-09-09 06:28:56.000000000","message":"we no longer need this parameter. in modular libvirt we set\nnova::params::modular_libvirt: true\n\nso in this we can just set \nnova::params::modular_libvirt: false","commit_id":"6e9a3a4a44c38c531fe5aaf0486001d4bc6f34e2"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"86f0099086927da20df579d505fb1048e8afbeaa","unresolved":false,"context_lines":[{"line_number":267,"context_line":"      Disk cachemodes for RBD backend."},{"line_number":268,"context_line":"  # DEPRECATED: the following options are deprecated and are currently maintained"},{"line_number":269,"context_line":"  # for backwards compatibility. They will be removed in future release."},{"line_number":270,"context_line":"  NovaModularLibvirtDaemons:"},{"line_number":271,"context_line":"    type: boolean"},{"line_number":272,"context_line":"    default: false"},{"line_number":273,"context_line":"    description: \u003e"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"b115750f_ed82c363","line":270,"in_reply_to":"364ed2e0_fea1a325","updated":"2021-09-09 11:14:45.000000000","message":"Done","commit_id":"6e9a3a4a44c38c531fe5aaf0486001d4bc6f34e2"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"4e8689f9572c5f1d2ff504c23bdc21c344b73896","unresolved":true,"context_lines":[{"line_number":348,"context_line":"              NovaLibvirtOptVolumes: {get_param: NovaLibvirtOptVolumes}"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"  ContainersCommon:"},{"line_number":351,"context_line":"    type: ../containers-common.yaml"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"  NovaLibvirtLogging:"},{"line_number":354,"context_line":"    type: OS::TripleO::Services::Logging::NovaLibvirt"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"1c62518b_f3fa3746","line":351,"updated":"2021-09-09 06:28:56.000000000","message":"this path needs to be updated to ../../containers-common.yaml","commit_id":"6e9a3a4a44c38c531fe5aaf0486001d4bc6f34e2"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"86f0099086927da20df579d505fb1048e8afbeaa","unresolved":false,"context_lines":[{"line_number":348,"context_line":"              NovaLibvirtOptVolumes: {get_param: NovaLibvirtOptVolumes}"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"  ContainersCommon:"},{"line_number":351,"context_line":"    type: ../containers-common.yaml"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"  NovaLibvirtLogging:"},{"line_number":354,"context_line":"    type: OS::TripleO::Services::Logging::NovaLibvirt"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"71cb70d1_4c9b1d44","line":351,"in_reply_to":"1c62518b_f3fa3746","updated":"2021-09-09 11:14:45.000000000","message":"Done","commit_id":"6e9a3a4a44c38c531fe5aaf0486001d4bc6f34e2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"27e1ca58ce00c8115054c1c83d7a4211a4399c6a","unresolved":true,"context_lines":[{"line_number":413,"context_line":"            rbd_persistent_storage: {get_param: CinderEnableRbdBackend}"},{"line_number":414,"context_line":"            rbd_disk_cachemodes: {get_param: RbdDiskCachemodes}"},{"line_number":415,"context_line":"            tripleo::profile::base::nova::libvirt::modular_libvirt: false"},{"line_number":416,"context_line":"            nova::params::modular_libvirt: false"},{"line_number":417,"context_line":"          - if:"},{"line_number":418,"context_line":"              - use_tls_for_live_migration"},{"line_number":419,"context_line":"              - tripleo::profile::base::nova::migration::client::libvirt_tls: true"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"6fb6c1a0_eac57f1f","line":416,"range":{"start_line":416,"start_character":12,"end_line":416,"end_character":48},"updated":"2021-10-06 14:46:19.000000000","message":"IMO we should not tweak anything in nova::params. Please use the usual puppet parameters instead.","commit_id":"768b66f885cd43552e63acfeb6c2ab68a5668e90"}],"deployment/logging/files/nova-libvirt.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"27e1ca58ce00c8115054c1c83d7a4211a4399c6a","unresolved":true,"context_lines":[{"line_number":95,"context_line":"          template:"},{"line_number":96,"context_line":"            \u0027LEVEL:file:/var/log/libvirt/virtsecretd.log\u0027"},{"line_number":97,"context_line":"          params:"},{"line_number":98,"context_line":"            LEVEL: {get_param: LibvirtVirtsecretdLogLevel}"},{"line_number":99,"context_line":"      nova::compute::libvirt::virtnodedevd::log_outputs:"},{"line_number":100,"context_line":"        str_replace:"},{"line_number":101,"context_line":"          template:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"7be205e9_53e9c153","line":98,"range":{"start_line":98,"start_character":19,"end_line":98,"end_character":58},"updated":"2021-10-06 14:46:19.000000000","message":"We should implement the same logic to honor Debug/LibvirtDebug. Honestly speaking the initial design with LogLevel parameters were wrong. It might make sense to deprecate existing LogLevel parameters and just rely on Debug/LibvirtDebug for the new modular daemons...\n\nAlso the deployment/logging/stdout/nova-libvirt.yaml file should be updated as well.","commit_id":"768b66f885cd43552e63acfeb6c2ab68a5668e90"}],"deployment/nova/nova-modular-libvirt-container-puppet.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"327b2f8548d2b93217f50f30c250e591d20f9c91","unresolved":true,"context_lines":[{"line_number":552,"context_line":"          permissions: {get_attr: [VirtCommon, kolla_permissions]}"},{"line_number":553,"context_line":"      docker_config:"},{"line_number":554,"context_line":"        step_3:"},{"line_number":555,"context_line":"          nova_virtlogd:"},{"line_number":556,"context_line":"            start_order: 0"},{"line_number":557,"context_line":"            image: {get_param: ContainerNovaLibvirtImage}"},{"line_number":558,"context_line":"            ulimit: {get_param: ContainerNovaLibvirtUlimit}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ca4f4cc7_9bc610b4","line":555,"updated":"2021-09-01 12:57:03.000000000","message":"as discussed, needs rebase as it misses virtlogd_wrapper and other parameters. also move the non modular libvirt file to be deprecated","commit_id":"15526efd6f1e26aa6c188413c3d9a4d33c73a005"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"8efd2f2fc43f40ed289fcd58c97b5d13fd88dd42","unresolved":true,"context_lines":[{"line_number":585,"context_line":"                        - {get_attr: [NovaLibvirtLogging, volumes]}"},{"line_number":586,"context_line":"                        - - /var/lib/kolla/config_files/nova_virtlogd.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":587,"context_line":"                          - /var/lib/config-data/puppet-generated/nova_libvirt:/var/lib/kolla/config_files/src:ro"},{"line_number":588,"context_line":"                          - /lib/modules:/lib/modules:ro"},{"line_number":589,"context_line":"                          - /dev:/dev"},{"line_number":590,"context_line":"                          - /run:/run"},{"line_number":591,"context_line":"                          - /sys/fs/cgroup:/sys/fs/cgroup"},{"line_number":592,"context_line":"                          - /run/libvirt:/run/libvirt:shared"},{"line_number":593,"context_line":"                          - /var/lib/libvirt:/var/lib/libvirt"},{"line_number":594,"context_line":"                          - /etc/libvirt/qemu:/etc/libvirt/qemu:ro"},{"line_number":595,"context_line":"                          - /var/log/libvirt/qemu:/var/log/libvirt/qemu"},{"line_number":596,"context_line":"                          - /var/lib/nova:/var/lib/nova:shared"},{"line_number":597,"context_line":"                        - if:"},{"line_number":598,"context_line":"                            - {get_param: NovaEnableVirtlogdContainerWrapper}"},{"line_number":599,"context_line":"                            - - /var/lib/container-config-scripts/virtlogd_wrapper:/usr/local/bin/virtlogd_wrapper:ro"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"74086a1f_daaa1136","line":596,"range":{"start_line":588,"start_character":1,"end_line":596,"end_character":62},"updated":"2021-09-03 13:47:43.000000000","message":"some of those are already in get_attr: [VirtCommon, volumes], can we add it and just add the specific ones?","commit_id":"3081f969b987890cbfae1b94e464b882b48cc5d7"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"f615fbd10fea3cb32f14f6b2ba6e27595c0dc299","unresolved":false,"context_lines":[{"line_number":585,"context_line":"                        - {get_attr: [NovaLibvirtLogging, volumes]}"},{"line_number":586,"context_line":"                        - - /var/lib/kolla/config_files/nova_virtlogd.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":587,"context_line":"                          - /var/lib/config-data/puppet-generated/nova_libvirt:/var/lib/kolla/config_files/src:ro"},{"line_number":588,"context_line":"                          - /lib/modules:/lib/modules:ro"},{"line_number":589,"context_line":"                          - /dev:/dev"},{"line_number":590,"context_line":"                          - /run:/run"},{"line_number":591,"context_line":"                          - /sys/fs/cgroup:/sys/fs/cgroup"},{"line_number":592,"context_line":"                          - /run/libvirt:/run/libvirt:shared"},{"line_number":593,"context_line":"                          - /var/lib/libvirt:/var/lib/libvirt"},{"line_number":594,"context_line":"                          - /etc/libvirt/qemu:/etc/libvirt/qemu:ro"},{"line_number":595,"context_line":"                          - /var/log/libvirt/qemu:/var/log/libvirt/qemu"},{"line_number":596,"context_line":"                          - /var/lib/nova:/var/lib/nova:shared"},{"line_number":597,"context_line":"                        - if:"},{"line_number":598,"context_line":"                            - {get_param: NovaEnableVirtlogdContainerWrapper}"},{"line_number":599,"context_line":"                            - - /var/lib/container-config-scripts/virtlogd_wrapper:/usr/local/bin/virtlogd_wrapper:ro"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bbb8691c_07da24c0","line":596,"range":{"start_line":588,"start_character":1,"end_line":596,"end_character":62},"in_reply_to":"74086a1f_daaa1136","updated":"2021-09-04 05:20:06.000000000","message":"Done","commit_id":"3081f969b987890cbfae1b94e464b882b48cc5d7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b85c1f37c98b6fef09bda62c8e39a31a6dfc213b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"0aa10a83_b2743048","side":"PARENT","line":286,"range":{"start_line":276,"start_character":0,"end_line":286,"end_character":43},"updated":"2021-09-07 15:32:52.000000000","message":"this original condition works for me, while the new one fails in Heat","commit_id":"6f5cf846ede6093bff81da80080e4fa025d0e60c"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"257fbf6774abacf4d6686c1fff382332366a17c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"68db137a_136a333a","side":"PARENT","line":286,"range":{"start_line":276,"start_character":0,"end_line":286,"end_character":43},"in_reply_to":"0aa10a83_b2743048","updated":"2021-09-07 18:26:52.000000000","message":"Done","commit_id":"6f5cf846ede6093bff81da80080e4fa025d0e60c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7360d2ff07750c46e8065dfbd91530c81e127f4e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"803aadfb_ec1a74f9","side":"PARENT","line":689,"range":{"start_line":689,"start_character":0,"end_line":689,"end_character":20},"updated":"2021-09-07 16:01:32.000000000","message":"I\u0027ve also dropped this one, since it seems there is nothing to concat","commit_id":"6f5cf846ede6093bff81da80080e4fa025d0e60c"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"257fbf6774abacf4d6686c1fff382332366a17c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"d8f5e601_86e9a24b","side":"PARENT","line":689,"range":{"start_line":689,"start_character":0,"end_line":689,"end_character":20},"in_reply_to":"803aadfb_ec1a74f9","updated":"2021-09-07 18:26:52.000000000","message":"Done","commit_id":"6f5cf846ede6093bff81da80080e4fa025d0e60c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4616924fb3b7cb110ac8081610487e485eec3164","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"e04b62c6_a3aebcf6","side":"PARENT","line":690,"updated":"2021-09-07 14:56:18.000000000","message":"worth noting TODO for validations?","commit_id":"6f5cf846ede6093bff81da80080e4fa025d0e60c"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"257fbf6774abacf4d6686c1fff382332366a17c5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"b932148e_14929f2a","side":"PARENT","line":690,"in_reply_to":"e04b62c6_a3aebcf6","updated":"2021-09-07 18:26:52.000000000","message":"I believe this is based on healthcheck which we removed anyways? Or maybe I\u0027m wrong here.","commit_id":"6f5cf846ede6093bff81da80080e4fa025d0e60c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4616924fb3b7cb110ac8081610487e485eec3164","unresolved":true,"context_lines":[{"line_number":663,"context_line":"                restart: always"},{"line_number":664,"context_line":"                depends_on:"},{"line_number":665,"context_line":"                  - tripleo_nova_virtlogd.service"},{"line_number":666,"context_line":"                # TODO:"},{"line_number":667,"context_line":"                #healthcheck:"},{"line_number":668,"context_line":"                #  test: \u0027/openstack/healthcheck virtqemud\u0027"},{"line_number":669,"context_line":"                environment:"},{"line_number":670,"context_line":"                  KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"},{"line_number":671,"context_line":"                volumes:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"6b8d17a9_47dbde81","line":668,"range":{"start_line":666,"start_character":0,"end_line":668,"end_character":59},"updated":"2021-09-07 14:56:18.000000000","message":"we could probably skip this completely for all containers since we\u0027re going to disable it by default in tripleo?","commit_id":"9c6c47558b301cf0b82c37be48a1da8ef827ddbe"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"257fbf6774abacf4d6686c1fff382332366a17c5","unresolved":false,"context_lines":[{"line_number":663,"context_line":"                restart: always"},{"line_number":664,"context_line":"                depends_on:"},{"line_number":665,"context_line":"                  - tripleo_nova_virtlogd.service"},{"line_number":666,"context_line":"                # TODO:"},{"line_number":667,"context_line":"                #healthcheck:"},{"line_number":668,"context_line":"                #  test: \u0027/openstack/healthcheck virtqemud\u0027"},{"line_number":669,"context_line":"                environment:"},{"line_number":670,"context_line":"                  KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"},{"line_number":671,"context_line":"                volumes:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5d779307_96f03d1e","line":668,"range":{"start_line":666,"start_character":0,"end_line":668,"end_character":59},"in_reply_to":"6b8d17a9_47dbde81","updated":"2021-09-07 18:26:52.000000000","message":"Done","commit_id":"9c6c47558b301cf0b82c37be48a1da8ef827ddbe"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"c9a8c142bd19842d7ffcefd8cf1a250c4759555e","unresolved":true,"context_lines":[{"line_number":717,"context_line":"                    - {get_attr: [VirtCommon, volumes]}"},{"line_number":718,"context_line":"                    - {get_attr: [RoleParametersValue, value, nova_libvirt_opt_volumes]}"},{"line_number":719,"context_line":"                    - - /var/lib/kolla/config_files/nova_virtproxyd.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":720,"context_line":"                      # TODO:"},{"line_number":721,"context_line":"                      #- /var/lib/container-config-scripts/nova_libvirt_launcher.sh:/nova_libvirt_launcher.sh:ro"},{"line_number":722,"context_line":"                      - /var/log/libvirt/qemu:/var/log/libvirt/qemu:ro"},{"line_number":723,"context_line":"        step_4:"},{"line_number":724,"context_line":"          if:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"3f137a92_47f2f4cb","line":721,"range":{"start_line":720,"start_character":0,"end_line":721,"end_character":112},"updated":"2021-09-15 10:22:20.000000000","message":"is here still a TODO?","commit_id":"d9b5f5e1d194ff81bc18aa184f5a8ca277a6a410"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"39b36726c8ec26d8bf6cbabc6f02d4b66c3d2664","unresolved":false,"context_lines":[{"line_number":717,"context_line":"                    - {get_attr: [VirtCommon, volumes]}"},{"line_number":718,"context_line":"                    - {get_attr: [RoleParametersValue, value, nova_libvirt_opt_volumes]}"},{"line_number":719,"context_line":"                    - - /var/lib/kolla/config_files/nova_virtproxyd.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":720,"context_line":"                      # TODO:"},{"line_number":721,"context_line":"                      #- /var/lib/container-config-scripts/nova_libvirt_launcher.sh:/nova_libvirt_launcher.sh:ro"},{"line_number":722,"context_line":"                      - /var/log/libvirt/qemu:/var/log/libvirt/qemu:ro"},{"line_number":723,"context_line":"        step_4:"},{"line_number":724,"context_line":"          if:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"833b3f21_062a2670","line":721,"range":{"start_line":720,"start_character":0,"end_line":721,"end_character":112},"in_reply_to":"3f137a92_47f2f4cb","updated":"2021-09-16 11:08:27.000000000","message":"Done","commit_id":"d9b5f5e1d194ff81bc18aa184f5a8ca277a6a410"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"c9a8c142bd19842d7ffcefd8cf1a250c4759555e","unresolved":true,"context_lines":[{"line_number":976,"context_line":"                dest: /etc/tmpfiles.d/run-libvirt.conf"},{"line_number":977,"context_line":"                content: |"},{"line_number":978,"context_line":"                  d /run/libvirt 0755 root root - -"},{"line_number":979,"context_line":"            - name: Install libvirt-client on host for convenience"},{"line_number":980,"context_line":"              package:"},{"line_number":981,"context_line":"                name: libvirt-client"},{"line_number":982,"context_line":"                state: present"},{"line_number":983,"context_line":"      metadata_settings:"},{"line_number":984,"context_line":"        list_concat:"},{"line_number":985,"context_line":"          - if:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"de8a9e80_46e6f2bf","line":982,"range":{"start_line":979,"start_character":0,"end_line":982,"end_character":30},"updated":"2021-09-15 10:22:20.000000000","message":"As discussed, I think we should not re-introduce this package on the host as it was removed on purpose in previous releases to remove all possible libvirt dependencies on the host. Also if we\u0027d add it here, we\u0027d also have to add it to the overcloud image","commit_id":"d9b5f5e1d194ff81bc18aa184f5a8ca277a6a410"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"39b36726c8ec26d8bf6cbabc6f02d4b66c3d2664","unresolved":false,"context_lines":[{"line_number":976,"context_line":"                dest: /etc/tmpfiles.d/run-libvirt.conf"},{"line_number":977,"context_line":"                content: |"},{"line_number":978,"context_line":"                  d /run/libvirt 0755 root root - -"},{"line_number":979,"context_line":"            - name: Install libvirt-client on host for convenience"},{"line_number":980,"context_line":"              package:"},{"line_number":981,"context_line":"                name: libvirt-client"},{"line_number":982,"context_line":"                state: present"},{"line_number":983,"context_line":"      metadata_settings:"},{"line_number":984,"context_line":"        list_concat:"},{"line_number":985,"context_line":"          - if:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"3ca8ed4c_9400057c","line":982,"range":{"start_line":979,"start_character":0,"end_line":982,"end_character":30},"in_reply_to":"de8a9e80_46e6f2bf","updated":"2021-09-16 11:08:27.000000000","message":"Done","commit_id":"d9b5f5e1d194ff81bc18aa184f5a8ca277a6a410"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"a4fd018acac1a25699259981c1aeb17ae519a2cb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":29,"id":"125d0bda_16304c3d","side":"PARENT","line":499,"updated":"2021-09-20 06:36:36.000000000","message":"CI is failing on the missing nova_libvirt_init_secret.sh container-config-scripts:\n\n2021-09-19 14:01:32.005582 |                                      |    WARNING | ERROR: Can\u0027t run container nova_libvirt_init_secret\nstderr: Error: statfs /var/lib/container-config-scripts/nova_libvirt_init_secret.sh: no such file or directory\n\nwhere do we have the container_config_scripts now? should it be in the common virt file?","commit_id":"006a5a9f8c21a0a15f92fb95cdb3d429ea24c192"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"4c90be8f6b59d5b6758d1463bf48b49d2b7669b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"a969fd39_888d8128","side":"PARENT","line":499,"in_reply_to":"125d0bda_16304c3d","updated":"2021-09-20 10:48:07.000000000","message":"Done","commit_id":"006a5a9f8c21a0a15f92fb95cdb3d429ea24c192"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"2875f78ea873faace62924598880e5d8d590cd07","unresolved":true,"context_lines":[{"line_number":517,"context_line":"          config_files: {get_attr: [VirtCommon, kolla_config_files]}"},{"line_number":518,"context_line":"          permissions: {get_attr: [VirtCommon, kolla_permissions]}"},{"line_number":519,"context_line":"      container_config_scripts:"},{"line_number":520,"context_line":"        nova_libvirt_launcher.sh:"},{"line_number":521,"context_line":"          mode: \"0755\""},{"line_number":522,"context_line":"          content:"},{"line_number":523,"context_line":"            str_replace:"},{"line_number":524,"context_line":"              template: |"},{"line_number":525,"context_line":"                #!/bin/bash"},{"line_number":526,"context_line":"                set -xe"},{"line_number":527,"context_line":"                if [[ -f /usr/lib/systemd/kvm-setup ]]; then"},{"line_number":528,"context_line":"                  /usr/lib/systemd/kvm-setup"},{"line_number":529,"context_line":"                fi"},{"line_number":530,"context_line":"                /usr/sbin/libvirtd LIBVIRTD_ARGS"},{"line_number":531,"context_line":"              params:"},{"line_number":532,"context_line":"                LIBVIRTD_ARGS:"},{"line_number":533,"context_line":"                  if:"},{"line_number":534,"context_line":"                    - use_tls_for_live_migration"},{"line_number":535,"context_line":"                    - \u0027--listen\u0027"},{"line_number":536,"context_line":"                    - \u0027\u0027"},{"line_number":537,"context_line":"        nova_libvirt_init_secret.sh:"},{"line_number":538,"context_line":"          mode: \"0755\""},{"line_number":539,"context_line":"          content: { get_file: ../../container_config_scripts/nova_libvirt_init_secret.sh }"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"20664315_4194f7b4","line":536,"range":{"start_line":520,"start_character":0,"end_line":536,"end_character":24},"updated":"2021-09-21 06:07:13.000000000","message":"nova_libvirt_launcher.sh is not used as it is for non modular libvirtd. Is there the need to have the same for virtproxyd?","commit_id":"0e1649df4f439a6824f316fc3df51029af0ac69e"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"4ea5dd79f6222705a7a912b2812e131c4ceeea01","unresolved":true,"context_lines":[{"line_number":517,"context_line":"          config_files: {get_attr: [VirtCommon, kolla_config_files]}"},{"line_number":518,"context_line":"          permissions: {get_attr: [VirtCommon, kolla_permissions]}"},{"line_number":519,"context_line":"      container_config_scripts:"},{"line_number":520,"context_line":"        nova_libvirt_launcher.sh:"},{"line_number":521,"context_line":"          mode: \"0755\""},{"line_number":522,"context_line":"          content:"},{"line_number":523,"context_line":"            str_replace:"},{"line_number":524,"context_line":"              template: |"},{"line_number":525,"context_line":"                #!/bin/bash"},{"line_number":526,"context_line":"                set -xe"},{"line_number":527,"context_line":"                if [[ -f /usr/lib/systemd/kvm-setup ]]; then"},{"line_number":528,"context_line":"                  /usr/lib/systemd/kvm-setup"},{"line_number":529,"context_line":"                fi"},{"line_number":530,"context_line":"                /usr/sbin/libvirtd LIBVIRTD_ARGS"},{"line_number":531,"context_line":"              params:"},{"line_number":532,"context_line":"                LIBVIRTD_ARGS:"},{"line_number":533,"context_line":"                  if:"},{"line_number":534,"context_line":"                    - use_tls_for_live_migration"},{"line_number":535,"context_line":"                    - \u0027--listen\u0027"},{"line_number":536,"context_line":"                    - \u0027\u0027"},{"line_number":537,"context_line":"        nova_libvirt_init_secret.sh:"},{"line_number":538,"context_line":"          mode: \"0755\""},{"line_number":539,"context_line":"          content: { get_file: ../../container_config_scripts/nova_libvirt_init_secret.sh }"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"5b8ccc29_01506b8d","line":536,"range":{"start_line":520,"start_character":0,"end_line":536,"end_character":24},"in_reply_to":"20664315_4194f7b4","updated":"2021-09-21 10:12:28.000000000","message":"As per https://libvirt.org/manpages/virtproxyd.html  there is no --listen parameter, we have to set listen_tcp and listen_tls in virtproxyd_config.\n\nThanks, I have addressed your comment.","commit_id":"0e1649df4f439a6824f316fc3df51029af0ac69e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"27e1ca58ce00c8115054c1c83d7a4211a4399c6a","unresolved":true,"context_lines":[{"line_number":261,"context_line":"                 logging level for a given category log outputs, as specified"},{"line_number":262,"context_line":"                 in https://libvirt.org/logging.html ."},{"line_number":263,"context_line":"    type: string"},{"line_number":264,"context_line":"    default: \u00271:logging 4:object 4:json 4:event 1:util\u0027"},{"line_number":265,"context_line":"  LibvirtTLSPriority:"},{"line_number":266,"context_line":"    description: \u003e"},{"line_number":267,"context_line":"      Override the compile time default TLS priority string."}],"source_content_type":"text/x-yaml","patch_set":32,"id":"fcaf3281_920a94ab","line":264,"range":{"start_line":264,"start_character":14,"end_line":264,"end_character":55},"updated":"2021-10-06 14:46:19.000000000","message":"This default should be updated to follow the one defined in conf files provided by package.\n\nFor example log_filters of virtproxy defaults to \"1:qemu 1:libvirt 4:object 4:json 4:event 1:util\"\n\nhttps://logserver.rdoproject.org/15/803915/32/openstack-check/tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001/0e7267e/logs/overcloud-novacompute-0/var/lib/config-data/puppet-generated/nova_libvirt/etc/libvirt/virtproxyd.conf.txt.gz","commit_id":"768b66f885cd43552e63acfeb6c2ab68a5668e90"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"27e1ca58ce00c8115054c1c83d7a4211a4399c6a","unresolved":true,"context_lines":[{"line_number":369,"context_line":"      RoleName: {get_param: RoleName}"},{"line_number":370,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"  VirtCommon:"},{"line_number":373,"context_line":"    type: ./nova-virt-common.yaml"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"outputs:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"aa19ca80_d5b682e1","line":372,"range":{"start_line":372,"start_character":2,"end_line":372,"end_character":12},"updated":"2021-10-06 14:46:19.000000000","message":"NovaLibvirtCommon might be a better naming.","commit_id":"768b66f885cd43552e63acfeb6c2ab68a5668e90"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"27e1ca58ce00c8115054c1c83d7a4211a4399c6a","unresolved":true,"context_lines":[{"line_number":370,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"  VirtCommon:"},{"line_number":373,"context_line":"    type: ./nova-virt-common.yaml"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"outputs:"},{"line_number":376,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"5f7d0ec6_ca578a72","line":373,"range":{"start_line":373,"start_character":17,"end_line":373,"end_character":21},"updated":"2021-10-06 14:46:19.000000000","message":"nova-libvirt-common or nova-livirt-base would be the better naming, which clearly explains the file is not related to general virtualization but libvirt.","commit_id":"768b66f885cd43552e63acfeb6c2ab68a5668e90"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"27e1ca58ce00c8115054c1c83d7a4211a4399c6a","unresolved":true,"context_lines":[{"line_number":448,"context_line":"            nova::compute::libvirt::services::modular_libvirt: true"},{"line_number":449,"context_line":"            nova::compute::libvirt::modular_libvirt: true"},{"line_number":450,"context_line":"            nova::migration::libvirt::modular_libvirt: true"},{"line_number":451,"context_line":"            nova::params::modular_libvirt: true"},{"line_number":452,"context_line":"          - if:"},{"line_number":453,"context_line":"              - use_tls_for_live_migration"},{"line_number":454,"context_line":"              - tripleo::profile::base::nova::migration::client::libvirt_tls: true"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1fd0f25e_76c8e95e","line":451,"range":{"start_line":451,"start_character":12,"end_line":451,"end_character":47},"updated":"2021-10-06 14:46:19.000000000","message":"This is not required.","commit_id":"768b66f885cd43552e63acfeb6c2ab68a5668e90"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"27e1ca58ce00c8115054c1c83d7a4211a4399c6a","unresolved":true,"context_lines":[{"line_number":898,"context_line":"                - { \u0027path\u0027: /var/lib/libvirt, \u0027setype\u0027: container_file_t }"},{"line_number":899,"context_line":"                - { \u0027path\u0027: /var/cache/libvirt }"},{"line_number":900,"context_line":"                - { \u0027path\u0027: /var/lib/nova, \u0027setype\u0027: container_file_t }"},{"line_number":901,"context_line":"                - { \u0027path\u0027: /run/libvirt, \u0027setype\u0027: virt_var_run_t }"},{"line_number":902,"context_line":"                - { \u0027path\u0027: /var/log/libvirt, \u0027setype\u0027: container_file_t }"},{"line_number":903,"context_line":"                - { \u0027path\u0027: /var/log/libvirt/qemu, \u0027setype\u0027: container_file_t }"},{"line_number":904,"context_line":"            # qemu user on host will be cretaed by libvirt package install, ensure"},{"line_number":905,"context_line":"            # the qemu user created with same uid/gid as like libvirt package."},{"line_number":906,"context_line":"            # These specific values are required since ovs is running on host."}],"source_content_type":"text/x-yaml","patch_set":32,"id":"175bfbcb_877a8400","line":903,"range":{"start_line":901,"start_character":68,"end_line":903,"end_character":79},"updated":"2021-10-06 14:46:19.000000000","message":"the same is implemented in NovaLibvirtLogging.","commit_id":"768b66f885cd43552e63acfeb6c2ab68a5668e90"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"bdc873cbe541f13e5301ffb74f4f72ecc8e7df2b","unresolved":true,"context_lines":[{"line_number":898,"context_line":"                - { \u0027path\u0027: /var/lib/libvirt, \u0027setype\u0027: container_file_t }"},{"line_number":899,"context_line":"                - { \u0027path\u0027: /var/cache/libvirt }"},{"line_number":900,"context_line":"                - { \u0027path\u0027: /var/lib/nova, \u0027setype\u0027: container_file_t }"},{"line_number":901,"context_line":"                - { \u0027path\u0027: /run/libvirt, \u0027setype\u0027: virt_var_run_t }"},{"line_number":902,"context_line":"                - { \u0027path\u0027: /var/log/libvirt, \u0027setype\u0027: container_file_t }"},{"line_number":903,"context_line":"                - { \u0027path\u0027: /var/log/libvirt/qemu, \u0027setype\u0027: container_file_t }"},{"line_number":904,"context_line":"            # qemu user on host will be cretaed by libvirt package install, ensure"},{"line_number":905,"context_line":"            # the qemu user created with same uid/gid as like libvirt package."},{"line_number":906,"context_line":"            # These specific values are required since ovs is running on host."}],"source_content_type":"text/x-yaml","patch_set":32,"id":"f847ecdb_2e5e3255","line":903,"range":{"start_line":901,"start_character":68,"end_line":903,"end_character":79},"in_reply_to":"175bfbcb_877a8400","updated":"2021-10-08 13:03:43.000000000","message":"it\u0027s different here in NovaLibvirtLogging as -\n\n\" - { \u0027path\u0027: /var/log/containers/libvirt, \u0027setype\u0027: container_file_t, \u0027mode\u0027: \u00270750\u0027 }\"\n\nhttps://opendev.org/openstack/tripleo-heat-templates/src/branch/master/deployment/logging/files/nova-libvirt.yaml#L140","commit_id":"768b66f885cd43552e63acfeb6c2ab68a5668e90"}],"deployment/nova/nova-virt-common.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"8efd2f2fc43f40ed289fcd58c97b5d13fd88dd42","unresolved":true,"context_lines":[{"line_number":70,"context_line":"  CephClientUserName:"},{"line_number":71,"context_line":"    default: openstack"},{"line_number":72,"context_line":"    type: string"},{"line_number":73,"context_line":"  CephClusterName:"},{"line_number":74,"context_line":"    type: string"},{"line_number":75,"context_line":"    default: ceph"},{"line_number":76,"context_line":"    description: The Ceph cluster name."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"87e86fab_8170b273","line":73,"updated":"2021-09-03 13:47:43.000000000","message":"The Ceph parameters need an update in here.\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/deployment/nova/nova-libvirt-container-puppet.yaml#L78-L86","commit_id":"3081f969b987890cbfae1b94e464b882b48cc5d7"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"f615fbd10fea3cb32f14f6b2ba6e27595c0dc299","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  CephClientUserName:"},{"line_number":71,"context_line":"    default: openstack"},{"line_number":72,"context_line":"    type: string"},{"line_number":73,"context_line":"  CephClusterName:"},{"line_number":74,"context_line":"    type: string"},{"line_number":75,"context_line":"    default: ceph"},{"line_number":76,"context_line":"    description: The Ceph cluster name."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"4ce5cb36_0f0c0f57","line":73,"in_reply_to":"87e86fab_8170b273","updated":"2021-09-04 05:20:06.000000000","message":"Done","commit_id":"3081f969b987890cbfae1b94e464b882b48cc5d7"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"8efd2f2fc43f40ed289fcd58c97b5d13fd88dd42","unresolved":true,"context_lines":[{"line_number":127,"context_line":"    description: Common kolla permissions."},{"line_number":128,"context_line":"    value:"},{"line_number":129,"context_line":"      list_concat:"},{"line_number":130,"context_line":"        -"},{"line_number":131,"context_line":"          - path:"},{"line_number":132,"context_line":"              str_replace:"},{"line_number":133,"context_line":"                template: /etc/ceph/CLUSTER.client.USER.keyring"},{"line_number":134,"context_line":"                params:"},{"line_number":135,"context_line":"                  CLUSTER: {get_param: CephClusterName}"},{"line_number":136,"context_line":"                  USER: {get_param: CephClientUserName}"},{"line_number":137,"context_line":"            owner: nova:nova"},{"line_number":138,"context_line":"            perm: \u00270600\u0027"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  volumes:"},{"line_number":141,"context_line":"    description: Common volumes for all moduler virt daemons."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ff70c270_21113735","line":138,"range":{"start_line":130,"start_character":0,"end_line":138,"end_character":24},"updated":"2021-09-03 13:47:43.000000000","message":"need to be updated \n\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/deployment/nova/nova-libvirt-container-puppet.yaml#L467-L487","commit_id":"3081f969b987890cbfae1b94e464b882b48cc5d7"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"f615fbd10fea3cb32f14f6b2ba6e27595c0dc299","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    description: Common kolla permissions."},{"line_number":128,"context_line":"    value:"},{"line_number":129,"context_line":"      list_concat:"},{"line_number":130,"context_line":"        -"},{"line_number":131,"context_line":"          - path:"},{"line_number":132,"context_line":"              str_replace:"},{"line_number":133,"context_line":"                template: /etc/ceph/CLUSTER.client.USER.keyring"},{"line_number":134,"context_line":"                params:"},{"line_number":135,"context_line":"                  CLUSTER: {get_param: CephClusterName}"},{"line_number":136,"context_line":"                  USER: {get_param: CephClientUserName}"},{"line_number":137,"context_line":"            owner: nova:nova"},{"line_number":138,"context_line":"            perm: \u00270600\u0027"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  volumes:"},{"line_number":141,"context_line":"    description: Common volumes for all moduler virt daemons."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"cd30b84f_4c6b335f","line":138,"range":{"start_line":130,"start_character":0,"end_line":138,"end_character":24},"in_reply_to":"ff70c270_21113735","updated":"2021-09-04 05:20:06.000000000","message":"Done","commit_id":"3081f969b987890cbfae1b94e464b882b48cc5d7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"27e1ca58ce00c8115054c1c83d7a4211a4399c6a","unresolved":true,"context_lines":[{"line_number":154,"context_line":"            - - str_replace:"},{"line_number":155,"context_line":"                  template: \"MEMORY_BACKING_DIR:MEMORY_BACKING_DIR\""},{"line_number":156,"context_line":"                  params:"},{"line_number":157,"context_line":"                    MEMORY_BACKING_DIR: {get_attr: [RoleParametersValue, value, memory_backing_dir]}"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":32,"id":"7d506ed2_d3e4eeb8","line":157,"range":{"start_line":157,"start_character":52,"end_line":157,"end_character":71},"updated":"2021-10-06 14:46:19.000000000","message":"This can\u0027t be looked up by this template.","commit_id":"768b66f885cd43552e63acfeb6c2ab68a5668e90"}],"releasenotes/notes/modular-libvirt-daemons-b5ad6043d6510077.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e328315154e97bdccb8db9a2bf145d17a4e2abbb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This change adds functionality to enable modular libvirt daemons."},{"line_number":5,"context_line":"    All these daemons runs in its respective container. Also the default"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"87001c77_8bbd9f67","line":2,"updated":"2021-09-07 15:05:51.000000000","message":"please also mention NovaModularLibvirtDaemons and logging params added","commit_id":"9c6c47558b301cf0b82c37be48a1da8ef827ddbe"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"257fbf6774abacf4d6686c1fff382332366a17c5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This change adds functionality to enable modular libvirt daemons."},{"line_number":5,"context_line":"    All these daemons runs in its respective container. Also the default"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"839c99bc_2b0e13ba","line":2,"in_reply_to":"87001c77_8bbd9f67","updated":"2021-09-07 18:26:52.000000000","message":"Done","commit_id":"9c6c47558b301cf0b82c37be48a1da8ef827ddbe"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"288e37e6017591263cd6101ebbfa8c15fab516f6","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    - ``LibvirtVirtproxydLogFilters``"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    It\u0027s also important to note the inclusiong of the already-deprecated parameter"},{"line_number":25,"context_line":"    ``NovaModularLibvirtDaemons`` that will give operators the possibility to deploy"},{"line_number":26,"context_line":"    monolithic libvirt while it\u0027s still available."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    More information regarding modular libvirt daemons is available here."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"c39c0ba9_31c9ddd2","line":25,"updated":"2021-09-09 12:00:58.000000000","message":"after removal of the param, this looks no longer actual","commit_id":"a69d344032d3033bf3a1526151695f12c15885ef"}]}