)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c2c35eb9b9fa3a58e0c708f5aae74dedbfe72499","unresolved":true,"context_lines":[{"line_number":12,"context_line":"This change removes override of uefi_pxe parameters because the values"},{"line_number":13,"context_line":"passed should be used for iPXE instead of PXE."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] 4d13da9cc7b8f8fa9ee428731f88d5723eddeffa"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I107a5df068df3c6ea636cf4b4783a417ab249f38"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"a0d3d8ee_9ee75a30","line":15,"range":{"start_line":15,"start_character":4,"end_line":15,"end_character":44},"updated":"2021-09-22 23:55:11.000000000","message":"For record I pointed the wrong patch and this should be 5f7d84f483be165fde04954453e156ceefc43d28 instead...","commit_id":"bd7c489dc7346f071f15080c2b6c4715e39bbb3c"}],"deployment/ironic/ironic-conductor-container-puppet.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"150bd95352e8a07dedbaae4f96eef6e8520a4b17","unresolved":true,"context_lines":[{"line_number":427,"context_line":"                params:"},{"line_number":428,"context_line":"                  $NETWORK: {get_param: [ServiceNetMap, IronicNetwork]}"},{"line_number":429,"context_line":"            # NOTE(dtantsur): UEFI only works with iPXE currently for us"},{"line_number":430,"context_line":"            ironic::drivers::pxe::uefi_pxe_config_template: \u0027$pybasedir/drivers/modules/ipxe_config.template\u0027"},{"line_number":431,"context_line":"            ironic::drivers::pxe::uefi_pxe_bootfile_name: \u0027snponly.efi\u0027"},{"line_number":432,"context_line":"            ironic::pxe::ipxe_name_base: \u0027ipxe-snponly\u0027"},{"line_number":433,"context_line":"            ironic::pxe::uefi_ipxe_bootfile_name: \u0027snponly.efi\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1bdc8290_bd9abfa7","line":430,"range":{"start_line":430,"start_character":3,"end_line":430,"end_character":109},"updated":"2021-08-10 03:58:59.000000000","message":"I never thought about this now, but fundimentally this is shooting the pxe interface in the foot if someone wishes to use it. Quite literally, the service knows better and it would be better to rip the overrides out.","commit_id":"7bed4c5343705b1aaeffb4eccd6f3ffa1f1e2d16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"150bd95352e8a07dedbaae4f96eef6e8520a4b17","unresolved":true,"context_lines":[{"line_number":428,"context_line":"                  $NETWORK: {get_param: [ServiceNetMap, IronicNetwork]}"},{"line_number":429,"context_line":"            # NOTE(dtantsur): UEFI only works with iPXE currently for us"},{"line_number":430,"context_line":"            ironic::drivers::pxe::uefi_pxe_config_template: \u0027$pybasedir/drivers/modules/ipxe_config.template\u0027"},{"line_number":431,"context_line":"            ironic::drivers::pxe::uefi_pxe_bootfile_name: \u0027snponly.efi\u0027"},{"line_number":432,"context_line":"            ironic::pxe::ipxe_name_base: \u0027ipxe-snponly\u0027"},{"line_number":433,"context_line":"            ironic::pxe::uefi_ipxe_bootfile_name: \u0027snponly.efi\u0027"},{"line_number":434,"context_line":"            ironic::drivers::agent::deploy_logs_storage_backend: {get_param: IronicDeployLogsStorageBackend}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f5945aa_96cfe5fa","line":431,"range":{"start_line":431,"start_character":0,"end_line":431,"end_character":71},"updated":"2021-08-10 03:58:59.000000000","message":"So ultimately, we shouldn\u0027t set this for PXE. Ironic has two interfaces, ipxe and pxe. We want people to be able to independently use them as makes sense. Overriding them is just wrong.\n\nThis entire config is ironic\u0027s classic PXE interface settings and not iPXE","commit_id":"7bed4c5343705b1aaeffb4eccd6f3ffa1f1e2d16"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"31b7105b6d90c3873495f1102a055b9b0aa59e92","unresolved":true,"context_lines":[{"line_number":428,"context_line":"                  $NETWORK: {get_param: [ServiceNetMap, IronicNetwork]}"},{"line_number":429,"context_line":"            # NOTE(dtantsur): UEFI only works with iPXE currently for us"},{"line_number":430,"context_line":"            ironic::drivers::pxe::uefi_pxe_config_template: \u0027$pybasedir/drivers/modules/ipxe_config.template\u0027"},{"line_number":431,"context_line":"            ironic::drivers::pxe::uefi_pxe_bootfile_name: \u0027snponly.efi\u0027"},{"line_number":432,"context_line":"            ironic::pxe::ipxe_name_base: \u0027ipxe-snponly\u0027"},{"line_number":433,"context_line":"            ironic::pxe::uefi_ipxe_bootfile_name: \u0027snponly.efi\u0027"},{"line_number":434,"context_line":"            ironic::drivers::agent::deploy_logs_storage_backend: {get_param: IronicDeployLogsStorageBackend}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9b67ee3e_8e99c26b","line":431,"range":{"start_line":431,"start_character":0,"end_line":431,"end_character":71},"in_reply_to":"7f5945aa_96cfe5fa","updated":"2021-08-10 04:48:33.000000000","message":"It was just my mistake(or mislook) and I thought this was pointing to uefi_ipxe_bootfile_name. Maybe we can just remove these definitions and rely on defaults defined in puppet-ironic.","commit_id":"7bed4c5343705b1aaeffb4eccd6f3ffa1f1e2d16"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e0e35119070c2cb3ce7712e8852ff58ae5ab167d","unresolved":true,"context_lines":[{"line_number":428,"context_line":"                  $NETWORK: {get_param: [ServiceNetMap, IronicNetwork]}"},{"line_number":429,"context_line":"            # NOTE(dtantsur): UEFI only works with iPXE currently for us"},{"line_number":430,"context_line":"            ironic::drivers::pxe::uefi_pxe_config_template: \u0027$pybasedir/drivers/modules/ipxe_config.template\u0027"},{"line_number":431,"context_line":"            ironic::drivers::pxe::uefi_pxe_bootfile_name: \u0027snponly.efi\u0027"},{"line_number":432,"context_line":"            ironic::pxe::ipxe_name_base: \u0027ipxe-snponly\u0027"},{"line_number":433,"context_line":"            ironic::pxe::uefi_ipxe_bootfile_name: \u0027snponly.efi\u0027"},{"line_number":434,"context_line":"            ironic::drivers::agent::deploy_logs_storage_backend: {get_param: IronicDeployLogsStorageBackend}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"debc9329_ccef1401","line":431,"range":{"start_line":431,"start_character":0,"end_line":431,"end_character":71},"in_reply_to":"9b67ee3e_8e99c26b","updated":"2021-08-10 05:05:03.000000000","message":"So what I should have done was not change the value but remove this overrides completely because this parameter is for PXE boot while ipxe.efi is for iPXE boot. Because the change in puppet-ironic has been backported, we should backport this back to train as well.\n\nI have create a separate commit to set \"iPXE\" parameters to enforce usage of snponly.efi, which I initially intended... If snponly.efi is a preferred option then backporting that patch would make sense, too.","commit_id":"7bed4c5343705b1aaeffb4eccd6f3ffa1f1e2d16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e4e31f6ba5f356cfacb356ad7d39fff4e195e65b","unresolved":true,"context_lines":[{"line_number":426,"context_line":"                  \"%{hiera(\u0027$NETWORK_uri\u0027)}\""},{"line_number":427,"context_line":"                params:"},{"line_number":428,"context_line":"                  $NETWORK: {get_param: [ServiceNetMap, IronicNetwork]}"},{"line_number":429,"context_line":"            # NOTE(dtantsur): UEFI only works with iPXE currently for us"},{"line_number":430,"context_line":"            ironic::drivers::pxe::uefi_pxe_config_template: \u0027$pybasedir/drivers/modules/ipxe_config.template\u0027"},{"line_number":431,"context_line":"            ironic::drivers::pxe::uefi_pxe_bootfile_name: \u0027ipxe.efi\u0027"},{"line_number":432,"context_line":"            ironic::drivers::agent::deploy_logs_storage_backend: {get_param: IronicDeployLogsStorageBackend}"},{"line_number":433,"context_line":"            ironic::drivers::agent::deploy_logs_local_path: \u0027/var/log/ironic/deploy/\u0027"},{"line_number":434,"context_line":"            ironic::drivers::agent::deploy_logs_collect:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e7cd2239_878f7ca3","side":"PARENT","line":431,"range":{"start_line":429,"start_character":0,"end_line":431,"end_character":68},"updated":"2021-08-23 19:29:52.000000000","message":"So these are actually best to be removed because they break the \"pxe\" boot interface as opposed to the \"ipxe\" boot interface. If TripleO were to explicitly say \"We want to support grub on this interface\", I would say \"cool cool\" and say the appropriate settings need to be used... and grub files put into place. :\\","commit_id":"087a703fe136dbe351d2cff3da8041e7a9775bb9"}]}