)]}'
{"deployment/nova/nova-api-container-puppet.yaml":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"0b9a85ee889ca7db40b0b456b3db7dcd6a4200fc","unresolved":true,"context_lines":[{"line_number":59,"context_line":"    default: 0"},{"line_number":60,"context_line":"    description: Number of workers for Nova services."},{"line_number":61,"context_line":"    type: number"},{"line_number":62,"context_line":"  NovaEnforceSecureRbac:"},{"line_number":63,"context_line":"    description: \u003e"},{"line_number":64,"context_line":"      Enforcing authorization based on common RBAC personas only for Nova APIs."},{"line_number":65,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2c6557f5_605a219c","line":62,"range":{"start_line":62,"start_character":2,"end_line":62,"end_character":23},"updated":"2021-08-19 17:13:10.000000000","message":"This going back and forth in another review [0] to see if we should add a single global parameter or not.\n\n[0] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/781571","commit_id":"0ab165e21ebc62192ee1c3bf39c69ada64cd46cc"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"3927b023829cc28e8cea219abf887184f554faae","unresolved":true,"context_lines":[{"line_number":59,"context_line":"    default: 0"},{"line_number":60,"context_line":"    description: Number of workers for Nova services."},{"line_number":61,"context_line":"    type: number"},{"line_number":62,"context_line":"  NovaEnforceSecureRbac:"},{"line_number":63,"context_line":"    description: \u003e"},{"line_number":64,"context_line":"      Enforcing authorization based on common RBAC personas only for Nova APIs."},{"line_number":65,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cc28952f_4f2705e2","line":62,"range":{"start_line":62,"start_character":2,"end_line":62,"end_character":23},"in_reply_to":"2c6557f5_605a219c","updated":"2021-08-27 20:57:31.000000000","message":"Based on the conversation in another change [0], I added a separate global option for this [1]. I also updated a separate change using the global that you can use for an example [2].\n\n[0] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/781571/14\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/806449/1\n[2] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/804277","commit_id":"0ab165e21ebc62192ee1c3bf39c69ada64cd46cc"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6f57bda0c0f82891b08fb7de9ad1ad3b84def76e","unresolved":true,"context_lines":[{"line_number":61,"context_line":"    type: number"},{"line_number":62,"context_line":"  EnforceSecureRbac:"},{"line_number":63,"context_line":"    description: \u003e"},{"line_number":64,"context_line":"      Enforcing authorization based on common RBAC personas only for Nova APIs."},{"line_number":65,"context_line":"    type: boolean"},{"line_number":66,"context_line":"    default: false"},{"line_number":67,"context_line":"  KeystoneRegion:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e29f6527_0918a7f3","line":64,"range":{"start_line":64,"start_character":69,"end_line":64,"end_character":73},"updated":"2021-09-07 21:39:12.000000000","message":"Same comment here as in the other patches that are using this variable. Should this variable be defined consistently? Just curious, which description wins, the last one registered?","commit_id":"9be787240c2dbdf215e00fa12d082b1b071b98a6"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"fffa81177fd6db0669a6815e922feb67eb8a5e39","unresolved":true,"context_lines":[{"line_number":61,"context_line":"    type: number"},{"line_number":62,"context_line":"  EnforceSecureRbac:"},{"line_number":63,"context_line":"    description: \u003e"},{"line_number":64,"context_line":"      Enforcing authorization based on common RBAC personas only for Nova APIs."},{"line_number":65,"context_line":"    type: boolean"},{"line_number":66,"context_line":"    default: false"},{"line_number":67,"context_line":"  KeystoneRegion:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"cf0886e1_e1274aad","line":64,"range":{"start_line":64,"start_character":69,"end_line":64,"end_character":73},"in_reply_to":"e29f6527_0918a7f3","updated":"2021-09-29 13:21:57.000000000","message":"if it\u0027s meant to be global, then the description should not say for Nova only. If we want service specific ones, I\u0027d use NovaEnforceSecureRbac.","commit_id":"9be787240c2dbdf215e00fa12d082b1b071b98a6"}]}