)]}'
{"deployment/swift/swift-proxy-container-puppet.yaml":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"999f1677ce45dfd996860ca4c148119833993590","unresolved":true,"context_lines":[{"line_number":90,"context_line":"    default: \u0027\u0027"},{"line_number":91,"context_line":"    description: Indicate whether this resource may be shared with the domain received in the request"},{"line_number":92,"context_line":"                 \"origin\" header."},{"line_number":93,"context_line":"  SwiftEnforceSecureRbac:"},{"line_number":94,"context_line":"    description: \u003e"},{"line_number":95,"context_line":"      Enforcing authorization based on common RBAC personas only for Swift APIs."},{"line_number":96,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f747ee05_987d1207","line":93,"range":{"start_line":93,"start_character":2,"end_line":93,"end_character":24},"updated":"2021-08-27 20:56:23.000000000","message":"Based on the conversation in another change [0], I added a separate global option for this [1]. I also updated a separate change using the global that you can use for an example [2].\n\n[0] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/781571/14\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/806449/1\n[2] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/804277","commit_id":"a725869b0d5e7563541df404b6bcc77472f1df57"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"238ea74ad3558185bf73c315fdfe2950ec1d06c1","unresolved":true,"context_lines":[{"line_number":185,"context_line":"              - ResellerAdmin"},{"line_number":186,"context_line":"          - if:"},{"line_number":187,"context_line":"            - {get_param: SwiftEnforceSecureRbac}"},{"line_number":188,"context_line":"            - tripleo::profile::base::swift::proxy::enforce_new_defaults: true"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"          - swift::proxy::versioned_writes::allow_versioned_writes: true"},{"line_number":191,"context_line":"          - if:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f0cfae29_d3ec3c0b","line":188,"range":{"start_line":188,"start_character":14,"end_line":188,"end_character":78},"updated":"2021-08-27 13:25:41.000000000","message":"As I mentioned in the puppet-tripleo patch you can define hieradata for puppet-swift directly.","commit_id":"a725869b0d5e7563541df404b6bcc77472f1df57"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"238ea74ad3558185bf73c315fdfe2950ec1d06c1","unresolved":true,"context_lines":[{"line_number":187,"context_line":"            - {get_param: SwiftEnforceSecureRbac}"},{"line_number":188,"context_line":"            - tripleo::profile::base::swift::proxy::enforce_new_defaults: true"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"          - swift::proxy::versioned_writes::allow_versioned_writes: true"},{"line_number":191,"context_line":"          - if:"},{"line_number":192,"context_line":"            - {get_param: SwiftEncryptionEnabled}"},{"line_number":193,"context_line":"            - swift::keymaster::key_id: \u0027test_id\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"24b14302_1a372cb9","line":190,"range":{"start_line":190,"start_character":10,"end_line":190,"end_character":11},"updated":"2021-08-27 13:25:41.000000000","message":"This should be removed and the line should be inserted between L185 and L186. This requires additional map_merge which looks inefficient.","commit_id":"a725869b0d5e7563541df404b6bcc77472f1df57"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a20f081d85033264c2ad8c24f8411b66fcf9078d","unresolved":true,"context_lines":[{"line_number":90,"context_line":"    default: \u0027\u0027"},{"line_number":91,"context_line":"    description: Indicate whether this resource may be shared with the domain received in the request"},{"line_number":92,"context_line":"                 \"origin\" header."},{"line_number":93,"context_line":"  EnforceSecureRbac:"},{"line_number":94,"context_line":"    type: boolean"},{"line_number":95,"context_line":"    default: false"},{"line_number":96,"context_line":"    description: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"80c2a48f_12b0d3c7","line":93,"updated":"2021-08-30 21:35:41.000000000","message":"I think this is already proposed here [0].\n\nCan we re-use that implementation?\n\n[0] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/806449/3/deployment/keystone/keystone-container-puppet.yaml","commit_id":"762f5056d5d78ff58ee29962443ecc422dc1e980"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"0a020887e5ad1eac3741452c55fe61e3c9ee1fbc","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    default: \u0027\u0027"},{"line_number":91,"context_line":"    description: Indicate whether this resource may be shared with the domain received in the request"},{"line_number":92,"context_line":"                 \"origin\" header."},{"line_number":93,"context_line":"  EnforceSecureRbac:"},{"line_number":94,"context_line":"    type: boolean"},{"line_number":95,"context_line":"    default: false"},{"line_number":96,"context_line":"    description: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"a4b0f354_0ba529ff","line":93,"in_reply_to":"72d77b28_c55aa820","updated":"2021-09-07 21:40:50.000000000","message":"Ack","commit_id":"762f5056d5d78ff58ee29962443ecc422dc1e980"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1c8dd684b657c423a074f346d213070b74d28df6","unresolved":true,"context_lines":[{"line_number":90,"context_line":"    default: \u0027\u0027"},{"line_number":91,"context_line":"    description: Indicate whether this resource may be shared with the domain received in the request"},{"line_number":92,"context_line":"                 \"origin\" header."},{"line_number":93,"context_line":"  EnforceSecureRbac:"},{"line_number":94,"context_line":"    type: boolean"},{"line_number":95,"context_line":"    default: false"},{"line_number":96,"context_line":"    description: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"72d77b28_c55aa820","line":93,"in_reply_to":"80c2a48f_12b0d3c7","updated":"2021-08-31 04:25:18.000000000","message":"We need to add the parameter to each template refering the parameter so adding the same parameter to this template file for swift-proxy-server is the correct approach, IMO.","commit_id":"762f5056d5d78ff58ee29962443ecc422dc1e980"}]}