)]}'
{"overcloud.j2.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e44e298a2f16b2ce15ca447b32a8944bb83a4706","unresolved":true,"context_lines":[{"line_number":438,"context_line":"{%- if role.deprecated_param_extraconfig is defined %}"},{"line_number":439,"context_line":"    - {{role.deprecated_param_extraconfig}}"},{"line_number":440,"context_line":"{%- endif %}"},{"line_number":441,"context_line":"{%- endfor %} "},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"conditions:"},{"line_number":444,"context_line":"  add_vips_to_etc_hosts: {equals : [{get_param: AddVipsToEtcHosts}, True]}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"77d51f82_467378ec","line":441,"range":{"start_line":441,"start_character":13,"end_line":441,"end_character":14},"updated":"2021-08-27 19:13:35.000000000","message":"nit: whitespace.","commit_id":"10761f58ec00d8632f66a64baf350a0585ff3aed"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"f91f3eb956325f233402e6071eb0dc18ad8b31f2","unresolved":false,"context_lines":[{"line_number":438,"context_line":"{%- if role.deprecated_param_extraconfig is defined %}"},{"line_number":439,"context_line":"    - {{role.deprecated_param_extraconfig}}"},{"line_number":440,"context_line":"{%- endif %}"},{"line_number":441,"context_line":"{%- endfor %} "},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"conditions:"},{"line_number":444,"context_line":"  add_vips_to_etc_hosts: {equals : [{get_param: AddVipsToEtcHosts}, True]}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"52c79c26_e5de5691","line":441,"range":{"start_line":441,"start_character":13,"end_line":441,"end_character":14},"in_reply_to":"77d51f82_467378ec","updated":"2021-08-27 23:18:14.000000000","message":"Done","commit_id":"10761f58ec00d8632f66a64baf350a0585ff3aed"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e44e298a2f16b2ce15ca447b32a8944bb83a4706","unresolved":true,"context_lines":[{"line_number":675,"context_line":"    properties:"},{"line_number":676,"context_line":"      value:"},{"line_number":677,"context_line":"        if:"},{"line_number":678,"context_line":"        - {{role.name}}_network_config_update_exists"},{"line_number":679,"context_line":"        - {get_param: {{role.name}}NetworkConfigUpdate}"},{"line_number":680,"context_line":"        - {get_param: NetworkConfigUpdate}"},{"line_number":681,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"15fdaf68_c2c735d3","line":678,"range":{"start_line":678,"start_character":10,"end_line":678,"end_character":52},"updated":"2021-08-27 19:13:35.000000000","message":"Do we need the heat conditional?\n\nCan we not just do this?\n\n  if:\n  - {get_param: {{role.name}}NetworkConfigUpdate}\n  - {get_param: {{role.name}}NetworkConfigUpdate}\n  - {get_param: NetworkConfigUpdate}\n\n\nIn any case, the explicitly setting \u0027false\u0027 for a role won\u0027t turn of updates for that role when NetworkConfigUpdate is true. I.e if you do the below, that can be a bit confusing and the old code allowed to use such a pattern. Should we just drop the \"global\" NetworkConfigUpdate and require the operator to set it for each individual role?\n\n NetworkConfigUpdate: true\n ControllerNetworkConfigUpdate: false","commit_id":"10761f58ec00d8632f66a64baf350a0585ff3aed"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"f91f3eb956325f233402e6071eb0dc18ad8b31f2","unresolved":true,"context_lines":[{"line_number":675,"context_line":"    properties:"},{"line_number":676,"context_line":"      value:"},{"line_number":677,"context_line":"        if:"},{"line_number":678,"context_line":"        - {{role.name}}_network_config_update_exists"},{"line_number":679,"context_line":"        - {get_param: {{role.name}}NetworkConfigUpdate}"},{"line_number":680,"context_line":"        - {get_param: NetworkConfigUpdate}"},{"line_number":681,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ba3abe13_201a7438","line":678,"range":{"start_line":678,"start_character":10,"end_line":678,"end_character":52},"in_reply_to":"15fdaf68_c2c735d3","updated":"2021-08-27 23:18:14.000000000","message":"I\u0027ll have a think about this one. I guess we\u0027re just setting this Heat Value so that we can get_attr it in the map_merge section. The if statement might be able to move to there instead I guess.\n\nMight be difficult make it role based and also global while avoiding that. Maybe documenting it better would help. \n\nRe, dropping the global. I mean, if you have 10 roles, it\u0027s a bit annoying to set it for each role. I imagine people would like having the ability to set it globally. Happy for it to be a point of discussion thought and see what everyone thinks.","commit_id":"10761f58ec00d8632f66a64baf350a0585ff3aed"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"5f95e814d6562446d7e92f8ea7667bf839a8f518","unresolved":true,"context_lines":[{"line_number":675,"context_line":"    properties:"},{"line_number":676,"context_line":"      value:"},{"line_number":677,"context_line":"        if:"},{"line_number":678,"context_line":"        - {{role.name}}_network_config_update_exists"},{"line_number":679,"context_line":"        - {get_param: {{role.name}}NetworkConfigUpdate}"},{"line_number":680,"context_line":"        - {get_param: NetworkConfigUpdate}"},{"line_number":681,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"f6e6a7bf_b2ea5e13","line":678,"range":{"start_line":678,"start_character":10,"end_line":678,"end_character":52},"in_reply_to":"841cdc00_70bf8eea","updated":"2021-09-13 04:54:40.000000000","message":"I missed this comment sorry. Yeah, so I left the global there just because it\u0027s annoying if you have multiple roles and your intention is to update all of them. I guess we could remove the global and just leave it role based if that\u0027s  the direction we all want to take with this?","commit_id":"10761f58ec00d8632f66a64baf350a0585ff3aed"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"4c28f03efec4a849d70fe97ccfaa3a74d532a0eb","unresolved":true,"context_lines":[{"line_number":675,"context_line":"    properties:"},{"line_number":676,"context_line":"      value:"},{"line_number":677,"context_line":"        if:"},{"line_number":678,"context_line":"        - {{role.name}}_network_config_update_exists"},{"line_number":679,"context_line":"        - {get_param: {{role.name}}NetworkConfigUpdate}"},{"line_number":680,"context_line":"        - {get_param: NetworkConfigUpdate}"},{"line_number":681,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"841cdc00_70bf8eea","line":678,"range":{"start_line":678,"start_character":10,"end_line":678,"end_character":52},"in_reply_to":"ba3abe13_201a7438","updated":"2021-09-01 08:34:39.000000000","message":"I believe we can solve this using role-specific parameters. https://docs.openstack.org/project-deploy-guide/tripleo-docs/latest/features/role_specific_parameters.html\n\nSince it is a new parameter, it can ben modified to use this format - WDYT?","commit_id":"10761f58ec00d8632f66a64baf350a0585ff3aed"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"c5ac962b2a52fe01ee4cd6f8e0c4e1fc4afe1a5d","unresolved":true,"context_lines":[{"line_number":675,"context_line":"    properties:"},{"line_number":676,"context_line":"      value:"},{"line_number":677,"context_line":"        if:"},{"line_number":678,"context_line":"        - {{role.name}}_network_config_update_exists"},{"line_number":679,"context_line":"        - {get_param: {{role.name}}NetworkConfigUpdate}"},{"line_number":680,"context_line":"        - {get_param: NetworkConfigUpdate}"},{"line_number":681,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"a2d0294f_467008b7","line":678,"range":{"start_line":678,"start_character":10,"end_line":678,"end_character":52},"in_reply_to":"f6e6a7bf_b2ea5e13","updated":"2021-09-13 05:41:42.000000000","message":"IMO, this configuration is not used by users so frequently as it has implications based on changes on nic config. So I prefer to go with removing global.\n\nOR\n\nAlternatively, if global is preferred then, the limitation can be overcome by using the other role-specific format, like below:\n\nNetworkConfigUpdate: true\nComputeAParameters:\n  NetworkConfigUpdate: false","commit_id":"10761f58ec00d8632f66a64baf350a0585ff3aed"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"3e668647958f207bf61a5891d2db8a62bb245d1a","unresolved":true,"context_lines":[{"line_number":148,"context_line":"  NetworkDeploymentActions:"},{"line_number":149,"context_line":"    type: comma_delimited_list"},{"line_number":150,"context_line":"    description: \u003e"},{"line_number":151,"context_line":"      DEPRECATED - Use NetworkConfigUpdate instead."},{"line_number":152,"context_line":"    default: [\u0027CREATE\u0027]"},{"line_number":153,"context_line":"  NetworkConfigUpdate:"},{"line_number":154,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3340cdb8_3b051d98","line":151,"range":{"start_line":151,"start_character":6,"end_line":151,"end_character":51},"updated":"2021-09-13 06:00:46.000000000","message":"Probably need to mention that it\u0027s not used anymore.","commit_id":"4a48a2ccf45fccec7867bca27241f0d902a507bd"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"08f412d1860a4d3034124deb5e7581b11fa25023","unresolved":true,"context_lines":[{"line_number":148,"context_line":"  NetworkDeploymentActions:"},{"line_number":149,"context_line":"    type: comma_delimited_list"},{"line_number":150,"context_line":"    description: \u003e"},{"line_number":151,"context_line":"      DEPRECATED - Use NetworkConfigUpdate instead."},{"line_number":152,"context_line":"    default: [\u0027CREATE\u0027]"},{"line_number":153,"context_line":"  NetworkConfigUpdate:"},{"line_number":154,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"171c24d1_ea58d697","line":151,"range":{"start_line":151,"start_character":6,"end_line":151,"end_character":51},"in_reply_to":"3340cdb8_3b051d98","updated":"2021-09-13 06:12:27.000000000","message":"I think we can drop this parameter as it\u0027s not used and we don\u0027t do stack update with ephemeral heat for this to create any issues.","commit_id":"4a48a2ccf45fccec7867bca27241f0d902a507bd"}],"releasenotes/notes/network-update-var-355dbbb4daee7f46.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"00d5b4322ff4bed4382df077a5ff257da3b41bad","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Introduce new parameters {{role.name}}NetworkConfigUpdate."},{"line_number":5,"context_line":"    This will be a bool. When {{role.name}}NetworkConfigUpdate is True"},{"line_number":6,"context_line":"    existing network configurations will be updated. By default, this "},{"line_number":7,"context_line":"    is False and only new deployments will have the networks configured. "},{"line_number":8,"context_line":"    This parameter is role based only, with no global option."},{"line_number":9,"context_line":"deprecations:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"0e0a548e_6787221d","line":6,"range":{"start_line":6,"start_character":69,"end_line":6,"end_character":70},"updated":"2021-09-14 09:05:54.000000000","message":"empty spaces","commit_id":"5edb21ee3ee290f32c8c17ac1acc5083032e5ee6"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"00d5b4322ff4bed4382df077a5ff257da3b41bad","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    existing network configurations will be updated. By default, this "},{"line_number":7,"context_line":"    is False and only new deployments will have the networks configured. "},{"line_number":8,"context_line":"    This parameter is role based only, with no global option."},{"line_number":9,"context_line":"deprecations:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    This change removes NetworkDeploymentActions and"},{"line_number":12,"context_line":"    {{role.name}}NetworkDeploymentActions."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"4c82e208_4989a6ca","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":12},"updated":"2021-09-14 09:05:54.000000000","message":"Deprecations should not be used for something that is removed in the release, use upgrade section instead.\n\nhttps://docs.openstack.org/reno/latest/user/usage.html#editing-a-release-note","commit_id":"5edb21ee3ee290f32c8c17ac1acc5083032e5ee6"}]}