)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d63eed1f8c8c4740be21b443bccbd98019613ba9","unresolved":true,"context_lines":[{"line_number":15,"context_line":"find the container, or can\u0027t restart it."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Related rhbz#1973674"},{"line_number":18,"context_line":"Closes-Bug: #1940729"},{"line_number":19,"context_line":"Change-Id: I1b8c8e83d7b4a14a8643d63a61519f6bbac5b3d6"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ifafb2e71da1a921eeba8d8c6197cfb74d1ee045e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"93e1eb46_6d3a6655","line":21,"range":{"start_line":18,"start_character":20,"end_line":21,"end_character":52},"updated":"2021-08-23 00:04:23.000000000","message":"Please remove one of them.","commit_id":"0de954a6954de688c6317a0a857c807afa46feef"}],"deployment/haproxy/haproxy-public-tls-inject.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d63eed1f8c8c4740be21b443bccbd98019613ba9","unresolved":true,"context_lines":[{"line_number":176,"context_line":"                  shell: |"},{"line_number":177,"context_line":"                    set -e"},{"line_number":178,"context_line":"                    container_id\u003d$({{ container_cli }} ps --filter name\u003dhaproxy-bundle -q)"},{"line_number":179,"context_line":"                    if [[ $container_id ]]; then"},{"line_number":180,"context_line":"                      tar -c {{ cert_path }} | {{ container_cli }} exec -i $(echo $container_id) tar -C / -xv"},{"line_number":181,"context_line":"                    else"},{"line_number":182,"context_line":"                      {{ container_cli }} cp {{ cert_path }} {{ item }}:{{ cert_path }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ee487d56_12e594f1","line":179,"range":{"start_line":179,"start_character":26,"end_line":179,"end_character":39},"updated":"2021-08-23 00:04:23.000000000","message":"it seems this would fail when $container_id is empty.\n\n$ if [[ ]]; then\nbash: syntax error near `;\u0027\n\nI think it\u0027s better to use something like;\n\nif [[ \"x$container_id\" !\u003d \"x\" ]]; then","commit_id":"0de954a6954de688c6317a0a857c807afa46feef"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"1e4ec1a5d9287d5dd5bb1826ab4059b7eb957f0b","unresolved":true,"context_lines":[{"line_number":176,"context_line":"                  shell: |"},{"line_number":177,"context_line":"                    set -e"},{"line_number":178,"context_line":"                    container_id\u003d$({{ container_cli }} ps --filter name\u003dhaproxy-bundle -q)"},{"line_number":179,"context_line":"                    if [[ $container_id ]]; then"},{"line_number":180,"context_line":"                      tar -c {{ cert_path }} | {{ container_cli }} exec -i $(echo $container_id) tar -C / -xv"},{"line_number":181,"context_line":"                    else"},{"line_number":182,"context_line":"                      {{ container_cli }} cp {{ cert_path }} {{ item }}:{{ cert_path }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"14113a04_36876b11","line":179,"range":{"start_line":179,"start_character":26,"end_line":179,"end_character":39},"in_reply_to":"ee487d56_12e594f1","updated":"2021-08-23 00:20:57.000000000","message":"Yeah, this whole section can be improved, I agree. I\u0027ll try the suggested instead.","commit_id":"0de954a6954de688c6317a0a857c807afa46feef"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d63eed1f8c8c4740be21b443bccbd98019613ba9","unresolved":true,"context_lines":[{"line_number":177,"context_line":"                    set -e"},{"line_number":178,"context_line":"                    container_id\u003d$({{ container_cli }} ps --filter name\u003dhaproxy-bundle -q)"},{"line_number":179,"context_line":"                    if [[ $container_id ]]; then"},{"line_number":180,"context_line":"                      tar -c {{ cert_path }} | {{ container_cli }} exec -i $(echo $container_id) tar -C / -xv"},{"line_number":181,"context_line":"                    else"},{"line_number":182,"context_line":"                      {{ container_cli }} cp {{ cert_path }} {{ item }}:{{ cert_path }}"},{"line_number":183,"context_line":"                    fi"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5617e611_f3406038","line":180,"range":{"start_line":180,"start_character":75,"end_line":180,"end_character":96},"updated":"2021-08-23 00:04:23.000000000","message":"Can we get rid of echo here ?","commit_id":"0de954a6954de688c6317a0a857c807afa46feef"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"1e4ec1a5d9287d5dd5bb1826ab4059b7eb957f0b","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                    set -e"},{"line_number":178,"context_line":"                    container_id\u003d$({{ container_cli }} ps --filter name\u003dhaproxy-bundle -q)"},{"line_number":179,"context_line":"                    if [[ $container_id ]]; then"},{"line_number":180,"context_line":"                      tar -c {{ cert_path }} | {{ container_cli }} exec -i $(echo $container_id) tar -C / -xv"},{"line_number":181,"context_line":"                    else"},{"line_number":182,"context_line":"                      {{ container_cli }} cp {{ cert_path }} {{ item }}:{{ cert_path }}"},{"line_number":183,"context_line":"                    fi"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f66e9769_4a31a9ec","line":180,"range":{"start_line":180,"start_character":75,"end_line":180,"end_character":96},"in_reply_to":"5617e611_f3406038","updated":"2021-08-23 00:20:57.000000000","message":"Ack","commit_id":"0de954a6954de688c6317a0a857c807afa46feef"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b14eafd45dab5d30c10af2458a965f51ed088b22","unresolved":true,"context_lines":[{"line_number":181,"context_line":"                    else"},{"line_number":182,"context_line":"                      {{ container_cli }} cp {{ cert_path }} {{ item }}:{{ cert_path }}"},{"line_number":183,"context_line":"                    fi"},{"line_number":184,"context_line":"                    {{ container_cli }} exec --user root $(echo $container_id) chgrp haproxy {{ cert_path }}"},{"line_number":185,"context_line":"                    {{ container_cli }} kill --signal\u003dHUP $(echo $container_id)"},{"line_number":186,"context_line":"                  register: container_kill_result"},{"line_number":187,"context_line":"                  failed_when:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"30511974_bdbcb313","line":184,"range":{"start_line":184,"start_character":57,"end_line":184,"end_character":78},"updated":"2021-08-23 00:20:10.000000000","message":"This should be implemented in the above if block, otherwise this becomes an invalid command.","commit_id":"0de954a6954de688c6317a0a857c807afa46feef"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d63eed1f8c8c4740be21b443bccbd98019613ba9","unresolved":true,"context_lines":[{"line_number":185,"context_line":"                    {{ container_cli }} kill --signal\u003dHUP $(echo $container_id)"},{"line_number":186,"context_line":"                  register: container_kill_result"},{"line_number":187,"context_line":"                  failed_when:"},{"line_number":188,"context_line":"                    - (\"no such container\" in container_kill_result.stderr)"},{"line_number":189,"context_line":"                    - (\"container state improper\" in container_kill_result.stderr)"},{"line_number":190,"context_line":"                  with_items: \"{{ container_id.stdout.split(\u0027\\n\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"269a586d_2beae786","line":188,"updated":"2021-08-23 00:04:23.000000000","message":"Why did you remove these not ?","commit_id":"0de954a6954de688c6317a0a857c807afa46feef"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"1e4ec1a5d9287d5dd5bb1826ab4059b7eb957f0b","unresolved":true,"context_lines":[{"line_number":185,"context_line":"                    {{ container_cli }} kill --signal\u003dHUP $(echo $container_id)"},{"line_number":186,"context_line":"                  register: container_kill_result"},{"line_number":187,"context_line":"                  failed_when:"},{"line_number":188,"context_line":"                    - (\"no such container\" in container_kill_result.stderr)"},{"line_number":189,"context_line":"                    - (\"container state improper\" in container_kill_result.stderr)"},{"line_number":190,"context_line":"                  with_items: \"{{ container_id.stdout.split(\u0027\\n\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6fc58496_d7e172c3","line":188,"in_reply_to":"269a586d_2beae786","updated":"2021-08-23 00:20:57.000000000","message":"stderr contains: \"stderr\": \"tar: Removing leading `/\u0027 from member names\". when this works. So with the nots, this fails every time.","commit_id":"0de954a6954de688c6317a0a857c807afa46feef"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"42ea93d088811cd2d94084df26a0981c2948c30e","unresolved":true,"context_lines":[{"line_number":185,"context_line":"                  register: container_kill_result"},{"line_number":186,"context_line":"                  failed_when:"},{"line_number":187,"context_line":"                    - (\"no such container\" not in container_kill_result.stderr)"},{"line_number":188,"context_line":"                    - (\"container state improper\" not in container_kill_result.stderr)"},{"line_number":189,"context_line":"                  with_items: \"{{ container_id.stdout.split(\u0027\\n\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d76d794b_0de6524d","side":"PARENT","line":188,"updated":"2021-09-01 15:53:04.000000000","message":"maybe adding an extra rc !\u003d 0 condition could\u0027ve been enough to keep it working unchanged.","commit_id":"2a8601f3edd58ff1d9fd15b3c7924f14b67901a3"}]}