)]}'
{"ci/environments/scenario001-standalone.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"2da7ef113812cae3dbfe9a2778e3b37f2cd2a44d","unresolved":true,"context_lines":[{"line_number":73,"context_line":"    - name: altrbd"},{"line_number":74,"context_line":"      pg_num: 8"},{"line_number":75,"context_line":"      rule_name: replicated_rule"},{"line_number":76,"context_line":"      application: rbd"},{"line_number":77,"context_line":"  #NOTE: These ID\u0027s and keys should be regenerated for"},{"line_number":78,"context_line":"  # a production deployment. What is here is suitable for"},{"line_number":79,"context_line":"  # developer and CI testing only."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"a80fdb56_c29fb881","line":76,"updated":"2021-09-03 15:22:45.000000000","message":"who we actually had this in the examples at https://docs.openstack.org/project-deploy-guide/tripleo-docs/latest/features/ceph_config.html\n\ngood catch","commit_id":"08073cbd8e62ef74115a05a4098429288c71255e"}],"deployment/cephadm/ceph-base.yaml":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"14dd911af5102cf0e066ee90ba91ee2d7a600413","unresolved":true,"context_lines":[{"line_number":376,"context_line":"      parameter to false to have cephadm deploy the ceph cluster during overcloud"},{"line_number":377,"context_line":"      deployment. DeployedCeph and CephDynamicSpec are mutually exclusive."},{"line_number":378,"context_line":"  CephRbdTrashPurgeInterval:"},{"line_number":379,"context_line":"    default: 1d"},{"line_number":380,"context_line":"    type: string"},{"line_number":381,"context_line":"    description: |"},{"line_number":382,"context_line":"      The interval applied to the rbd trash purge scheduler."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b267f73a_11ec217c","line":379,"range":{"start_line":379,"start_character":13,"end_line":379,"end_character":15},"updated":"2021-08-26 19:54:35.000000000","message":"IMO 1 day is probably longer than is reasonable for the behavior we\u0027d expect from Cinder on this.  It means that after deleting lots of volumes, admins will have to wait a day for space to actually be reclaimed.\n\nMy initial thought was that this should be something more like 15-30 minutes.\n\nFWIW, the Cinder driver has a feature to drive trash purging itself rather than having Ceph do it, and the default there is 1 minute.","commit_id":"21005d8827749686d5901cde7f236b0f9bfa5e74"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"0481db2ce4fe41a50d038bd121e27842ef64ab8e","unresolved":true,"context_lines":[{"line_number":376,"context_line":"      parameter to false to have cephadm deploy the ceph cluster during overcloud"},{"line_number":377,"context_line":"      deployment. DeployedCeph and CephDynamicSpec are mutually exclusive."},{"line_number":378,"context_line":"  CephRbdTrashPurgeInterval:"},{"line_number":379,"context_line":"    default: 1d"},{"line_number":380,"context_line":"    type: string"},{"line_number":381,"context_line":"    description: |"},{"line_number":382,"context_line":"      The interval applied to the rbd trash purge scheduler."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ecb789db_580efcaf","line":379,"range":{"start_line":379,"start_character":13,"end_line":379,"end_character":15},"in_reply_to":"b267f73a_11ec217c","updated":"2021-08-27 09:09:41.000000000","message":"ack and thanks for jumping in!\nIt makes sense, and 1d is probably too much compared to the expectations on the Cinder side, so I\u0027m going to update this patch to reduce it to 15 minutes, which could be a fair default value.","commit_id":"21005d8827749686d5901cde7f236b0f9bfa5e74"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"2da7ef113812cae3dbfe9a2778e3b37f2cd2a44d","unresolved":true,"context_lines":[{"line_number":380,"context_line":"    type: boolean"},{"line_number":381,"context_line":"    description: Disable cephadm after Ceph is deployed"},{"line_number":382,"context_line":"  CephRbdTrashPurgeInterval:"},{"line_number":383,"context_line":"    default: 15"},{"line_number":384,"context_line":"    type: string"},{"line_number":385,"context_line":"    description: |"},{"line_number":386,"context_line":"      The interval applied to the rbd trash purge scheduler, that can be"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"c29ed0bd_07890917","line":383,"updated":"2021-09-03 15:22:45.000000000","message":"to be eventually synced with the default we have in tripleo-ansible ;(","commit_id":"08073cbd8e62ef74115a05a4098429288c71255e"}]}