)]}'
{"deployment/openvswitch/openvswitch-dpdk-baremetal-ansible.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"e88d46434fb4aded07e3dee41270736e9fdf1ae7","unresolved":true,"context_lines":[{"line_number":232,"context_line":"        - - name: ddp package selection"},{"line_number":233,"context_line":"            vars:"},{"line_number":234,"context_line":"              ddp_package: {get_attr: [RoleParametersDpdk, value, ddp_package]}"},{"line_number":235,"context_line":"            shell: |"},{"line_number":236,"context_line":"              rm -f /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":237,"context_line":"              ln -s /lib/firmware/intel/ice/{{ ddp_package }}/ice[_-]*.pkg /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":238,"context_line":"              dracut -f"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"84d59277_7a322913","line":235,"updated":"2021-09-09 05:38:37.000000000","message":"There are no checks present to apply the change only on required machines (non-intel machines)","commit_id":"d1fe98a54adb645e0c87eda5c5ce612b8f1be9bd"},{"author":{"_account_id":22865,"name":"Jaganathan Palanisamy","email":"jpalanis@redhat.com","username":"jaganathancse"},"change_message_id":"617f37e04435b7712c5abe21cecde29ef3757d51","unresolved":true,"context_lines":[{"line_number":232,"context_line":"        - - name: ddp package selection"},{"line_number":233,"context_line":"            vars:"},{"line_number":234,"context_line":"              ddp_package: {get_attr: [RoleParametersDpdk, value, ddp_package]}"},{"line_number":235,"context_line":"            shell: |"},{"line_number":236,"context_line":"              rm -f /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":237,"context_line":"              ln -s /lib/firmware/intel/ice/{{ ddp_package }}/ice[_-]*.pkg /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":238,"context_line":"              dracut -f"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c39df50d_e7637d95","line":235,"in_reply_to":"84d59277_7a322913","updated":"2021-09-22 07:31:20.000000000","message":"planning to add the condition like this task works only when user provided DdpPackage parameter is not default ddp package.\nIs this looks fine? so works for any role when user provides input for the DdpPackage parameter.","commit_id":"d1fe98a54adb645e0c87eda5c5ce612b8f1be9bd"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"cd892129e96221ed15a68a25f85b20ad752cc491","unresolved":true,"context_lines":[{"line_number":232,"context_line":"        - - name: ddp package selection"},{"line_number":233,"context_line":"            vars:"},{"line_number":234,"context_line":"              ddp_package: {get_attr: [RoleParametersDpdk, value, ddp_package]}"},{"line_number":235,"context_line":"            shell: |"},{"line_number":236,"context_line":"              rm -f /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":237,"context_line":"              ln -s /lib/firmware/intel/ice/{{ ddp_package }}/ice[_-]*.pkg /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":238,"context_line":"              dracut -f"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3de3fa3e_3e2829e5","line":235,"in_reply_to":"c39df50d_e7637d95","updated":"2021-09-22 09:11:20.000000000","message":"Yes.","commit_id":"d1fe98a54adb645e0c87eda5c5ce612b8f1be9bd"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"e88d46434fb4aded07e3dee41270736e9fdf1ae7","unresolved":true,"context_lines":[{"line_number":234,"context_line":"              ddp_package: {get_attr: [RoleParametersDpdk, value, ddp_package]}"},{"line_number":235,"context_line":"            shell: |"},{"line_number":236,"context_line":"              rm -f /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":237,"context_line":"              ln -s /lib/firmware/intel/ice/{{ ddp_package }}/ice[_-]*.pkg /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":238,"context_line":"              dracut -f"},{"line_number":239,"context_line":"            when: step|int \u003d\u003d 0"},{"line_number":240,"context_line":"        - get_attr: [BootParams, role_data, deploy_steps_tasks]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3abc5564_50fe0422","line":237,"range":{"start_line":237,"start_character":62,"end_line":237,"end_character":70},"updated":"2021-09-09 05:38:37.000000000","message":"is there a possibility to have multiple ice package versions because of update/upgrade?","commit_id":"d1fe98a54adb645e0c87eda5c5ce612b8f1be9bd"},{"author":{"_account_id":22865,"name":"Jaganathan Palanisamy","email":"jpalanis@redhat.com","username":"jaganathancse"},"change_message_id":"617f37e04435b7712c5abe21cecde29ef3757d51","unresolved":true,"context_lines":[{"line_number":234,"context_line":"              ddp_package: {get_attr: [RoleParametersDpdk, value, ddp_package]}"},{"line_number":235,"context_line":"            shell: |"},{"line_number":236,"context_line":"              rm -f /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":237,"context_line":"              ln -s /lib/firmware/intel/ice/{{ ddp_package }}/ice[_-]*.pkg /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":238,"context_line":"              dracut -f"},{"line_number":239,"context_line":"            when: step|int \u003d\u003d 0"},{"line_number":240,"context_line":"        - get_attr: [BootParams, role_data, deploy_steps_tasks]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"40cd1e35_ff132b3f","line":237,"range":{"start_line":237,"start_character":62,"end_line":237,"end_character":70},"in_reply_to":"3abc5564_50fe0422","updated":"2021-09-22 07:31:20.000000000","message":"yes possible, will add the update and upgrade tasks also.","commit_id":"d1fe98a54adb645e0c87eda5c5ce612b8f1be9bd"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"cd892129e96221ed15a68a25f85b20ad752cc491","unresolved":true,"context_lines":[{"line_number":234,"context_line":"              ddp_package: {get_attr: [RoleParametersDpdk, value, ddp_package]}"},{"line_number":235,"context_line":"            shell: |"},{"line_number":236,"context_line":"              rm -f /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":237,"context_line":"              ln -s /lib/firmware/intel/ice/{{ ddp_package }}/ice[_-]*.pkg /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":238,"context_line":"              dracut -f"},{"line_number":239,"context_line":"            when: step|int \u003d\u003d 0"},{"line_number":240,"context_line":"        - get_attr: [BootParams, role_data, deploy_steps_tasks]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7ffc64eb_fa476e31","line":237,"range":{"start_line":237,"start_character":62,"end_line":237,"end_character":70},"in_reply_to":"40cd1e35_ff132b3f","updated":"2021-09-22 09:11:20.000000000","message":"It is not required to add in upgrade tasks. The question is if the folder has to files matching with same pattern \"ice[_-]*.pkg\" for the given ddp package, then how does ln command works.","commit_id":"d1fe98a54adb645e0c87eda5c5ce612b8f1be9bd"},{"author":{"_account_id":22865,"name":"Jaganathan Palanisamy","email":"jpalanis@redhat.com","username":"jaganathancse"},"change_message_id":"ec5ec0eea36244e6dd90e5dda140818819595779","unresolved":false,"context_lines":[{"line_number":234,"context_line":"              ddp_package: {get_attr: [RoleParametersDpdk, value, ddp_package]}"},{"line_number":235,"context_line":"            shell: |"},{"line_number":236,"context_line":"              rm -f /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":237,"context_line":"              ln -s /lib/firmware/intel/ice/{{ ddp_package }}/ice[_-]*.pkg /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":238,"context_line":"              dracut -f"},{"line_number":239,"context_line":"            when: step|int \u003d\u003d 0"},{"line_number":240,"context_line":"        - get_attr: [BootParams, role_data, deploy_steps_tasks]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c51497f4_b1f86d97","line":237,"range":{"start_line":237,"start_character":62,"end_line":237,"end_character":70},"in_reply_to":"4f266ef6_ebd64222","updated":"2021-09-22 18:42:08.000000000","message":"Ack","commit_id":"d1fe98a54adb645e0c87eda5c5ce612b8f1be9bd"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"e5e649a7d63cde60ef6e16de925115dc12e2201b","unresolved":true,"context_lines":[{"line_number":234,"context_line":"              ddp_package: {get_attr: [RoleParametersDpdk, value, ddp_package]}"},{"line_number":235,"context_line":"            shell: |"},{"line_number":236,"context_line":"              rm -f /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":237,"context_line":"              ln -s /lib/firmware/intel/ice/{{ ddp_package }}/ice[_-]*.pkg /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":238,"context_line":"              dracut -f"},{"line_number":239,"context_line":"            when: step|int \u003d\u003d 0"},{"line_number":240,"context_line":"        - get_attr: [BootParams, role_data, deploy_steps_tasks]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4f266ef6_ebd64222","line":237,"range":{"start_line":237,"start_character":62,"end_line":237,"end_character":70},"in_reply_to":"5f200d63_43179166","updated":"2021-09-22 09:33:07.000000000","message":"If you don\u0027t intend to take the version as a parameter, then pick the latest one for now and expose the version later. But it should not throw an error.","commit_id":"d1fe98a54adb645e0c87eda5c5ce612b8f1be9bd"},{"author":{"_account_id":22865,"name":"Jaganathan Palanisamy","email":"jpalanis@redhat.com","username":"jaganathancse"},"change_message_id":"7d818ffb0337d81046f20844c3dd4e6db732bd15","unresolved":true,"context_lines":[{"line_number":234,"context_line":"              ddp_package: {get_attr: [RoleParametersDpdk, value, ddp_package]}"},{"line_number":235,"context_line":"            shell: |"},{"line_number":236,"context_line":"              rm -f /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":237,"context_line":"              ln -s /lib/firmware/intel/ice/{{ ddp_package }}/ice[_-]*.pkg /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":238,"context_line":"              dracut -f"},{"line_number":239,"context_line":"            when: step|int \u003d\u003d 0"},{"line_number":240,"context_line":"        - get_attr: [BootParams, role_data, deploy_steps_tasks]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f200d63_43179166","line":237,"range":{"start_line":237,"start_character":62,"end_line":237,"end_character":70},"in_reply_to":"7ffc64eb_fa476e31","updated":"2021-09-22 09:21:31.000000000","message":"we get below error if multiple files with same pattern,\nln: target \u0027/lib/firmware/intel/ice/ddp/ice.pkg\u0027 is not a directory\n\nif possible multiple versions ddp package ice files with same pattern. then we may need to have one more input parameter for version to identify right one.\ndo we need to implement right now?","commit_id":"d1fe98a54adb645e0c87eda5c5ce612b8f1be9bd"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"fb97936fc22282aef3d2c361360166446888f66d","unresolved":true,"context_lines":[{"line_number":229,"context_line":"    value:"},{"line_number":230,"context_line":"      service_name: openvswitch"},{"line_number":231,"context_line":"      deploy_steps_tasks:"},{"line_number":232,"context_line":"        - - name: Ddp packages and select the package"},{"line_number":233,"context_line":"            vars:"},{"line_number":234,"context_line":"              ddp_package: {get_attr: [RoleParametersDpdk, value, ddp_package]}"},{"line_number":235,"context_line":"            block:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ebd78480_2df4ace7","line":232,"updated":"2021-09-23 05:20:35.000000000","message":"With this approach, it is not possible to have a global parameter, but only the role-specific. Because if there are 2 DPDK roles (1 role requires DDP pkg change and 2nd role does not), adding the parameter globally will fail the deployment for the 2nd role. \n\nWhy not take the approach of applying the package only if it is present, else skip it? What are the drawbacks?","commit_id":"8459e095f82ac68a42f7f74e9ffc6c8ad27f3e5a"},{"author":{"_account_id":22865,"name":"Jaganathan Palanisamy","email":"jpalanis@redhat.com","username":"jaganathancse"},"change_message_id":"140b4d3a3b711a2c0725b14ca4762b9239bf2e30","unresolved":true,"context_lines":[{"line_number":229,"context_line":"    value:"},{"line_number":230,"context_line":"      service_name: openvswitch"},{"line_number":231,"context_line":"      deploy_steps_tasks:"},{"line_number":232,"context_line":"        - - name: Ddp packages and select the package"},{"line_number":233,"context_line":"            vars:"},{"line_number":234,"context_line":"              ddp_package: {get_attr: [RoleParametersDpdk, value, ddp_package]}"},{"line_number":235,"context_line":"            block:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"04cb7d33_5b468a71","line":232,"in_reply_to":"ebd78480_2df4ace7","updated":"2021-09-23 06:43:40.000000000","message":"Current approach, will not fail for other DPDK roles if not used this parameter since default DDP package is already configured for all the DPDK roles and here we are providing option in role level to change the required DDP package.","commit_id":"8459e095f82ac68a42f7f74e9ffc6c8ad27f3e5a"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"fb97936fc22282aef3d2c361360166446888f66d","unresolved":true,"context_lines":[{"line_number":234,"context_line":"              ddp_package: {get_attr: [RoleParametersDpdk, value, ddp_package]}"},{"line_number":235,"context_line":"            block:"},{"line_number":236,"context_line":"              - name: Gets latest version of required Ddp package"},{"line_number":237,"context_line":"                shell: \"ls --sort\u003dversion -r /lib/firmware/intel/ice/{{ ddp_package }}/ice[_-]?*.pkg\""},{"line_number":238,"context_line":"                register: ddp_package_files"},{"line_number":239,"context_line":"              - name: ddp package selection"},{"line_number":240,"context_line":"                shell: |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c5c00104_39849dfb","line":237,"updated":"2021-09-23 05:20:35.000000000","message":"What happens if \"/lib/firmware/intel/ice/{{ ddp_package }}/\" is not present? Should it be treated as error in deployment?","commit_id":"8459e095f82ac68a42f7f74e9ffc6c8ad27f3e5a"},{"author":{"_account_id":22865,"name":"Jaganathan Palanisamy","email":"jpalanis@redhat.com","username":"jaganathancse"},"change_message_id":"10fc5a0f1ce684f7037f4c30aff8e95a37f4e4a4","unresolved":true,"context_lines":[{"line_number":234,"context_line":"              ddp_package: {get_attr: [RoleParametersDpdk, value, ddp_package]}"},{"line_number":235,"context_line":"            block:"},{"line_number":236,"context_line":"              - name: Gets latest version of required Ddp package"},{"line_number":237,"context_line":"                shell: \"ls --sort\u003dversion -r /lib/firmware/intel/ice/{{ ddp_package }}/ice[_-]?*.pkg\""},{"line_number":238,"context_line":"                register: ddp_package_files"},{"line_number":239,"context_line":"              - name: ddp package selection"},{"line_number":240,"context_line":"                shell: |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"eea24746_2e7a2412","line":237,"in_reply_to":"a65e2c98_752bc70f","updated":"2021-09-23 07:05:12.000000000","message":"typo ddp package directory\n\nplease let me know do we need to avoid deployment error incase for invalid ddp package input.","commit_id":"8459e095f82ac68a42f7f74e9ffc6c8ad27f3e5a"},{"author":{"_account_id":22865,"name":"Jaganathan Palanisamy","email":"jpalanis@redhat.com","username":"jaganathancse"},"change_message_id":"140b4d3a3b711a2c0725b14ca4762b9239bf2e30","unresolved":true,"context_lines":[{"line_number":234,"context_line":"              ddp_package: {get_attr: [RoleParametersDpdk, value, ddp_package]}"},{"line_number":235,"context_line":"            block:"},{"line_number":236,"context_line":"              - name: Gets latest version of required Ddp package"},{"line_number":237,"context_line":"                shell: \"ls --sort\u003dversion -r /lib/firmware/intel/ice/{{ ddp_package }}/ice[_-]?*.pkg\""},{"line_number":238,"context_line":"                register: ddp_package_files"},{"line_number":239,"context_line":"              - name: ddp package selection"},{"line_number":240,"context_line":"                shell: |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a65e2c98_752bc70f","line":237,"in_reply_to":"c5c00104_39849dfb","updated":"2021-09-23 06:43:40.000000000","message":"yes, will raise deployment error if user provides invalid ddp package director manually.","commit_id":"8459e095f82ac68a42f7f74e9ffc6c8ad27f3e5a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"cb9136c5a3dccce2018e7dfbe5281cabbc50b8e5","unresolved":true,"context_lines":[{"line_number":239,"context_line":"              - name: ddp package selection"},{"line_number":240,"context_line":"                shell: |"},{"line_number":241,"context_line":"                  rm -f /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":242,"context_line":"                  ln -s {{ ddp_package_files.stdout.split(\u0027\\n\u0027)[0] }} /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":243,"context_line":"                  dracut -f"},{"line_number":244,"context_line":"            when: step|int \u003d\u003d 0 and ddp_package|string !\u003d \"ddp\""},{"line_number":245,"context_line":"        - get_attr: [BootParams, role_data, deploy_steps_tasks]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"704df3a1_417dffab","line":242,"range":{"start_line":242,"start_character":27,"end_line":242,"end_character":66},"updated":"2021-09-23 13:03:46.000000000","message":"Might be a good idea to add a check in here that this actually has data","commit_id":"8459e095f82ac68a42f7f74e9ffc6c8ad27f3e5a"},{"author":{"_account_id":22865,"name":"Jaganathan Palanisamy","email":"jpalanis@redhat.com","username":"jaganathancse"},"change_message_id":"98c49917e72c76786086aeea77c9f2dfeaa51bd3","unresolved":false,"context_lines":[{"line_number":239,"context_line":"              - name: ddp package selection"},{"line_number":240,"context_line":"                shell: |"},{"line_number":241,"context_line":"                  rm -f /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":242,"context_line":"                  ln -s {{ ddp_package_files.stdout.split(\u0027\\n\u0027)[0] }} /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":243,"context_line":"                  dracut -f"},{"line_number":244,"context_line":"            when: step|int \u003d\u003d 0 and ddp_package|string !\u003d \"ddp\""},{"line_number":245,"context_line":"        - get_attr: [BootParams, role_data, deploy_steps_tasks]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"47022fbc_3db2b845","line":242,"range":{"start_line":242,"start_character":27,"end_line":242,"end_character":66},"in_reply_to":"704df3a1_417dffab","updated":"2021-09-24 11:59:26.000000000","message":"Ack","commit_id":"8459e095f82ac68a42f7f74e9ffc6c8ad27f3e5a"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"fb97936fc22282aef3d2c361360166446888f66d","unresolved":true,"context_lines":[{"line_number":241,"context_line":"                  rm -f /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":242,"context_line":"                  ln -s {{ ddp_package_files.stdout.split(\u0027\\n\u0027)[0] }} /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":243,"context_line":"                  dracut -f"},{"line_number":244,"context_line":"            when: step|int \u003d\u003d 0 and ddp_package|string !\u003d \"ddp\""},{"line_number":245,"context_line":"        - get_attr: [BootParams, role_data, deploy_steps_tasks]"},{"line_number":246,"context_line":"        - - name: Run ovs-dpdk role"},{"line_number":247,"context_line":"            when: step|int \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"61fc6f59_48cfb341","line":244,"updated":"2021-09-23 05:20:35.000000000","message":"These tasks will run during the tripleo update/upgrade which does not reboot the nodes. What happens when the link is changed to a different version but the node is not rebooted? The node will be rebooted manually by the user after the update/upgrade.","commit_id":"8459e095f82ac68a42f7f74e9ffc6c8ad27f3e5a"},{"author":{"_account_id":22865,"name":"Jaganathan Palanisamy","email":"jpalanis@redhat.com","username":"jaganathancse"},"change_message_id":"140b4d3a3b711a2c0725b14ca4762b9239bf2e30","unresolved":true,"context_lines":[{"line_number":241,"context_line":"                  rm -f /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":242,"context_line":"                  ln -s {{ ddp_package_files.stdout.split(\u0027\\n\u0027)[0] }} /lib/firmware/intel/ice/ddp/ice.pkg"},{"line_number":243,"context_line":"                  dracut -f"},{"line_number":244,"context_line":"            when: step|int \u003d\u003d 0 and ddp_package|string !\u003d \"ddp\""},{"line_number":245,"context_line":"        - get_attr: [BootParams, role_data, deploy_steps_tasks]"},{"line_number":246,"context_line":"        - - name: Run ovs-dpdk role"},{"line_number":247,"context_line":"            when: step|int \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"91314230_484e49f0","line":244,"in_reply_to":"61fc6f59_48cfb341","updated":"2021-09-23 06:43:40.000000000","message":"No issues, will change to updated version once manual reboot is done.","commit_id":"8459e095f82ac68a42f7f74e9ffc6c8ad27f3e5a"}]}