)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"531b9762cd60380a4140d6fbdcc5decc81fa5a85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"21cb4101_a164fd2b","updated":"2021-10-12 21:51:28.000000000","message":"I think this is ready for some more reviews.","commit_id":"433cc93755214a77abd82fb4a2f97512c2ee9f70"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2775bd4f849f1365768453b2feb2ec7ee3a3b5d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1d0e9b6d_9d4fd9a9","updated":"2021-10-12 18:30:58.000000000","message":"Ok - I reviewed these policies and deployed them cleanly in a standalone environment. We\u0027re also testing this patch in https://review.rdoproject.org/r/c/testproject/+/36122","commit_id":"433cc93755214a77abd82fb4a2f97512c2ee9f70"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"eb5803589ba95b7a588855dea1914a998274d669","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4a4f6aff_4390c4b3","updated":"2021-10-12 18:29:59.000000000","message":"recheck","commit_id":"433cc93755214a77abd82fb4a2f97512c2ee9f70"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1a0d046b0406220a382fd51b39e73944b62e2b1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bae04229_c7be94fb","updated":"2021-11-03 12:15:48.000000000","message":"recheck","commit_id":"433cc93755214a77abd82fb4a2f97512c2ee9f70"}],"environments/enable-secure-rbac.yaml":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2c47c9acb808b8c4a5cba338a936e04fe532fc7a","unresolved":true,"context_lines":[{"line_number":2402,"context_line":"      value: \"(role:reader and system_scope:all) or rule:owner\""},{"line_number":2403,"context_line":"    keystone-identity_get_application_credentials:"},{"line_number":2404,"context_line":"      key: \"identity:get_application_credentials\""},{"line_number":2405,"context_line":"      value: \"rule:identity:get_application_credential\""},{"line_number":2406,"context_line":"    keystone-identity_list_application_credentials:"},{"line_number":2407,"context_line":"      key: \"identity:list_application_credentials\""},{"line_number":2408,"context_line":"      value: \"(role:reader and system_scope:all) or rule:owner\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1bce8a7e_399c6089","side":"PARENT","line":2405,"updated":"2021-09-28 13:29:10.000000000","message":"These policies look like they are being aliased, but we\u0027re fixing the typos upstream in keystone \n\nhttps://review.opendev.org/c/openstack/keystone/+/810324/1/keystone/common/policies/application_credential.py\n\nWe need to make sure what we have here is consistent with the policies upstream when that review merges.","commit_id":"5a06d064cf148211ffd8b5b2871efae340f681ad"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2c47c9acb808b8c4a5cba338a936e04fe532fc7a","unresolved":true,"context_lines":[{"line_number":2437,"context_line":"      key: \"identity:ec2_create_credential\""},{"line_number":2438,"context_line":"      value: \"rule:admin_or_owner\""},{"line_number":2439,"context_line":"    keystone-identity_ec2_create_credentials:"},{"line_number":2440,"context_line":"      key: \"identity:ec2_create_credentials\""},{"line_number":2441,"context_line":"      value: \"rule:identity:ec2_create_credential\""},{"line_number":2442,"context_line":"    keystone-identity_ec2_delete_credential:"},{"line_number":2443,"context_line":"      key: \"identity:ec2_delete_credential\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"592488b2_6011cff0","line":2440,"updated":"2021-09-28 13:29:10.000000000","message":"This is wrong since we\u0027re not aliasing anything here in keystone. It was a typo and it\u0027s being fixed in keystone.\n\nhttps://review.opendev.org/c/openstack/keystone/+/806205\n\nThis should be regenerated when the upstream review merges in keystone or corrected here.","commit_id":"690018df9b9c5967ec4da923b0fec99efa52835e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2c47c9acb808b8c4a5cba338a936e04fe532fc7a","unresolved":true,"context_lines":[{"line_number":2566,"context_line":"      key: \"identity:list_identity_providers\""},{"line_number":2567,"context_line":"      value: \"rule:admin_required\""},{"line_number":2568,"context_line":"    keystone-identity_get_identity_provider:"},{"line_number":2569,"context_line":"      key: \"identity:get_identity_provider\""},{"line_number":2570,"context_line":"      value: \"rule:admin_required\""},{"line_number":2571,"context_line":"    keystone-identity_update_identity_provider:"},{"line_number":2572,"context_line":"      key: \"identity:update_identity_provider\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6d1aaf99_3d33c226","line":2569,"updated":"2021-09-28 13:29:10.000000000","message":"This is being fixed https://review.opendev.org/c/openstack/keystone/+/806243/3/keystone/common/policies/identity_provider.py","commit_id":"690018df9b9c5967ec4da923b0fec99efa52835e"}]}
