)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"abf101ede0f8742f471ef271009def546df7e6d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"53770dfd_b1398afa","updated":"2021-10-12 17:15:23.000000000","message":"I think we\u0027re ready for another set of eyes on this.\n\nThanks, Sean.","commit_id":"b30b3cc82b823148b38a70298d1256cc19e488b8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a280bec394d608d200eaaa3299248f7bc5a20521","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"199023c1_bd993859","updated":"2021-10-12 17:12:15.000000000","message":"this looks correct to me.\n\ni think i need to start an upstream discussion around the topic of does most of the placement api need\nto be system only\n\nor could we expose list ing trait and resouce classes as allow by anyone with a reader role\n\ncreating them or queryting the inventoreis i agree shoudl eb system only be default but i think there are a few apis upstream that we coudl relax more then we currently have.\n\nfor the ","commit_id":"b30b3cc82b823148b38a70298d1256cc19e488b8"}],"environments/enable-secure-rbac.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"76ecd3918e3facda0afd83b5ef4ddf05644e2bd5","unresolved":true,"context_lines":[{"line_number":760,"context_line":"      value: \"rule:admin_api\""},{"line_number":761,"context_line":"    placement-placement_reshaper_reshape:"},{"line_number":762,"context_line":"      key: \"placement:reshaper:reshape\""},{"line_number":763,"context_line":"      value: \"rule:system_admin_api\""},{"line_number":764,"context_line":"  NeutronApiPolicies:"},{"line_number":765,"context_line":"    neutron-context_is_admin:"},{"line_number":766,"context_line":"      key: \"context_is_admin\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"29af0dda_405ac6cf","line":763,"range":{"start_line":763,"start_character":14,"end_line":763,"end_character":36},"updated":"2021-10-05 19:42:33.000000000","message":"this shoudl be rule:admin_api","commit_id":"dd4ea2fbca4dc77c2db98b5359466329b7ef0101"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bce405ef645047ea2f14e230391b99eeed2e8416","unresolved":false,"context_lines":[{"line_number":760,"context_line":"      value: \"rule:admin_api\""},{"line_number":761,"context_line":"    placement-placement_reshaper_reshape:"},{"line_number":762,"context_line":"      key: \"placement:reshaper:reshape\""},{"line_number":763,"context_line":"      value: \"rule:system_admin_api\""},{"line_number":764,"context_line":"  NeutronApiPolicies:"},{"line_number":765,"context_line":"    neutron-context_is_admin:"},{"line_number":766,"context_line":"      key: \"context_is_admin\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"55208b28_af52438c","line":763,"range":{"start_line":763,"start_character":14,"end_line":763,"end_character":36},"in_reply_to":"29af0dda_405ac6cf","updated":"2021-10-05 20:35:44.000000000","message":"Done","commit_id":"dd4ea2fbca4dc77c2db98b5359466329b7ef0101"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a280bec394d608d200eaaa3299248f7bc5a20521","unresolved":true,"context_lines":[{"line_number":716,"context_line":"    placement-placement_resource_providers_usages:"},{"line_number":717,"context_line":"      key: \"placement:resource_providers:usages\""},{"line_number":718,"context_line":"      value: \"rule:admin_api\""},{"line_number":719,"context_line":"    placement-placement_usages:"},{"line_number":720,"context_line":"      key: \"placement:usages\""},{"line_number":721,"context_line":"      value: \"rule:admin_api or rule:project_reader_api\""},{"line_number":722,"context_line":"    placement-placement_traits_list:"},{"line_number":723,"context_line":"      key: \"placement:traits:list\""},{"line_number":724,"context_line":"      value: \"rule:admin_api\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"50b5440d_ea079227","line":721,"range":{"start_line":719,"start_character":5,"end_line":721,"end_character":56},"updated":"2021-10-12 17:12:15.000000000","message":"yes so everything in placment  by defult is more or less admin only expct for the project usages apip\n\n\nhttps://github.com/openstack/placement/blob/master/placement/policies/usage.py#L35-L47\n\nthis is used to list tenant usage for quotas.\n\nso this is correct.","commit_id":"b30b3cc82b823148b38a70298d1256cc19e488b8"}]}