)]}'
{"deployment/swift/swift-proxy-container-puppet.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"50e246b91d6ff52a23296912e602922dedf20fea","unresolved":true,"context_lines":[{"line_number":429,"context_line":"          when:"},{"line_number":430,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":431,"context_line":"            - swift_rsyslog_configured is not defined or"},{"line_number":432,"context_line":"              not swift_rsyslog_configured"},{"line_number":433,"context_line":"          block:"},{"line_number":434,"context_line":"            - name: Check if rsyslog exists"},{"line_number":435,"context_line":"              shell: systemctl is-active rsyslog"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d3458a09_6bc79a3c","line":432,"range":{"start_line":432,"start_character":18,"end_line":432,"end_character":42},"updated":"2021-09-24 14:03:31.000000000","message":"To be safe you should also likely use swift_rsyslog_configured|bool","commit_id":"80298a5225dc7c064bfe11dde4ca1a39a5bce2d4"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"abaf34a67630686c2707f20f909e3f8c6859a444","unresolved":true,"context_lines":[{"line_number":428,"context_line":"        - name: Configure rsyslog for swift-proxy"},{"line_number":429,"context_line":"          when:"},{"line_number":430,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":431,"context_line":"            - swift_rsyslog_configured is not defined or"},{"line_number":432,"context_line":"              not swift_rsyslog_configured"},{"line_number":433,"context_line":"          block:"},{"line_number":434,"context_line":"            - name: Check if rsyslog exists"},{"line_number":435,"context_line":"              shell: systemctl is-active rsyslog"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"86ddf71a_d51d6581","line":432,"range":{"start_line":431,"start_character":0,"end_line":432,"end_character":42},"updated":"2021-09-24 10:57:09.000000000","message":"so sometimes duplication is our friend... it would look simpler to remove the nested blocks, three layers of conditions, and merge it all to a linear tasks","commit_id":"80298a5225dc7c064bfe11dde4ca1a39a5bce2d4"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"cb4ecfe9ce0be33006df95bc780e2721e0a604bd","unresolved":true,"context_lines":[{"line_number":429,"context_line":"          when:"},{"line_number":430,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":431,"context_line":"            - swift_rsyslog_configured is not defined or"},{"line_number":432,"context_line":"              not swift_rsyslog_configured"},{"line_number":433,"context_line":"          block:"},{"line_number":434,"context_line":"            - name: Check if rsyslog exists"},{"line_number":435,"context_line":"              shell: systemctl is-active rsyslog"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"db294c28_89a99db6","line":432,"range":{"start_line":432,"start_character":18,"end_line":432,"end_character":42},"in_reply_to":"0738528a_b57e1008","updated":"2021-09-27 07:50:16.000000000","message":"reworked to remove the duplicate tasks completely rather than skipping those.","commit_id":"80298a5225dc7c064bfe11dde4ca1a39a5bce2d4"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d49522a705b948a0334d38a6593e8a61cc3a1878","unresolved":true,"context_lines":[{"line_number":428,"context_line":"        - name: Configure rsyslog for swift-proxy"},{"line_number":429,"context_line":"          when:"},{"line_number":430,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":431,"context_line":"            - swift_rsyslog_configured is not defined or"},{"line_number":432,"context_line":"              not swift_rsyslog_configured"},{"line_number":433,"context_line":"          block:"},{"line_number":434,"context_line":"            - name: Check if rsyslog exists"},{"line_number":435,"context_line":"              shell: systemctl is-active rsyslog"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"cc558c25_cef6c47d","line":432,"range":{"start_line":431,"start_character":0,"end_line":432,"end_character":42},"in_reply_to":"4820e948_f2b2dec7","updated":"2021-09-27 10:33:27.000000000","message":"thank you, this looks much cleaner now","commit_id":"80298a5225dc7c064bfe11dde4ca1a39a5bce2d4"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"8383ff11574640966a19a397cd6a37b94867fdb4","unresolved":true,"context_lines":[{"line_number":428,"context_line":"        - name: Configure rsyslog for swift-proxy"},{"line_number":429,"context_line":"          when:"},{"line_number":430,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":431,"context_line":"            - swift_rsyslog_configured is not defined or"},{"line_number":432,"context_line":"              not swift_rsyslog_configured"},{"line_number":433,"context_line":"          block:"},{"line_number":434,"context_line":"            - name: Check if rsyslog exists"},{"line_number":435,"context_line":"              shell: systemctl is-active rsyslog"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4820e948_f2b2dec7","line":432,"range":{"start_line":431,"start_character":0,"end_line":432,"end_character":42},"in_reply_to":"86ddf71a_d51d6581","updated":"2021-09-24 11:34:01.000000000","message":"Probably a refactoring effort, if we\u0027re fine running duplicate tasks (added in [1]). This is not worse than what we had before and fixes the current issue.\n\n[1] https://github.com/openstack/tripleo-heat-templates/commit/cef9c0e88e413299269dde0946a7c81c0186de48","commit_id":"80298a5225dc7c064bfe11dde4ca1a39a5bce2d4"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"68ffadbcb3822335934263ca21447fd6239d2559","unresolved":true,"context_lines":[{"line_number":429,"context_line":"          when:"},{"line_number":430,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":431,"context_line":"            - swift_rsyslog_configured is not defined or"},{"line_number":432,"context_line":"              not swift_rsyslog_configured"},{"line_number":433,"context_line":"          block:"},{"line_number":434,"context_line":"            - name: Check if rsyslog exists"},{"line_number":435,"context_line":"              shell: systemctl is-active rsyslog"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0738528a_b57e1008","line":432,"range":{"start_line":432,"start_character":18,"end_line":432,"end_character":42},"in_reply_to":"d3458a09_6bc79a3c","updated":"2021-09-27 04:37:05.000000000","message":"It seems to work fine without that (not treated as a string I suppose)\n\n2021-09-24 11:54:29 | 2021-09-24 11:54:29.870808 | fa163e45-a1c8-89f8-3a5a-00000000390f |       TASK | Check if rsyslog exists\n2021-09-24 11:54:30 | 2021-09-24 11:54:30.184922 | fa163e45-a1c8-89f8-3a5a-00000000390f |    CHANGED | Check if rsyslog exists | overcloud-controller-0\n2021-09-24 11:54:30 | 2021-09-24 11:54:30.187033 | fa163e45-a1c8-89f8-3a5a-00000000390f |     TIMING | Check if rsyslog exists | overcloud-controller-0 | 0:13:37.481668 | 0.31s\n2021-09-24 11:54:30 | 2021-09-24 11:54:30.201912 | fa163e45-a1c8-89f8-3a5a-000000003911 |       TASK | Forward logging to swift.log file\n2021-09-24 11:54:30 | 2021-09-24 11:54:30.743222 | fa163e45-a1c8-89f8-3a5a-000000003d47 |    CHANGED | Enable and start tripleo-container-shutdown | overcloud-controller-1\n2021-09-24 11:54:31 | 2021-09-24 11:54:31.059646 | fa163e45-a1c8-89f8-3a5a-000000003911 |    CHANGED | Forward logging to swift.log file | overcloud-controller-0\n2021-09-24 11:54:31 | 2021-09-24 11:54:31.061262 | fa163e45-a1c8-89f8-3a5a-000000003911 |     TIMING | Forward logging to swift.log file | overcloud-controller-0 | 0:13:38.355904 | 0.86s\n2021-09-24 11:54:31 | 2021-09-24 11:54:31.073592 | fa163e45-a1c8-89f8-3a5a-000000003912 |       TASK | Restart rsyslogd service after logging conf change\n2021-09-24 11:54:31 | 2021-09-24 11:54:31.597457 | fa163e45-a1c8-89f8-3a5a-000000003912 |    CHANGED | Restart rsyslogd service after logging conf change | overcloud-controller-0\n2021-09-24 11:54:31 | 2021-09-24 11:54:31.599599 | fa163e45-a1c8-89f8-3a5a-000000003912 |     TIMING | Restart rsyslogd service after logging conf change | overcloud-controller-0 | 0:13:38.894243 | 0.52s\n2021-09-24 11:54:31 | 2021-09-24 11:54:31.618013 | fa163e45-a1c8-89f8-3a5a-000000003913 |       TASK | set fact swift rsyslog configured\n2021-09-24 11:54:31 | 2021-09-24 11:54:31.646132 | fa163e45-a1c8-89f8-3a5a-000000003913 |         OK | set fact swift rsyslog configured | overcloud-controller-0\n2021-09-24 11:54:31 | 2021-09-24 11:54:31.647156 | fa163e45-a1c8-89f8-3a5a-000000003913 |     TIMING | set fact swift rsyslog configured | overcloud-controller-0 | 0:13:38.941799 | 0.03s\n2021-09-24 11:54:31 | 2021-09-24 11:54:31.662142 | fa163e45-a1c8-89f8-3a5a-000000003915 |       TASK | Check if rsyslog exists\n2021-09-24 11:54:31 | 2021-09-24 11:54:31.681177 | fa163e45-a1c8-89f8-3a5a-000000003915 |    SKIPPED | Check if rsyslog exists | overcloud-controller-0\n2021-09-24 11:54:31 | 2021-09-24 11:54:31.682334 | fa163e45-a1c8-89f8-3a5a-000000003915 |     TIMING | Check if rsyslog exists | overcloud-controller-0 | 0:13:38.976963 | 0.02s\n2021-09-24 11:54:31 | 2021-09-24 11:54:31.692782 | fa163e45-a1c8-89f8-3a5a-000000003917 |       TASK | Forward logging to swift.log file\n2021-09-24 11:54:31 | 2021-09-24 11:54:31.715991 | fa163e45-a1c8-89f8-3a5a-000000003d49 |       TASK | Create /usr/lib/systemd/system-preset/91-netns-placeholder.preset\n2021-09-24 11:54:31 | 2021-09-24 11:54:31.722257 | fa163e45-a1c8-89f8-3a5a-000000003917 |    SKIPPED | Forward logging to swift.log file | overcloud-controller-0\n2021-09-24 11:54:31 | 2021-09-24 11:54:31.723996 | fa163e45-a1c8-89f8-3a5a-000000003917 |     TIMING | Forward logging to swift.log file | overcloud-controller-0 | 0:13:39.018630 | 0.03s\n2021-09-24 11:54:31 | 2021-09-24 11:54:31.740654 | fa163e45-a1c8-89f8-3a5a-000000003918 |       TASK | Restart rsyslogd service after logging conf change\n2021-09-24 11:54:31 | 2021-09-24 11:54:31.763660 | fa163e45-a1c8-89f8-3a5a-000000003918 |    SKIPPED | Restart rsyslogd service after logging conf change | overcloud-controller-0\n2021-09-24 11:54:31 | 2021-09-24 11:54:31.764898 | fa163e45-a1c8-89f8-3a5a-000000003918 |     TIMING | Restart rsyslogd service after logging conf change | overcloud-controller-0 | 0:13:39.059535 | 0.02s\n2021-09-24 11:54:31 | 2021-09-24 11:54:31.775237 | fa163e45-a1c8-89f8-3a5a-000000003919 |       TASK | set fact swift rsyslog configured\n2021-09-24 11:54:31 | 2021-09-24 11:54:31.796064 | fa163e45-a1c8-89f8-3a5a-000000003919 |    SKIPPED | set fact swift rsyslog configured | overcloud-controller-0\n2021-09-24 11:54:31 | 2021-09-24 11:54:31.797638 | fa163e45-a1c8-89f8-3a5a-000000003919 |     TIMING | set fact swift rsyslog configured | overcloud-controller-0 | 0:13:39.092279 | 0.02s","commit_id":"80298a5225dc7c064bfe11dde4ca1a39a5bce2d4"}],"deployment/swift/swift-storage-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b42cd6c8e3a93a66dce554f40b35c08225c813f3","unresolved":true,"context_lines":[{"line_number":749,"context_line":"                    - swift_logconfig is changed"},{"line_number":750,"context_line":"              when:"},{"line_number":751,"context_line":"                - swift_rsyslog_config is defined"},{"line_number":752,"context_line":"                - swift_rsyslog_config.rc \u003d\u003d 0"},{"line_number":753,"context_line":"        - name: Run kolla_set_configs to copy ring files"},{"line_number":754,"context_line":"          when: step|int \u003d\u003d 5"},{"line_number":755,"context_line":"          shell: \"{{ container_cli }} exec -u root {{ item }} /usr/local/bin/kolla_set_configs\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6db1fcee_0c168b86","line":752,"updated":"2021-09-23 13:02:25.000000000","message":"but why? is ansible so bad on systmed status ActiveStatus?..","commit_id":"2a4441ed30c01f992171f6c99aa5accb25136cee"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"851d3f13819ebe24a90fee424c25f8d0e83532ca","unresolved":true,"context_lines":[{"line_number":749,"context_line":"                    - swift_logconfig is changed"},{"line_number":750,"context_line":"              when:"},{"line_number":751,"context_line":"                - swift_rsyslog_config is defined"},{"line_number":752,"context_line":"                - swift_rsyslog_config.rc \u003d\u003d 0"},{"line_number":753,"context_line":"        - name: Run kolla_set_configs to copy ring files"},{"line_number":754,"context_line":"          when: step|int \u003d\u003d 5"},{"line_number":755,"context_line":"          shell: \"{{ container_cli }} exec -u root {{ item }} /usr/local/bin/kolla_set_configs\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8f991f52_5f0e6a1e","line":752,"in_reply_to":"6db1fcee_0c168b86","updated":"2021-09-23 13:07:10.000000000","message":"JFYI using the systemd module to get status is one of those \u0027it makes ansible worse calls\u0027 because $reasons.  It\u0027s woefully inefficient and bloats memory","commit_id":"2a4441ed30c01f992171f6c99aa5accb25136cee"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"0f95531c2195f24abc50c047963d98cd0fcaeca1","unresolved":true,"context_lines":[{"line_number":749,"context_line":"                    - swift_logconfig is changed"},{"line_number":750,"context_line":"              when:"},{"line_number":751,"context_line":"                - swift_rsyslog_config is defined"},{"line_number":752,"context_line":"                - swift_rsyslog_config.rc \u003d\u003d 0"},{"line_number":753,"context_line":"        - name: Run kolla_set_configs to copy ring files"},{"line_number":754,"context_line":"          when: step|int \u003d\u003d 5"},{"line_number":755,"context_line":"          shell: \"{{ container_cli }} exec -u root {{ item }} /usr/local/bin/kolla_set_configs\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5e9210f9_55a8d3a4","line":752,"in_reply_to":"8f991f52_5f0e6a1e","updated":"2021-09-24 05:18:11.000000000","message":"There is something crazy going on it seems. Now that we\u0027ve overcloud logs are collected, lets see how this behaves.","commit_id":"2a4441ed30c01f992171f6c99aa5accb25136cee"}]}