)]}'
{"common/deploy-steps-playbooks-common.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c817018d9c92a19ee699b1e3968c37d547be41e7","unresolved":true,"context_lines":[{"line_number":5,"context_line":"# So we don\u0027t break the MaxFailPercentage feature since these plays can\u0027t use"},{"line_number":6,"context_line":"# Ansible strategies."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- hosts: localhost"},{"line_number":9,"context_line":"  name: Check if required variables are defined"},{"line_number":10,"context_line":"  tasks:"},{"line_number":11,"context_line":"    - fail:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"af138a39_3ae88ad3","line":8,"range":{"start_line":8,"start_character":9,"end_line":8,"end_character":18},"updated":"2021-09-24 11:30:12.000000000","message":"IIUC we should replace this as well but replacing this by Group results in pep8 failure...","commit_id":"ae36eb8ec77ab44bad5980e3b3718738eca298ed"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c343eb4f9d142eaaa9495f265768c5f0e4df9ec3","unresolved":true,"context_lines":[{"line_number":5,"context_line":"# So we don\u0027t break the MaxFailPercentage feature since these plays can\u0027t use"},{"line_number":6,"context_line":"# Ansible strategies."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- hosts: localhost"},{"line_number":9,"context_line":"  name: Check if required variables are defined"},{"line_number":10,"context_line":"  tasks:"},{"line_number":11,"context_line":"    - fail:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a876807b_d845f651","line":8,"range":{"start_line":8,"start_character":9,"end_line":8,"end_character":18},"in_reply_to":"af138a39_3ae88ad3","updated":"2021-09-24 13:56:20.000000000","message":"No if you look this has no actual execution logic and is purely a data check. localhost is fine","commit_id":"ae36eb8ec77ab44bad5980e3b3718738eca298ed"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c343eb4f9d142eaaa9495f265768c5f0e4df9ec3","unresolved":true,"context_lines":[{"line_number":79,"context_line":"  any_errors_fatal: True"},{"line_number":80,"context_line":"  tasks:"},{"line_number":81,"context_line":"    - name: Render all_nodes data as group_vars for overcloud"},{"line_number":82,"context_line":"      delegate_to: \"{{ groups[\u0027Undercloud\u0027] | first }}\""},{"line_number":83,"context_line":"      become: false"},{"line_number":84,"context_line":"      run_once: true"},{"line_number":85,"context_line":"      when: not ansible_check_mode|bool"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"db4e35b3_d5c35931","line":82,"updated":"2021-09-24 13:56:20.000000000","message":"This is rendered on the localhost (host executing) not necessarily the undercloud.","commit_id":"ae36eb8ec77ab44bad5980e3b3718738eca298ed"}],"common/deploy-steps-tasks-step-0.j2.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c343eb4f9d142eaaa9495f265768c5f0e4df9ec3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- name: Deploy step tasks for step 0"},{"line_number":2,"context_line":"  delegate_to: \"{% raw %}{{ groups[\u0027Undercloud\u0027] | first }}{% endraw %}\""},{"line_number":3,"context_line":"  run_once: true"},{"line_number":4,"context_line":"  debug:"},{"line_number":5,"context_line":"    msg: Use --start-at-task \u0027Deploy step tasks for step 0\u0027 to resume from this task"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"2240a176_6d5d62f6","line":2,"updated":"2021-09-24 13:56:20.000000000","message":"Once again this is a logging task and localhost is correct","commit_id":"ae36eb8ec77ab44bad5980e3b3718738eca298ed"}],"common/deploy-steps.j2":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c343eb4f9d142eaaa9495f265768c5f0e4df9ec3","unresolved":true,"context_lines":[{"line_number":471,"context_line":"              tasks:"},{"line_number":472,"context_line":"{% raw %}"},{"line_number":473,"context_line":"                - name: External deployment step 0"},{"line_number":474,"context_line":"                  delegate_to: \"{{ groups[\u0027Undercloud\u0027] | first }}\""},{"line_number":475,"context_line":"                  run_once: true"},{"line_number":476,"context_line":"                  debug:"},{"line_number":477,"context_line":"                    msg: Use --start-at-task \u0027External deployment step 0\u0027 to resume from this task"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3d74043c_a23d6acb","line":474,"updated":"2021-09-24 13:56:20.000000000","message":"This is a logging task and should not be run with anything but localhost","commit_id":"ae36eb8ec77ab44bad5980e3b3718738eca298ed"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8b1377712c33826bbc131d569fb652a168e8755a","unresolved":true,"context_lines":[{"line_number":471,"context_line":"              tasks:"},{"line_number":472,"context_line":"{% raw %}"},{"line_number":473,"context_line":"                - name: External deployment step 0"},{"line_number":474,"context_line":"                  delegate_to: \"{{ groups[\u0027Undercloud\u0027] | first }}\""},{"line_number":475,"context_line":"                  run_once: true"},{"line_number":476,"context_line":"                  debug:"},{"line_number":477,"context_line":"                    msg: Use --start-at-task \u0027External deployment step 0\u0027 to resume from this task"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"8b54bc5d_113e108b","line":474,"in_reply_to":"3d74043c_a23d6acb","updated":"2021-09-24 14:20:44.000000000","message":"yes, like if running on a laptop, while having an undercloud in inventory as another host, it should still work locally, correct?..\nor do you mean standalone case, where there is no undercloud at all?","commit_id":"ae36eb8ec77ab44bad5980e3b3718738eca298ed"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"132d45ef5955c5a657f8ae30d25c4970d9f7c5ad","unresolved":true,"context_lines":[{"line_number":471,"context_line":"              tasks:"},{"line_number":472,"context_line":"{% raw %}"},{"line_number":473,"context_line":"                - name: External deployment step 0"},{"line_number":474,"context_line":"                  delegate_to: \"{{ groups[\u0027Undercloud\u0027] | first }}\""},{"line_number":475,"context_line":"                  run_once: true"},{"line_number":476,"context_line":"                  debug:"},{"line_number":477,"context_line":"                    msg: Use --start-at-task \u0027External deployment step 0\u0027 to resume from this task"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"cf6bb916_1bbc676f","line":474,"in_reply_to":"8b54bc5d_113e108b","updated":"2021-09-24 14:24:09.000000000","message":"The only reason to delegate to undercloud is if you need to execute code on the undercloud (e.g. doing overcloud openstack actions).  Everything else that\u0027s localhost is usually because the expectation is that we want to run it on the thing running ansible.  Which may or may not be an undercloud.  I believe we still build out an undercloud role in the standalone so these still work but it\u0027s effectively localhost. I\u0027d have to double check.","commit_id":"ae36eb8ec77ab44bad5980e3b3718738eca298ed"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fe6284ed469327e6c150542507ee156d25dc32d5","unresolved":true,"context_lines":[{"line_number":471,"context_line":"              tasks:"},{"line_number":472,"context_line":"{% raw %}"},{"line_number":473,"context_line":"                - name: External deployment step 0"},{"line_number":474,"context_line":"                  delegate_to: \"{{ groups[\u0027Undercloud\u0027] | first }}\""},{"line_number":475,"context_line":"                  run_once: true"},{"line_number":476,"context_line":"                  debug:"},{"line_number":477,"context_line":"                    msg: Use --start-at-task \u0027External deployment step 0\u0027 to resume from this task"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"d908e115_bbe9f338","line":474,"in_reply_to":"cf6bb916_1bbc676f","updated":"2021-09-24 14:29:04.000000000","message":"FYI: So far the Undercloud group is defined in inventory even in a standalone deployment.\n\n https://d4698fe03376793369e5-3f28c2c0c6b192e8ac5a4ae954bec2d0.ssl.cf1.rackcdn.com/810389/2/check/tripleo-ci-centos-8-scenario002-standalone/ea3a433/logs/undercloud/home/zuul/tripleo-deploy/standalone-ansible-djabsxb5/inventory/tripleo","commit_id":"ae36eb8ec77ab44bad5980e3b3718738eca298ed"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c343eb4f9d142eaaa9495f265768c5f0e4df9ec3","unresolved":true,"context_lines":[{"line_number":1654,"context_line":"            - name: Get nova-compute service ID"},{"line_number":1655,"context_line":"              command: openstack compute service list --service nova-compute --column ID --column Host --format yaml"},{"line_number":1656,"context_line":"              register: nova_compute_service_result"},{"line_number":1657,"context_line":"              delegate_to: \"{{ groups[\u0027Undercloud\u0027] | first }}\""},{"line_number":1658,"context_line":"              check_mode: false"},{"line_number":1659,"context_line":"              changed_when: false"},{"line_number":1660,"context_line":"            - name: is additional Cell?"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"411ea673_d2061e59","line":1657,"updated":"2021-09-24 13:56:20.000000000","message":"this is the only file where this might make sense to switch to undercloud to match other logic since this actually runs cloud actions.","commit_id":"ae36eb8ec77ab44bad5980e3b3718738eca298ed"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4b75f20e871b5063ea6ba1838b0f8a5beccf8e9b","unresolved":true,"context_lines":[{"line_number":1698,"context_line":"                                (\u0027rc\u0027 in stop_nova_compute and stop_nova_compute.rc !\u003d 0)\""},{"line_number":1699,"context_line":"                - name: Delete nova-compute service"},{"line_number":1700,"context_line":"                  command: openstack compute service delete {{ nova_compute_service[0].ID }}"},{"line_number":1701,"context_line":"                  delegate_to: \"{{ groups[\u0027Undercloud\u0027] | first }}\""},{"line_number":1702,"context_line":"                  check_mode: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"811c8632_3c530376","line":1701,"updated":"2021-09-24 14:17:54.000000000","message":"my understanding those delegates should run on computes, not undercloud?","commit_id":"b0de138b41dddcee21b3db58a00e20223cddd841"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"6a73a5455d6261e970ea9724c98bcafa962da934","unresolved":true,"context_lines":[{"line_number":1698,"context_line":"                                (\u0027rc\u0027 in stop_nova_compute and stop_nova_compute.rc !\u003d 0)\""},{"line_number":1699,"context_line":"                - name: Delete nova-compute service"},{"line_number":1700,"context_line":"                  command: openstack compute service delete {{ nova_compute_service[0].ID }}"},{"line_number":1701,"context_line":"                  delegate_to: \"{{ groups[\u0027Undercloud\u0027] | first }}\""},{"line_number":1702,"context_line":"                  check_mode: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"cd13fd6b_9494225b","line":1701,"in_reply_to":"7b9c5b47_29085284","updated":"2021-09-24 14:23:51.000000000","message":"mhm, but there is no more nova on undercloud since...W?","commit_id":"b0de138b41dddcee21b3db58a00e20223cddd841"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9a32ac75d51c72fbd41a2f49b8381c79f97dbb44","unresolved":true,"context_lines":[{"line_number":1698,"context_line":"                                (\u0027rc\u0027 in stop_nova_compute and stop_nova_compute.rc !\u003d 0)\""},{"line_number":1699,"context_line":"                - name: Delete nova-compute service"},{"line_number":1700,"context_line":"                  command: openstack compute service delete {{ nova_compute_service[0].ID }}"},{"line_number":1701,"context_line":"                  delegate_to: \"{{ groups[\u0027Undercloud\u0027] | first }}\""},{"line_number":1702,"context_line":"                  check_mode: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7b9c5b47_29085284","line":1701,"in_reply_to":"811c8632_3c530376","updated":"2021-09-24 14:20:05.000000000","message":"It runs on the undercloud because this is a scale down task.  I wonder if the scale down tasks still get the full inventory since we ditched mistral","commit_id":"b0de138b41dddcee21b3db58a00e20223cddd841"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"883f876e4d0b866839f345c3b610618588a87259","unresolved":true,"context_lines":[{"line_number":1698,"context_line":"                                (\u0027rc\u0027 in stop_nova_compute and stop_nova_compute.rc !\u003d 0)\""},{"line_number":1699,"context_line":"                - name: Delete nova-compute service"},{"line_number":1700,"context_line":"                  command: openstack compute service delete {{ nova_compute_service[0].ID }}"},{"line_number":1701,"context_line":"                  delegate_to: \"{{ groups[\u0027Undercloud\u0027] | first }}\""},{"line_number":1702,"context_line":"                  check_mode: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8a54dd4b_05629704","line":1701,"in_reply_to":"811c8632_3c530376","updated":"2021-09-24 14:24:52.000000000","message":"This should be executed in undercloud because this required access to API endpoint and clouds.yaml (see L1650 which uses OS_CLOUD). This commit doesn\u0027t effectively change behavior but just change how it is defined so if this should be fixed then that\u0027s a separate topic IMO.","commit_id":"b0de138b41dddcee21b3db58a00e20223cddd841"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a29930b9ae975854f1b70ca91e16acae8094234b","unresolved":true,"context_lines":[{"line_number":1698,"context_line":"                                (\u0027rc\u0027 in stop_nova_compute and stop_nova_compute.rc !\u003d 0)\""},{"line_number":1699,"context_line":"                - name: Delete nova-compute service"},{"line_number":1700,"context_line":"                  command: openstack compute service delete {{ nova_compute_service[0].ID }}"},{"line_number":1701,"context_line":"                  delegate_to: \"{{ groups[\u0027Undercloud\u0027] | first }}\""},{"line_number":1702,"context_line":"                  check_mode: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"19edf4c7_349e9aac","line":1701,"in_reply_to":"8a54dd4b_05629704","updated":"2021-09-24 14:26:56.000000000","message":"ah, ok, that makes sense...","commit_id":"b0de138b41dddcee21b3db58a00e20223cddd841"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"dcb96fda71c8ca1feab3a5d718f8101a72ba522d","unresolved":true,"context_lines":[{"line_number":1698,"context_line":"                                (\u0027rc\u0027 in stop_nova_compute and stop_nova_compute.rc !\u003d 0)\""},{"line_number":1699,"context_line":"                - name: Delete nova-compute service"},{"line_number":1700,"context_line":"                  command: openstack compute service delete {{ nova_compute_service[0].ID }}"},{"line_number":1701,"context_line":"                  delegate_to: \"{{ groups[\u0027Undercloud\u0027] | first }}\""},{"line_number":1702,"context_line":"                  check_mode: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"2ddc91e4_55116077","line":1701,"in_reply_to":"cd13fd6b_9494225b","updated":"2021-09-24 14:24:49.000000000","message":"nova client*","commit_id":"b0de138b41dddcee21b3db58a00e20223cddd841"}]}