)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"5133961648b9139282b75eb414873bae7e280e60","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use EnableInternalTLS to set pssl in nb and sb"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a user changes EnableInternalTLS from false to true on an existing"},{"line_number":10,"context_line":"deployment, ovn sb and nb listening ports remain in ptcp when they"},{"line_number":11,"context_line":"should be changed to pssl."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1bf20e061901ebfe64813892a62848e0bfb62b86"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"6b8b1d4c_969ffc17","line":10,"range":{"start_line":9,"start_character":61,"end_line":10,"end_character":10},"updated":"2021-10-05 05:00:27.000000000","message":"Is this change specific to update? How does it work in a new deployment when EnableInternalTLS is enabled?","commit_id":"5a43e8a30704692f3eb184cce694dec52ed77635"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"7b21b8998eb0ddc1e29ef60f589aaaea5f506b1f","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use EnableInternalTLS to set pssl in nb and sb"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a user changes EnableInternalTLS from false to true on an existing"},{"line_number":10,"context_line":"deployment, ovn sb and nb listening ports remain in ptcp when they"},{"line_number":11,"context_line":"should be changed to pssl."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1bf20e061901ebfe64813892a62848e0bfb62b86"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"b7f3a78d_a33dd721","line":10,"range":{"start_line":9,"start_character":61,"end_line":10,"end_character":10},"in_reply_to":"6b8b1d4c_969ffc17","updated":"2021-10-06 13:59:33.000000000","message":"That\u0027s actually a good question.  It looks like it is created with /usr/lib/ocf/resource.d/ovn/ovndb-servers on startup when connection is empty.  This is provided by the package ovn2.11-2.11.1-57.el7fdp.x86_64 in RHOSP13 .","commit_id":"5a43e8a30704692f3eb184cce694dec52ed77635"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"2986854f6b95897935f9dc1899e79e36fbe501df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1b9b4cc3_b6a8ec3c","updated":"2021-11-03 19:13:53.000000000","message":"I think this patch is correct but I am wondering if this is upgrade specific. If I read this correctly, a fresh 16.x deployment with EnableInternalTLS enabled with have the OVN controllers talking ssl and the dbs listening for TCP. In any case this looks like a good patch.","commit_id":"5a43e8a30704692f3eb184cce694dec52ed77635"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"c706614a0386af8a23faebb7eb2aa232a8bd6d8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2346421c_36a66f21","in_reply_to":"1b9b4cc3_b6a8ec3c","updated":"2021-11-13 16:11:40.000000000","message":"We hit this issue when enabling TLS on an existing deployment .. perhaps it\u0027s not the right way to fix it but it looks like we rely on the pacemaker agents to create this and when it\u0027s empty, we have no issues as it\u0027ll create the right pssl listener but later on, it looks like the listener already exists and we do nothing about it.   I think this patch would solve it ... but maybe I\u0027m wrong.","commit_id":"5a43e8a30704692f3eb184cce694dec52ed77635"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"c78ac4f91df979e8b42ad238bfcbcb4b403754be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d0be823f_aa536c9c","in_reply_to":"2346421c_36a66f21","updated":"2021-11-18 13:21:22.000000000","message":"Ah. I think maybe I\u0027m conflating things here and it really doesnt\u0027 affect the validity of this patch. I\u0027m more questioning whether the status quo works as expected. I think we should merge once we get the required second +2.","commit_id":"5a43e8a30704692f3eb184cce694dec52ed77635"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"71a1523592922466860ecf96e5acd510cb8f91a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"28cfdbbe_f30792e0","in_reply_to":"d0be823f_aa536c9c","updated":"2021-11-19 02:15:11.000000000","message":"Let\u0027s wait until someone else shimes in then... I\u0027m not sure it\u0027s what we want but it appeared to be the right place to fix it but then again, I\u0027m no expert here ...","commit_id":"5a43e8a30704692f3eb184cce694dec52ed77635"}]}