)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"e426e6d52d5fec8232e066c2313993ee2f49c5db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bda3708a_6e4b8812","updated":"2021-10-20 22:23:13.000000000","message":"LGTM","commit_id":"cfb6118b62c8479384fe5ffd5bcfbf7d6bc14569"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"dccf8e92eaa53022a70c8402f88d88f47e7a834e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f1e96533_957a2e3b","updated":"2021-10-27 06:47:40.000000000","message":"\u003e Patch Set 2: Code-Review+2\n\u003e \n\u003e Marios Andreou wrote:\n\u003e \n\u003e \u003e (2 comments)\n\u003e \n\u003e I\u0027m assuming because if we take care of it in train, it won\u0027t be a thing in master due to this not being installed on the host since queens. This should have been cleaned up back in queens\n\nyeah but what about existing train installations that won\u0027t be getting this code... hmmm actually they *are* expected to get this change by way of minor update to latest train, before they do FFU to wallaby... ok... then\n\nSo we should at *least* get rid of those tasks on master anyway https://opendev.org/openstack/tripleo-heat-templates/src/commit/20311a0a50af684f2eab1a98adb58fe94f5ce933/deployment/database/mysql-pacemaker-puppet.yaml#L588  - even if we want to leave them in the wallaby/victoria/ussuri branch. We should get rid of it moving forward even if we don\u0027t replace it with what is added here (i.e. explicit removal)","commit_id":"7df7165742ee0fcdce63b8dc82e6e1c3fdb70157"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"22bb98ec841d7cd64ef0f18fceccc3564c7cbb25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"db80fa64_6c4bc03e","updated":"2021-10-21 14:53:33.000000000","message":"Another revision to fix the CM (Closes-Bug line)","commit_id":"7df7165742ee0fcdce63b8dc82e6e1c3fdb70157"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2bf5e89725fdf0f2a8601d07af5606a237ac2e77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c5639cf3_df4d4e5e","updated":"2021-10-22 09:00:34.000000000","message":"OK but why only train? it is same on master https://opendev.org/openstack/tripleo-heat-templates/src/commit/20311a0a50af684f2eab1a98adb58fe94f5ce933/deployment/database/mysql-pacemaker-puppet.yaml#L588","commit_id":"7df7165742ee0fcdce63b8dc82e6e1c3fdb70157"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fb4460b567e390dbded7019ad016394dd32c5ad0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"628e5a3c_93845a0d","updated":"2021-10-27 06:49:38.000000000","message":"so +2 here then but please see my previous comment here about removing the mariadb update tasks *at least* on master \u0026 wallaby (but probably better everywhere?) \n\nI\u0027ll leave the workflow to someone on the upgrades team - or ping me if no one hits workflow :)","commit_id":"7df7165742ee0fcdce63b8dc82e6e1c3fdb70157"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"55b9907f3e61aa8556c10bd6127039474437b484","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"096f0af0_e744f507","in_reply_to":"628e5a3c_93845a0d","updated":"2021-10-28 06:22:01.000000000","message":"Ack, I\u0027ll take care of it","commit_id":"7df7165742ee0fcdce63b8dc82e6e1c3fdb70157"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"55b9907f3e61aa8556c10bd6127039474437b484","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"72c95fd6_4c9e5781","updated":"2021-10-28 06:22:01.000000000","message":"Brought forward up to master and cherry-picked to in between branches","commit_id":"94540543f34c737d70d40ea87def3dcd11273260"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"6e3abae26d7786ebd13f7217c45aa1c41ad1ecee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ae5d8bf6_0a907ed7","updated":"2021-10-28 06:22:35.000000000","message":"Please, review once again so that we can get this merged at least in train first","commit_id":"94540543f34c737d70d40ea87def3dcd11273260"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"84a2f69ce983d506960b425b60f0f87abf6c90ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d269c9f2_06fc973a","updated":"2021-10-28 07:16:20.000000000","message":"ok re-adding vote no changes since v2\nthanks for posting the other branches","commit_id":"94540543f34c737d70d40ea87def3dcd11273260"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4e9a6fb9a7bb9da85e671d83be1856ca2f6ad02b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"12b9bc76_569f3650","updated":"2021-10-29 14:21:29.000000000","message":"wrong cherry pick info, now that master has landed please fix","commit_id":"94540543f34c737d70d40ea87def3dcd11273260"}],"deployment/database/mysql-pacemaker-puppet.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2bf5e89725fdf0f2a8601d07af5606a237ac2e77","unresolved":true,"context_lines":[{"line_number":558,"context_line":"            # mariadb package changes ownership of /var/lib/mysql on package"},{"line_number":559,"context_line":"            # update, so update here rather than in tripleo-package, to"},{"line_number":560,"context_line":"            # guarantee that ownership is fixed at the end of step 3"},{"line_number":561,"context_line":"            - name: Update host mariadb packages"},{"line_number":562,"context_line":"              when: step|int \u003d\u003d 3"},{"line_number":563,"context_line":"              package: name\u003dmariadb-server-galera state\u003dlatest"},{"line_number":564,"context_line":"            - name: Mysql upgrade script"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f887d247_29a2213f","side":"PARENT","line":561,"range":{"start_line":561,"start_character":20,"end_line":561,"end_character":26},"updated":"2021-10-22 09:00:34.000000000","message":"why not make this one a removal - also? so it goes away during the upgrade?","commit_id":"42f4b3acd29ffc12720a14413ac5952f9d56f0fd"}],"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"9f5d7f337019bf8390a4991c30cd948857e3c02c","unresolved":true,"context_lines":[{"line_number":235,"context_line":"                httpd"},{"line_number":236,"context_line":"                kernel-devel"},{"line_number":237,"context_line":"                mysql*"},{"line_number":238,"context_line":"                mariadb-server*"},{"line_number":239,"context_line":"                pacemaker*"},{"line_number":240,"context_line":"                python-jsonpointer"},{"line_number":241,"context_line":"                qemu-kvm-common-rhev"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"54731135_73b2e46c","line":238,"updated":"2021-10-22 12:50:10.000000000","message":"It might be even better to do this during the leapp process here: https://opendev.org/openstack/tripleo-heat-templates/src/commit/42f4b3acd29ffc12720a14413ac5952f9d56f0fd/environments/lifecycle/upgrade-prepare.yaml#L23\n\nHowever, I don\u0027t think that will take a wildcard.","commit_id":"7df7165742ee0fcdce63b8dc82e6e1c3fdb70157"}]}