)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"59a89606ab77dd7fb3559caf1a9fd7aa885c8df9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"441dd5d9_a216171a","updated":"2021-11-01 13:03:07.000000000","message":"check-rdo","commit_id":"4bf4866030c78c5f9343eb0084d72c4a03beefa7"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"001afe1c6921e4886a1e42fd24eb7059d8906734","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5c848948_c8acb06e","updated":"2021-11-05 12:47:17.000000000","message":"recheck","commit_id":"4bf4866030c78c5f9343eb0084d72c4a03beefa7"}],"deployment/cinder/cinder-api-container-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"97ee302b8f288f7272cd3131ec24a8c10a7bad93","unresolved":true,"context_lines":[{"line_number":430,"context_line":"            if ! openstack volume type show \"{{ default_volume_type }}\"; then"},{"line_number":431,"context_line":"                openstack volume type create --public \"{{ default_volume_type }}\""},{"line_number":432,"context_line":"            fi"},{"line_number":433,"context_line":"            # Avoid potential confusion with cinder\u0027s own __DEFAULT__ volume type:"},{"line_number":434,"context_line":"            # - For greenfield deployments (no volumes exist) then it\u0027s safe to delete"},{"line_number":435,"context_line":"            #   the __DEFAULT__ type."},{"line_number":436,"context_line":"            # - Otherwise, update the __DEFAULT__ type\u0027s description so users may"},{"line_number":437,"context_line":"            #   know which is the actual default volume type."},{"line_number":438,"context_line":"            eval $(openstack volume type show __DEFAULT__ -f shell -c id -c description)"},{"line_number":439,"context_line":"            if [ -n \"$id\" ]; then"},{"line_number":440,"context_line":"                vols\u003d$(openstack volume list -f value -c ID)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"01f99682_28cbe1d4","line":437,"range":{"start_line":433,"start_character":0,"end_line":437,"end_character":61},"updated":"2021-10-26 03:09:03.000000000","message":"Argh, I added this comment at the last minute, and it\u0027s tripping up the jinja2 expansion. On further reflection, I\u0027m going to eliminate the comment.","commit_id":"da1243f8bcc824283da22be21be674f563e0b863"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2b258a34e58cb4bdb52c3a47d35dc844f8cf5991","unresolved":true,"context_lines":[{"line_number":430,"context_line":"            if ! openstack volume type show \"{{ default_volume_type }}\"; then"},{"line_number":431,"context_line":"                openstack volume type create --public \"{{ default_volume_type }}\""},{"line_number":432,"context_line":"            fi"},{"line_number":433,"context_line":"            eval $(openstack volume type show __DEFAULT__ -f shell -c id -c description)"},{"line_number":434,"context_line":"            if [ -n \"$id\" ]; then"},{"line_number":435,"context_line":"                vols\u003d$(openstack volume list -f value -c ID)"},{"line_number":436,"context_line":"                tripleo_descr\u003d\"For internal use, \u0027{{ default_volume_type }}\u0027 is the default volume type\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"02aec27a_f2ec081c","line":433,"updated":"2021-10-26 12:56:47.000000000","message":"if we assume green/brown cases, shouldn\u0027t that belong to external_update_tasks?","commit_id":"4bf4866030c78c5f9343eb0084d72c4a03beefa7"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6d154afd16c93e8049ac1edcb69d3072f126b37e","unresolved":true,"context_lines":[{"line_number":430,"context_line":"            if ! openstack volume type show \"{{ default_volume_type }}\"; then"},{"line_number":431,"context_line":"                openstack volume type create --public \"{{ default_volume_type }}\""},{"line_number":432,"context_line":"            fi"},{"line_number":433,"context_line":"            eval $(openstack volume type show __DEFAULT__ -f shell -c id -c description)"},{"line_number":434,"context_line":"            if [ -n \"$id\" ]; then"},{"line_number":435,"context_line":"                vols\u003d$(openstack volume list -f value -c ID)"},{"line_number":436,"context_line":"                tripleo_descr\u003d\"For internal use, \u0027{{ default_volume_type }}\u0027 is the default volume type\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c7e820c9_699773b6","line":433,"in_reply_to":"02aec27a_f2ec081c","updated":"2021-10-26 13:08:57.000000000","message":"The intent is to always do whatever is necessary to clean things up, and not just do the cleanup on an upgrade. Sorry, I\u0027m not sure if I\u0027ve addressed your concern.","commit_id":"4bf4866030c78c5f9343eb0084d72c4a03beefa7"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c73d40f15ee7375ae158377d1f910c39016915ea","unresolved":true,"context_lines":[{"line_number":430,"context_line":"            if ! openstack volume type show \"{{ default_volume_type }}\"; then"},{"line_number":431,"context_line":"                openstack volume type create --public \"{{ default_volume_type }}\""},{"line_number":432,"context_line":"            fi"},{"line_number":433,"context_line":"            eval $(openstack volume type show __DEFAULT__ -f shell -c id -c description)"},{"line_number":434,"context_line":"            if [ -n \"$id\" ]; then"},{"line_number":435,"context_line":"                vols\u003d$(openstack volume list -f value -c ID)"},{"line_number":436,"context_line":"                tripleo_descr\u003d\"For internal use, \u0027{{ default_volume_type }}\u0027 is the default volume type\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fb02dbfb_ce302af3","line":433,"in_reply_to":"9672c1af_83cec627","updated":"2021-11-03 13:35:06.000000000","message":"Sure, on the initial deployment there won\u0027t be any volumes, and tasks in external_update_tasks are brown field, where volumes probably exist. But in order for everything to be idempotent, I think conditionals would be required in both places. Locating everything here (as opposed to covering brown field in external_update_tasks) simply consolidates the logic, and avoids having to repeat the conditionals.","commit_id":"4bf4866030c78c5f9343eb0084d72c4a03beefa7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4f96cd33f15ac934f0d07bb8ec70beee6286351f","unresolved":true,"context_lines":[{"line_number":430,"context_line":"            if ! openstack volume type show \"{{ default_volume_type }}\"; then"},{"line_number":431,"context_line":"                openstack volume type create --public \"{{ default_volume_type }}\""},{"line_number":432,"context_line":"            fi"},{"line_number":433,"context_line":"            eval $(openstack volume type show __DEFAULT__ -f shell -c id -c description)"},{"line_number":434,"context_line":"            if [ -n \"$id\" ]; then"},{"line_number":435,"context_line":"                vols\u003d$(openstack volume list -f value -c ID)"},{"line_number":436,"context_line":"                tripleo_descr\u003d\"For internal use, \u0027{{ default_volume_type }}\u0027 is the default volume type\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9672c1af_83cec627","line":433,"in_reply_to":"c7e820c9_699773b6","updated":"2021-11-03 10:39:38.000000000","message":"I didn\u0027t mean upgrades, but minor updates. Otherwise, we should not expect any volumes there in the basic deployment run?","commit_id":"4bf4866030c78c5f9343eb0084d72c4a03beefa7"}]}