)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7807335000847f62493a9a0bcdd8b1344b7ded5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9a828baf_f256a168","updated":"2021-10-26 08:34:16.000000000","message":"I noticed my silly mistake and I should remove not puppet_config but container_puppet_tasks ...","commit_id":"5d5bab2092ca1a314f209db2e622e8223bf281ed"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0fda2770f77e2d9f8f1386b43219c2e9ec79f0a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"22d1553b_2e757414","updated":"2021-11-08 12:13:56.000000000","message":"recheck","commit_id":"040859a739fd0d5a09949abece42a148a9cda969"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3936b6b13e5ff8dacffc32cae3af4fc28b39c476","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"87930ec0_c3d25316","updated":"2021-11-09 03:52:40.000000000","message":"recheck","commit_id":"040859a739fd0d5a09949abece42a148a9cda969"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"bc15221582994a9c87682d8a63e4ca57718915b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"964bd71b_69bfaa58","updated":"2021-11-04 01:26:10.000000000","message":"recheck","commit_id":"040859a739fd0d5a09949abece42a148a9cda969"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"c690f609b1b0367ab41537c8cc3c1243d861775f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a3e642ea_09201534","updated":"2021-11-04 10:39:33.000000000","message":"recheck","commit_id":"040859a739fd0d5a09949abece42a148a9cda969"}],"deployment/cinder/cinder-api-container-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"35a6edf73bd1436a2a4d3093eb483d3d0359c635","unresolved":true,"context_lines":[{"line_number":341,"context_line":"                  - /var/log/containers/httpd/cinder-api:/var/log/httpd:z"},{"line_number":342,"context_line":"            environment:"},{"line_number":343,"context_line":"              KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"},{"line_number":344,"context_line":"      container_puppet_tasks:"},{"line_number":345,"context_line":"        # Create the default volume type after the cinder-api service is"},{"line_number":346,"context_line":"        # running. The puppet code will ensure this is only done once, on"},{"line_number":347,"context_line":"        # the bootstrap node."},{"line_number":348,"context_line":"        step_4:"},{"line_number":349,"context_line":"          config_volume: \u0027cinder_init_tasks\u0027"},{"line_number":350,"context_line":"          puppet_tags: cinder_config,file,concat,file_line"},{"line_number":351,"context_line":"          step_config: \u0027include tripleo::profile::base::cinder::api\u0027"},{"line_number":352,"context_line":"          config_image: *cinder_api_image"},{"line_number":353,"context_line":"          volumes:"},{"line_number":354,"context_line":"            - /var/lib/config-data/puppet-generated/cinder/etc/cinder/:/etc/cinder/:ro"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"      metadata_settings:"},{"line_number":357,"context_line":"        get_attr: [ApacheServiceBase, role_data, metadata_settings]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ee9ff85e_f84dc46e","line":354,"range":{"start_line":344,"start_character":0,"end_line":354,"end_character":86},"updated":"2021-10-26 03:17:12.000000000","message":"I suspect this entire block can be removed. If memory serves (it\u0027s been a while), I added this block solely for the purpose of having puppet create the type, but only after cinder\u0027s API service is running. The work is now handled in the external_steps_deploy block at L415.\n\nBTW, it won\u0027t interfere with this patch, but I\u0027ve got another change related to the default volume type [1].\n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/815332","commit_id":"31f796786176d6643f189e07e8cb7e3b52b492d1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"19a04acfd973b11bd34bf47d22eb55a36cfdaaa4","unresolved":false,"context_lines":[{"line_number":341,"context_line":"                  - /var/log/containers/httpd/cinder-api:/var/log/httpd:z"},{"line_number":342,"context_line":"            environment:"},{"line_number":343,"context_line":"              KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"},{"line_number":344,"context_line":"      container_puppet_tasks:"},{"line_number":345,"context_line":"        # Create the default volume type after the cinder-api service is"},{"line_number":346,"context_line":"        # running. The puppet code will ensure this is only done once, on"},{"line_number":347,"context_line":"        # the bootstrap node."},{"line_number":348,"context_line":"        step_4:"},{"line_number":349,"context_line":"          config_volume: \u0027cinder_init_tasks\u0027"},{"line_number":350,"context_line":"          puppet_tags: cinder_config,file,concat,file_line"},{"line_number":351,"context_line":"          step_config: \u0027include tripleo::profile::base::cinder::api\u0027"},{"line_number":352,"context_line":"          config_image: *cinder_api_image"},{"line_number":353,"context_line":"          volumes:"},{"line_number":354,"context_line":"            - /var/lib/config-data/puppet-generated/cinder/etc/cinder/:/etc/cinder/:ro"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"      metadata_settings:"},{"line_number":357,"context_line":"        get_attr: [ApacheServiceBase, role_data, metadata_settings]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"06650f7f_d5bb296d","line":354,"range":{"start_line":344,"start_character":0,"end_line":354,"end_character":86},"in_reply_to":"b173fa90_89081454","updated":"2021-10-26 04:20:31.000000000","message":"Done","commit_id":"31f796786176d6643f189e07e8cb7e3b52b492d1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"91aa4ec769f8766fd949c1991c90239ed3f86223","unresolved":true,"context_lines":[{"line_number":341,"context_line":"                  - /var/log/containers/httpd/cinder-api:/var/log/httpd:z"},{"line_number":342,"context_line":"            environment:"},{"line_number":343,"context_line":"              KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"},{"line_number":344,"context_line":"      container_puppet_tasks:"},{"line_number":345,"context_line":"        # Create the default volume type after the cinder-api service is"},{"line_number":346,"context_line":"        # running. The puppet code will ensure this is only done once, on"},{"line_number":347,"context_line":"        # the bootstrap node."},{"line_number":348,"context_line":"        step_4:"},{"line_number":349,"context_line":"          config_volume: \u0027cinder_init_tasks\u0027"},{"line_number":350,"context_line":"          puppet_tags: cinder_config,file,concat,file_line"},{"line_number":351,"context_line":"          step_config: \u0027include tripleo::profile::base::cinder::api\u0027"},{"line_number":352,"context_line":"          config_image: *cinder_api_image"},{"line_number":353,"context_line":"          volumes:"},{"line_number":354,"context_line":"            - /var/lib/config-data/puppet-generated/cinder/etc/cinder/:/etc/cinder/:ro"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"      metadata_settings:"},{"line_number":357,"context_line":"        get_attr: [ApacheServiceBase, role_data, metadata_settings]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b173fa90_89081454","line":354,"range":{"start_line":344,"start_character":0,"end_line":354,"end_character":86},"in_reply_to":"ee9ff85e_f84dc46e","updated":"2021-10-26 04:13:50.000000000","message":"I agree with you and this container is used to create a volume type and has no effect now(it just ensures all parameters for api are set). I\u0027ll fix this soon.\n\nAnd thanks for you additional information! I\u0027ll check the patch later.","commit_id":"31f796786176d6643f189e07e8cb7e3b52b492d1"}]}