)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"2dc812b04d36697d025e2b5b72d7e0e24a90b935","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e699b5ee_204826c8","updated":"2021-10-27 06:13:47.000000000","message":"I\u0027m okay with this.\nI think we could remove the check for \u0027:\u0027 in ip_subnet in two places.","commit_id":"48ed6294c8b487d9503a2a865aae5cb00a4483d7"}],"network/network.j2":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"691c23361881858d8649add50cd9e4a5df6c0941","unresolved":true,"context_lines":[{"line_number":95,"context_line":"      Cidr for the {{network.name_lower}} network\u0027s {{subnet}} subnet."},{"line_number":96,"context_line":"    type: string"},{"line_number":97,"context_line":"  {{network.name}}AllocationPools_{{subnet}}:"},{"line_number":98,"context_line":"{%-     if network.ipv6|default(false) or ipv6_override or \":\" in network.subnets[subnet][\u0027ip_subnet\u0027] %}"},{"line_number":99,"context_line":"    default: {{network.subnets[subnet][\u0027ipv6_allocation_pools\u0027]|default(network.subnets[subnet][\u0027allocation_pools\u0027]|default([]))}}"},{"line_number":100,"context_line":"{%-     else %}"},{"line_number":101,"context_line":"    default: {{network.subnets[subnet][\u0027allocation_pools\u0027]|default([])}}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"47d7269f_a72dc8d6","line":98,"range":{"start_line":98,"start_character":56,"end_line":98,"end_character":102},"updated":"2021-10-27 02:31:28.000000000","message":"We can probably get rid of this check as \u0027ipv6\u0027 is a required key with network data v2 and user should also be using \u0027ipv6_subnet\u0027 (both v1 and v2). Not sure why we\u0027re checking \u0027ip_subnet\u0027 key here.","commit_id":"48ed6294c8b487d9503a2a865aae5cb00a4483d7"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"2dc812b04d36697d025e2b5b72d7e0e24a90b935","unresolved":true,"context_lines":[{"line_number":95,"context_line":"      Cidr for the {{network.name_lower}} network\u0027s {{subnet}} subnet."},{"line_number":96,"context_line":"    type: string"},{"line_number":97,"context_line":"  {{network.name}}AllocationPools_{{subnet}}:"},{"line_number":98,"context_line":"{%-     if network.ipv6|default(false) or ipv6_override or \":\" in network.subnets[subnet][\u0027ip_subnet\u0027] %}"},{"line_number":99,"context_line":"    default: {{network.subnets[subnet][\u0027ipv6_allocation_pools\u0027]|default(network.subnets[subnet][\u0027allocation_pools\u0027]|default([]))}}"},{"line_number":100,"context_line":"{%-     else %}"},{"line_number":101,"context_line":"    default: {{network.subnets[subnet][\u0027allocation_pools\u0027]|default([])}}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"50c85bbb_2d1e1cd7","line":98,"range":{"start_line":98,"start_character":56,"end_line":98,"end_character":102},"in_reply_to":"47d7269f_a72dc8d6","updated":"2021-10-27 06:13:47.000000000","message":"v1 allows IPv4 or IPv6 in \u0027ip_subnet\u0027 https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/network_data.yaml#L27-L28\n\nhowever, I think we can remove the check as well.\n\nIf we set IPv6 address in \u0027ip_subnet\u0027, I would also expect IPv6 allocation pool in network.subnets[subnet][\u0027allocation_pools\u0027] and ditto for network.subnets[subnet][\u0027gateway_ip\u0027]","commit_id":"48ed6294c8b487d9503a2a865aae5cb00a4483d7"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"f68ac9f1b70a133020caad50394b9fdc9cb89f9b","unresolved":true,"context_lines":[{"line_number":95,"context_line":"      Cidr for the {{network.name_lower}} network\u0027s {{subnet}} subnet."},{"line_number":96,"context_line":"    type: string"},{"line_number":97,"context_line":"  {{network.name}}AllocationPools_{{subnet}}:"},{"line_number":98,"context_line":"{%-     if network.ipv6|default(false) or ipv6_override or \":\" in network.subnets[subnet][\u0027ip_subnet\u0027] %}"},{"line_number":99,"context_line":"    default: {{network.subnets[subnet][\u0027ipv6_allocation_pools\u0027]|default(network.subnets[subnet][\u0027allocation_pools\u0027]|default([]))}}"},{"line_number":100,"context_line":"{%-     else %}"},{"line_number":101,"context_line":"    default: {{network.subnets[subnet][\u0027allocation_pools\u0027]|default([])}}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"f70badf1_b9ab0026","line":98,"range":{"start_line":98,"start_character":56,"end_line":98,"end_character":102},"in_reply_to":"50c85bbb_2d1e1cd7","updated":"2021-10-28 08:46:46.000000000","message":"\u003e If we set IPv6 address in \u0027ip_subnet\u0027, I would also expect IPv6 allocation pool in network.subnets[subnet][\u0027allocation_pools\u0027] and ditto for network.subnets[subnet][\u0027gateway_ip\u0027]\n\nOn second tought, we may not want to change this behaviour.\nLet\u0027s merge this as is. The entire file should be removed, as it is not actually used with network-v2.","commit_id":"48ed6294c8b487d9503a2a865aae5cb00a4483d7"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"94a70bf0c92395c535d48c55b407823f700f4fb8","unresolved":true,"context_lines":[{"line_number":95,"context_line":"      Cidr for the {{network.name_lower}} network\u0027s {{subnet}} subnet."},{"line_number":96,"context_line":"    type: string"},{"line_number":97,"context_line":"  {{network.name}}AllocationPools_{{subnet}}:"},{"line_number":98,"context_line":"{%-     if network.ipv6|default(false) or ipv6_override or \":\" in network.subnets[subnet][\u0027ip_subnet\u0027] %}"},{"line_number":99,"context_line":"    default: {{network.subnets[subnet][\u0027ipv6_allocation_pools\u0027]|default(network.subnets[subnet][\u0027allocation_pools\u0027]|default([]))}}"},{"line_number":100,"context_line":"{%-     else %}"},{"line_number":101,"context_line":"    default: {{network.subnets[subnet][\u0027allocation_pools\u0027]|default([])}}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"c31aff0b_a08cd2a6","line":98,"range":{"start_line":98,"start_character":56,"end_line":98,"end_character":102},"in_reply_to":"f70badf1_b9ab0026","updated":"2021-10-28 11:23:46.000000000","message":"OK","commit_id":"48ed6294c8b487d9503a2a865aae5cb00a4483d7"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"2dc812b04d36697d025e2b5b72d7e0e24a90b935","unresolved":true,"context_lines":[{"line_number":104,"context_line":"      Ip allocation pool range for the {{network.name_lower}} network\u0027s {{subnet}} subnet."},{"line_number":105,"context_line":"    type: json"},{"line_number":106,"context_line":"  {{network.name}}InterfaceDefaultRoute_{{subnet}}:"},{"line_number":107,"context_line":"{%-     if network.ipv6|default(false) or ipv6_override or \":\" in network.subnets[subnet][\u0027ip_subnet\u0027] %}"},{"line_number":108,"context_line":"    default: \"{{network.subnets[subnet][\u0027gateway_ipv6\u0027]|default(network.subnets[subnet][\u0027gateway_ip\u0027]|default([]))}}\""},{"line_number":109,"context_line":"{%-     else %}"},{"line_number":110,"context_line":"    default: \"{{network.subnets[subnet][\u0027gateway_ip\u0027]|default([])}}\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7d7595b6_0a742853","line":107,"range":{"start_line":107,"start_character":59,"end_line":107,"end_character":102},"updated":"2021-10-27 06:13:47.000000000","message":"this one could be removed as well.","commit_id":"48ed6294c8b487d9503a2a865aae5cb00a4483d7"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"2dc812b04d36697d025e2b5b72d7e0e24a90b935","unresolved":true,"context_lines":[{"line_number":208,"context_line":"      # All networks have an implicit network segment when created, map this subnet to that segment."},{"line_number":209,"context_line":"      segment: {get_attr: [{{network.name}}Network, segments, 0, id]}"},{"line_number":210,"context_line":"      ip_version: {if: [is_ipv6, 6, 4]}"},{"line_number":211,"context_line":"{%- if network.ipv6|default(false) or ipv6_override or \":\" in network.ip_subnet|default(\"\") %}"},{"line_number":212,"context_line":"      ipv6_address_mode: {get_param: IPv6AddressMode}"},{"line_number":213,"context_line":"      ipv6_ra_mode: {get_param: IPv6RAMode}"},{"line_number":214,"context_line":"{%- else %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5de815e9_d1e77975","line":211,"range":{"start_line":211,"start_character":55,"end_line":211,"end_character":91},"updated":"2021-10-27 06:13:47.000000000","message":"this one we should keep.","commit_id":"48ed6294c8b487d9503a2a865aae5cb00a4483d7"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"2dc812b04d36697d025e2b5b72d7e0e24a90b935","unresolved":true,"context_lines":[{"line_number":256,"context_line":"      host_routes: {get_param: {{network.name}}Routes_{{subnet}}}"},{"line_number":257,"context_line":"      segment: {get_resource: {{network.name}}Segment_{{subnet}}}"},{"line_number":258,"context_line":"      ip_version: {if: [is_ipv6, 6, 4]}"},{"line_number":259,"context_line":"{%- if network.ipv6|default(false) or ipv6_override or \":\" in network.ip_subnet|default(\"\") %}"},{"line_number":260,"context_line":"      ipv6_address_mode: {get_param: IPv6AddressMode}"},{"line_number":261,"context_line":"      ipv6_ra_mode: {get_param: IPv6RAMode}"},{"line_number":262,"context_line":"{%- else %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9c97576a_68fca1d4","line":259,"range":{"start_line":259,"start_character":55,"end_line":259,"end_character":91},"updated":"2021-10-27 06:13:47.000000000","message":"this as well.","commit_id":"48ed6294c8b487d9503a2a865aae5cb00a4483d7"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"c716207fded9f095ec86089270e3459f6c453de0","unresolved":true,"context_lines":[{"line_number":256,"context_line":"      host_routes: {get_param: {{network.name}}Routes_{{subnet}}}"},{"line_number":257,"context_line":"      segment: {get_resource: {{network.name}}Segment_{{subnet}}}"},{"line_number":258,"context_line":"      ip_version: {if: [is_ipv6, 6, 4]}"},{"line_number":259,"context_line":"{%- if network.ipv6|default(false) or ipv6_override or \":\" in network.ip_subnet|default(\"\") %}"},{"line_number":260,"context_line":"      ipv6_address_mode: {get_param: IPv6AddressMode}"},{"line_number":261,"context_line":"      ipv6_ra_mode: {get_param: IPv6RAMode}"},{"line_number":262,"context_line":"{%- else %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"22c331b6_5e56e3a6","line":259,"range":{"start_line":259,"start_character":55,"end_line":259,"end_character":91},"in_reply_to":"9c97576a_68fca1d4","updated":"2021-10-27 06:14:37.000000000","message":"should keep this one.","commit_id":"48ed6294c8b487d9503a2a865aae5cb00a4483d7"}]}