)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"c68ac66d09694a381d21026d7e457b3b469a31ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6f1e9fcd_0cd436ba","updated":"2021-11-05 13:37:04.000000000","message":"recheck","commit_id":"6ac8dd396cb57fe4957c93466fba197ee73f6a86"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"b171a9f21d6b75a2ddcc5551f0997463d8332322","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cc4ec01b_ef601e76","updated":"2021-11-05 13:14:24.000000000","message":"recheck","commit_id":"6ac8dd396cb57fe4957c93466fba197ee73f6a86"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"7d22840d48e222de4f430f6ad28b6a617874b772","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"408f050a_b386af07","updated":"2021-11-10 20:21:11.000000000","message":"Adding -1 to solicit a response to my previous comments.","commit_id":"357b356706d55a828b9434a952442ea6c7e51c4c"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"f058f3d6525192a35a4e56e209a6aa2f3798f6b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"df083440_adf7ce62","updated":"2021-11-10 19:53:45.000000000","message":"check-check-rdo","commit_id":"357b356706d55a828b9434a952442ea6c7e51c4c"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"5263f3dfee68a0b68c86f6a24ddf3607acf1f42e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3b9f2a6c_2cb4a92d","updated":"2021-11-08 16:21:45.000000000","message":"check-rdo","commit_id":"357b356706d55a828b9434a952442ea6c7e51c4c"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"4f7e900e9220185dac984b573d3848b7c21888df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"84bae811_98df359a","updated":"2021-11-08 18:38:30.000000000","message":"check-rdo","commit_id":"357b356706d55a828b9434a952442ea6c7e51c4c"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"cdf3c91a1f46d5a99a15e85ed909c49fe185d863","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bf349b5b_c5777a14","updated":"2021-11-09 14:01:13.000000000","message":"check-rdo","commit_id":"357b356706d55a828b9434a952442ea6c7e51c4c"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"98dead47757fd1df8fd4143acf6ee3fc1a7fe95f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8cf185d9_3bcbdc8b","updated":"2021-11-06 03:28:35.000000000","message":"recheck","commit_id":"357b356706d55a828b9434a952442ea6c7e51c4c"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"bd250deb3cdfd5e6e03b4135a8c0caab45313ba8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d3318f44_fb6cf551","updated":"2021-11-05 21:51:54.000000000","message":"recheck","commit_id":"357b356706d55a828b9434a952442ea6c7e51c4c"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d4518fafac70e66844f6190c3ebda42ab7a1fd02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"dce70f91_645bf118","updated":"2021-11-11 15:44:34.000000000","message":"While doing a test to check the results (as seen in cinder.conf) of using a blank string for the default CinderPureIscsiCidr value, I uncovered a couple of typos that I previously missed.","commit_id":"7ab031c6675c41540ea90cb04f6a91918b9d0bce"}],"deployment/cinder/cinder-backend-pure-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"e2b071fb2816f208f5b759c98808421815fff9cd","unresolved":true,"context_lines":[{"line_number":76,"context_line":"  CinderPureImageCache:"},{"line_number":77,"context_line":"    type: boolean"},{"line_number":78,"context_line":"    default: true"},{"line_number":79,"context_line":"  CinderPureHostPersonality:"},{"line_number":80,"context_line":"    type: string"},{"line_number":81,"context_line":"  CinderPureEradicateOnDelete:"},{"line_number":82,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"377a5aa3_f218a91e","line":79,"updated":"2021-11-05 13:41:51.000000000","message":"There are a few things I\u0027d like to see:\n\n1. Please add a description, which is especially useful when the parameter name doesn\u0027t reveal what it\u0027s used for. It\u0027s often easy to reuse or tweak cinder\u0027s own description, [1].\n\n2. You can add a constraint to the list of possible values listed in [1] (see [2] for an example, which, btw, could be added here near L63). The only tricky bit is I think you need to use an empty value \u0027\u0027 to represent the \"None\" case.\n\n3. Based on my reading of [1], it probably makes sense to define a default value of \u0027\u0027 for the THT parameter.\n\n[1] https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/drivers/pure.py#L64\n[2] https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/deployment/cinder/cinder-backend-dellemc-xtremio-puppet.yaml#L68","commit_id":"6ac8dd396cb57fe4957c93466fba197ee73f6a86"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"e2b071fb2816f208f5b759c98808421815fff9cd","unresolved":true,"context_lines":[{"line_number":98,"context_line":"            cinder::backend::pure::use_chap_auth: {get_param: CinderPureUseChap}"},{"line_number":99,"context_line":"            cinder::backend::pure::use_multipath_for_image_xfer: {get_param: CinderPureMultipathXfer}"},{"line_number":100,"context_line":"            cinder::backend::pure::image_volume_cache_enabled : {get_param: CinderPureImageCache}"},{"line_number":101,"context_line":"            cinder::backend::pure::pure_eradicate_on_delete : {get_param: CinderPureEradicateOnDelete}"},{"line_number":102,"context_line":"            cinder::backend::pure::pure_iscsi_cidr : {get_param: CinderPureIscsiCidr}"},{"line_number":103,"context_line":"          - if:"},{"line_number":104,"context_line":"            - not: {equals : [{get_param: CinderPureAvailabilityZone}, \u0027\u0027]}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"31de04fd_2864a0e6","line":101,"updated":"2021-11-05 13:41:51.000000000","message":"As I noted in another review, I don\u0027t see this parameter supported in puppet-cinder.","commit_id":"6ac8dd396cb57fe4957c93466fba197ee73f6a86"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"e2b071fb2816f208f5b759c98808421815fff9cd","unresolved":true,"context_lines":[{"line_number":99,"context_line":"            cinder::backend::pure::use_multipath_for_image_xfer: {get_param: CinderPureMultipathXfer}"},{"line_number":100,"context_line":"            cinder::backend::pure::image_volume_cache_enabled : {get_param: CinderPureImageCache}"},{"line_number":101,"context_line":"            cinder::backend::pure::pure_eradicate_on_delete : {get_param: CinderPureEradicateOnDelete}"},{"line_number":102,"context_line":"            cinder::backend::pure::pure_iscsi_cidr : {get_param: CinderPureIscsiCidr}"},{"line_number":103,"context_line":"          - if:"},{"line_number":104,"context_line":"            - not: {equals : [{get_param: CinderPureAvailabilityZone}, \u0027\u0027]}"},{"line_number":105,"context_line":"            - cinder::backend::pure::backend_availability_zone: {get_param: CinderPureAvailabilityZone}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1476ac19_199c80ee","line":102,"updated":"2021-11-05 13:41:51.000000000","message":"The CinderPureIscsiCidr parameter needs to be defined, above.","commit_id":"6ac8dd396cb57fe4957c93466fba197ee73f6a86"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"36107f332a886df3f11c6c68c78b68f010c9f929","unresolved":true,"context_lines":[{"line_number":80,"context_line":"    default: true"},{"line_number":81,"context_line":"  CinderPureHostPersonality:"},{"line_number":82,"context_line":"    type: string"},{"line_number":83,"context_line":"    default: \u0027\u0027"},{"line_number":84,"context_line":"    contraints:"},{"line_number":85,"context_line":"      - allowed_values: [\u0027aix\u0027, \u0027esxi\u0027, \u0027hitachi-vsp\u0027, \u0027hpux\u0027,"},{"line_number":86,"context_line":"                         \u0027oracle-vm-server\u0027, \u0027solaris\u0027, \u0027vms\u0027, \u0027\u0027]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a2c663f_4a3b9f86","line":83,"updated":"2021-11-08 20:26:21.000000000","message":"I think this is a situation where something like \"none\" would work instead of \u0027\u0027 (empty string). The conditional at L126 will ensure the hiera variable is set only when there\u0027s an actual host personality to configure.","commit_id":"357b356706d55a828b9434a952442ea6c7e51c4c"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"4e296e92866de91dcfc960f050ac833c26eba385","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    default: true"},{"line_number":81,"context_line":"  CinderPureHostPersonality:"},{"line_number":82,"context_line":"    type: string"},{"line_number":83,"context_line":"    default: \u0027\u0027"},{"line_number":84,"context_line":"    contraints:"},{"line_number":85,"context_line":"      - allowed_values: [\u0027aix\u0027, \u0027esxi\u0027, \u0027hitachi-vsp\u0027, \u0027hpux\u0027,"},{"line_number":86,"context_line":"                         \u0027oracle-vm-server\u0027, \u0027solaris\u0027, \u0027vms\u0027, \u0027\u0027]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3da4881e_cd28ff2f","line":83,"in_reply_to":"3a2c663f_4a3b9f86","updated":"2021-11-10 20:28:25.000000000","message":"Done","commit_id":"357b356706d55a828b9434a952442ea6c7e51c4c"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"36107f332a886df3f11c6c68c78b68f010c9f929","unresolved":true,"context_lines":[{"line_number":88,"context_line":"                 used between the array and the initiator."},{"line_number":89,"context_line":"  CinderPureIscsiCidr:"},{"line_number":90,"context_line":"    type: string"},{"line_number":91,"context_line":"    default: \u0027\u0027"},{"line_number":92,"context_line":"    description: CIDR of FlashArray iSCSI targets hosts are allowed"},{"line_number":93,"context_line":"                 to connect to."},{"line_number":94,"context_line":"  CinderPureEradicateOnDelete:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"363dc4cc_f222418b","line":91,"updated":"2021-11-08 20:26:21.000000000","message":"I know your puppet-cinder patch uses the magic \"$::os_service_default\" method of specify the default value, and that\u0027s important because openstack puppet is used by multiple deployment tools and therefore needs to be non-opinionated. But it\u0027s OK for tripleo to be more opinionated, and here it means you could set the default value to \"0.0.0.0/0\" (which, I know, is the driver\u0027s default value).\n\nI mention this because \u0027\u0027 doesn\u0027t inform the user what they\u0027ll get unless they override the default value.\n\nAn alternative might be to enhance the description to tell the user that a blank string is equivalent to \"0.0.0.0/0\" (any valid IPv4 host).\n\nHmm, that raises another question. If the Pure Storage backend supports IPv6, then how would that affect things?","commit_id":"357b356706d55a828b9434a952442ea6c7e51c4c"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"4e296e92866de91dcfc960f050ac833c26eba385","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                 used between the array and the initiator."},{"line_number":89,"context_line":"  CinderPureIscsiCidr:"},{"line_number":90,"context_line":"    type: string"},{"line_number":91,"context_line":"    default: \u0027\u0027"},{"line_number":92,"context_line":"    description: CIDR of FlashArray iSCSI targets hosts are allowed"},{"line_number":93,"context_line":"                 to connect to."},{"line_number":94,"context_line":"  CinderPureEradicateOnDelete:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a514c064_e3669040","line":91,"in_reply_to":"363dc4cc_f222418b","updated":"2021-11-10 20:28:25.000000000","message":"IPv6 support for the iSCSI CIDR only became available and is supported by the _list param we will be adding in a subsequent patch.\nThis patch will be backported to Wallaby which doesn\u0027t support the _list parameter nor IPv6","commit_id":"357b356706d55a828b9434a952442ea6c7e51c4c"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c0a4b1fc5f44111599342f5d565974b2793e67b3","unresolved":true,"context_lines":[{"line_number":83,"context_line":"    default: None"},{"line_number":84,"context_line":"    contraints:"},{"line_number":85,"context_line":"      - allowed_values: [\u0027aix\u0027, \u0027esxi\u0027, \u0027hitachi-vsp\u0027, \u0027hpux\u0027,"},{"line_number":86,"context_line":"                         \u0027oracle-vm-server\u0027, \u0027solaris\u0027, \u0027vms\u0027, \u0027\u0027]"},{"line_number":87,"context_line":"    description: Determines how the Purity system tunes the protocol"},{"line_number":88,"context_line":"                 used between the array and the initiator."},{"line_number":89,"context_line":"  CinderPureIscsiCidr:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"45b6f883_8e18e0a2","line":86,"range":{"start_line":86,"start_character":63,"end_line":86,"end_character":65},"updated":"2021-11-10 21:09:49.000000000","message":"Sorry, I should have been more clear. The \u0027None\u0027 on L83 would need to be in the list of allowed_values (or \u0027none\u0027 to be consistent about using lower case). THT doesn\u0027t interpret None in the same manner that python does. Here, \u0027none\u0027 is simply a string.\n\nAnd, to be doubly sorry, I\u0027m rethinking my suggestion to use \u0027None\u0027 (or \u0027none\u0027), and maybe a blank value is easier to understand. If you could enhance the description the same way you did for the CinderPureIscsiCidr parameter (L94..95) and change L83 back to \u0027\u0027 then it will lgtm. That way both parameters follow the same convention of using a blank string.","commit_id":"f190776ced5d3d178c19f6b54afb6c764076f237"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"1fb77a814335af1e484ae027b243e3d60da5d707","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    default: None"},{"line_number":84,"context_line":"    contraints:"},{"line_number":85,"context_line":"      - allowed_values: [\u0027aix\u0027, \u0027esxi\u0027, \u0027hitachi-vsp\u0027, \u0027hpux\u0027,"},{"line_number":86,"context_line":"                         \u0027oracle-vm-server\u0027, \u0027solaris\u0027, \u0027vms\u0027, \u0027\u0027]"},{"line_number":87,"context_line":"    description: Determines how the Purity system tunes the protocol"},{"line_number":88,"context_line":"                 used between the array and the initiator."},{"line_number":89,"context_line":"  CinderPureIscsiCidr:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e28f120a_c986bbe8","line":86,"range":{"start_line":86,"start_character":63,"end_line":86,"end_character":65},"in_reply_to":"45b6f883_8e18e0a2","updated":"2021-11-10 22:06:23.000000000","message":"Ack","commit_id":"f190776ced5d3d178c19f6b54afb6c764076f237"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c0a4b1fc5f44111599342f5d565974b2793e67b3","unresolved":true,"context_lines":[{"line_number":125,"context_line":"            - not: {equals : [{get_param: CinderPureAvailabilityZone}, \u0027\u0027]}"},{"line_number":126,"context_line":"            - cinder::backend::pure::backend_availability_zone: {get_param: CinderPureAvailabilityZone}"},{"line_number":127,"context_line":"          - if:"},{"line_number":128,"context_line":"            - not: {equals : [{get_param: CinderPureHostPersonality}, \u0027\u0027]}"},{"line_number":129,"context_line":"            - cinder::backend::pure::pure_host_personality: {get_param: CinderPureHostPersonality}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7cb296f2_060e983a","line":128,"range":{"start_line":128,"start_character":70,"end_line":128,"end_character":72},"updated":"2021-11-10 21:09:49.000000000","message":"This should probably be \u0027none\u0027 (not a blank string) per my previous comment.","commit_id":"f190776ced5d3d178c19f6b54afb6c764076f237"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"4f5f2bde76a63aee31b239c6e004210a7497bae8","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            - not: {equals : [{get_param: CinderPureAvailabilityZone}, \u0027\u0027]}"},{"line_number":126,"context_line":"            - cinder::backend::pure::backend_availability_zone: {get_param: CinderPureAvailabilityZone}"},{"line_number":127,"context_line":"          - if:"},{"line_number":128,"context_line":"            - not: {equals : [{get_param: CinderPureHostPersonality}, \u0027\u0027]}"},{"line_number":129,"context_line":"            - cinder::backend::pure::pure_host_personality: {get_param: CinderPureHostPersonality}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"283ae09f_9181d833","line":128,"range":{"start_line":128,"start_character":70,"end_line":128,"end_character":72},"in_reply_to":"7cb296f2_060e983a","updated":"2021-11-10 21:17:22.000000000","message":"Nevermind, I\u0027m now thinking \u0027\u0027 is the better approach.","commit_id":"f190776ced5d3d178c19f6b54afb6c764076f237"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d4518fafac70e66844f6190c3ebda42ab7a1fd02","unresolved":true,"context_lines":[{"line_number":63,"context_line":"  CinderPureStorageProtocol:"},{"line_number":64,"context_line":"    type: string"},{"line_number":65,"context_line":"    default: \u0027iSCSI\u0027"},{"line_number":66,"context_line":"    contraints:"},{"line_number":67,"context_line":"      - allowed_values: [\u0027iSCSI\u0027, \u0027FC\u0027]"},{"line_number":68,"context_line":"  CinderPureSanIp:"},{"line_number":69,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6d0a8327_d7a10a63","line":66,"range":{"start_line":66,"start_character":4,"end_line":66,"end_character":14},"updated":"2021-11-11 15:44:34.000000000","message":"-1: typo \"constraints\"","commit_id":"7ab031c6675c41540ea90cb04f6a91918b9d0bce"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"31f50238a480ea0579448f9c2da7612c5afaf119","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  CinderPureStorageProtocol:"},{"line_number":64,"context_line":"    type: string"},{"line_number":65,"context_line":"    default: \u0027iSCSI\u0027"},{"line_number":66,"context_line":"    contraints:"},{"line_number":67,"context_line":"      - allowed_values: [\u0027iSCSI\u0027, \u0027FC\u0027]"},{"line_number":68,"context_line":"  CinderPureSanIp:"},{"line_number":69,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"984696a5_7ebd3dff","line":66,"range":{"start_line":66,"start_character":4,"end_line":66,"end_character":14},"in_reply_to":"6d0a8327_d7a10a63","updated":"2021-11-11 15:52:16.000000000","message":"Done","commit_id":"7ab031c6675c41540ea90cb04f6a91918b9d0bce"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d4518fafac70e66844f6190c3ebda42ab7a1fd02","unresolved":true,"context_lines":[{"line_number":81,"context_line":"  CinderPureHostPersonality:"},{"line_number":82,"context_line":"    type: string"},{"line_number":83,"context_line":"    default: \u0027\u0027"},{"line_number":84,"context_line":"    contraints:"},{"line_number":85,"context_line":"      - allowed_values: [\u0027aix\u0027, \u0027esxi\u0027, \u0027hitachi-vsp\u0027, \u0027hpux\u0027,"},{"line_number":86,"context_line":"                         \u0027oracle-vm-server\u0027, \u0027solaris\u0027, \u0027vms\u0027, \u0027\u0027]"},{"line_number":87,"context_line":"    description: Determines how the Purity system tunes the protocol"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"784f8f0c_c6eba3b8","line":84,"range":{"start_line":84,"start_character":4,"end_line":84,"end_character":14},"updated":"2021-11-11 15:44:34.000000000","message":"\"constraints\"","commit_id":"7ab031c6675c41540ea90cb04f6a91918b9d0bce"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"31f50238a480ea0579448f9c2da7612c5afaf119","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  CinderPureHostPersonality:"},{"line_number":82,"context_line":"    type: string"},{"line_number":83,"context_line":"    default: \u0027\u0027"},{"line_number":84,"context_line":"    contraints:"},{"line_number":85,"context_line":"      - allowed_values: [\u0027aix\u0027, \u0027esxi\u0027, \u0027hitachi-vsp\u0027, \u0027hpux\u0027,"},{"line_number":86,"context_line":"                         \u0027oracle-vm-server\u0027, \u0027solaris\u0027, \u0027vms\u0027, \u0027\u0027]"},{"line_number":87,"context_line":"    description: Determines how the Purity system tunes the protocol"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"73994fd9_9541a9d2","line":84,"range":{"start_line":84,"start_character":4,"end_line":84,"end_character":14},"in_reply_to":"784f8f0c_c6eba3b8","updated":"2021-11-11 15:52:16.000000000","message":"Done","commit_id":"7ab031c6675c41540ea90cb04f6a91918b9d0bce"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"18f460f061d31117f9cab15fd6a72e97c59b3b18","unresolved":true,"context_lines":[{"line_number":89,"context_line":"                 A blank string will default to no Host Pesonality."},{"line_number":90,"context_line":"  CinderPureIscsiCidr:"},{"line_number":91,"context_line":"    type: string"},{"line_number":92,"context_line":"    default: \u0027\u0027"},{"line_number":93,"context_line":"    description: CIDR of FlashArray iSCSI targets hosts are allowed"},{"line_number":94,"context_line":"                 to connect to."},{"line_number":95,"context_line":"                 A Blank string will default to \"0.0.0.0/0\", ie."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f830557_2b61f6af","line":92,"updated":"2021-11-11 16:14:30.000000000","message":"My local test (mocking a Pure backend with a bogus IP address) reveals this blank default value ends up in cinder.conf:\n\n[tripleo_pure]\npure_iscsi_cidr\u003d\n\nI don\u0027t know how the driver will behave, but this doesn\u0027t look valid. If my suspicion is correct, then I think you either need to set the default THT value to \"0.0.0.0/0\", or add a conditional similar to L129. I think it would be fine if you modify the default value.","commit_id":"6ab3dc066bc5413531c19e654200d632d0323d98"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"16210f8cb083ac4b2edb846653920828b05591fc","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                 A blank string will default to no Host Pesonality."},{"line_number":90,"context_line":"  CinderPureIscsiCidr:"},{"line_number":91,"context_line":"    type: string"},{"line_number":92,"context_line":"    default: \u0027\u0027"},{"line_number":93,"context_line":"    description: CIDR of FlashArray iSCSI targets hosts are allowed"},{"line_number":94,"context_line":"                 to connect to."},{"line_number":95,"context_line":"                 A Blank string will default to \"0.0.0.0/0\", ie."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bfc89c55_6b252cfd","line":92,"in_reply_to":"7f830557_2b61f6af","updated":"2021-11-11 16:31:15.000000000","message":"Yep - I tried it on a real backend and it does cause an issue.\nUpdated the default string","commit_id":"6ab3dc066bc5413531c19e654200d632d0323d98"}],"environments/cinder-pure-config.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"110ab3084844ff2f289c1a8644833fdd6b5b7167","unresolved":true,"context_lines":[{"line_number":17,"context_line":"  CinderPureImageCache: true"},{"line_number":18,"context_line":"  CinderPureHostPersonality: \u0027\u0027"},{"line_number":19,"context_line":"  CinderPureEradicateOnDelete: false"},{"line_number":20,"context_line":"  CinderPureIscsiCidr: \u0027\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# To configure multiple Pure backends, use CinderPureMultiConfig to"},{"line_number":23,"context_line":"# assign parameter values specific to that backend. For example:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"90233471_937ef08e","line":20,"updated":"2021-11-15 13:48:57.000000000","message":"Whoops, I missed the fact that this should be \u00270.0.0.0/0\u0027. An empty string actually causes problems.","commit_id":"70720d21d7b7bb011dac79b1144d1380263bf592"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"4bf679770ea02ad124a478f974f977812a00c9a2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  CinderPureImageCache: true"},{"line_number":18,"context_line":"  CinderPureHostPersonality: \u0027\u0027"},{"line_number":19,"context_line":"  CinderPureEradicateOnDelete: false"},{"line_number":20,"context_line":"  CinderPureIscsiCidr: \u0027\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# To configure multiple Pure backends, use CinderPureMultiConfig to"},{"line_number":23,"context_line":"# assign parameter values specific to that backend. For example:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"cd499868_5104e931","line":20,"in_reply_to":"90233471_937ef08e","updated":"2021-11-16 15:28:18.000000000","message":"Small patch created to resolve this:  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/817956","commit_id":"70720d21d7b7bb011dac79b1144d1380263bf592"}]}