)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f9ed79e1e316d27d16e629eefc0a34d9dc04b3fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fae5ce68_9c3a44de","updated":"2021-11-15 13:51:57.000000000","message":"I propose the code on master be fixed (just a small patch to set CinderPureIscsiCidr to \u00270.0.0.0/0\u0027 in the environments/cinder-pure-config.yaml file). Then fold that change into this backport.","commit_id":"0f6e2a4ee4941ebcc58b0c97edd2be698465855f"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ab47b3e58d6e6a9fa00228e9698ce4c10a6c6f2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cf960f75_7524b44b","updated":"2021-11-15 10:14:41.000000000","message":"Though this is a backport it seems there are some inconsistencies in the defaults. Not sure if those were intentional.","commit_id":"0f6e2a4ee4941ebcc58b0c97edd2be698465855f"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"6690ee05189d5a8191672596c1c946c6b9c5c3a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8aee1633_ac38a036","updated":"2021-11-12 21:47:34.000000000","message":"recheck","commit_id":"0f6e2a4ee4941ebcc58b0c97edd2be698465855f"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"ad4b434e044d5da090a924682f320982cb3e3bf0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b7408a04_57fcb052","in_reply_to":"fae5ce68_9c3a44de","updated":"2021-11-16 11:39:29.000000000","message":"small patch created:  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/817956","commit_id":"0f6e2a4ee4941ebcc58b0c97edd2be698465855f"}],"environments/cinder-pure-config.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ab47b3e58d6e6a9fa00228e9698ce4c10a6c6f2b","unresolved":true,"context_lines":[{"line_number":15,"context_line":"  CinderPureUseChap: false"},{"line_number":16,"context_line":"  CinderPureMultipathXfer: true"},{"line_number":17,"context_line":"  CinderPureImageCache: true"},{"line_number":18,"context_line":"  CinderPureHostPersonality: \u0027\u0027"},{"line_number":19,"context_line":"  CinderPureEradicateOnDelete: false"},{"line_number":20,"context_line":"  CinderPureIscsiCidr: \u0027\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# To configure multiple Pure backends, use CinderPureMultiConfig to"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fb9a1269_8b173fba","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":36},"updated":"2021-11-15 10:14:41.000000000","message":"Why do we need these here when the template parameters have the same default values?","commit_id":"0f6e2a4ee4941ebcc58b0c97edd2be698465855f"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"418ac1876f8e2ea412bbcd5859be041b909d7a7b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  CinderPureUseChap: false"},{"line_number":16,"context_line":"  CinderPureMultipathXfer: true"},{"line_number":17,"context_line":"  CinderPureImageCache: true"},{"line_number":18,"context_line":"  CinderPureHostPersonality: \u0027\u0027"},{"line_number":19,"context_line":"  CinderPureEradicateOnDelete: false"},{"line_number":20,"context_line":"  CinderPureIscsiCidr: \u0027\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# To configure multiple Pure backends, use CinderPureMultiConfig to"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fb31c71_4c16a0f9","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":36},"in_reply_to":"84d23dcd_058c0ce5","updated":"2021-11-19 03:02:06.000000000","message":"Ack","commit_id":"0f6e2a4ee4941ebcc58b0c97edd2be698465855f"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"e914e379946d458aa466ec5d0141a34f6adecf81","unresolved":true,"context_lines":[{"line_number":15,"context_line":"  CinderPureUseChap: false"},{"line_number":16,"context_line":"  CinderPureMultipathXfer: true"},{"line_number":17,"context_line":"  CinderPureImageCache: true"},{"line_number":18,"context_line":"  CinderPureHostPersonality: \u0027\u0027"},{"line_number":19,"context_line":"  CinderPureEradicateOnDelete: false"},{"line_number":20,"context_line":"  CinderPureIscsiCidr: \u0027\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# To configure multiple Pure backends, use CinderPureMultiConfig to"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"84d23dcd_058c0ce5","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":36},"in_reply_to":"fb9a1269_8b173fba","updated":"2021-11-15 13:47:03.000000000","message":"Technically, we don\u0027t need them. But all of the env files for storage backends have done this (at least as far back as my memory goes). I think they help by providing a summary of the parameters supported by each backend.","commit_id":"0f6e2a4ee4941ebcc58b0c97edd2be698465855f"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ab47b3e58d6e6a9fa00228e9698ce4c10a6c6f2b","unresolved":true,"context_lines":[{"line_number":17,"context_line":"  CinderPureImageCache: true"},{"line_number":18,"context_line":"  CinderPureHostPersonality: \u0027\u0027"},{"line_number":19,"context_line":"  CinderPureEradicateOnDelete: false"},{"line_number":20,"context_line":"  CinderPureIscsiCidr: \u0027\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# To configure multiple Pure backends, use CinderPureMultiConfig to"},{"line_number":23,"context_line":"# assign parameter values specific to that backend. For example:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"88625f60_d6791b39","line":20,"range":{"start_line":20,"start_character":2,"end_line":20,"end_character":25},"updated":"2021-11-15 10:14:41.000000000","message":"This one seems to have a different default value i.e \u00270.0.0.0/0\u0027","commit_id":"0f6e2a4ee4941ebcc58b0c97edd2be698465855f"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"418ac1876f8e2ea412bbcd5859be041b909d7a7b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  CinderPureImageCache: true"},{"line_number":18,"context_line":"  CinderPureHostPersonality: \u0027\u0027"},{"line_number":19,"context_line":"  CinderPureEradicateOnDelete: false"},{"line_number":20,"context_line":"  CinderPureIscsiCidr: \u0027\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# To configure multiple Pure backends, use CinderPureMultiConfig to"},{"line_number":23,"context_line":"# assign parameter values specific to that backend. For example:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"66fb5204_74d317df","line":20,"range":{"start_line":20,"start_character":2,"end_line":20,"end_character":25},"in_reply_to":"44255d42_ff492a92","updated":"2021-11-19 03:02:06.000000000","message":"Ack","commit_id":"0f6e2a4ee4941ebcc58b0c97edd2be698465855f"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"e914e379946d458aa466ec5d0141a34f6adecf81","unresolved":true,"context_lines":[{"line_number":17,"context_line":"  CinderPureImageCache: true"},{"line_number":18,"context_line":"  CinderPureHostPersonality: \u0027\u0027"},{"line_number":19,"context_line":"  CinderPureEradicateOnDelete: false"},{"line_number":20,"context_line":"  CinderPureIscsiCidr: \u0027\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# To configure multiple Pure backends, use CinderPureMultiConfig to"},{"line_number":23,"context_line":"# assign parameter values specific to that backend. For example:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"44255d42_ff492a92","line":20,"range":{"start_line":20,"start_character":2,"end_line":20,"end_character":25},"in_reply_to":"88625f60_d6791b39","updated":"2021-11-15 13:47:03.000000000","message":"Ooh, good catch! This value was updated in the last patch set (on master), and I missed the fact that the value in the env file wasn\u0027t updated. It will need to be fixed on master, too.","commit_id":"0f6e2a4ee4941ebcc58b0c97edd2be698465855f"}]}