)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"6c89842edaa1a37ef3bd5871560830ecbe7f9f61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"56ea6319_751d6c96","updated":"2021-12-03 11:43:36.000000000","message":"Needs variable change and resolve the var-lib-myql state file issue.","commit_id":"a2406f3eb4bc3687246a325f252cc31f5cd630d1"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"44864ca44b57f117463bee850686b1e69723d4eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d1bda139_63dfcc19","updated":"2022-01-11 06:38:21.000000000","message":"I guess the code is ok in terms of flow, maybe we\u0027d like to optimize a little bit the code to avoid duplication as per Jose\u0027s comment","commit_id":"61026bc46b7822d270d223c9442ccaa2526d6763"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"c86eab1d18d647644d83f661dd4d2d896ed1e8f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"aff78b9d_e178e414","updated":"2022-01-12 13:54:29.000000000","message":"I missed that the new tasks have also the run_once option, so the difference is not only in the with_items values. Therefore we require the duplication. \nApproving the patch.","commit_id":"61026bc46b7822d270d223c9442ccaa2526d6763"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"a3f78a069ca7509b1d0174a8de4778712817cb82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4127ce26_91929e9a","updated":"2022-01-14 20:18:42.000000000","message":"recheck","commit_id":"61026bc46b7822d270d223c9442ccaa2526d6763"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"95946d21fa2137a22bcae8c53f90532bad01c3dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5c4b1557_14ea3113","updated":"2022-01-14 11:37:19.000000000","message":"recheck","commit_id":"61026bc46b7822d270d223c9442ccaa2526d6763"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"89209d5052e024b515f6f6be7cbd84b509c25d4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"799e8d86_28f1575d","updated":"2022-01-13 10:18:18.000000000","message":"recheck","commit_id":"61026bc46b7822d270d223c9442ccaa2526d6763"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"b5550bb8ff0f21d1a01a26b6b3955d274cabe4ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8498b859_24c9ca8e","updated":"2022-01-14 05:40:36.000000000","message":"recheck","commit_id":"61026bc46b7822d270d223c9442ccaa2526d6763"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"a29652539c6b1b765316c414ac5995419b1dcd5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8ce72f76_ba80f4a0","updated":"2022-01-12 18:29:20.000000000","message":"recheck","commit_id":"61026bc46b7822d270d223c9442ccaa2526d6763"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"55e4a5b9bc4dc11d277357accc7c9a820b23a77c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5d99f4d6_3ce4176f","updated":"2022-01-14 10:05:00.000000000","message":"tripleo-ci-centos-7-containers-multinode failure - Exception raised: No module named pathlib2\nBug: https://bugs.launchpad.net/tripleo/+bug/1957805\nhttps://review.rdoproject.org/r/c/openstack/validations-libs-distgit/+/38100 - proposed fix\ntrain is in promotion now","commit_id":"61026bc46b7822d270d223c9442ccaa2526d6763"}],"deployment/ceph-ansible/ceph-osd.yaml":[{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"c0e0091cbadb3b92ff2810cf9c8551e636c2a1ed","unresolved":true,"context_lines":[{"line_number":166,"context_line":"              - not furious_upgrade|bool"},{"line_number":167,"context_line":"            become: true"},{"line_number":168,"context_line":"            delegate_to: \"{{ ceph_mon_short_bootstrap_node_name }}\""},{"line_number":169,"context_line":"        - - name: Unset noout flag"},{"line_number":170,"context_line":"            shell: \"{{ container_cli }} exec -u root ceph-mon-${HOSTNAME%%.*} ceph osd unset {{ item }}\""},{"line_number":171,"context_line":"            with_items:"},{"line_number":172,"context_line":"              - noout"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"411dddc9_ff3082b7","line":169,"updated":"2022-01-11 06:36:25.000000000","message":"Explaining a little bit more what\u0027s the difference with the task above would help for future understanding.","commit_id":"1a970183f2c447afc0789be09096c5d06576ec63"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7ee3ff8c5bee7dd464fbe1964935afcf506cd858","unresolved":true,"context_lines":[{"line_number":42,"context_line":"    type: boolean"},{"line_number":43,"context_line":"    default: false"},{"line_number":44,"context_line":"    description: Parameter used to trigger the dashboard deployment."},{"line_number":45,"context_line":"  FuriousUpgrade:"},{"line_number":46,"context_line":"    type: boolean"},{"line_number":47,"context_line":"    default: false"},{"line_number":48,"context_line":"    description: Parameter used for pausing all ceph osds during a"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"58bb3fe1_b8934112","line":45,"range":{"start_line":45,"start_character":2,"end_line":45,"end_character":9},"updated":"2021-12-03 14:12:15.000000000","message":"Can we use \u0027OfflineUpgrade\u0027 instead?","commit_id":"a2406f3eb4bc3687246a325f252cc31f5cd630d1"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7ee3ff8c5bee7dd464fbe1964935afcf506cd858","unresolved":true,"context_lines":[{"line_number":45,"context_line":"  FuriousUpgrade:"},{"line_number":46,"context_line":"    type: boolean"},{"line_number":47,"context_line":"    default: false"},{"line_number":48,"context_line":"    description: Parameter used for pausing all ceph osds during a"},{"line_number":49,"context_line":"                 special case of upgrade called Furious. This causes"},{"line_number":50,"context_line":"                 outage!"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"conditions:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5ab68c1a_e9ca4ed3","line":49,"range":{"start_line":48,"start_character":58,"end_line":49,"end_character":55},"updated":"2021-12-03 14:12:15.000000000","message":"during a special case of upgrade which assumes that we take the whole environment offline","commit_id":"a2406f3eb4bc3687246a325f252cc31f5cd630d1"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"c0e0091cbadb3b92ff2810cf9c8551e636c2a1ed","unresolved":true,"context_lines":[{"line_number":126,"context_line":"                run_once: true"},{"line_number":127,"context_line":"                shell: \"{{ container_client }} exec -u root ceph-mon-${HOSTNAME%%.*} ceph osd set {{ item }}\""},{"line_number":128,"context_line":"                become: true"},{"line_number":129,"context_line":"                with_items:"},{"line_number":130,"context_line":"                  - noout"},{"line_number":131,"context_line":"                  - norecover"},{"line_number":132,"context_line":"                  - nobackfill"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"27f60430_316bdcc4","line":129,"updated":"2022-01-11 06:36:25.000000000","message":"I have been comparing both blocks in the upgrade tasks and post_upgrade_tasks and unless I missed something, it looks like the only different thing between blocks is the with_items section. Why not using this https://www.reddit.com/r/ansible/comments/99ymjf/can_i_use_with_items_with_conditional_of_each_item/ instead of duplicating the whole block twice?\n\nThe idea would be to leave the code as it was initially and modify only the Set noout flag and Unset noout flag:\n\nshell: {{ container_client }} exec -u root ceph-mon-${HOSTNAME%%.*} ceph osd set {{ item.flag }}\"\nwhen: \"item.when\"\nwith_items:\n    - { flag: noout, when: true }\n    - { flag: norecover, when: true }\n    - { flag: nobackfill, when: true }\n    - { flag: norebalance,when: true }\n    - { flag: nodeep-scrub, when: not allinone_upgrade }\n    - { flag: nodown, when: allinone_upgrade }\n    - { flag: pause, when: allinone_upgrade }\n\nI also bet that it would be possible to use jinja2 templating to conditionally create the list of whith_items, something like:\n\nwith_items:\n    - noout\n    - norecover\n    - nobackfill\n    - norebalance\n    {% if all_inone_upgrade %}\n    - nodown\n    - pause\n    {% else %}\n    - nodeep-scrub\n    {% endif %}\n\nThere might be many other approaches...but the idea is to avoid duplicating so many tasks, if possible.","commit_id":"61026bc46b7822d270d223c9442ccaa2526d6763"}]}