)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"4b0e2a02e0fcc43482b0d1dace1de2e8b0528711","unresolved":true,"context_lines":[{"line_number":10,"context_line":"impacting upgrade of existing deployments."},{"line_number":11,"context_line":"Add a pre-check during upgrade and bail out if Redis is not"},{"line_number":12,"context_line":"enabled explicitely during upgrade and if the resource already"},{"line_number":13,"context_line":"exists in pacemaker."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Icd7503c9b9b5edc7ecfe20e6217fb8efeebf3140"},{"line_number":16,"context_line":"Related-Bug: #1872645"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"516103f0_28a7643e","line":13,"updated":"2021-11-16 19:43:58.000000000","message":"We should deprecate and remove it somehow to reduce variability of product components.","commit_id":"9bff7d158a4c714288b26d514a4c1aecd02f1dcc"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"4ab95fe4f8aed74a962a1bd1db166a731be0a54a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"impacting upgrade of existing deployments."},{"line_number":11,"context_line":"Add a pre-check during upgrade and bail out if Redis is not"},{"line_number":12,"context_line":"enabled explicitely during upgrade and if the resource already"},{"line_number":13,"context_line":"exists in pacemaker."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Icd7503c9b9b5edc7ecfe20e6217fb8efeebf3140"},{"line_number":16,"context_line":"Related-Bug: #1872645"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7ae2d34f_46771de0","line":13,"in_reply_to":"516103f0_28a7643e","updated":"2021-11-18 13:18:29.000000000","message":"We can\u0027t deprecate it just yet as it is used by other services not enabled by default. The only ones that comes to mind right now are old telemetry, and designate.","commit_id":"9bff7d158a4c714288b26d514a4c1aecd02f1dcc"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"3be07177d960be11accf7821e7db37a7cae50269","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1d46e48c_579acfa5","updated":"2021-11-17 15:44:34.000000000","message":"WIP seems like the hiera keys are not pushed during the upgrade_prepare. It needs more work","commit_id":"9bff7d158a4c714288b26d514a4c1aecd02f1dcc"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"9d3e8b1e28abddc34cd8d1acafec5ac3267cc1a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"99264404_3d935c3c","updated":"2021-11-25 09:13:46.000000000","message":"patch had a logic inversion. I\u0027m testing it locally post FFU without and without the redis resource. Then I will test it during the FFU.","commit_id":"86901a69b10a04d343995b4a6409c99728db3244"}],"deployment/pacemaker/pacemaker-baremetal-puppet.yaml":[{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"2bfac180cff094799bb028046aa15353f5576e0e","unresolved":true,"context_lines":[{"line_number":227,"context_line":"                    exit 1"},{"line_number":228,"context_line":"                  fi"},{"line_number":229,"context_line":"                fi"},{"line_number":230,"context_line":"                exit 0"},{"line_number":231,"context_line":"        - name: Create hiera data to upgrade pacemaker in a stepwise manner."},{"line_number":232,"context_line":"          when:"},{"line_number":233,"context_line":"            - step|int \u003d\u003d 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0c037bd6_ea859d16","line":230,"updated":"2021-11-16 19:42:53.000000000","message":"We need exit 0 here. In worst case scenario return code of hiera -c /etc/puppet/hiera.yaml enabled_services | jq -r \u0027.[]\u0027 | grep -wq redis \nwhich will be grep no match return code which is -1","commit_id":"d0281c1957dcc0fa01a1a183c6e32f4ac473f175"}]}