)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"644faf3b418aa35e5fd2a56edeb48453dae24bcd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e4980d1b_8c9d4d24","updated":"2021-11-19 20:43:48.000000000","message":"Marking this as WIP until we verify the policies introduces here are consistent with the policies in the service on stable/wallaby.\n\nOnce that\u0027s acknowledge, or +1\u0027d, from the service I\u0027ll remove the WIP.","commit_id":"0ec2f51952e6e0c0a2a9048cc9b3ff6ec55997bd"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"de7237f0b27386ad41e6383d52ce8acaa78fb04e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b7fbb2bb_53d5586d","updated":"2021-12-07 15:49:26.000000000","message":"Thanks Goutham. Sounds like we can wait for https://review.opendev.org/c/openstack/tripleo-heat-templates/+/818840 to land and include it here.","commit_id":"0ec2f51952e6e0c0a2a9048cc9b3ff6ec55997bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fd2b864c6f08af67c36792b9e0e19f5a8fe3a963","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"28c785ee_2675e2d6","updated":"2021-11-23 00:19:47.000000000","message":"Thanks for posting this Lance; commented about one ineffective policy override inline, please take a look!","commit_id":"0ec2f51952e6e0c0a2a9048cc9b3ff6ec55997bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c5003caaecf278ec3d5ec6420baa33c056a31ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0e8e3c86_78afbcf3","in_reply_to":"b7fbb2bb_53d5586d","updated":"2021-12-07 18:24:20.000000000","message":"Yep - i did propose a backport as well: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/820885 \n\nI\u0027ll update this patch resolving the other comment i had.. :)","commit_id":"0ec2f51952e6e0c0a2a9048cc9b3ff6ec55997bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"69c9db5e18bea0d6b17d130380cdf485fda25835","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ad9430c3_861cf957","updated":"2021-12-15 18:23:19.000000000","message":"Self +1, but also indicating i\u0027ve reviewed this for the manila team","commit_id":"ed9a79329938ec4c755bad274f228148ca4d81c2"}],"environments/enable-secure-rbac.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fd2b864c6f08af67c36792b9e0e19f5a8fe3a963","unresolved":true,"context_lines":[{"line_number":3302,"context_line":"      value: \"role:reader and project_id:%(project_id)s\""},{"line_number":3303,"context_line":"    manila-context_is_admin:"},{"line_number":3304,"context_line":"      key: \"context_is_admin\""},{"line_number":3305,"context_line":"      value: \"rule:system-admin\""},{"line_number":3306,"context_line":"    manila-admin_or_owner:"},{"line_number":3307,"context_line":"      key: \"admin_or_owner\""},{"line_number":3308,"context_line":"      value: \"is_admin:True or project_id:%(project_id)s\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1659c565_7204a8b8","line":3305,"range":{"start_line":3305,"start_character":0,"end_line":3305,"end_character":32},"updated":"2021-11-23 00:19:47.000000000","message":"I missed this in the original patch on master - for allowing project scoped roles, this needs to revert to \"role:admin\" as well, since manila performs quite a few checks internally with \"context.is_admin\";\n\nIm fixing this here:  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/818840","commit_id":"0ec2f51952e6e0c0a2a9048cc9b3ff6ec55997bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7ff21295953ed5155047368a0e57e7e8b962f82b","unresolved":true,"context_lines":[{"line_number":3302,"context_line":"      value: \"role:reader and project_id:%(project_id)s\""},{"line_number":3303,"context_line":"    manila-context_is_admin:"},{"line_number":3304,"context_line":"      key: \"context_is_admin\""},{"line_number":3305,"context_line":"      value: \"rule:system-admin\""},{"line_number":3306,"context_line":"    manila-admin_or_owner:"},{"line_number":3307,"context_line":"      key: \"admin_or_owner\""},{"line_number":3308,"context_line":"      value: \"is_admin:True or project_id:%(project_id)s\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dd3dcc45_6e6b9f39","line":3305,"range":{"start_line":3305,"start_character":0,"end_line":3305,"end_character":32},"in_reply_to":"1659c565_7204a8b8","updated":"2021-12-07 18:32:32.000000000","message":"Cherry-pick to stable/wallaby is here: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/820885","commit_id":"0ec2f51952e6e0c0a2a9048cc9b3ff6ec55997bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fd2b864c6f08af67c36792b9e0e19f5a8fe3a963","unresolved":true,"context_lines":[{"line_number":3366,"context_line":"    manila-share_extend:"},{"line_number":3367,"context_line":"      key: \"share:extend\""},{"line_number":3368,"context_line":"      value: \"(rule:admin_api) or (rule:project-member)\""},{"line_number":3369,"context_line":"    manila-share_force_extend:"},{"line_number":3370,"context_line":"      key: \"share:force_extend\""},{"line_number":3371,"context_line":"      value: \"(rule:admin_api) or (rule:project-admin)\""},{"line_number":3372,"context_line":"    manila-share_shrink:"},{"line_number":3373,"context_line":"      key: \"share:shrink\""},{"line_number":3374,"context_line":"      value: \"(rule:admin_api) or (rule:project-member)\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8c19fdfd_0106c9d7","line":3371,"range":{"start_line":3369,"start_character":4,"end_line":3371,"end_character":55},"updated":"2021-11-23 00:19:47.000000000","message":"This policy didn\u0027t exist in stable/wallaby - only relevant for Xena+\nWe can drop this.\n\n[1] https://docs.openstack.org/manila/latest/contributor/api_microversion_history.html#id53","commit_id":"0ec2f51952e6e0c0a2a9048cc9b3ff6ec55997bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7ff21295953ed5155047368a0e57e7e8b962f82b","unresolved":false,"context_lines":[{"line_number":3366,"context_line":"    manila-share_extend:"},{"line_number":3367,"context_line":"      key: \"share:extend\""},{"line_number":3368,"context_line":"      value: \"(rule:admin_api) or (rule:project-member)\""},{"line_number":3369,"context_line":"    manila-share_force_extend:"},{"line_number":3370,"context_line":"      key: \"share:force_extend\""},{"line_number":3371,"context_line":"      value: \"(rule:admin_api) or (rule:project-admin)\""},{"line_number":3372,"context_line":"    manila-share_shrink:"},{"line_number":3373,"context_line":"      key: \"share:shrink\""},{"line_number":3374,"context_line":"      value: \"(rule:admin_api) or (rule:project-member)\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c6f2d472_12c92323","line":3371,"range":{"start_line":3369,"start_character":4,"end_line":3371,"end_character":55},"in_reply_to":"8c19fdfd_0106c9d7","updated":"2021-12-07 18:32:32.000000000","message":"Done","commit_id":"0ec2f51952e6e0c0a2a9048cc9b3ff6ec55997bd"}]}