)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"b55cd8916bc55a5420eb43b922d6dc5eaea50e0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"499271a9_957811a8","updated":"2021-12-02 10:43:41.000000000","message":"+1 on adding a releasenote","commit_id":"7363026d1b77cbe38cab4b5cd56c4d7444853d99"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"59428cdeb9d1525e59c7a51db649d5695051a91f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d1df1423_e76739f1","updated":"2022-05-23 14:58:54.000000000","message":"A dedicated set of reviews are available in https://review.opendev.org/q/topic:mariabackup to tackle mariabackup support.","commit_id":"7363026d1b77cbe38cab4b5cd56c4d7444853d99"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"a42da2cc9098901902d3ad6dd75f2492f16818bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c7afab8a_5e9e7ccf","updated":"2021-12-02 05:39:42.000000000","message":"Good to have a release notes for the new parameter.","commit_id":"7363026d1b77cbe38cab4b5cd56c4d7444853d99"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"84f9b96fe24b45d6fa3ad20e491bcb12f33d5fe3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"798a5137_1364d86b","updated":"2023-06-05 14:57:39.000000000","message":"Should we abandon this one then ?","commit_id":"7363026d1b77cbe38cab4b5cd56c4d7444853d99"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"b6c81ad4fa58233e976b5c7e1bb153b175d37540","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b61b7c93_7c9dcec5","updated":"2022-01-26 22:32:47.000000000","message":"The depends-on patch needs to be merged.\nCurrently the patch is WIP (-1)","commit_id":"7363026d1b77cbe38cab4b5cd56c4d7444853d99"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"6f0af7b873f2a7b6c93f0f0affdc844edaf56e54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"28eb86b1_80fcc68e","updated":"2021-11-23 15:13:28.000000000","message":"is anyone considering what changes to the galera resource agent might be needed to accommodate for \"mariabackup\" correctly?   IIUC the RA is pretty strongly optimized around the rsync use case and its particular quirks.  an xtrabackup-style change like this is certainly good from an arch perspective but not sure if the RA would need adjustments also.","commit_id":"7363026d1b77cbe38cab4b5cd56c4d7444853d99"}],"deployment/database/mysql-pacemaker-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bd7b23866b84d2e0f0e7705948b85230078a226a","unresolved":true,"context_lines":[{"line_number":164,"context_line":"          - if:"},{"line_number":165,"context_line":"            - {get_param: MysqlWsrepSstMethod}"},{"line_number":166,"context_line":"            - tripleo::profile::pacemaker::database::mysql_bundle::wsrep_sst_method: {get_param: MysqlWsrepSstMethod}"},{"line_number":167,"context_line":"            - null"},{"line_number":168,"context_line":"          - tripleo::profile::pacemaker::database::mysql_bundle::bind_address:"},{"line_number":169,"context_line":"              str_replace:"},{"line_number":170,"context_line":"                template:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ca7f2fa2_0141d84e","line":167,"range":{"start_line":167,"start_character":12,"end_line":167,"end_character":18},"updated":"2021-11-23 11:37:12.000000000","message":"iirc, this is no longer needed with newer Heat","commit_id":"789f17538d8c4c5806cb899a82d6b246140f3858"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"9a27c2631810b8a8aa2a9e32d4d428eb9a0c8e24","unresolved":false,"context_lines":[{"line_number":164,"context_line":"          - if:"},{"line_number":165,"context_line":"            - {get_param: MysqlWsrepSstMethod}"},{"line_number":166,"context_line":"            - tripleo::profile::pacemaker::database::mysql_bundle::wsrep_sst_method: {get_param: MysqlWsrepSstMethod}"},{"line_number":167,"context_line":"            - null"},{"line_number":168,"context_line":"          - tripleo::profile::pacemaker::database::mysql_bundle::bind_address:"},{"line_number":169,"context_line":"              str_replace:"},{"line_number":170,"context_line":"                template:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e99139ef_c4c13bf1","line":167,"range":{"start_line":167,"start_character":12,"end_line":167,"end_character":18},"in_reply_to":"14262b98_96ce38f3","updated":"2021-11-23 12:41:59.000000000","message":"that line can be removed","commit_id":"789f17538d8c4c5806cb899a82d6b246140f3858"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"2cb34f2cbbe135fc0a1c3342fd0fa4abea6282f1","unresolved":false,"context_lines":[{"line_number":164,"context_line":"          - if:"},{"line_number":165,"context_line":"            - {get_param: MysqlWsrepSstMethod}"},{"line_number":166,"context_line":"            - tripleo::profile::pacemaker::database::mysql_bundle::wsrep_sst_method: {get_param: MysqlWsrepSstMethod}"},{"line_number":167,"context_line":"            - null"},{"line_number":168,"context_line":"          - tripleo::profile::pacemaker::database::mysql_bundle::bind_address:"},{"line_number":169,"context_line":"              str_replace:"},{"line_number":170,"context_line":"                template:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"14262b98_96ce38f3","line":167,"range":{"start_line":167,"start_character":12,"end_line":167,"end_character":18},"in_reply_to":"ca7f2fa2_0141d84e","updated":"2021-11-23 12:37:50.000000000","message":"what do I put ?  empty line ?","commit_id":"789f17538d8c4c5806cb899a82d6b246140f3858"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"5814210a64d2757d5ff3ee561984948210821672","unresolved":true,"context_lines":[{"line_number":162,"context_line":"                    expression: concat($.data.rightSplit(separator \u003d\u003e \":\", maxSplits \u003d\u003e 1)[0], \":pcmklatest\")"},{"line_number":163,"context_line":"            tripleo::profile::pacemaker::database::mysql_bundle::control_port: 3123"},{"line_number":164,"context_line":"            tripleo::profile::pacemaker::database::mysql_bundle::container_backend: {get_param: ContainerCli}"},{"line_number":165,"context_line":"          - if:"},{"line_number":166,"context_line":"            - mysql_wsrep_sst_method_set"},{"line_number":167,"context_line":"            - tripleo::profile::pacemaker::database::mysql_bundle::wsrep_sst_method: {get_param: MysqlWsrepSstMethod}"},{"line_number":168,"context_line":"          - tripleo::profile::pacemaker::database::mysql_bundle::bind_address:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"58f3c563_dfd5feae","line":165,"range":{"start_line":165,"start_character":9,"end_line":165,"end_character":15},"updated":"2021-11-23 13:06:14.000000000","message":"You can use an \u0027if\u0027 without \u0027else\u0027 and the key/enclosing item  would be ignored.\n\nThough this will work, you can still optimize as below without an additional merge.\n\ntripleo::profile::pacemaker::database::mysql_bundle::wsrep_sst_method:\n  if:\n    - not: {equals: [{get_param: MysqlWsrepSstMethod}, \u0027\u0027]}\n    - {get_param: MysqlWsrepSstMethod}","commit_id":"dbe09da115f53b44dc2240a9dd5fb2afd7d091ab"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"b0f6ca9753830023924333241f091901ca887427","unresolved":true,"context_lines":[{"line_number":162,"context_line":"                    expression: concat($.data.rightSplit(separator \u003d\u003e \":\", maxSplits \u003d\u003e 1)[0], \":pcmklatest\")"},{"line_number":163,"context_line":"            tripleo::profile::pacemaker::database::mysql_bundle::control_port: 3123"},{"line_number":164,"context_line":"            tripleo::profile::pacemaker::database::mysql_bundle::container_backend: {get_param: ContainerCli}"},{"line_number":165,"context_line":"          - if:"},{"line_number":166,"context_line":"            - mysql_wsrep_sst_method_set"},{"line_number":167,"context_line":"            - tripleo::profile::pacemaker::database::mysql_bundle::wsrep_sst_method: {get_param: MysqlWsrepSstMethod}"},{"line_number":168,"context_line":"          - tripleo::profile::pacemaker::database::mysql_bundle::bind_address:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d19f9d90_f0f1912e","line":165,"range":{"start_line":165,"start_character":9,"end_line":165,"end_character":15},"in_reply_to":"58f3c563_dfd5feae","updated":"2021-11-23 13:16:07.000000000","message":"This is counter intuitive ... so if that value is not set, the whole tripleo::profile::pacemaker::database::mysql_bundle::wsrep_sst_method won\u0027t be set at all ?","commit_id":"dbe09da115f53b44dc2240a9dd5fb2afd7d091ab"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"fb86d72f504c8d46314d20f2f1d9b5cb87ecb4a6","unresolved":true,"context_lines":[{"line_number":162,"context_line":"                    expression: concat($.data.rightSplit(separator \u003d\u003e \":\", maxSplits \u003d\u003e 1)[0], \":pcmklatest\")"},{"line_number":163,"context_line":"            tripleo::profile::pacemaker::database::mysql_bundle::control_port: 3123"},{"line_number":164,"context_line":"            tripleo::profile::pacemaker::database::mysql_bundle::container_backend: {get_param: ContainerCli}"},{"line_number":165,"context_line":"          - if:"},{"line_number":166,"context_line":"            - mysql_wsrep_sst_method_set"},{"line_number":167,"context_line":"            - tripleo::profile::pacemaker::database::mysql_bundle::wsrep_sst_method: {get_param: MysqlWsrepSstMethod}"},{"line_number":168,"context_line":"          - tripleo::profile::pacemaker::database::mysql_bundle::bind_address:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8b5df06a_0ac9f50c","line":165,"range":{"start_line":165,"start_character":9,"end_line":165,"end_character":15},"in_reply_to":"9450b8b5_98746eb6","updated":"2021-11-23 13:32:03.000000000","message":"And I meant that this is counter intuitive:\n~~~\ntripleo::profile::pacemaker::database::mysql_bundle::wsrep_sst_method:\n  if:\n    - not: {equals: [{get_param: MysqlWsrepSstMethod}, \u0027\u0027]}\n    - {get_param: MysqlWsrepSstMethod}\n~~~\n\nWhat will be the value of tripleo::profile::pacemaker::database::mysql_bundle::wsrep_sst_method if MysqlWsrepSstMethod is empty ?  Will it be \"undef\" or will the line me missing ?","commit_id":"dbe09da115f53b44dc2240a9dd5fb2afd7d091ab"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ccbb3fc00e8d112adb0c64325796b957935f7357","unresolved":true,"context_lines":[{"line_number":162,"context_line":"                    expression: concat($.data.rightSplit(separator \u003d\u003e \":\", maxSplits \u003d\u003e 1)[0], \":pcmklatest\")"},{"line_number":163,"context_line":"            tripleo::profile::pacemaker::database::mysql_bundle::control_port: 3123"},{"line_number":164,"context_line":"            tripleo::profile::pacemaker::database::mysql_bundle::container_backend: {get_param: ContainerCli}"},{"line_number":165,"context_line":"          - if:"},{"line_number":166,"context_line":"            - mysql_wsrep_sst_method_set"},{"line_number":167,"context_line":"            - tripleo::profile::pacemaker::database::mysql_bundle::wsrep_sst_method: {get_param: MysqlWsrepSstMethod}"},{"line_number":168,"context_line":"          - tripleo::profile::pacemaker::database::mysql_bundle::bind_address:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9450b8b5_98746eb6","line":165,"range":{"start_line":165,"start_character":9,"end_line":165,"end_character":15},"in_reply_to":"d19f9d90_f0f1912e","updated":"2021-11-23 13:24:27.000000000","message":"Maybe someone who does not know how this function works and is a feature added to ignore[1] some resource properties and keys based on a condition and not always provide a default for else[1]\n\n[1] https://github.com/openstack/heat/blob/master/heat/engine/hot/functions.py#L1322-L1324","commit_id":"dbe09da115f53b44dc2240a9dd5fb2afd7d091ab"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ccbb3fc00e8d112adb0c64325796b957935f7357","unresolved":true,"context_lines":[{"line_number":162,"context_line":"            tripleo::profile::pacemaker::database::mysql_bundle::control_port: 3123"},{"line_number":163,"context_line":"            tripleo::profile::pacemaker::database::mysql_bundle::container_backend: {get_param: ContainerCli}"},{"line_number":164,"context_line":"            tripleo::profile::pacemaker::database::mysql_bundle::wsrep_sst_method:"},{"line_number":165,"context_line":"              if:"},{"line_number":166,"context_line":"                - {not: {equals: [{get_param: MysqlWsrepSstMethod}, \u0027\u0027]}}"},{"line_number":167,"context_line":"                - {get_param: MysqlWsrepSstMethod}"},{"line_number":168,"context_line":"          - tripleo::profile::pacemaker::database::mysql_bundle::bind_address:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fef592a0_ea5fadd6","line":165,"range":{"start_line":165,"start_character":14,"end_line":165,"end_character":17},"updated":"2021-11-23 13:24:27.000000000","message":"Does not look indented correctly.","commit_id":"ccee08655fa302a70764cc1d82b65426a814ae79"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"683e74916b3205a4cf9f90ec9d23c3b6da328bf9","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            tripleo::profile::pacemaker::database::mysql_bundle::control_port: 3123"},{"line_number":163,"context_line":"            tripleo::profile::pacemaker::database::mysql_bundle::container_backend: {get_param: ContainerCli}"},{"line_number":164,"context_line":"            tripleo::profile::pacemaker::database::mysql_bundle::wsrep_sst_method:"},{"line_number":165,"context_line":"              if:"},{"line_number":166,"context_line":"                - {not: {equals: [{get_param: MysqlWsrepSstMethod}, \u0027\u0027]}}"},{"line_number":167,"context_line":"                - {get_param: MysqlWsrepSstMethod}"},{"line_number":168,"context_line":"          - tripleo::profile::pacemaker::database::mysql_bundle::bind_address:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ab179086_4cdbf6c2","line":165,"range":{"start_line":165,"start_character":14,"end_line":165,"end_character":17},"in_reply_to":"fef592a0_ea5fadd6","updated":"2021-11-23 13:28:23.000000000","message":"It\u0027s the same as the other lines.","commit_id":"ccee08655fa302a70764cc1d82b65426a814ae79"}]}