)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"52080af410c6aa78145cab5bb0b2c95cf87cd090","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ec4720b8_d8c2707a","updated":"2021-11-24 15:54:48.000000000","message":"this is great to have! some space nits and two comments","commit_id":"d2191a5214bd26f5e0804c28c5571262de3c3c99"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"25c55a01ad0f16b8786fa83ae4dfa9cb5f265e74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1517fe58_fe542a43","updated":"2022-01-14 17:01:41.000000000","message":"This looks alright, I think we can merge as is and fix any issues (if any) later.","commit_id":"925af6378e8740792fa0bc3fb0f241cf2fed863f"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"c6e798aacddb858c8182f1aacf2478e42a985d5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2a400f92_831c27c4","updated":"2022-01-20 05:59:01.000000000","message":"recheck","commit_id":"925af6378e8740792fa0bc3fb0f241cf2fed863f"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"edc3d7a3aa66561e8883c231e7d393cfc7e4c77c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a424bae9_7074d54e","updated":"2022-01-18 06:08:02.000000000","message":"recheck","commit_id":"925af6378e8740792fa0bc3fb0f241cf2fed863f"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"53eb1a6475ae307e9f67aed41e87ea7b404b754f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a82a61ed_e77a8ee5","updated":"2022-01-17 06:27:16.000000000","message":"recheck\n\nError:\n2022-01-14 17:56:28.147070 | primary |  Problem: cannot install the best candidate for the job\n2022-01-14 17:56:28.147079 | primary |   - nothing provides openssl-libs(x86-64) \u003d 1:3.0.0-6.el9 needed by openssl-devel-1:3.0.0-6.el9.x86_64","commit_id":"925af6378e8740792fa0bc3fb0f241cf2fed863f"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"783db6f9fbd5c9b1dc9a02cd8641c0e35894533c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9e9a9595_8f62e4a2","updated":"2022-01-18 15:24:52.000000000","message":"recheck\n\nc9 content provider seems to be passing again","commit_id":"925af6378e8740792fa0bc3fb0f241cf2fed863f"}],"environments/deployed-network-environment.j2.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"52080af410c6aa78145cab5bb0b2c95cf87cd090","unresolved":true,"context_lines":[{"line_number":26,"context_line":"      {%- set name_lower \u003d network.name_lower|default(network.name.lower()) %} "},{"line_number":27,"context_line":"      {{ name_lower }}:"},{"line_number":28,"context_line":"        network:"},{"line_number":29,"context_line":"          dns_domain: {{ name_lower}}.tripleodomain."},{"line_number":30,"context_line":"          mtu: {{ network.mtu }}"},{"line_number":31,"context_line":"          name: {{ name_lower }}"},{"line_number":32,"context_line":"          tags: "}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d6ae0436_fdcb2e1a","line":29,"range":{"start_line":29,"start_character":25,"end_line":29,"end_character":35},"updated":"2021-11-24 15:54:48.000000000","message":"should dns_domain be network.name.lower() always to match [1]? otherwise we get names like internal_api.tripleodomain. .\n\n[1] https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/ansible_plugins/modules/tripleo_composable_network.py#L148","commit_id":"d2191a5214bd26f5e0804c28c5571262de3c3c99"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"bfbd692d4a0e4bc1b18dc380db6a69f02843a4e1","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      {%- set name_lower \u003d network.name_lower|default(network.name.lower()) %} "},{"line_number":27,"context_line":"      {{ name_lower }}:"},{"line_number":28,"context_line":"        network:"},{"line_number":29,"context_line":"          dns_domain: {{ name_lower}}.tripleodomain."},{"line_number":30,"context_line":"          mtu: {{ network.mtu }}"},{"line_number":31,"context_line":"          name: {{ name_lower }}"},{"line_number":32,"context_line":"          tags: "}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4ba56550_52f02f3c","line":29,"range":{"start_line":29,"start_character":25,"end_line":29,"end_character":35},"in_reply_to":"d6ae0436_fdcb2e1a","updated":"2021-12-01 22:23:33.000000000","message":"i suppose so. thanks!","commit_id":"d2191a5214bd26f5e0804c28c5571262de3c3c99"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"52080af410c6aa78145cab5bb0b2c95cf87cd090","unresolved":true,"context_lines":[{"line_number":43,"context_line":"            ip_version: 4"},{"line_number":44,"context_line":"            name: {{ subnet }}"},{"line_number":45,"context_line":"            tags:"},{"line_number":46,"context_line":"              {%- if subnet.vlan %}"},{"line_number":47,"context_line":"              - tripleo_vlan_id\u003d{{ network.subnets[subnet].vlan }}"},{"line_number":48,"context_line":"              {%- else %}"},{"line_number":49,"context_line":"              []"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8abe11f4_5a8b6f94","line":46,"range":{"start_line":46,"start_character":21,"end_line":46,"end_character":32},"updated":"2021-11-24 15:54:48.000000000","message":"needs to be network.subnets[subnet].vlan","commit_id":"d2191a5214bd26f5e0804c28c5571262de3c3c99"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"bfbd692d4a0e4bc1b18dc380db6a69f02843a4e1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            ip_version: 4"},{"line_number":44,"context_line":"            name: {{ subnet }}"},{"line_number":45,"context_line":"            tags:"},{"line_number":46,"context_line":"              {%- if subnet.vlan %}"},{"line_number":47,"context_line":"              - tripleo_vlan_id\u003d{{ network.subnets[subnet].vlan }}"},{"line_number":48,"context_line":"              {%- else %}"},{"line_number":49,"context_line":"              []"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a8289e2_b661bc5d","line":46,"range":{"start_line":46,"start_character":21,"end_line":46,"end_character":32},"in_reply_to":"8abe11f4_5a8b6f94","updated":"2021-12-01 22:23:33.000000000","message":"Done","commit_id":"d2191a5214bd26f5e0804c28c5571262de3c3c99"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"7c78c6f1e9be2553c731abcfb842dc5e341f5c89","unresolved":true,"context_lines":[{"line_number":23,"context_line":"  DeployedNetworkEnvironment:"},{"line_number":24,"context_line":"    net_attributes_map:"},{"line_number":25,"context_line":"      {%- for network in networks if network.enabled|default(true) %}"},{"line_number":26,"context_line":"      {%- set name_lower \u003d network.name_lower|default(network.name.lower()) %} "},{"line_number":27,"context_line":"      {{ name_lower }}:"},{"line_number":28,"context_line":"        network:"},{"line_number":29,"context_line":"          dns_domain: {{ network.name.lower() }}.tripleodomain."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c70cdfc4_95c295ac","line":26,"range":{"start_line":26,"start_character":6,"end_line":26,"end_character":78},"updated":"2021-12-02 12:29:28.000000000","message":"nit, we set network.name_lower in the process_templates script[1] so at this stage it is always defined. So this is\u0027nt needed.\n\n\n[1] https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/tools/process-templates.py#L189-L190","commit_id":"0994ad54a48a0c33017cfd285a6ec0ff46c3120e"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"7c78c6f1e9be2553c731abcfb842dc5e341f5c89","unresolved":true,"context_lines":[{"line_number":23,"context_line":"  DeployedNetworkEnvironment:"},{"line_number":24,"context_line":"    net_attributes_map:"},{"line_number":25,"context_line":"      {%- for network in networks if network.enabled|default(true) %}"},{"line_number":26,"context_line":"      {%- set name_lower \u003d network.name_lower|default(network.name.lower()) %} "},{"line_number":27,"context_line":"      {{ name_lower }}:"},{"line_number":28,"context_line":"        network:"},{"line_number":29,"context_line":"          dns_domain: {{ network.name.lower() }}.tripleodomain."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fc0376d7_c13432db","line":26,"range":{"start_line":26,"start_character":78,"end_line":26,"end_character":79},"updated":"2021-12-02 12:29:28.000000000","message":"nit: whitespace.","commit_id":"0994ad54a48a0c33017cfd285a6ec0ff46c3120e"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"6f8f376c11356c409d523ec13f7647a3b4e82bac","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  DeployedNetworkEnvironment:"},{"line_number":24,"context_line":"    net_attributes_map:"},{"line_number":25,"context_line":"      {%- for network in networks if network.enabled|default(true) %}"},{"line_number":26,"context_line":"      {%- set name_lower \u003d network.name_lower|default(network.name.lower()) %} "},{"line_number":27,"context_line":"      {{ name_lower }}:"},{"line_number":28,"context_line":"        network:"},{"line_number":29,"context_line":"          dns_domain: {{ network.name.lower() }}.tripleodomain."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e91003cd_63455225","line":26,"range":{"start_line":26,"start_character":6,"end_line":26,"end_character":78},"in_reply_to":"c70cdfc4_95c295ac","updated":"2021-12-15 21:00:19.000000000","message":"Done","commit_id":"0994ad54a48a0c33017cfd285a6ec0ff46c3120e"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"6f8f376c11356c409d523ec13f7647a3b4e82bac","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  DeployedNetworkEnvironment:"},{"line_number":24,"context_line":"    net_attributes_map:"},{"line_number":25,"context_line":"      {%- for network in networks if network.enabled|default(true) %}"},{"line_number":26,"context_line":"      {%- set name_lower \u003d network.name_lower|default(network.name.lower()) %} "},{"line_number":27,"context_line":"      {{ name_lower }}:"},{"line_number":28,"context_line":"        network:"},{"line_number":29,"context_line":"          dns_domain: {{ network.name.lower() }}.tripleodomain."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0fe4d626_26a479c7","line":26,"range":{"start_line":26,"start_character":78,"end_line":26,"end_character":79},"in_reply_to":"fc0376d7_c13432db","updated":"2021-12-15 21:00:19.000000000","message":"Done","commit_id":"0994ad54a48a0c33017cfd285a6ec0ff46c3120e"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"7c78c6f1e9be2553c731abcfb842dc5e341f5c89","unresolved":true,"context_lines":[{"line_number":26,"context_line":"      {%- set name_lower \u003d network.name_lower|default(network.name.lower()) %} "},{"line_number":27,"context_line":"      {{ name_lower }}:"},{"line_number":28,"context_line":"        network:"},{"line_number":29,"context_line":"          dns_domain: {{ network.name.lower() }}.tripleodomain."},{"line_number":30,"context_line":"          mtu: {{ network.mtu }}"},{"line_number":31,"context_line":"          name: {{ name_lower }}"},{"line_number":32,"context_line":"          tags:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d80af81f_4879fd78","line":29,"range":{"start_line":29,"start_character":22,"end_line":29,"end_character":63},"updated":"2021-12-02 12:29:28.000000000","message":"We want to check if \u0027network.dns_domain\u0027 is defined and use that, and then fall back to this to match[1].\n\n.tripleodomain. does not match .localdomain which we use elsewhere[2].\n\nNOTE: \u0027network.dns_domain\u0027 takes the whole thing so, network_a can have networka.adomain.foo. and network_b can have networkb.bdomain.bar.\n\n\n\n[1] https://opendev.org/openstack/tripleo-ansible/src/branch/master/tripleo_ansible/ansible_plugins/module_utils/network_data_v2.py#L256\n[2] https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/overcloud.j2.yaml#L30","commit_id":"0994ad54a48a0c33017cfd285a6ec0ff46c3120e"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"6f8f376c11356c409d523ec13f7647a3b4e82bac","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      {%- set name_lower \u003d network.name_lower|default(network.name.lower()) %} "},{"line_number":27,"context_line":"      {{ name_lower }}:"},{"line_number":28,"context_line":"        network:"},{"line_number":29,"context_line":"          dns_domain: {{ network.name.lower() }}.tripleodomain."},{"line_number":30,"context_line":"          mtu: {{ network.mtu }}"},{"line_number":31,"context_line":"          name: {{ name_lower }}"},{"line_number":32,"context_line":"          tags:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"baaa08ef_732c12e8","line":29,"range":{"start_line":29,"start_character":22,"end_line":29,"end_character":63},"in_reply_to":"d80af81f_4879fd78","updated":"2021-12-15 21:00:19.000000000","message":"Done","commit_id":"0994ad54a48a0c33017cfd285a6ec0ff46c3120e"}]}