)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"696e776e3a6e875c70b3d123ee3023ec39b4e65f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bc6a4911_0ff00fef","updated":"2021-11-30 15:04:25.000000000","message":"WIP. There will be dependencies","commit_id":"65e6cd7b37305c35c8b51cfb8d0f2b206b4fe8df"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"c8d012412594cc20337cd5d2a6e49e687ee07199","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"fda3e1cb_91759741","updated":"2022-02-03 12:20:54.000000000","message":"recheck","commit_id":"53536ffaa3da92f0bae845ab987f77cfb9a351c9"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"00131575b811e56dbffb97f1a224970e7f5da40b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"d6eb698f_af135590","updated":"2022-02-06 22:09:33.000000000","message":"recheck","commit_id":"450cb73df33ee37de128e91d1b54fa8ae0346548"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"7a70b138ff6f0733d5484da7b6c3c2e2a0eb080c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"a7dc35f1_54f70121","updated":"2022-02-08 11:24:57.000000000","message":"recheck","commit_id":"207c1391b3ab7a76271d489ba7a0b830954c1c68"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"f2dc9df03df032918f46fe568528a17607f05244","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"498d27ab_c4d55f8c","updated":"2022-04-20 21:22:49.000000000","message":"if we\u0027re removing the old parameters (instead of deprecating), I\u0027d prefer to not add new ones either, and instead just rely on using --limit. These parameters were always problematic anyways b/c they stay stored in the Heat environment.","commit_id":"d79b23dbedc1a29111da32fb5a97d58463d28ac2"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"5bf74dd9c2215b18b9903cb036373e0a3ffdffdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"eb6406e6_009e244d","updated":"2022-04-19 13:33:15.000000000","message":"recheck","commit_id":"d79b23dbedc1a29111da32fb5a97d58463d28ac2"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"555bf006310badc1b54acad87c3069940e443167","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"519da477_6eb09e6b","in_reply_to":"498d27ab_c4d55f8c","updated":"2022-04-20 21:54:28.000000000","message":"I don\u0027t think we will get away with just removing like I suggested here. We\u0027ll need to deprecate it.\n\nI agree, it does indeed seem redundant to have both methods. How about I change this one to just deprecate the params and we wont bother replacing them.","commit_id":"d79b23dbedc1a29111da32fb5a97d58463d28ac2"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"1a7d71c39492e19ffdef5b0e8a0b954d37319d01","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"8cc1d485_8a6448a6","updated":"2022-07-05 13:34:49.000000000","message":"lgtm but see comment on release note","commit_id":"922415e99df333575310a2f49e7f2728396d1a66"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"aafa459ad062039c3820350643f2c2b2fa9b9f60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"fdac2c3f_0cdbee63","updated":"2022-04-21 05:27:08.000000000","message":"recheck","commit_id":"922415e99df333575310a2f49e7f2728396d1a66"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"88f233c50085f8b5d015e8310babe9302bff8d4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"ecd625f4_9dcf95d6","updated":"2022-07-13 13:29:09.000000000","message":"seems there is a problem in the scenarios with ceph related parameters (e.g. LocalCephAnsibleFetchDirectoryBackup?)","commit_id":"12034e41053c789e3c97740738b5477c2e625866"}],"deployment/cephadm/ceph-base.yaml":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"88f233c50085f8b5d015e8310babe9302bff8d4e","unresolved":true,"context_lines":[{"line_number":370,"context_line":"  description: Do not use deprecated params, they will be removed."},{"line_number":371,"context_line":"  parameters:"},{"line_number":372,"context_line":"    - CephPoolDefaultPgNum"},{"line_number":373,"context_line":"    - CephPoolDefaultSize"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"conditions:"},{"line_number":376,"context_line":"  custom_registry_host:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"1579146f_ebf83e01","side":"PARENT","line":373,"updated":"2022-07-13 13:29:09.000000000","message":"Are these no longer deprecated?","commit_id":"5a741ba973aa2742a7fe7d3c85b6ce1d353965aa"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"25a3f768a2d82875255fc09fbac94ea01d08efaa","unresolved":true,"context_lines":[{"line_number":370,"context_line":"  description: Do not use deprecated params, they will be removed."},{"line_number":371,"context_line":"  parameters:"},{"line_number":372,"context_line":"    - CephPoolDefaultPgNum"},{"line_number":373,"context_line":"    - CephPoolDefaultSize"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"conditions:"},{"line_number":376,"context_line":"  custom_registry_host:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"d905a39a_c76866ae","side":"PARENT","line":373,"in_reply_to":"1579146f_ebf83e01","updated":"2022-07-14 14:44:07.000000000","message":"Not sure why I would have removed them from here. Thanks for picking that up.","commit_id":"5a741ba973aa2742a7fe7d3c85b6ce1d353965aa"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"f43d8c098472a36202db80fe51080d542711fb35","unresolved":false,"context_lines":[{"line_number":370,"context_line":"  description: Do not use deprecated params, they will be removed."},{"line_number":371,"context_line":"  parameters:"},{"line_number":372,"context_line":"    - CephPoolDefaultPgNum"},{"line_number":373,"context_line":"    - CephPoolDefaultSize"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"conditions:"},{"line_number":376,"context_line":"  custom_registry_host:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"5754b693_a4b49fec","side":"PARENT","line":373,"in_reply_to":"d905a39a_c76866ae","updated":"2022-08-02 22:52:38.000000000","message":"Done","commit_id":"5a741ba973aa2742a7fe7d3c85b6ce1d353965aa"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"6b1b80cae0fa5f8a7e2e8af255561730db7f8100","unresolved":true,"context_lines":[{"line_number":371,"context_line":"  parameters:"},{"line_number":372,"context_line":"  - CephPoolDefaultPgNum"},{"line_number":373,"context_line":"  - CephPoolDefaultSize"},{"line_number":374,"context_line":"  - LocalCephAnsibleFetchDirectoryBackup"},{"line_number":375,"context_line":"  - SwiftFetchDirGetTempurl"},{"line_number":376,"context_line":"  - SwiftFetchDirPutTempurl"},{"line_number":377,"context_line":"  - CephIPv6"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"86ddf1cf_9b968836","line":374,"updated":"2022-08-02 18:12:37.000000000","message":"Seems a pile of these were removed on you. See https://review.opendev.org/c/openstack/tripleo-heat-templates/+/844617","commit_id":"64497c57efff6efe2d5e5392f1544d54831fb62b"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"f43d8c098472a36202db80fe51080d542711fb35","unresolved":false,"context_lines":[{"line_number":371,"context_line":"  parameters:"},{"line_number":372,"context_line":"  - CephPoolDefaultPgNum"},{"line_number":373,"context_line":"  - CephPoolDefaultSize"},{"line_number":374,"context_line":"  - LocalCephAnsibleFetchDirectoryBackup"},{"line_number":375,"context_line":"  - SwiftFetchDirGetTempurl"},{"line_number":376,"context_line":"  - SwiftFetchDirPutTempurl"},{"line_number":377,"context_line":"  - CephIPv6"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"644172f1_ebbd3bf6","line":374,"in_reply_to":"86ddf1cf_9b968836","updated":"2022-08-02 22:52:38.000000000","message":"Ack, rebased this change to address that.","commit_id":"64497c57efff6efe2d5e5392f1544d54831fb62b"}],"deployment/neutron/neutron-plugin-ml2.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"044020a865e7946bd544b40f0fc0bb911cf7d97d","unresolved":true,"context_lines":[{"line_number":104,"context_line":"    description: Firewall driver for realizing neutron security group function"},{"line_number":105,"context_line":"    type: string"},{"line_number":106,"context_line":"    default: \u0027\u0027"},{"line_number":107,"context_line":"  NeutronOvsVnicTypeExcludelist:"},{"line_number":108,"context_line":"    description: |"},{"line_number":109,"context_line":"        Comma-separated list of VNIC types for which support in Neutron is"},{"line_number":110,"context_line":"        administratively prohibited by the OVS mechanism driver."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"4b1ad03b_666a8e2f","line":107,"range":{"start_line":107,"start_character":2,"end_line":107,"end_character":31},"updated":"2021-12-01 02:05:50.000000000","message":"These parameter were already deprecated in favor of the new ProhibitList parameters so I think we can leave them or just remove them.","commit_id":"c2e58a1bcdaabfa09d2ff767677112372bb9a1d8"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"46b8689c7755656240179aacb1316fd0e9baecf0","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    description: Firewall driver for realizing neutron security group function"},{"line_number":105,"context_line":"    type: string"},{"line_number":106,"context_line":"    default: \u0027\u0027"},{"line_number":107,"context_line":"  NeutronOvsVnicTypeExcludelist:"},{"line_number":108,"context_line":"    description: |"},{"line_number":109,"context_line":"        Comma-separated list of VNIC types for which support in Neutron is"},{"line_number":110,"context_line":"        administratively prohibited by the OVS mechanism driver."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9b649ce9_07969466","line":107,"range":{"start_line":107,"start_character":2,"end_line":107,"end_character":31},"in_reply_to":"4b1ad03b_666a8e2f","updated":"2021-12-01 03:23:20.000000000","message":"Ack","commit_id":"c2e58a1bcdaabfa09d2ff767677112372bb9a1d8"}],"deployment/neutron/neutron-sriov-agent-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"044020a865e7946bd544b40f0fc0bb911cf7d97d","unresolved":true,"context_lines":[{"line_number":86,"context_line":"     - role_specific"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"conditions:"},{"line_number":89,"context_line":"  derive_pci_whitelist_enabled:"},{"line_number":90,"context_line":"    or:"},{"line_number":91,"context_line":"      - and:"},{"line_number":92,"context_line":"        - {get_param: DerivePciIncludelistEnabled}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fae903d4_13181191","line":89,"range":{"start_line":89,"start_character":2,"end_line":89,"end_character":30},"updated":"2021-12-01 02:05:50.000000000","message":"Should we also rename these internal parameters and the script file we use ?\nBecause this would require additional steps I tend to leave this for a separate work.","commit_id":"c2e58a1bcdaabfa09d2ff767677112372bb9a1d8"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"46b8689c7755656240179aacb1316fd0e9baecf0","unresolved":true,"context_lines":[{"line_number":86,"context_line":"     - role_specific"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"conditions:"},{"line_number":89,"context_line":"  derive_pci_whitelist_enabled:"},{"line_number":90,"context_line":"    or:"},{"line_number":91,"context_line":"      - and:"},{"line_number":92,"context_line":"        - {get_param: DerivePciIncludelistEnabled}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"e2b374f1_905a3bd7","line":89,"range":{"start_line":89,"start_character":2,"end_line":89,"end_character":30},"in_reply_to":"fae903d4_13181191","updated":"2021-12-01 03:23:20.000000000","message":"I was going to leave these just for consistency with Neutron configs. What do you think?","commit_id":"c2e58a1bcdaabfa09d2ff767677112372bb9a1d8"}],"overcloud.j2.yaml":[{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"62d280165e0891ca023cf4199acd7658397bac7b","unresolved":true,"context_lines":[{"line_number":355,"context_line":"    description: \u003e"},{"line_number":356,"context_line":"      Set to true to append per network Vips to /etc/hosts on each node."},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"  DeploymentServerBlacklist:"},{"line_number":359,"context_line":"    default: []"},{"line_number":360,"context_line":"    type: comma_delimited_list"},{"line_number":361,"context_line":"    description: \u003e"},{"line_number":362,"context_line":"      List of server hostnames to exclude from any triggered deployments."},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"  GlobalConfigExtraMapData:"},{"line_number":365,"context_line":"    type: json"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"52ef3056_8d6e9967","line":362,"range":{"start_line":358,"start_character":1,"end_line":362,"end_character":73},"updated":"2023-02-13 20:01:23.000000000","message":"Shouldn\u0027t we introduce surrogate parameter here too?","commit_id":"65e12501b0ce2900139a37d434b7959babf98df8"}],"puppet/role.role.j2.yaml":[{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"62d280165e0891ca023cf4199acd7658397bac7b","unresolved":true,"context_lines":[{"line_number":155,"context_line":"    description: \u003e"},{"line_number":156,"context_line":"      Map of server hostnames to exclude from any triggered"},{"line_number":157,"context_line":"      deployments. If the value is 1, the server will be excluded. This"},{"line_number":158,"context_line":"      parameter is generated from the parent template."},{"line_number":159,"context_line":"  RoleParameters:"},{"line_number":160,"context_line":"    type: json"},{"line_number":161,"context_line":"    description: Parameters specific to the role"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"8d2c45a8_451f7d0a","line":158,"updated":"2023-02-13 20:01:23.000000000","message":"ditto","commit_id":"65e12501b0ce2900139a37d434b7959babf98df8"}],"releasenotes/notes/inclusive_language-796c95c230afb4c5.yaml":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"1a7d71c39492e19ffdef5b0e8a0b954d37319d01","unresolved":true,"context_lines":[{"line_number":6,"context_line":"   This functionality can be replaced by leveraging the `--limit`"},{"line_number":7,"context_line":"   option with the `openstack overcloud deploy` command. "},{"line_number":8,"context_line":"   "},{"line_number":9,"context_line":"    "}],"source_content_type":"text/x-yaml","patch_set":22,"id":"607d65a8_ddca56c0","line":9,"updated":"2022-07-05 13:34:49.000000000","message":"extra spaces at EOL","commit_id":"922415e99df333575310a2f49e7f2728396d1a66"}]}