)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8f759dfb16ed567df82198b74383624bd6990a48","unresolved":true,"context_lines":[{"line_number":13,"context_line":"At the same time we resolve race in ovn-controller shut down"},{"line_number":14,"context_line":"where ovn-controller stops but keeps hanging."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Resolves: rhbz#1942449"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I209f1d4ed11ca23c163eb15a9f43b6e5a1238cad"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7e65aedf_b108d804","line":16,"updated":"2021-12-08 14:59:33.000000000","message":"should have a launchpad bug for upstream and not a bz","commit_id":"e67b7a12f6550e62b773d99f57460334d32d7af7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"1410ab3ce1468865d55bcd301abcbb27f62168c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5e690b23_28b47ca8","updated":"2021-12-03 05:16:58.000000000","message":"Hi Lukas,\n\nCurrently, we have a known bug with centos 7 content-provider job: https://bugs.launchpad.net/tripleo/+bug/1953082\n\nFix is in gate: https://review.opendev.org/c/openstack/tripleo-quickstart/+/820170","commit_id":"da8481a63105369875d7c29928216c0aee59b86e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6bf28fe375b5b5973f517c76387facabec37339f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"65b8cf29_e2f8054b","updated":"2021-12-06 11:44:46.000000000","message":"Tested downstream: https://rhos-ci-jenkins.lab.eng.tlv2.redhat.com/job/DFG-upgrades-ffu-16.2-from-13-latest_cdn-3cont_3db_3msg_2net_3hci-ipv4-ovn_uefi/144/","commit_id":"da8481a63105369875d7c29928216c0aee59b86e"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"89401008e7475035c4b696529720c306c9e74ce2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3896a3bb_e0739353","updated":"2021-12-03 08:09:25.000000000","message":"recheck\n\n https://review.opendev.org/c/openstack/tripleo-quickstart/+/820170 merged","commit_id":"da8481a63105369875d7c29928216c0aee59b86e"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"d01263a51ae9c6e5d697e7bfc073ee3333bb3bb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ec50fa6e_51ccef16","updated":"2021-12-08 08:51:14.000000000","message":"CI passed and manual test too.","commit_id":"e67b7a12f6550e62b773d99f57460334d32d7af7"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"f2d17479a62288136bd6bb76a05382ab94218baa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2cb0aad0_429a1dc1","updated":"2021-12-14 12:14:49.000000000","message":"ignore_errors: yes","commit_id":"5b0514cafc9e0597380b091f959db1ca695af830"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"ff31cf67c6661f4463472af62c3cf4ca6c6c44be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c8b06ec5_67ca66d7","updated":"2022-01-13 08:54:08.000000000","message":"recheck","commit_id":"0b323f7f0c4a8c3cc6571b56246e21baa0ccc038"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"cc492a9fd7f2e6608bfb1762ed37a518a612451e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"96d76b5c_2006e3e4","updated":"2022-01-21 13:55:41.000000000","message":"recheck","commit_id":"a2533dd8eef38bb4604298faf4f316c5b3f03e0e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d6de4007656cc9ed4a264926681cfa562ac32d6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d9555f01_45b36c74","in_reply_to":"96d76b5c_2006e3e4","updated":"2022-01-21 13:55:52.000000000","message":"Done","commit_id":"a2533dd8eef38bb4604298faf4f316c5b3f03e0e"}],"deployment/ovn/ovn-controller-container-puppet.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0350d0b87b3939a89e205975c403ecaf8c35bab3","unresolved":true,"context_lines":[{"line_number":397,"context_line":"            - name: Disable autorestart on ovn_controller container"},{"line_number":398,"context_line":"              command: docker update --restart\u003dno ovn_controller"},{"line_number":399,"context_line":"              when: ovn_controller_running.rc \u003d\u003d 0"},{"line_number":400,"context_line":"            - name: Tell ovn_controller to clean up and stop but don\u0027t fail on it"},{"line_number":401,"context_line":"              failed_when: false"},{"line_number":402,"context_line":"              shell: |"},{"line_number":403,"context_line":"                docker exec -u root ovn_controller bash -c \"if [ -f /usr/bin/ovn-appctl ] ; then ovn-appctl -t ovn-controller exit ; else ovs-appctl --timeout\u003d30 -t ovn-controller exit ; fi\""},{"line_number":404,"context_line":"              when: ovn_controller_running.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2d9c60a1_d19f1ea3","line":401,"range":{"start_line":400,"start_character":60,"end_line":401,"end_character":32},"updated":"2021-12-02 11:27:47.000000000","message":"Can we rather capture a normal exit output and use failed_when to identify if it exited normally? Or perhaps can we find out from the OVN folks if there\u0027s a better way of ensuring it exits cleanly?","commit_id":"27a0b42a0ead7ace6e0e607e78e98f1485f4312b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"476d9b27c59d9d0e4a15ec60f8259f9405f4d733","unresolved":true,"context_lines":[{"line_number":397,"context_line":"            - name: Disable autorestart on ovn_controller container"},{"line_number":398,"context_line":"              command: docker update --restart\u003dno ovn_controller"},{"line_number":399,"context_line":"              when: ovn_controller_running.rc \u003d\u003d 0"},{"line_number":400,"context_line":"            - name: Tell ovn_controller to clean up and stop but don\u0027t fail on it"},{"line_number":401,"context_line":"              failed_when: false"},{"line_number":402,"context_line":"              shell: |"},{"line_number":403,"context_line":"                docker exec -u root ovn_controller bash -c \"if [ -f /usr/bin/ovn-appctl ] ; then ovn-appctl -t ovn-controller exit ; else ovs-appctl --timeout\u003d30 -t ovn-controller exit ; fi\""},{"line_number":404,"context_line":"              when: ovn_controller_running.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"867cd8ae_83258d50","line":401,"range":{"start_line":400,"start_character":60,"end_line":401,"end_character":32},"updated":"2021-12-08 09:22:50.000000000","message":"Can you explain why we used \u0027failed_when: false\u0027 here?\n\nIs there any alternative? Do we know why it hangs - is it perhaps still busy draining connections?\n\nFor example:\n\n1. Could we have it fail when we get output that doesn\u0027t match what we expect?\n2. Could we not use timeout, but perhaps do some sort of loop to wait until it is drained of connections naturally?","commit_id":"e67b7a12f6550e62b773d99f57460334d32d7af7"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"100d0e7a058768b5031cf116477c11694b6a5689","unresolved":true,"context_lines":[{"line_number":397,"context_line":"            - name: Disable autorestart on ovn_controller container"},{"line_number":398,"context_line":"              command: docker update --restart\u003dno ovn_controller"},{"line_number":399,"context_line":"              when: ovn_controller_running.rc \u003d\u003d 0"},{"line_number":400,"context_line":"            - name: Tell ovn_controller to clean up and stop but don\u0027t fail on it"},{"line_number":401,"context_line":"              failed_when: false"},{"line_number":402,"context_line":"              shell: |"},{"line_number":403,"context_line":"                docker exec -u root ovn_controller bash -c \"if [ -f /usr/bin/ovn-appctl ] ; then ovn-appctl -t ovn-controller exit ; else ovs-appctl --timeout\u003d30 -t ovn-controller exit ; fi\""},{"line_number":404,"context_line":"              when: ovn_controller_running.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"551dd067_c0fb4f2c","line":401,"range":{"start_line":400,"start_character":60,"end_line":401,"end_character":32},"in_reply_to":"3d384cd3_809da074","updated":"2021-12-08 12:05:43.000000000","message":"Ack - perhaps it\u0027s worth registering a BZ for the OVN folks to look at. We can do this as a workaround, but we really should have them explain why it\u0027s hanging and what we *should* be doing about it. That doesn\u0027t have to block this patch though.","commit_id":"e67b7a12f6550e62b773d99f57460334d32d7af7"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"4ee74f3773f4fde4c04e53525a3d9db1f72309fb","unresolved":true,"context_lines":[{"line_number":397,"context_line":"            - name: Disable autorestart on ovn_controller container"},{"line_number":398,"context_line":"              command: docker update --restart\u003dno ovn_controller"},{"line_number":399,"context_line":"              when: ovn_controller_running.rc \u003d\u003d 0"},{"line_number":400,"context_line":"            - name: Tell ovn_controller to clean up and stop but don\u0027t fail on it"},{"line_number":401,"context_line":"              failed_when: false"},{"line_number":402,"context_line":"              shell: |"},{"line_number":403,"context_line":"                docker exec -u root ovn_controller bash -c \"if [ -f /usr/bin/ovn-appctl ] ; then ovn-appctl -t ovn-controller exit ; else ovs-appctl --timeout\u003d30 -t ovn-controller exit ; fi\""},{"line_number":404,"context_line":"              when: ovn_controller_running.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3d384cd3_809da074","line":401,"range":{"start_line":400,"start_character":60,"end_line":401,"end_character":32},"in_reply_to":"867cd8ae_83258d50","updated":"2021-12-08 11:44:55.000000000","message":"It just hangs for no apparent reason and as it\u0027s shutdown I don\u0027t think we will get any backport/fix any time soon. Plus the --timeout still returns error so we need to ignore it as it dies at that point. It does not seem to have traffic flowing through after this command is executed and it definetly does not drain connections as in CI we have ... hmm ... 5ish?","commit_id":"e67b7a12f6550e62b773d99f57460334d32d7af7"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"f2d17479a62288136bd6bb76a05382ab94218baa","unresolved":true,"context_lines":[{"line_number":398,"context_line":"              command: docker update --restart\u003dno ovn_controller"},{"line_number":399,"context_line":"              when: ovn_controller_running.rc \u003d\u003d 0"},{"line_number":400,"context_line":"            - name: Tell ovn_controller to clean up and stop but don\u0027t fail on it"},{"line_number":401,"context_line":"              failed_when: false"},{"line_number":402,"context_line":"              shell: |"},{"line_number":403,"context_line":"                docker exec -u root ovn_controller bash -c \"if [ -f /usr/bin/ovn-appctl ] ; then ovn-appctl -t ovn-controller exit ; else ovs-appctl --timeout\u003d30 -t ovn-controller exit ; fi\""},{"line_number":404,"context_line":"              when: ovn_controller_running.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"058ca452_7a08c701","line":401,"updated":"2021-12-14 12:14:49.000000000","message":"ignore_errors: yes","commit_id":"5b0514cafc9e0597380b091f959db1ca695af830"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0878934d56079020a643b2ef7bd7ccfa49a02c57","unresolved":true,"context_lines":[{"line_number":398,"context_line":"              command: docker update --restart\u003dno ovn_controller"},{"line_number":399,"context_line":"              when: ovn_controller_running.rc \u003d\u003d 0"},{"line_number":400,"context_line":"            - name: Tell ovn_controller to clean up and stop but don\u0027t fail on it"},{"line_number":401,"context_line":"              failed_when: false"},{"line_number":402,"context_line":"              shell: |"},{"line_number":403,"context_line":"                docker exec -u root ovn_controller bash -c \"if [ -f /usr/bin/ovn-appctl ] ; then ovn-appctl -t ovn-controller exit ; else ovs-appctl --timeout\u003d30 -t ovn-controller exit ; fi\""},{"line_number":404,"context_line":"              when: ovn_controller_running.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"259d6b24_3abddb6d","line":401,"in_reply_to":"058ca452_7a08c701","updated":"2021-12-14 14:17:25.000000000","message":"failed_when: false is better","commit_id":"5b0514cafc9e0597380b091f959db1ca695af830"}],"deployment/ovn/ovn-dbs-pacemaker-puppet.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0878934d56079020a643b2ef7bd7ccfa49a02c57","unresolved":true,"context_lines":[{"line_number":403,"context_line":"              delegate_to: \"{{item}}\""},{"line_number":404,"context_line":"              with_items:"},{"line_number":405,"context_line":"                - \"{{hostvars[groups[\u0027overcloud\u0027][0]][\u0027ovn_dbs_short_node_names\u0027][1]}}\""},{"line_number":406,"context_line":"                - \"{{hostvars[groups[\u0027overcloud\u0027][0]][\u0027ovn_dbs_short_node_names\u0027][2]}}\""},{"line_number":407,"context_line":"              shell: |"},{"line_number":408,"context_line":"                grep $( hiera -c /etc/puppet/hiera.yaml ovn_dbs_vip ) /var/lib/openvswitch/ovn/ovnnb-active.conf"},{"line_number":409,"context_line":"              failed_when: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"42bf44fa_ba0fa128","line":406,"updated":"2021-12-14 14:17:25.000000000","message":"I wonder if theres a better way to do this since this is a list and this doesn\u0027t check the first node.  does with_items: \"{{hostvars[groups[\u0027overcloud\u0027][0]][\u0027ovn_dbs_short_node_names\u0027]}}\" work?","commit_id":"5b0514cafc9e0597380b091f959db1ca695af830"}]}