)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"b0e8cd6c159d0aa6f9a0e3d35a939f2749ef86fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"49caeef7_7dc36bf0","updated":"2021-12-13 10:28:38.000000000","message":"python3-redis package is missing from the octavia-* container images","commit_id":"86cc184cabdaaa71902b5a3024ee9775e7ee761d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2413c1b24bf930e89d81e4de682d60334153beb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"01769654_e2bbf783","updated":"2022-03-02 07:47:57.000000000","message":"tripleo-ci-centos-9-scenario010-standalone passed, the octavia services have the correct parameters:\n\n2022-03-01 10:29:44.975 16 INFO octavia.api.app [-] task_flow.jobboard_backend_driver \u003d redis_taskflow_driver\n2022-03-01 10:29:44.975 16 INFO octavia.api.app [-] task_flow.jobboard_backend_hosts \u003d [\u0027192.168.24.3\u0027]\n2022-03-01 10:29:44.975 16 INFO octavia.api.app [-] task_flow.jobboard_backend_namespace \u003d octavia_jobboard\n2022-03-01 10:29:44.975 16 INFO octavia.api.app [-] task_flow.jobboard_backend_password \u003d ****\n2022-03-01 10:29:44.975 16 INFO octavia.api.app [-] task_flow.jobboard_backend_port \u003d 6379\n2022-03-01 10:29:44.975 16 INFO octavia.api.app [-] task_flow.jobboard_enabled     \u003d True\n2022-03-01 10:29:44.976 16 INFO octavia.api.app [-] task_flow.jobboard_expiration_time \u003d 100\n2022-03-01 10:29:44.977 16 INFO octavia.api.app [-] task_flow.persistence_connection \u003d mysql+pymysql://octavia:1PR7JQZPtgYUIkSflaLLUNWCQ@192.168.24.3/octavia_persistence?read_default_file\u003d/etc/my.cnf.d/tripleo.cnf\u0026read_default_group\u003dtripleo\n","commit_id":"26bbc638a0067e517e60e306773dcf3ec95f1e86"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"073d8985281d881e30a6bf4f7fa68864b5e0de12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1abea933_0cb16338","updated":"2022-05-26 16:40:39.000000000","message":"Because this change is making Redis mandatory, you need to enable Redis in the following two jobs which have Octavia enabled.\n\n - ci/environments/scenario013-standalone.yaml\n - ci/environments/scenario010-multinode-containers.yaml","commit_id":"e80454826afc7f64bd346bbad6bc801a273e641c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d73d8f39a7b0a93fc928acc8efcdb1cd70afff80","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"eb27d293_ee698825","in_reply_to":"1abea933_0cb16338","updated":"2022-05-26 16:42:56.000000000","message":"(posting this to remove the resolved flag...)","commit_id":"e80454826afc7f64bd346bbad6bc801a273e641c"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"43d7261c7fda1c82b9a6386859f508cecd6bd38b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4ddf752f_be0a07e6","in_reply_to":"eb27d293_ee698825","updated":"2022-06-13 17:13:15.000000000","message":"done","commit_id":"e80454826afc7f64bd346bbad6bc801a273e641c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"41f1172b0a4a6e605c36e1cb316c338b4b6fc2d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"81bf1fcc_2352ae16","updated":"2022-06-16 00:44:27.000000000","message":"Thanks for updating. The implementation almost looks good to me. -1 because of some suggestions to make the logic simpler.","commit_id":"224f6647949389d339c0c6e12a15838ab1fae99e"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"c651c6c931e5c94a0a7a750f9657c608098e19ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9becdb31_4cfacfa8","updated":"2022-06-17 09:27:23.000000000","message":"recheck libvirt workaround is merged","commit_id":"58b017c59c01b3ca053cbd912fadda1b35108f4d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2b4bc163d4bdfd34add89684c26c91b3e8bccc30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e0d3f3b8_63cd2a62","updated":"2022-06-16 12:16:42.000000000","message":"recheck tripleo-ci-centos-9-scenario010-standalone nova cannot attach port","commit_id":"58b017c59c01b3ca053cbd912fadda1b35108f4d"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"edec7d5f5f3846792968af5a09ebb59796e5aeeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"18614541_48790da3","updated":"2022-08-29 13:03:55.000000000","message":"lgtm","commit_id":"3f55cbfbcf34822ca35f12240d7ebac6270ed6cf"}],"deployment/octavia/octavia-base.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d73d8f39a7b0a93fc928acc8efcdb1cd70afff80","unresolved":true,"context_lines":[{"line_number":317,"context_line":"            - octavia_client_cert_set"},{"line_number":318,"context_line":"            - {get_param: OctaviaClientCert}"},{"line_number":319,"context_line":"        octavia::task_flow::jobboard_enabled: {get_param: OctaviaEnableJobboard}"},{"line_number":320,"context_line":"        octavia::task_flow::jobboard_backend_hosts: \"%{hiera(\u0027redis_vip\u0027)}\""},{"line_number":321,"context_line":"        octavia::task_flow::jobboard_backend_password: {get_param: RedisPassword}"},{"line_number":322,"context_line":"        octavia::task_flow::jobboard_expiration_time: 100"},{"line_number":323,"context_line":"        octavia::task_flow::persistence_connection:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"4fadd559_3cda5684","line":320,"range":{"start_line":320,"start_character":7,"end_line":320,"end_character":75},"updated":"2022-05-26 16:42:56.000000000","message":"This logic would make Redis mandatory evne if OctaviaEnableJobboard is false, which does not make clear sense.\n\nI think it\u0027s better you include the whole octavia::task_flow block only if OctaviaEnableJobboard is true.","commit_id":"e80454826afc7f64bd346bbad6bc801a273e641c"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"43d7261c7fda1c82b9a6386859f508cecd6bd38b","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            - octavia_client_cert_set"},{"line_number":318,"context_line":"            - {get_param: OctaviaClientCert}"},{"line_number":319,"context_line":"        octavia::task_flow::jobboard_enabled: {get_param: OctaviaEnableJobboard}"},{"line_number":320,"context_line":"        octavia::task_flow::jobboard_backend_hosts: \"%{hiera(\u0027redis_vip\u0027)}\""},{"line_number":321,"context_line":"        octavia::task_flow::jobboard_backend_password: {get_param: RedisPassword}"},{"line_number":322,"context_line":"        octavia::task_flow::jobboard_expiration_time: 100"},{"line_number":323,"context_line":"        octavia::task_flow::persistence_connection:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bd2bd826_f13a3572","line":320,"range":{"start_line":320,"start_character":7,"end_line":320,"end_character":75},"in_reply_to":"4fadd559_3cda5684","updated":"2022-06-13 17:13:15.000000000","message":"Done","commit_id":"e80454826afc7f64bd346bbad6bc801a273e641c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"41f1172b0a4a6e605c36e1cb316c338b4b6fc2d1","unresolved":true,"context_lines":[{"line_number":327,"context_line":"            - octavia_client_cert_set"},{"line_number":328,"context_line":"            - {get_param: OctaviaClientCert}"},{"line_number":329,"context_line":"        octavia::task_flow::jobboard_enabled: {get_param: OctaviaEnableJobboard}"},{"line_number":330,"context_line":"        octavia::task_flow::jobboard_backend_hosts:"},{"line_number":331,"context_line":"          if:"},{"line_number":332,"context_line":"            - octavia_enable_jobboard"},{"line_number":333,"context_line":"            - \"%{hiera(\u0027redis_vip\u0027)}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"871f64ad_58af34a4","line":330,"range":{"start_line":330,"start_character":8,"end_line":330,"end_character":50},"updated":"2022-06-16 00:44:27.000000000","message":"I think it\u0027d be more readable if we nest these parameters in a single if block instead of adding the same if condition in multiple places.","commit_id":"224f6647949389d339c0c6e12a15838ab1fae99e"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"1dcdea6f0a940ecf04939c9aaefeec25e1c9abc8","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            - octavia_client_cert_set"},{"line_number":328,"context_line":"            - {get_param: OctaviaClientCert}"},{"line_number":329,"context_line":"        octavia::task_flow::jobboard_enabled: {get_param: OctaviaEnableJobboard}"},{"line_number":330,"context_line":"        octavia::task_flow::jobboard_backend_hosts:"},{"line_number":331,"context_line":"          if:"},{"line_number":332,"context_line":"            - octavia_enable_jobboard"},{"line_number":333,"context_line":"            - \"%{hiera(\u0027redis_vip\u0027)}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"133cf616_ed482c42","line":330,"range":{"start_line":330,"start_character":8,"end_line":330,"end_character":50},"in_reply_to":"871f64ad_58af34a4","updated":"2022-06-16 09:02:44.000000000","message":"done (added a big map_merge for all the params)","commit_id":"224f6647949389d339c0c6e12a15838ab1fae99e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"41f1172b0a4a6e605c36e1cb316c338b4b6fc2d1","unresolved":true,"context_lines":[{"line_number":329,"context_line":"        octavia::task_flow::jobboard_enabled: {get_param: OctaviaEnableJobboard}"},{"line_number":330,"context_line":"        octavia::task_flow::jobboard_backend_hosts:"},{"line_number":331,"context_line":"          if:"},{"line_number":332,"context_line":"            - octavia_enable_jobboard"},{"line_number":333,"context_line":"            - \"%{hiera(\u0027redis_vip\u0027)}\""},{"line_number":334,"context_line":"        octavia::task_flow::jobboard_backend_password:"},{"line_number":335,"context_line":"          if:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"2a187b9e_0810fb04","line":332,"range":{"start_line":332,"start_character":14,"end_line":332,"end_character":37},"updated":"2022-06-16 00:44:27.000000000","message":"You can just use {get_param: OctaviaEnableJobboard }","commit_id":"224f6647949389d339c0c6e12a15838ab1fae99e"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"1dcdea6f0a940ecf04939c9aaefeec25e1c9abc8","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        octavia::task_flow::jobboard_enabled: {get_param: OctaviaEnableJobboard}"},{"line_number":330,"context_line":"        octavia::task_flow::jobboard_backend_hosts:"},{"line_number":331,"context_line":"          if:"},{"line_number":332,"context_line":"            - octavia_enable_jobboard"},{"line_number":333,"context_line":"            - \"%{hiera(\u0027redis_vip\u0027)}\""},{"line_number":334,"context_line":"        octavia::task_flow::jobboard_backend_password:"},{"line_number":335,"context_line":"          if:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"89eb9665_bfb526a6","line":332,"range":{"start_line":332,"start_character":14,"end_line":332,"end_character":37},"in_reply_to":"2a187b9e_0810fb04","updated":"2022-06-16 09:02:44.000000000","message":"done","commit_id":"224f6647949389d339c0c6e12a15838ab1fae99e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"41f1172b0a4a6e605c36e1cb316c338b4b6fc2d1","unresolved":true,"context_lines":[{"line_number":338,"context_line":"        octavia::task_flow::jobboard_expiration_time:"},{"line_number":339,"context_line":"          if:"},{"line_number":340,"context_line":"            - octavia_enable_jobboard"},{"line_number":341,"context_line":"            - 100"},{"line_number":342,"context_line":"        octavia::task_flow::persistence_connection:"},{"line_number":343,"context_line":"          if:"},{"line_number":344,"context_line":"            - octavia_enable_jobboard"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"b9d7fe61_9913e400","line":341,"range":{"start_line":341,"start_character":14,"end_line":341,"end_character":17},"updated":"2022-06-16 00:44:27.000000000","message":"I\u0027m just curious but is this the tuning specific to TripleO ? The parameter defaults to 30 in Octavia and if 100 (or 120 ?) would be a globally better value then it\u0027d make sense to change the default value in Octavia (though that change would not be bacportable)","commit_id":"224f6647949389d339c0c6e12a15838ab1fae99e"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"bec4c12c372e41ba1dda6f74fcb24cd17687021d","unresolved":false,"context_lines":[{"line_number":338,"context_line":"        octavia::task_flow::jobboard_expiration_time:"},{"line_number":339,"context_line":"          if:"},{"line_number":340,"context_line":"            - octavia_enable_jobboard"},{"line_number":341,"context_line":"            - 100"},{"line_number":342,"context_line":"        octavia::task_flow::persistence_connection:"},{"line_number":343,"context_line":"          if:"},{"line_number":344,"context_line":"            - octavia_enable_jobboard"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"2c6b7f48_81a18438","line":341,"range":{"start_line":341,"start_character":14,"end_line":341,"end_character":17},"in_reply_to":"8eba8d06_ff3b08a5","updated":"2022-08-26 13:41:23.000000000","message":"it\u0027s now 30","commit_id":"224f6647949389d339c0c6e12a15838ab1fae99e"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"1dcdea6f0a940ecf04939c9aaefeec25e1c9abc8","unresolved":false,"context_lines":[{"line_number":338,"context_line":"        octavia::task_flow::jobboard_expiration_time:"},{"line_number":339,"context_line":"          if:"},{"line_number":340,"context_line":"            - octavia_enable_jobboard"},{"line_number":341,"context_line":"            - 100"},{"line_number":342,"context_line":"        octavia::task_flow::persistence_connection:"},{"line_number":343,"context_line":"          if:"},{"line_number":344,"context_line":"            - octavia_enable_jobboard"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"8eba8d06_ff3b08a5","line":341,"range":{"start_line":341,"start_character":14,"end_line":341,"end_character":17},"in_reply_to":"b9d7fe61_9913e400","updated":"2022-06-16 09:02:44.000000000","message":"In the patchset 8, I added a new parameter to define it, the default is 30 (same default as in Octavia).\nfor a reason, we override this value to 100 in the U/S Octavia CI, but I think this is something we should remove there.","commit_id":"224f6647949389d339c0c6e12a15838ab1fae99e"}]}