)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"119fffd066bf8a77b201c3268e7c469db5005ee1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4b132514_97ee5edd","updated":"2021-12-16 08:57:39.000000000","message":"I\u0027ve also got inputs from the upgrades folk:\n\nIt\u0027ve been not enough to just do it in upgrade tasks at this point as there are already upgraded deployments\n\n(so I guess it\u0027s good to go)","commit_id":"3983bc7445276a7183689466c613fdf62c446126"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"967401fee3f89565d8f1d1dfff9ddcd4531262b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"16780ab8_a355d1eb","updated":"2021-12-14 14:18:44.000000000","message":"Nice change!","commit_id":"3983bc7445276a7183689466c613fdf62c446126"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4659e3236d102aa9a00e12f0252ca57759077624","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c4ae03a2_a5713209","updated":"2022-01-11 10:31:56.000000000","message":"could we please move this thing forward?","commit_id":"3983bc7445276a7183689466c613fdf62c446126"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2fb9572b90825bf079947c6aaacc5e7f54603ea9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1207f4fc_002a270b","updated":"2021-12-20 10:52:18.000000000","message":"could you take a look please","commit_id":"3983bc7445276a7183689466c613fdf62c446126"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"ef6f3aafcceb1e58b4c775b6a80a1300a5b702d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fbc01fcf_01d2ccd8","updated":"2021-12-10 08:20:48.000000000","message":"in general lgtm, as commented the cell0 has a hard coded ID, so we could just check for existence and update if required, no need to really get the cell0 id. ","commit_id":"3983bc7445276a7183689466c613fdf62c446126"}],"deployment/nova/nova-api-container-puppet.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"ef6f3aafcceb1e58b4c775b6a80a1300a5b702d1","unresolved":true,"context_lines":[{"line_number":573,"context_line":"                  template: |"},{"line_number":574,"context_line":"                    #!/bin/bash"},{"line_number":575,"context_line":"                    CLIST\u003d$(su nova -s /bin/bash -c \"nova-manage cell_v2 list_cells\")"},{"line_number":576,"context_line":"                    CELLID\u003d$(printf \"$CLIST\" | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d \"cell0\" {print $4}\u0027)"},{"line_number":577,"context_line":"                    CELLDBC\u003d$(printf \"$CLIST\" | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d \"cell0\" {print $8}\u0027)"},{"line_number":578,"context_line":"                    if [ \"$CELLID\" ]; then"},{"line_number":579,"context_line":"                      if [ ! \"$CELLDBC\" \u003d \"CELL0DB\" ]; then"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1ed18467_466ace60","line":576,"updated":"2021-12-10 08:20:48.000000000","message":"The CELLID for cell0 is always 00000000-0000-0000-0000-000000000000 [1], so a simple check for this specific ID or the cell0 name should be enough to validate if it got already created.\n\n[1] https://github.com/openstack/nova/blob/master/nova/objects/cell_mapping.py#L73","commit_id":"3983bc7445276a7183689466c613fdf62c446126"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"1eb50452ba9cbb56fb4de49ad4a4382d5e181369","unresolved":true,"context_lines":[{"line_number":573,"context_line":"                  template: |"},{"line_number":574,"context_line":"                    #!/bin/bash"},{"line_number":575,"context_line":"                    CLIST\u003d$(su nova -s /bin/bash -c \"nova-manage cell_v2 list_cells\")"},{"line_number":576,"context_line":"                    CELLID\u003d$(printf \"$CLIST\" | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d \"cell0\" {print $4}\u0027)"},{"line_number":577,"context_line":"                    CELLDBC\u003d$(printf \"$CLIST\" | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d \"cell0\" {print $8}\u0027)"},{"line_number":578,"context_line":"                    if [ \"$CELLID\" ]; then"},{"line_number":579,"context_line":"                      if [ ! \"$CELLDBC\" \u003d \"CELL0DB\" ]; then"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"aeed06db_ec4e5935","line":576,"in_reply_to":"1a7caa3b_1130f064","updated":"2021-12-10 11:29:49.000000000","message":"sure we can do that as well","commit_id":"3983bc7445276a7183689466c613fdf62c446126"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"35fc91bf8df3e4106b0fdb55b3ffe2d115e5aceb","unresolved":true,"context_lines":[{"line_number":573,"context_line":"                  template: |"},{"line_number":574,"context_line":"                    #!/bin/bash"},{"line_number":575,"context_line":"                    CLIST\u003d$(su nova -s /bin/bash -c \"nova-manage cell_v2 list_cells\")"},{"line_number":576,"context_line":"                    CELLID\u003d$(printf \"$CLIST\" | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d \"cell0\" {print $4}\u0027)"},{"line_number":577,"context_line":"                    CELLDBC\u003d$(printf \"$CLIST\" | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d \"cell0\" {print $8}\u0027)"},{"line_number":578,"context_line":"                    if [ \"$CELLID\" ]; then"},{"line_number":579,"context_line":"                      if [ ! \"$CELLDBC\" \u003d \"CELL0DB\" ]; then"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a7caa3b_1130f064","line":576,"in_reply_to":"1ed18467_466ace60","updated":"2021-12-10 11:24:48.000000000","message":"Sure we can do that. I was thinkig about future multiple cells support, and keeping that pattern around just as an example. It costs nothing, since parses the saved cells list info, which we require only once...","commit_id":"3983bc7445276a7183689466c613fdf62c446126"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b02adbbdcf2bb555dfe421a8e9987394b87fd26e","unresolved":true,"context_lines":[{"line_number":573,"context_line":"                  template: |"},{"line_number":574,"context_line":"                    #!/bin/bash"},{"line_number":575,"context_line":"                    CLIST\u003d$(su nova -s /bin/bash -c \"nova-manage cell_v2 list_cells\")"},{"line_number":576,"context_line":"                    CELLID\u003d$(printf \"$CLIST\" | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d \"cell0\" {print $4}\u0027)"},{"line_number":577,"context_line":"                    CELLDBC\u003d$(printf \"$CLIST\" | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d \"cell0\" {print $8}\u0027)"},{"line_number":578,"context_line":"                    if [ \"$CELLID\" ]; then"},{"line_number":579,"context_line":"                      if [ ! \"$CELLDBC\" \u003d \"CELL0DB\" ]; then"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7c540213_ebeb5c21","line":576,"in_reply_to":"74025269_2213ec73","updated":"2021-12-14 17:17:24.000000000","message":"we will do that once we\u0027ll be implementing multiple cells support. For now I kept it simple enought (knowing that we only have a cell0 today) but also w/o hardcoding the 000* ID for it. This just provides a basic direction to follow later, when implementing multi-cells. Then we will add a loop... I hope it works","commit_id":"3983bc7445276a7183689466c613fdf62c446126"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"0dcfaf746555aa9d1e6cdfd391e128a03efb3397","unresolved":true,"context_lines":[{"line_number":573,"context_line":"                  template: |"},{"line_number":574,"context_line":"                    #!/bin/bash"},{"line_number":575,"context_line":"                    CLIST\u003d$(su nova -s /bin/bash -c \"nova-manage cell_v2 list_cells\")"},{"line_number":576,"context_line":"                    CELLID\u003d$(printf \"$CLIST\" | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d \"cell0\" {print $4}\u0027)"},{"line_number":577,"context_line":"                    CELLDBC\u003d$(printf \"$CLIST\" | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d \"cell0\" {print $8}\u0027)"},{"line_number":578,"context_line":"                    if [ \"$CELLID\" ]; then"},{"line_number":579,"context_line":"                      if [ ! \"$CELLDBC\" \u003d \"CELL0DB\" ]; then"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"0334bda2_9060396b","line":576,"in_reply_to":"7c540213_ebeb5c21","updated":"2021-12-15 10:17:15.000000000","message":"I think we should keep this automation (at least for now ) just for cell0 and default cell (what is already there). For multiple cells you cannot fully template the database and transport url because you split the services on different nodes, managed by different heat stacks and have therefore different nova.conf files for the cells. therefore the central DB requires some information e.g. endpoint ip/hostname information of the cell to be in the DB as the local nova.conf does not have that cell information. e.g. if the passwords/users are kept same across cells those parts of the URL can be templated. See  https://access.redhat.com/documentation/en-us/red_hat_openstack_platform/16.2/html-single/scaling_deployments_with_compute_cells/index#proc_creating-the-cell-within-the-compute-service_creating-managing-cells","commit_id":"3983bc7445276a7183689466c613fdf62c446126"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"967401fee3f89565d8f1d1dfff9ddcd4531262b2","unresolved":true,"context_lines":[{"line_number":573,"context_line":"                  template: |"},{"line_number":574,"context_line":"                    #!/bin/bash"},{"line_number":575,"context_line":"                    CLIST\u003d$(su nova -s /bin/bash -c \"nova-manage cell_v2 list_cells\")"},{"line_number":576,"context_line":"                    CELLID\u003d$(printf \"$CLIST\" | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d \"cell0\" {print $4}\u0027)"},{"line_number":577,"context_line":"                    CELLDBC\u003d$(printf \"$CLIST\" | sed -e \u00271,3d\u0027 -e \u0027$d\u0027 | awk -F \u0027 *| *\u0027 \u0027$2 \u003d\u003d \"cell0\" {print $8}\u0027)"},{"line_number":578,"context_line":"                    if [ \"$CELLID\" ]; then"},{"line_number":579,"context_line":"                      if [ ! \"$CELLDBC\" \u003d \"CELL0DB\" ]; then"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"74025269_2213ec73","line":576,"in_reply_to":"aeed06db_ec4e5935","updated":"2021-12-14 14:18:44.000000000","message":"I like the idea of supporting multiple cells but shouldn\u0027t we loop through the results and not look for cell0?","commit_id":"3983bc7445276a7183689466c613fdf62c446126"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"ef6f3aafcceb1e58b4c775b6a80a1300a5b702d1","unresolved":true,"context_lines":[{"line_number":581,"context_line":"                        # for all the scheduler, conductor, API service workers."},{"line_number":582,"context_line":"                        # For now that\u0027s achieved as the containers get recreated"},{"line_number":583,"context_line":"                        echo \"(cellv2) Updating cell0 cell_v2 cell $CELLID\""},{"line_number":584,"context_line":"                        su nova -s /bin/bash -c \"/usr/bin/nova-manage cell_v2 update_cell --cell_uuid $CELLID --name\u003dcell0 --database_connection\u003d\u0027CELL0DB\u0027\""},{"line_number":585,"context_line":"                      fi"},{"line_number":586,"context_line":"                    else"},{"line_number":587,"context_line":"                      echo \"(cellv2) Creating cell0 cell_v2 cell\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"02717034_9be9b0f4","line":584,"updated":"2021-12-10 08:20:48.000000000","message":"as said above the CELLID is always 00000000-0000-0000-0000-000000000000, so could hard code it here.","commit_id":"3983bc7445276a7183689466c613fdf62c446126"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"86604920055777074d6c9d460287474658f5b431","unresolved":true,"context_lines":[{"line_number":585,"context_line":"                      fi"},{"line_number":586,"context_line":"                    else"},{"line_number":587,"context_line":"                      echo \"(cellv2) Creating cell0 cell_v2 cell\""},{"line_number":588,"context_line":"                      su nova -s /bin/bash -c \"/usr/bin/nova-manage cell_v2 map_cell0 --database_connection\u003d\u0027CELL0DB\u0027\""},{"line_number":589,"context_line":"                    fi"},{"line_number":590,"context_line":"                    # skip DB sync as the conductor container executes it later"},{"line_number":591,"context_line":"                  params:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7fefb09a_852b057f","line":588,"range":{"start_line":588,"start_character":47,"end_line":588,"end_character":117},"updated":"2021-12-10 17:07:49.000000000","message":"maybe this should update the cell0 mapping when it exists","commit_id":"3983bc7445276a7183689466c613fdf62c446126"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a6cd5d4afa0fec2b066f4a5b0f3f6f2f7c3f41ae","unresolved":true,"context_lines":[{"line_number":585,"context_line":"                      fi"},{"line_number":586,"context_line":"                    else"},{"line_number":587,"context_line":"                      echo \"(cellv2) Creating cell0 cell_v2 cell\""},{"line_number":588,"context_line":"                      su nova -s /bin/bash -c \"/usr/bin/nova-manage cell_v2 map_cell0 --database_connection\u003d\u0027CELL0DB\u0027\""},{"line_number":589,"context_line":"                    fi"},{"line_number":590,"context_line":"                    # skip DB sync as the conductor container executes it later"},{"line_number":591,"context_line":"                  params:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"83efa425_491a7e8e","line":588,"range":{"start_line":588,"start_character":47,"end_line":588,"end_character":117},"in_reply_to":"7fefb09a_852b057f","updated":"2021-12-10 17:13:06.000000000","message":"do you mean in the nova code? it would be nice, yes. For now the docs only mention create, but not update options for it","commit_id":"3983bc7445276a7183689466c613fdf62c446126"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"74b1e57d5834de7304b4e718d10efd481ec1680b","unresolved":true,"context_lines":[{"line_number":585,"context_line":"                      fi"},{"line_number":586,"context_line":"                    else"},{"line_number":587,"context_line":"                      echo \"(cellv2) Creating cell0 cell_v2 cell\""},{"line_number":588,"context_line":"                      su nova -s /bin/bash -c \"/usr/bin/nova-manage cell_v2 map_cell0 --database_connection\u003d\u0027CELL0DB\u0027\""},{"line_number":589,"context_line":"                    fi"},{"line_number":590,"context_line":"                    # skip DB sync as the conductor container executes it later"},{"line_number":591,"context_line":"                  params:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"47c4fcce_b9e8ea5f","line":588,"range":{"start_line":588,"start_character":47,"end_line":588,"end_character":117},"in_reply_to":"83efa425_491a7e8e","updated":"2021-12-14 16:49:03.000000000","message":"Yes, AFAICT map_cell0 will just output a message in this case, but does not fail.","commit_id":"3983bc7445276a7183689466c613fdf62c446126"}]}