)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"554e717199ddb830fa3f93f482fa91c85fab8d67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0cb31d38_6e0d24b5","updated":"2022-01-05 15:43:23.000000000","message":"recheck upgrade failure","commit_id":"f51498909097304b756619b5c58700958748f0b9"}],"network/config/2-linux-bonds-vlans/role.role.j2.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"075010b86e2e2714b593ed5610ae90ac4ec26bd4","unresolved":true,"context_lines":[{"line_number":214,"context_line":"              mtu:"},{"line_number":215,"context_line":"                get_attr: [MinViableMtuBondData, value]"},{"line_number":216,"context_line":"{%- for network in networks if network.name.startswith(\u0027Tenant\u0027) and network.name in _role_networks and network.enabled|default(true) %}"},{"line_number":217,"context_line":"        - type: vlan"},{"line_number":218,"context_line":"          device: bond-data"},{"line_number":219,"context_line":"          mtu:"},{"line_number":220,"context_line":"            get_param: {{network.name}}Mtu"},{"line_number":221,"context_line":"          vlan_id:"},{"line_number":222,"context_line":"            get_param: {{network.name}}NetworkVlanID"},{"line_number":223,"context_line":"          addresses:"},{"line_number":224,"context_line":"          - ip_netmask:"},{"line_number":225,"context_line":"              get_param: {{network.name}}IpSubnet"},{"line_number":226,"context_line":"          routes:"},{"line_number":227,"context_line":"            get_param: {{network.name}}InterfaceRoutes"},{"line_number":228,"context_line":"{%- endfor %}"},{"line_number":229,"context_line":"{%- else %}"},{"line_number":230,"context_line":"        - type: ovs_user_bridge"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"84558a7b_383ee57a","line":227,"range":{"start_line":217,"start_character":0,"end_line":227,"end_character":54},"updated":"2021-12-15 12:02:06.000000000","message":"I think the request is to move tenant vlan network under ovs-bridge, not the earlier change.\n\nThis is the comment in https://github.com/openstack/tripleo-heat-templates/tree/stable/train/network/config/2-linux-bonds-vlans\n\n\"The Tenant network does not need to be on a bridge in order for VXLAN to function, but the Tenant network appears on the bridge interface in order to group tenant VLAN traffic and VXLAN traffic together.\"","commit_id":"7bddda45a7d737637552fb8c77eb996685521707"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"1d7617150b7b5660e1b3b878d9ead0fde9a2d326","unresolved":true,"context_lines":[{"line_number":214,"context_line":"              mtu:"},{"line_number":215,"context_line":"                get_attr: [MinViableMtuBondData, value]"},{"line_number":216,"context_line":"{%- for network in networks if network.name.startswith(\u0027Tenant\u0027) and network.name in _role_networks and network.enabled|default(true) %}"},{"line_number":217,"context_line":"        - type: vlan"},{"line_number":218,"context_line":"          device: bond-data"},{"line_number":219,"context_line":"          mtu:"},{"line_number":220,"context_line":"            get_param: {{network.name}}Mtu"},{"line_number":221,"context_line":"          vlan_id:"},{"line_number":222,"context_line":"            get_param: {{network.name}}NetworkVlanID"},{"line_number":223,"context_line":"          addresses:"},{"line_number":224,"context_line":"          - ip_netmask:"},{"line_number":225,"context_line":"              get_param: {{network.name}}IpSubnet"},{"line_number":226,"context_line":"          routes:"},{"line_number":227,"context_line":"            get_param: {{network.name}}InterfaceRoutes"},{"line_number":228,"context_line":"{%- endfor %}"},{"line_number":229,"context_line":"{%- else %}"},{"line_number":230,"context_line":"        - type: ovs_user_bridge"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d32f6ed4_de952864","line":227,"range":{"start_line":217,"start_character":0,"end_line":227,"end_character":54},"in_reply_to":"84558a7b_383ee57a","updated":"2021-12-15 12:13:04.000000000","message":"Ah yeah, I think you\u0027re right. That makes more sense in the context of that snippet on the BZ now. I was a bit confused by the request on the BZ which is why I was asking for clarification. But this makes sense, I\u0027ll change it.","commit_id":"7bddda45a7d737637552fb8c77eb996685521707"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"4001136f021a6ce0bd7e9be3a6d6466391e90fa2","unresolved":true,"context_lines":[{"line_number":214,"context_line":"              mtu:"},{"line_number":215,"context_line":"                get_attr: [MinViableMtuBondData, value]"},{"line_number":216,"context_line":"{%- for network in networks if network.name.startswith(\u0027Tenant\u0027) and network.name in _role_networks and network.enabled|default(true) %}"},{"line_number":217,"context_line":"            - type: vlan"},{"line_number":218,"context_line":"              device: bond-data"},{"line_number":219,"context_line":"              mtu:"},{"line_number":220,"context_line":"                get_param: {{network.name}}Mtu"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"be72183f_a315c0c8","line":217,"range":{"start_line":217,"start_character":12,"end_line":217,"end_character":24},"updated":"2021-12-15 12:27:03.000000000","message":"has to be aligned with L200 (in bridge members, not bond members) I think. Needs to be changed in tripleo-ansible for newer branches.\n\nExample: https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_network_config/templates/bonds_vlans/bonds_vlans.j2","commit_id":"d7f90f000cba9f2f19ba015dc5c5f226b831add1"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"554e717199ddb830fa3f93f482fa91c85fab8d67","unresolved":true,"context_lines":[{"line_number":214,"context_line":"              mtu:"},{"line_number":215,"context_line":"                get_attr: [MinViableMtuBondData, value]"},{"line_number":216,"context_line":"{%- for network in networks if network.name.startswith(\u0027Tenant\u0027) and network.name in _role_networks and network.enabled|default(true) %}"},{"line_number":217,"context_line":"            - type: vlan"},{"line_number":218,"context_line":"              device: bond-data"},{"line_number":219,"context_line":"              mtu:"},{"line_number":220,"context_line":"                get_param: {{network.name}}Mtu"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"de854a10_0301d7b1","line":217,"range":{"start_line":217,"start_character":12,"end_line":217,"end_character":24},"in_reply_to":"be72183f_a315c0c8","updated":"2022-01-05 15:43:23.000000000","message":"seems you mean https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_network_config/templates/2_linux_bonds_vlans/2_linux_bonds_vlans.j2? as bonds_vlans one looks fine.","commit_id":"d7f90f000cba9f2f19ba015dc5c5f226b831add1"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"94101ffe847e61a14dbcc97b2fff09c33da8db9e","unresolved":true,"context_lines":[{"line_number":214,"context_line":"              mtu:"},{"line_number":215,"context_line":"                get_attr: [MinViableMtuBondData, value]"},{"line_number":216,"context_line":"{%- for network in networks if network.name.startswith(\u0027Tenant\u0027) and network.name in _role_networks and network.enabled|default(true) %}"},{"line_number":217,"context_line":"            - type: vlan"},{"line_number":218,"context_line":"              device: bond-data"},{"line_number":219,"context_line":"              mtu:"},{"line_number":220,"context_line":"                get_param: {{network.name}}Mtu"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"059f5a9d_290311d2","line":217,"range":{"start_line":217,"start_character":12,"end_line":217,"end_character":24},"in_reply_to":"d43cf830_23f1a972","updated":"2022-01-18 06:05:49.000000000","message":"Pushed https://review.opendev.org/c/openstack/tripleo-ansible/+/825039 for master, that can be backported till wallaby.","commit_id":"d7f90f000cba9f2f19ba015dc5c5f226b831add1"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"991f81ace4da70c03afa747af102a0b6cdd45742","unresolved":true,"context_lines":[{"line_number":214,"context_line":"              mtu:"},{"line_number":215,"context_line":"                get_attr: [MinViableMtuBondData, value]"},{"line_number":216,"context_line":"{%- for network in networks if network.name.startswith(\u0027Tenant\u0027) and network.name in _role_networks and network.enabled|default(true) %}"},{"line_number":217,"context_line":"            - type: vlan"},{"line_number":218,"context_line":"              device: bond-data"},{"line_number":219,"context_line":"              mtu:"},{"line_number":220,"context_line":"                get_param: {{network.name}}Mtu"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d43cf830_23f1a972","line":217,"range":{"start_line":217,"start_character":12,"end_line":217,"end_character":24},"in_reply_to":"de854a10_0301d7b1","updated":"2022-01-07 05:14:47.000000000","message":"right, I pasted the wrong link.","commit_id":"d7f90f000cba9f2f19ba015dc5c5f226b831add1"}]}