)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"ae1787b6e37ffb51de3b57a4978afbce35dc5f79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f74cf3d1_3597a1e6","updated":"2021-12-20 17:57:44.000000000","message":"I agree with Alex. Cleanup work such as removing deprecated code/features is generally a good idea in master, but the goal of stable releases is to avoid risks that could introduce a regression. I don\u0027t see the gain in reaching all the way back to the train release for something like this.","commit_id":"985587ebe6f8b0e57ae63ad10f83fb22eb297988"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3655b36194bc0ccb14cdd1942e67ad51114e6dfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7f540870_d3c1fb71","updated":"2021-12-20 23:56:04.000000000","message":"The auth_uri parameter doesn\u0027t exist in stable/train in most of the modules and I\u0027m not aware of any risks caused by this. I we need this to avoid conflict when backporting https://review.opendev.org/c/openstack/tripleo-heat-templates/+/822306 later.","commit_id":"985587ebe6f8b0e57ae63ad10f83fb22eb297988"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"32cb3746f7ba013e5100b642f0eea76fd4c45226","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"de82baf7_d13336e3","updated":"2021-12-21 02:38:48.000000000","message":"setting auth_uri after www_authenticate_uri is like dead code and confusing. We\u0027ve  defaults which are used for services like glance[1] and it overrides what we set with auth_uri.\n\n[1] https://github.com/openstack/puppet-glance/blob/stable/train/manifests/api/authtoken.pp#L195\n\nAs per code cleanup in stable branches, we backport stuff to drop cli command deprecation, so this is nothing in comparison.","commit_id":"ad99d7521cdc18a7cf6689cc81c718caa1b11284"}],"deployment/glance/glance-api-container-puppet.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"fd021edd6a73a15706122172dc3ea24fc04c371d","unresolved":true,"context_lines":[{"line_number":395,"context_line":"                  read_default_file: /etc/my.cnf.d/tripleo.cnf"},{"line_number":396,"context_line":"                  read_default_group: tripleo"},{"line_number":397,"context_line":"            glance::api::bind_port: {get_param: [EndpointMap, GlanceInternal, port]}"},{"line_number":398,"context_line":"            glance::api::authtoken::www_authenticate_uri: {get_param: [EndpointMap, KeystoneInternal, uri_no_suffix] }"},{"line_number":399,"context_line":"            glance::api::authtoken::auth_url: { get_param: [EndpointMap, KeystoneInternal, uri_no_suffix] }"},{"line_number":400,"context_line":"            glance::api::enable_v1_api: false"},{"line_number":401,"context_line":"            glance::api::enable_v2_api: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"eb6c42be_bdc0b35f","line":398,"range":{"start_line":398,"start_character":36,"end_line":398,"end_character":56},"updated":"2021-12-20 10:56:27.000000000","message":"Though this is a backport and possibly is ignored by clients, I think it should be using public endpoint. We can probably fix it in master and then backport.","commit_id":"985587ebe6f8b0e57ae63ad10f83fb22eb297988"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"241157e3a06e95cd02fad8e1bfe0fe4691e88378","unresolved":true,"context_lines":[{"line_number":395,"context_line":"                  read_default_file: /etc/my.cnf.d/tripleo.cnf"},{"line_number":396,"context_line":"                  read_default_group: tripleo"},{"line_number":397,"context_line":"            glance::api::bind_port: {get_param: [EndpointMap, GlanceInternal, port]}"},{"line_number":398,"context_line":"            glance::api::authtoken::www_authenticate_uri: {get_param: [EndpointMap, KeystoneInternal, uri_no_suffix] }"},{"line_number":399,"context_line":"            glance::api::authtoken::auth_url: { get_param: [EndpointMap, KeystoneInternal, uri_no_suffix] }"},{"line_number":400,"context_line":"            glance::api::enable_v1_api: false"},{"line_number":401,"context_line":"            glance::api::enable_v2_api: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fd6bc6e4_f9af8da8","line":398,"range":{"start_line":398,"start_character":36,"end_line":398,"end_character":56},"in_reply_to":"eb6c42be_bdc0b35f","updated":"2021-12-20 11:03:38.000000000","message":"I\u0027ve submitted a patch to master to replace usage of internal endpoint by public endpoint. Once that is merged in master I\u0027ll backport it back to train as well.\n https://review.opendev.org/c/openstack/tripleo-heat-templates/+/822306\n\nUnless anyone has huge concern, I\u0027d prefer keeping clean backport about this specific patch.","commit_id":"985587ebe6f8b0e57ae63ad10f83fb22eb297988"}],"deployment/swift/swift-proxy-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3655b36194bc0ccb14cdd1942e67ad51114e6dfb","unresolved":true,"context_lines":[{"line_number":162,"context_line":"            swift::proxy::authtoken::auth_url: {get_param: [EndpointMap, KeystoneInternal, uri_no_suffix]}"},{"line_number":163,"context_line":"            swift::proxy::authtoken::password: {get_param: SwiftPassword}"},{"line_number":164,"context_line":"            swift::proxy::authtoken::project_name: \u0027service\u0027"},{"line_number":165,"context_line":"            swift::proxy::s3token::www_authenticate_uri: {get_param: [EndpointMap, KeystoneV3Internal, uri]}"},{"line_number":166,"context_line":"            swift::proxy::node_timeout: {get_param: SwiftProxyNodeTimeout}"},{"line_number":167,"context_line":"          -"},{"line_number":168,"context_line":"            if:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"17524652_838c9647","line":165,"range":{"start_line":165,"start_character":12,"end_line":165,"end_character":55},"updated":"2021-12-20 23:56:04.000000000","message":"We should fix this. This was incorrect and fixed later by https://review.opendev.org/c/openstack/tripleo-heat-templates/+/782001","commit_id":"985587ebe6f8b0e57ae63ad10f83fb22eb297988"}]}