)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"358e1fb424d6ac4bf5677d1a017e8f827ee2928d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0f3ac0e1_1b007d00","updated":"2022-01-13 14:23:26.000000000","message":"recheck","commit_id":"b4a9058b86a51de51c4678c044f547f0286bf2e3"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"c0c403f2f48f8bb9619900cc04087dcda401aa95","unresolved":true,"context_lines":[{"line_number":1474,"context_line":"                  content: |"},{"line_number":1475,"context_line":"                    [Unit]"},{"line_number":1476,"context_line":"                    Description\u003dSuspend libvirt Guests in tripleo"},{"line_number":1477,"context_line":"                    Requires\u003dvirt-guest-shutdown.target network-online.target"},{"line_number":1478,"context_line":"                    After\u003dsystemd-machined.service tripleo_nova_libvirt.service"},{"line_number":1479,"context_line":"                    Before\u003dtripleo_nova_compute.service"},{"line_number":1480,"context_line":"                    Documentation\u003dman:libvirtd(8)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f515f8d2_0fd4c0b4","line":1477,"updated":"2021-12-22 09:02:12.000000000","message":"shouldn\u0027t network-online.target be listed in After\u003d to have an ordering dependency? iirc Requires is like Wants which don\u0027t give an ordering of when this service get started.","commit_id":"da16c42dab997c2a8ca96d89a03f090a8431f06d"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3fe848e94e38ce6f86198fadf6c3325c2a7b52e1","unresolved":true,"context_lines":[{"line_number":1474,"context_line":"                  content: |"},{"line_number":1475,"context_line":"                    [Unit]"},{"line_number":1476,"context_line":"                    Description\u003dSuspend libvirt Guests in tripleo"},{"line_number":1477,"context_line":"                    Requires\u003dvirt-guest-shutdown.target network-online.target"},{"line_number":1478,"context_line":"                    After\u003dsystemd-machined.service tripleo_nova_libvirt.service"},{"line_number":1479,"context_line":"                    Before\u003dtripleo_nova_compute.service"},{"line_number":1480,"context_line":"                    Documentation\u003dman:libvirtd(8)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b0a0b49f_9c33feab","line":1477,"in_reply_to":"a20fb585_a7290426","updated":"2022-01-11 10:43:36.000000000","message":"thank you! done","commit_id":"da16c42dab997c2a8ca96d89a03f090a8431f06d"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"e77c9673eb111845d2452d0bfb9b5ae65030a490","unresolved":true,"context_lines":[{"line_number":1474,"context_line":"                  content: |"},{"line_number":1475,"context_line":"                    [Unit]"},{"line_number":1476,"context_line":"                    Description\u003dSuspend libvirt Guests in tripleo"},{"line_number":1477,"context_line":"                    Requires\u003dvirt-guest-shutdown.target network-online.target"},{"line_number":1478,"context_line":"                    After\u003dsystemd-machined.service tripleo_nova_libvirt.service"},{"line_number":1479,"context_line":"                    Before\u003dtripleo_nova_compute.service"},{"line_number":1480,"context_line":"                    Documentation\u003dman:libvirtd(8)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a20fb585_a7290426","line":1477,"in_reply_to":"f515f8d2_0fd4c0b4","updated":"2022-01-07 17:59:44.000000000","message":"I agree here, based on manpages, we could end up having both network-online and libvirt started simultaneously. Nice catch Martin++.\n\n\n    Note that requirement dependencies do not influence the order in which services are started or stopped. This has to be configured independently with the After\u003d or Before\u003d options. If unit foo.service pulls in unit bar.service as configured with Wants\u003d and no ordering is configured with After\u003d or Before\u003d, then both units will be started simultaneously and without any delay between them if foo.service is activated.","commit_id":"da16c42dab997c2a8ca96d89a03f090a8431f06d"}]}