)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e38f59992df631afc0c54ec3ea38b211317cf049","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix cloud-init detection rules"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Only wait for cloud init, when it\u0027s enabled and active."},{"line_number":10,"context_line":"If it\u0027s enabled but inactive (vendor preset: disabled), it can\u0027t be"},{"line_number":11,"context_line":"waited. If it\u0027s active but disabled for the next reboot, it probably"},{"line_number":12,"context_line":"shouldn\u0027t be waited neither."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4075e503_cf064f22","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":28},"updated":"2022-01-12 03:48:51.000000000","message":"Ignoring enabled and inactive service is ignoring issue at startup.\n\nDo you mean \"when service was installed it was disabled and was manually enabled but not started or system rebooted after the enabling it\"?\n\n\nIf a service is enabled and is inactive, there is an issue and that should be fixed rather than ignoring it. The best we can do is try starting the service instead of ignoring.","commit_id":"f67db5f14a4121f5ffce567ddc58cb29bfb842f0"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"aa1b7432840b2d11fa212464140cefcdf8dd4140","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix cloud-init detection rules"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Only wait for cloud init, when it\u0027s enabled and active."},{"line_number":10,"context_line":"If it\u0027s enabled but inactive (vendor preset: disabled), it can\u0027t be"},{"line_number":11,"context_line":"waited. If it\u0027s active but disabled for the next reboot, it probably"},{"line_number":12,"context_line":"shouldn\u0027t be waited neither."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"45a9831d_810b9d49","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":28},"in_reply_to":"2be4c172_1550b778","updated":"2022-01-17 13:21:40.000000000","message":"Done","commit_id":"f67db5f14a4121f5ffce567ddc58cb29bfb842f0"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"88e94fa7ebcd0b4b4a4e76afa949afa2e1641340","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix cloud-init detection rules"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Only wait for cloud init, when it\u0027s enabled and active."},{"line_number":10,"context_line":"If it\u0027s enabled but inactive (vendor preset: disabled), it can\u0027t be"},{"line_number":11,"context_line":"waited. If it\u0027s active but disabled for the next reboot, it probably"},{"line_number":12,"context_line":"shouldn\u0027t be waited neither."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ed95bd42_6613ea4d","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":28},"in_reply_to":"4075e503_cf064f22","updated":"2022-01-12 08:15:31.000000000","message":"\"enabled and inactive\" is that I get when cloud-init has been disabled in the kernal command line:\n\n[zuul@standalone ~]$ systemctl is-enabled cloud-init.service \u0026\u0026 systemctl is-active cloud-init.service^C\n[zuul@standalone ~]$ cat /proc/cmdline \nBOOT_IMAGE\u003d(hd0,msdos1)/boot/vmlinuz-5.14.0-39.el9.x86_64 root\u003dUUID\u003d2dd5de90-e46f-421a-ac94-0d6c7f3b77bb ro console\u003dttyS0,115200n8 no_timer_check net.ifnames\u003d0 crashkernel\u003d1G-4G:192M,4G-64G:256M,64G-:512M cloud-init\u003ddisabled\n[zuul@standalone ~]$ systemctl is-enabled cloud-init.service \u0026\u0026 systemctl is-active cloud-init.service\nenabled\ninactive\n[zuul@standalone ~]$ systemctl status cloud-init.service\n○ cloud-init.service - Initial cloud-init job (metadata service crawler)\n     Loaded: loaded (/usr/lib/systemd/system/cloud-init.service; enabled; vendor preset: disabled)\n     Active: inactive (dead)\n\nSo, I believe the issue is that is-enabled should have been actually showing it as disabled, not enabled.\nIf you have better ideas how to handle such a case (parsing status?) let me know please, I\u0027ll adjust the patch.","commit_id":"f67db5f14a4121f5ffce567ddc58cb29bfb842f0"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"b2114b5cd72526328e36df5b75ee632bfeca6631","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix cloud-init detection rules"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Only wait for cloud init, when it\u0027s enabled and active."},{"line_number":10,"context_line":"If it\u0027s enabled but inactive (vendor preset: disabled), it can\u0027t be"},{"line_number":11,"context_line":"waited. If it\u0027s active but disabled for the next reboot, it probably"},{"line_number":12,"context_line":"shouldn\u0027t be waited neither."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2be4c172_1550b778","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":28},"in_reply_to":"ed95bd42_6613ea4d","updated":"2022-01-12 08:58:05.000000000","message":"We change the kernel args in tripleo-quickstart[1], hence it\u0027s not included in the boot goals, but I think it won\u0027t change the \u0027is-enabled\u0027 check.\n\nThis change would exclude genuine issues where cloud-init does not come up due to errors. \n\nIf we want to ensure that we honor kernel args, we should check that instead I guess.\n\n[1] https://opendev.org/openstack/tripleo-quickstart/commit/4d1581ccfad6bb9645622bdba219bec3b6f6e771","commit_id":"f67db5f14a4121f5ffce567ddc58cb29bfb842f0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c31fc7a7a1ecdef18235baf00a8e967b113d49a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"645f96fd_cb5e8ab5","updated":"2022-01-11 14:54:52.000000000","message":"Adding Rabi as I believe he looked into this the first time","commit_id":"f67db5f14a4121f5ffce567ddc58cb29bfb842f0"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"305c5e427f5098eb6f43fcc5731e365f5752f356","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8f47a28f_aeff9b8d","updated":"2022-01-10 16:20:41.000000000","message":"Should we disable it when it\u0027s enabled but not active?","commit_id":"f67db5f14a4121f5ffce567ddc58cb29bfb842f0"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7a86975db21adf65b47602c96b8f81bcf0efd4c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"345ecda7_c4926672","updated":"2022-01-12 09:18:30.000000000","message":"So this would ignore cases where the service fails to start after being enabled.\nBut I\u0027m not bought yet on adding a stricter \"ensure started\" logic aside to that we have here","commit_id":"f67db5f14a4121f5ffce567ddc58cb29bfb842f0"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7b11de3c08aa00327d0b7f8eb8e005d48973524b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6364be0e_e128edac","updated":"2022-01-11 15:57:46.000000000","message":"so it worked with my libvirt zuul reproducer, where I had inactive \u0026 enabled cloud-init (but vendor preset: disabled)","commit_id":"f67db5f14a4121f5ffce567ddc58cb29bfb842f0"}]}