)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ca36d6fbff69274bd91f4e92d56efb72a8cabedc","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disable libvirtd and stop it"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Disable libvirtd and stop it if ironic inspector is running in a"},{"line_number":10,"context_line":"container as the dnsmasq libvirtd process conflicts with the"},{"line_number":11,"context_line":"dnsmasq process from ironic inspector."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ied386c148717c53903bd5f58c575e8c6cabee7a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"2f21b040_fff5dfbe","line":10,"range":{"start_line":9,"start_character":29,"end_line":10,"end_character":9},"updated":"2022-01-13 14:36:39.000000000","message":"Ideally this commit message should be updated. It is now always disabling libvirtd.\n\nDid we get to the bottom of what exactly enables libvirtd, and did we raise bugs to at least question the behaviour?","commit_id":"503274955e1b8e490db2e232d446d581c41e9f5c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"d557e921b0284146cd7966eade564685badd7f77","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b5e4bed2_3ad245c7","updated":"2022-01-11 19:27:57.000000000","message":"Except for undercloud and maybe controllers when using bmaas, is there any other place where ironic-inspector could run? I don\u0027t see any valid scenario where this would be required alongside with libvirt.\n\nMaybe we should add this to ./deployment/undercloud/undercloud-upgrade.yaml instead?","commit_id":"a26b1d33064b16fab6d7be4ee6f4b445dabd3307"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"f641f9f32e9e08d4d08210059f3b1c2e4396f61d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a1a9c5ea_79cdaa1a","updated":"2022-01-12 03:50:21.000000000","message":"I don\u0027t think this should be in templates related to Ironic Inspector. While Ironic Inspector may be impacted by this, the proposed change here doesn\u0027t address why this happened in the first place. Even without Ironic deployed on the overcloud, we still don\u0027t want libvirt runing on the Controllers. In fact, I\u0027m not sure we ever want libvirt installed and running on any node do we? \n\nIf we\u0027re going to put this anywhere, it would make sense for it to go with the task that results in the issue to begin with. Somewhere here for example:\nhttps://github.com/openstack/tripleo-heat-templates/blob/stable/train/deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml#L595\n\n","commit_id":"a26b1d33064b16fab6d7be4ee6f4b445dabd3307"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"8ca0952bd97c3e8fbf1d3d7190eed8447df080cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"87d7fcc7_2c31fd9c","in_reply_to":"b5e4bed2_3ad245c7","updated":"2022-01-11 19:43:56.000000000","message":"overcloud baremetal too... and this is where we hit this issue with ironic inspector on the controllers...  I\u0027m pretty sure libvirt shouldn\u0027t be running on controlelrs.","commit_id":"a26b1d33064b16fab6d7be4ee6f4b445dabd3307"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"2036721b03e3b19581173b21271f98d4937fce18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d83f8597_58a0f9ae","updated":"2022-01-19 15:55:03.000000000","message":"recheck","commit_id":"5b9648dd9dc5cc15b15373894c48998952b4acb6"}],"deployment/ironic/ironic-inspector-container-puppet.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ae0928eeea23d285c6a861b84f664247b9e2e060","unresolved":true,"context_lines":[{"line_number":541,"context_line":"            environment:"},{"line_number":542,"context_line":"              KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"},{"line_number":543,"context_line":"      host_prep_tasks:"},{"line_number":544,"context_line":"        - name: check if libvirt is installed"},{"line_number":545,"context_line":"          command: /usr/bin/rpm -q libvirt-daemon"},{"line_number":546,"context_line":"          failed_when: false"},{"line_number":547,"context_line":"          register: libvirt_installed"},{"line_number":548,"context_line":"          check_mode: false"},{"line_number":549,"context_line":"        - name: make sure libvirt services are disabled and masked"},{"line_number":550,"context_line":"          service:"},{"line_number":551,"context_line":"            name: \"{{ item }}\""},{"line_number":552,"context_line":"            state: stopped"},{"line_number":553,"context_line":"            enabled: false"},{"line_number":554,"context_line":"            masked: true"},{"line_number":555,"context_line":"            daemon_reload: true"},{"line_number":556,"context_line":"          with_items:"},{"line_number":557,"context_line":"            - libvirtd.service"},{"line_number":558,"context_line":"            - virtlogd.socket"},{"line_number":559,"context_line":"          when: libvirt_installed.rc \u003d\u003d 0"},{"line_number":560,"context_line":"        - name: create fcontext entry for ironic-inspector data"},{"line_number":561,"context_line":"          community.general.sefcontext:"},{"line_number":562,"context_line":"            target: \"/var/lib/ironic-inspector/dhcp-hostsdir(/.*)?\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"307ead02_01c2b47d","line":559,"range":{"start_line":544,"start_character":0,"end_line":559,"end_character":41},"updated":"2022-01-11 16:29:43.000000000","message":"this feels weird.\nIf libvirt is running someone intended it to run, if that combination don\u0027t work should we error instead of breaking whatever other service which installed and enabled libvirt?","commit_id":"a26b1d33064b16fab6d7be4ee6f4b445dabd3307"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"7a213fb45af5360f8da6dacc11b4d45358b5b884","unresolved":false,"context_lines":[{"line_number":541,"context_line":"            environment:"},{"line_number":542,"context_line":"              KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"},{"line_number":543,"context_line":"      host_prep_tasks:"},{"line_number":544,"context_line":"        - name: check if libvirt is installed"},{"line_number":545,"context_line":"          command: /usr/bin/rpm -q libvirt-daemon"},{"line_number":546,"context_line":"          failed_when: false"},{"line_number":547,"context_line":"          register: libvirt_installed"},{"line_number":548,"context_line":"          check_mode: false"},{"line_number":549,"context_line":"        - name: make sure libvirt services are disabled and masked"},{"line_number":550,"context_line":"          service:"},{"line_number":551,"context_line":"            name: \"{{ item }}\""},{"line_number":552,"context_line":"            state: stopped"},{"line_number":553,"context_line":"            enabled: false"},{"line_number":554,"context_line":"            masked: true"},{"line_number":555,"context_line":"            daemon_reload: true"},{"line_number":556,"context_line":"          with_items:"},{"line_number":557,"context_line":"            - libvirtd.service"},{"line_number":558,"context_line":"            - virtlogd.socket"},{"line_number":559,"context_line":"          when: libvirt_installed.rc \u003d\u003d 0"},{"line_number":560,"context_line":"        - name: create fcontext entry for ironic-inspector data"},{"line_number":561,"context_line":"          community.general.sefcontext:"},{"line_number":562,"context_line":"            target: \"/var/lib/ironic-inspector/dhcp-hostsdir(/.*)?\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c8132f8e_6b858123","line":559,"range":{"start_line":544,"start_character":0,"end_line":559,"end_character":41},"in_reply_to":"307ead02_01c2b47d","updated":"2022-01-11 17:57:25.000000000","message":"No , when enabling the container-tools stream 2.0 on the controller while updating from 16.1 to 16.1.7, it installed dependencies which is \"libvirt-daemon\" which also starts libvirtd and its dnsmasq process which conflicts with ironic-introspector dnsmasq process because both are listening on the ::::::67 port.   We need this.  Thanks.","commit_id":"a26b1d33064b16fab6d7be4ee6f4b445dabd3307"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a05cf48110aedf22645111f92d9cc349e1a1db21","unresolved":false,"context_lines":[{"line_number":541,"context_line":"            environment:"},{"line_number":542,"context_line":"              KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"},{"line_number":543,"context_line":"      host_prep_tasks:"},{"line_number":544,"context_line":"        - name: check if libvirt is installed"},{"line_number":545,"context_line":"          command: /usr/bin/rpm -q libvirt-daemon"},{"line_number":546,"context_line":"          failed_when: false"},{"line_number":547,"context_line":"          register: libvirt_installed"},{"line_number":548,"context_line":"          check_mode: false"},{"line_number":549,"context_line":"        - name: make sure libvirt services are disabled and masked"},{"line_number":550,"context_line":"          service:"},{"line_number":551,"context_line":"            name: \"{{ item }}\""},{"line_number":552,"context_line":"            state: stopped"},{"line_number":553,"context_line":"            enabled: false"},{"line_number":554,"context_line":"            masked: true"},{"line_number":555,"context_line":"            daemon_reload: true"},{"line_number":556,"context_line":"          with_items:"},{"line_number":557,"context_line":"            - libvirtd.service"},{"line_number":558,"context_line":"            - virtlogd.socket"},{"line_number":559,"context_line":"          when: libvirt_installed.rc \u003d\u003d 0"},{"line_number":560,"context_line":"        - name: create fcontext entry for ironic-inspector data"},{"line_number":561,"context_line":"          community.general.sefcontext:"},{"line_number":562,"context_line":"            target: \"/var/lib/ironic-inspector/dhcp-hostsdir(/.*)?\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1e95eb3d_d7b37fd7","line":559,"range":{"start_line":544,"start_character":0,"end_line":559,"end_character":41},"in_reply_to":"39a43d50_4c6cd30f","updated":"2022-01-11 21:00:26.000000000","message":"Here is where it is enabled by tripleo, it would be better to fix there?\n\nhttps://opendev.org/openstack/tripleo-heat-templates/src/branch/master/deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml\nhttps://opendev.org/openstack/tripleo-heat-templates/src/branch/master/deployment/undercloud/undercloud-upgrade.yaml\n\nI also think we should talk to raise a bug for CentOS/container-tools upstream and ask why they enable the service by default? It seems a bad default to enable a service when it\u0027s not always required to run. For starters, for security reasons disabling anything not needed is a good thing.","commit_id":"a26b1d33064b16fab6d7be4ee6f4b445dabd3307"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"59a6d8d78bb77b5b96471c519bcd5da6961bb562","unresolved":false,"context_lines":[{"line_number":541,"context_line":"            environment:"},{"line_number":542,"context_line":"              KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"},{"line_number":543,"context_line":"      host_prep_tasks:"},{"line_number":544,"context_line":"        - name: check if libvirt is installed"},{"line_number":545,"context_line":"          command: /usr/bin/rpm -q libvirt-daemon"},{"line_number":546,"context_line":"          failed_when: false"},{"line_number":547,"context_line":"          register: libvirt_installed"},{"line_number":548,"context_line":"          check_mode: false"},{"line_number":549,"context_line":"        - name: make sure libvirt services are disabled and masked"},{"line_number":550,"context_line":"          service:"},{"line_number":551,"context_line":"            name: \"{{ item }}\""},{"line_number":552,"context_line":"            state: stopped"},{"line_number":553,"context_line":"            enabled: false"},{"line_number":554,"context_line":"            masked: true"},{"line_number":555,"context_line":"            daemon_reload: true"},{"line_number":556,"context_line":"          with_items:"},{"line_number":557,"context_line":"            - libvirtd.service"},{"line_number":558,"context_line":"            - virtlogd.socket"},{"line_number":559,"context_line":"          when: libvirt_installed.rc \u003d\u003d 0"},{"line_number":560,"context_line":"        - name: create fcontext entry for ironic-inspector data"},{"line_number":561,"context_line":"          community.general.sefcontext:"},{"line_number":562,"context_line":"            target: \"/var/lib/ironic-inspector/dhcp-hostsdir(/.*)?\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"39a43d50_4c6cd30f","line":559,"range":{"start_line":544,"start_character":0,"end_line":559,"end_character":41},"in_reply_to":"c8132f8e_6b858123","updated":"2022-01-11 20:48:34.000000000","message":"So we end up with running libvirtd on all nodes?\nWithout TripleO specifically telling the service to be there?\nBecause enabling container-tools stream 2.0 enables it?\n\nI don\u0027t think this is a ironic-inspector issue, we should put something in place around where container-tools is happening to sledgehammer it\u0027s defaults?","commit_id":"a26b1d33064b16fab6d7be4ee6f4b445dabd3307"}],"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"924a6c6d2fede85620b15e82e914fa875af3fdf4","unresolved":true,"context_lines":[{"line_number":310,"context_line":"            enabled: false"},{"line_number":311,"context_line":"            masked: true"},{"line_number":312,"context_line":"            daemon_reload: true"},{"line_number":313,"context_line":"          with_items:"},{"line_number":314,"context_line":"            - libvirtd.service"},{"line_number":315,"context_line":"            - virtlogd.socket"},{"line_number":316,"context_line":"          when: libvirt_installed.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e5f2963a_7514e40a","line":313,"range":{"start_line":313,"start_character":10,"end_line":313,"end_character":20},"updated":"2022-01-12 15:17:38.000000000","message":"We should probably use loop instead:\n\nhttps://docs.ansible.com/ansible/latest/user_guide/playbooks_loops.html#migrating-from-with-x-to-loop","commit_id":"467157a4d3580e1c57edff677e24b7a94816684b"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"014d8179ca2b45e126d6477628a26c75674469f8","unresolved":false,"context_lines":[{"line_number":310,"context_line":"            enabled: false"},{"line_number":311,"context_line":"            masked: true"},{"line_number":312,"context_line":"            daemon_reload: true"},{"line_number":313,"context_line":"          with_items:"},{"line_number":314,"context_line":"            - libvirtd.service"},{"line_number":315,"context_line":"            - virtlogd.socket"},{"line_number":316,"context_line":"          when: libvirt_installed.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f26c590_7435d90e","line":313,"range":{"start_line":313,"start_character":10,"end_line":313,"end_character":20},"in_reply_to":"e5f2963a_7514e40a","updated":"2022-01-12 17:09:45.000000000","message":"Ack","commit_id":"467157a4d3580e1c57edff677e24b7a94816684b"}]}