)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"626e656079292027656ca7e8ea8e027ba361daf9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1032fe56_7e0da11e","updated":"2022-01-21 16:41:37.000000000","message":"recheck","commit_id":"e36f44cadd2dd887e7ef29c25437e9b8cd67a1ac"},{"author":{"_account_id":33688,"name":"Vijayalakshmi","display_name":"Viji Candappa","email":"vcandapp@redhat.com","username":"VijiC"},"change_message_id":"a704e7a0c6dc78b07c394968f07ad4f3eda00a3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aa8622a6_aab8b79c","updated":"2022-01-21 07:39:48.000000000","message":"recheck","commit_id":"e36f44cadd2dd887e7ef29c25437e9b8cd67a1ac"},{"author":{"_account_id":33688,"name":"Vijayalakshmi","display_name":"Viji Candappa","email":"vcandapp@redhat.com","username":"VijiC"},"change_message_id":"a3ac689769e72e3e042cdb5ab64557b328b7f933","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b24ff2d2_5e83c55e","updated":"2022-01-20 04:37:17.000000000","message":"recheck","commit_id":"e36f44cadd2dd887e7ef29c25437e9b8cd67a1ac"}],"deployment/neutron/derive_pci_passthrough_whitelist.py":[{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"c1934f1efc2396e4b92ab10a5745c9060395ee04","unresolved":true,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    \"\"\"Check if user config list is valid \"\"\""},{"line_number":317,"context_line":"    try:"},{"line_number":318,"context_line":"        user_configs[0] and isinstance(user_configs, list)"},{"line_number":319,"context_line":"    except (IndexError):"},{"line_number":320,"context_line":"        raise"},{"line_number":321,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"62e47053_72331ec9","line":318,"updated":"2022-01-17 08:01:26.000000000","message":"Can we do something like \n    if not (isinstance(user_configs, list) and len(user_configs) \u003e 0 and isinstance(user_configs[0], dict)):\n        raise InvalidConfigException(\"Invalid format for nova::compute::pci::passthrough\")","commit_id":"61366835cc602b9ce798235b3ec56e6bf0326300"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"c0818cb6877f31a21ac8918853e598a6b4820f97","unresolved":true,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    \"\"\"Check if user config list is valid \"\"\""},{"line_number":317,"context_line":"    try:"},{"line_number":318,"context_line":"        user_configs[0] and isinstance(user_configs, list)"},{"line_number":319,"context_line":"    except (IndexError):"},{"line_number":320,"context_line":"        raise"},{"line_number":321,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"f4dd9a23_884f6cef","line":318,"in_reply_to":"62e47053_72331ec9","updated":"2022-01-17 10:55:12.000000000","message":"I would prefer not to check for instance of user_config[0] as is the responsibility of the function generate_combined_configuration, which does processing.\n\nIMO, when there is no user_config to derive (empty list), it should not be an error, it should skip derive params and treat it as nothing to do. If it other than list, then it could be error to signify something went wrong.","commit_id":"61366835cc602b9ce798235b3ec56e6bf0326300"},{"author":{"_account_id":33688,"name":"Vijayalakshmi","display_name":"Viji Candappa","email":"vcandapp@redhat.com","username":"VijiC"},"change_message_id":"0ba045bed23ba92d66aabc8c585ccbcc7385e516","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    \"\"\"Check if user config list is valid \"\"\""},{"line_number":317,"context_line":"    try:"},{"line_number":318,"context_line":"        user_configs[0] and isinstance(user_configs, list)"},{"line_number":319,"context_line":"    except (IndexError):"},{"line_number":320,"context_line":"        raise"},{"line_number":321,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7329182d_241c5f7b","line":318,"in_reply_to":"f4dd9a23_884f6cef","updated":"2022-01-19 08:28:46.000000000","message":"Done","commit_id":"61366835cc602b9ce798235b3ec56e6bf0326300"}]}