)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"6a6b43e5cad049e06dbc69ad4b3a5e5428666807","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"86e15ab6_4203504f","updated":"2022-01-13 11:22:45.000000000","message":"is it safe to provide defaults that might change the current value(s)?\ndoes that pose an upgrade impact?","commit_id":"6c9e85c45a72cf547699a86e8b5fed060b57ee8e"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"de7b109aeeb68773cc217ed2cee6cfac7c5a5a82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f9ce4242_cb9b700d","updated":"2022-01-13 14:11:18.000000000","message":"the error is here https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_15c/824525/2/check/openstack-tox-pep8/15ccd69/job-output.txt","commit_id":"6c9e85c45a72cf547699a86e8b5fed060b57ee8e"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"eb886d1f6e303f3b892a7c40756133857f928601","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"74b7c029_1bcf23d2","updated":"2022-01-13 17:01:17.000000000","message":"w-1 until we understand better if this is what we really want to do and if it\u0027s safe on update for pre-existing volumes","commit_id":"59cd5e707c19ebb8ee52fe084f5d7474802b5df2"}],"deployment/cinder/cinder-volume-container-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"320a202482d155075962094b6634de9e4df7a47f","unresolved":true,"context_lines":[{"line_number":176,"context_line":"        CinderRbdExtraPools"},{"line_number":177,"context_line":"        CinderRbdAvailabilityZone"},{"line_number":178,"context_line":"        CinderRbdFlattenVolumeFromSnapshot"},{"line_number":179,"context_line":"        RbdStoreChunkSize"},{"line_number":180,"context_line":"  CephClusterFSID:"},{"line_number":181,"context_line":"    type: string"},{"line_number":182,"context_line":"    description: The Ceph cluster FSID. Must be a UUID."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"29ba2095_45e8e300","line":179,"updated":"2022-01-13 15:49:00.000000000","message":"As noted by Franceso, you\u0027ll need to update the CinderRbdMultiConfig parameter description in all THT that reference it.","commit_id":"6c9e85c45a72cf547699a86e8b5fed060b57ee8e"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"722cef6374cec083c44d8eff0878bc7356eb664a","unresolved":true,"context_lines":[{"line_number":176,"context_line":"        CinderRbdExtraPools"},{"line_number":177,"context_line":"        CinderRbdAvailabilityZone"},{"line_number":178,"context_line":"        CinderRbdFlattenVolumeFromSnapshot"},{"line_number":179,"context_line":"        RbdStoreChunkSize"},{"line_number":180,"context_line":"  CephClusterFSID:"},{"line_number":181,"context_line":"    type: string"},{"line_number":182,"context_line":"    description: The Ceph cluster FSID. Must be a UUID."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c31d97f7_92b37f4b","line":179,"in_reply_to":"29ba2095_45e8e300","updated":"2022-01-13 16:33:05.000000000","message":"ack thanks","commit_id":"6c9e85c45a72cf547699a86e8b5fed060b57ee8e"}],"deployment/glance/glance-api-container-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"320a202482d155075962094b6634de9e4df7a47f","unresolved":true,"context_lines":[{"line_number":378,"context_line":"  RbdStoreChunkSize:"},{"line_number":379,"context_line":"    default: 8"},{"line_number":380,"context_line":"    description: \u003e"},{"line_number":381,"context_line":"      Chunk size, in megabytes, to use for RBD cloning operations."},{"line_number":382,"context_line":"    type: number"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"conditions:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1de87888_3f1f2403","line":381,"range":{"start_line":381,"start_character":32,"end_line":381,"end_character":65},"updated":"2022-01-13 15:49:00.000000000","message":"I don\u0027t believe this is accurate, because the chunk size pertains to all RBD objects. It\u0027s true the glance/cinder interop issue arose when cinder is cloning a glance image, but in cinder the same chunk size config option is used when creating a volume.\n\nLooking at their respective code, glance defaults to 8M and cinder to 4M, so this patch will override cinder\u0027s default value and cinder will use 8M for all RBD volumes. I\u0027m not suggesting this is a problem, just that this patch affects more than cloning operations.","commit_id":"6c9e85c45a72cf547699a86e8b5fed060b57ee8e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"81064494c8e2f46dde863fce153de6099f23155e","unresolved":true,"context_lines":[{"line_number":378,"context_line":"  RbdStoreChunkSize:"},{"line_number":379,"context_line":"    default: 8"},{"line_number":380,"context_line":"    description: \u003e"},{"line_number":381,"context_line":"      Chunk size, in megabytes, to use for RBD cloning operations."},{"line_number":382,"context_line":"    type: number"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"conditions:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9dc9a15b_bee11c69","line":381,"range":{"start_line":381,"start_character":32,"end_line":381,"end_character":65},"in_reply_to":"1aa6c859_27d91cf6","updated":"2022-01-13 16:46:31.000000000","message":"Yes, when cloning an RBD image, previously the rbd lib would ignore the caller\u0027s chunk size (cinder\u0027s is 4M) in favor of the parent image\u0027s chunk size (glance\u0027s is 8M). The cinder patch you referenced in the commit message [1] fixed cinder so that it passes the parent\u0027s chunk size (which is 8M) regardless of cinder\u0027s configured chunk size (4M).\n\n[1] https://review.opendev.org/c/openstack/cinder/+/804265\n\nThis patch would override both cinder\u0027s and glance\u0027s default chunk size. It won\u0027t directly impact glance, which already defaults to 8M, but it would override cinder\u0027s default value.","commit_id":"6c9e85c45a72cf547699a86e8b5fed060b57ee8e"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"722cef6374cec083c44d8eff0878bc7356eb664a","unresolved":true,"context_lines":[{"line_number":378,"context_line":"  RbdStoreChunkSize:"},{"line_number":379,"context_line":"    default: 8"},{"line_number":380,"context_line":"    description: \u003e"},{"line_number":381,"context_line":"      Chunk size, in megabytes, to use for RBD cloning operations."},{"line_number":382,"context_line":"    type: number"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"conditions:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1aa6c859_27d91cf6","line":381,"range":{"start_line":381,"start_character":32,"end_line":381,"end_character":65},"in_reply_to":"1de87888_3f1f2403","updated":"2022-01-13 16:33:05.000000000","message":"my understanding is that in previous versions the rbd library would ignore the value passed by the caller if the image chunk size did not match ... and use the image chunk size but as you pointed there might be other implications\n\nEric do you see any issue with this?","commit_id":"6c9e85c45a72cf547699a86e8b5fed060b57ee8e"}]}