)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"d52a8f936e761d26f32f487b732887c4fcfbf0cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"927ab5e1_b61b6bf2","updated":"2022-01-17 15:30:36.000000000","message":"Did some quick testing and Bogdan\u0027s suggestion is more elegant indeed. I\u0027m going to redo the patch modifying the script itself. \n\nThank you all for your comments","commit_id":"33e4e4594ec049253d3dfc93a17db96271b9724b"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"ca342deb74596cccf1ccaa75b3b4d4912146e885","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"833a9819_6130ce78","updated":"2022-01-17 10:50:03.000000000","message":"Tested it in a custom environment with good results (the undercloud upgrade failed, but at a later point)\n\n","commit_id":"33e4e4594ec049253d3dfc93a17db96271b9724b"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"06ea2b5a159500a36b4c37517e78f30c8da5dd50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e81cd2a7_f19fe4e2","updated":"2022-01-17 15:47:31.000000000","message":"Executing the script as it is (without passing OS_CLOUD):\n\nINFO:undercloud:Exporting network from stack qe-Cloud-0 to /home/stack/overcloud-deploy/qe-Cloud-0/tripleo-qe-Cloud-0-network-data.yaml\n/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\n  DeprecationWarning\nMissing value auth-url required for auth plugin password\nTraceback (most recent call last):\n  File \"/var/lib/tripleo-config/scripts/undercloud-upgrade-ephemeral-heat.py\", line 406, in \u003cmodule\u003e\n    main()\n  File \"/var/lib/tripleo-config/scripts/undercloud-upgrade-ephemeral-heat.py\", line 373, in main\n    export_networks(stack, stack_dir)\n  File \"/var/lib/tripleo-config/scripts/undercloud-upgrade-ephemeral-heat.py\", line 274, in export_networks\n    \u0027--yes\u0027])\n  File \"/usr/lib64/python3.6/subprocess.py\", line 311, in check_call\n    raise CalledProcessError(retcode, cmd)\nsubprocess.CalledProcessError: Command \u0027[\u0027openstack\u0027, \u0027overcloud\u0027, \u0027network\u0027, \u0027extract\u0027, \u0027--stack\u0027, \u0027qe-Cloud-0\u0027, \u0027--output\u0027, \u0027/home/stack/overcloud-deploy/qe-Cloud-0/tripleo-qe-Cloud-0-network-data.yaml\u0027, \u0027--yes\u0027]\u0027 returned non-zero exit status 1.\n~                                                                             \n\nExecuting the script with this patch modification:\n\nINFO:undercloud:Exporting network from stack qe-Cloud-0 to /home/stack/overcloud-deploy/qe-Cloud-0/tripleo-qe-Cloud-0-network-data.yaml\n/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\n  DeprecationWarning\n^M\nPLAY [Overcloud Network Extract Networks] **************************************\n2022-01-17 15:27:33.753554 | 5254008d-a1ec-1253-24eb-000000000008 |    SKIPPED | fail | localhost\n2022-01-17 15:27:33.754775 | 5254008d-a1ec-1253-24eb-000000000008 |     TIMING | fail | localhost | 0:00:00.079677 | 0.03s\n2022-01-17 15:27:33.792702 | 5254008d-a1ec-1253-24eb-000000000009 |    SKIPPED | fail | localhost\n2022-01-17 15:27:33.793965 | 5254008d-a1ec-1253-24eb-000000000009 |     TIMING | fail | localhost | 0:00:00.118864 | 0.04s\n2022-01-17 15:27:33.797104 | 5254008d-a1ec-1253-24eb-00000000000a |       TASK | Check if output file exists\n2022-01-17 15:27:34.143608 | 5254008d-a1ec-1253-24eb-00000000000a |         OK | Check if output file exists | localhost\n2022-01-17 15:27:34.145353 | 5254008d-a1ec-1253-24eb-00000000000a |     TIMING | Check if output file exists | localhost | 0:00:00.470256 | 0.35s\n2022-01-17 15:27:34.184314 | 5254008d-a1ec-1253-24eb-00000000000b |    SKIPPED | fail | localhost\n2022-01-17 15:27:34.185661 | 5254008d-a1ec-1253-24eb-00000000000b |     TIMING | fail | localhost | 0:00:00.510560 | 0.04s\n2022-01-17 15:27:34.189729 | 5254008d-a1ec-1253-24eb-00000000000d |       TASK | Get network data from overcloud stack\n2022-01-17 15:27:40.817432 | 5254008d-a1ec-1253-24eb-00000000000d |    CHANGED | Get network data from overcloud stack | localhost\n2022-01-17 15:27:40.819848 | 5254008d-a1ec-1253-24eb-00000000000d |     TIMING | Get network data from overcloud stack | localhost | 0:00:07.144752 | 6.63s\n2022-01-17 15:27:40.824244 | 5254008d-a1ec-1253-24eb-00000000000e |       TASK | Write network data to output file\n2022-01-17 15:27:41.364052 | 5254008d-a1ec-1253-24eb-00000000000e |      FATAL | Write network data to output file | localhost | error\u003d{\"changed\": false, \"checksum\": \"ab5838ff240befbbad5277f4d2774dfc9029d6b8\", \"msg\": \"Destination /home/stack/overcloud-deploy/qe-Cloud-0 not writable\"}\n2022-01-17 15:27:41.365542 | 5254008d-a1ec-1253-24eb-00000000000e |     TIMING | Write network data to output file | localhost | 0:00:07.690439 | 0.54s\n^M\nNO MORE HOSTS LEFT *************************************************************\n^M\nPLAY RECAP *********************************************************************\nlocalhost                  : ok\u003d2    changed\u003d1    unreachable\u003d0    failed\u003d1    skipped\u003d3    rescued\u003d0    ignored\u003d0\n2022-01-17 15:27:41.369193 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Summary Information ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n2022-01-17 15:27:41.369582 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Total Tasks: 6          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n2022-01-17 15:27:41.369973 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Elapsed Time: 0:00:07.694891 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n2022-01-17 15:27:41.370349 |                                 UUID |       Info |       Host |   Task Name |   Run Time\n2022-01-17 15:27:41.370752 | 5254008d-a1ec-1253-24eb-00000000000d |    SUMMARY |  localhost | Get network data from overcloud stack | 6.63s\n2022-01-17 15:27:41.371121 | 5254008d-a1ec-1253-24eb-00000000000e |    SUMMARY |  localhost | Write network data to output file | 0.54s\n2022-01-17 15:27:41.371496 | 5254008d-a1ec-1253-24eb-00000000000a |    SUMMARY |  localhost | Check if output file exists | 0.35s\n2022-01-17 15:27:41.371921 | 5254008d-a1ec-1253-24eb-00000000000b |    SUMMARY |  localhost | fail | 0.04s\n2022-01-17 15:27:41.372280 | 5254008d-a1ec-1253-24eb-000000000009 |    SUMMARY |  localhost | fail | 0.04s\n2022-01-17 15:27:41.372625 | 5254008d-a1ec-1253-24eb-000000000008 |    SUMMARY |  localhost | fail | 0.03s\n2022-01-17 15:27:41.372996 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ End Summary Information ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n2022-01-17 15:27:41.373392 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ State Information ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n2022-01-17 15:27:41.373783 | ~~~~~~~~~~~~~~~~~~ Number of nodes which did not deploy successfully: 1 ~~~~~~~~~~~~~~~~~\n2022-01-17 15:27:41.374130 |  The following node(s) had failures: localhost\n2022-01-17 15:27:41.374484 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\nAnsible execution failed. playbook: /usr/share/ansible/tripleo-playbooks/cli-overcloud-network-extract.yaml, Run Status: failed, Return Code: 2\nException occured while running the command\nTraceback (most recent call last):\n  File \"/usr/lib/python3.6/site-packages/tripleoclient/command.py\", line 34, in run\n    super(Command, self).run(parsed_args)\n  File \"/usr/lib/python3.6/site-packages/osc_lib/command/command.py\", line 39, in run\n    return super(Command, self).run(parsed_args)\n  File \"/usr/lib/python3.6/site-packages/cliff/command.py\", line 186, in run\n    return_code \u003d self.take_action(parsed_args) or 0\n  File \"/usr/lib/python3.6/site-packages/tripleoclient/v2/overcloud_network.py\", line 77, in take_action\n    extra_vars\u003dextra_vars,\n  File \"/usr/lib/python3.6/site-packages/tripleoclient/utils.py\", line 730, in run_ansible_playbook\n    raise RuntimeError(err_msg)\nRuntimeError: Ansible execution failed. playbook: /usr/share/ansible/tripleo-playbooks/cli-overcloud-network-extract.yaml, Run Status: failed, Return Code: 2\nAnsible execution failed. playbook: /usr/share/ansible/tripleo-playbooks/cli-overcloud-network-extract.yaml, Run Status: failed, Return Code: 2\nTraceback (most recent call last):\n  File \"/var/lib/tripleo-config/scripts/undercloud-upgrade-ephemeral-heat.py\", line 406, in \u003cmodule\u003e\n    main()\n  File \"/var/lib/tripleo-config/scripts/undercloud-upgrade-ephemeral-heat.py\", line 373, in main\n    export_networks(stack, stack_dir, args.cloud)\n  File \"/var/lib/tripleo-config/scripts/undercloud-upgrade-ephemeral-heat.py\", line 274, in export_networks\n    \u0027--yes\u0027], env\u003d{\u0027OS_CLOUD\u0027: cloud})\n  File \"/usr/lib64/python3.6/subprocess.py\", line 311, in check_call\n    raise CalledProcessError(retcode, cmd)\nsubprocess.CalledProcessError: Command \u0027[\u0027openstack\u0027, \u0027overcloud\u0027, \u0027network\u0027, \u0027extract\u0027, \u0027--stack\u0027, \u0027qe-Cloud-0\u0027, \u0027--output\u0027, \u0027/home/stack/overcloud-deploy/qe-Cloud-0/tripleo-qe-Cloud-0-network-data.yaml\u0027, \u0027--yes\u0027]\u0027 returned non-zero exit status 1.\n\n\nFails somewhere else, but this is another issue to deal with.","commit_id":"ed560e46cf629de31565b208f650b0285e81f735"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"5430a435a5cf780a0b8f57fa8609770ca7f931e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"487ddf95_1d70126b","updated":"2022-01-18 06:01:46.000000000","message":"c9 -https://bugs.launchpad.net/tripleo/+bug/1958202\nc8 - https://bugs.launchpad.net/tripleo/+bug/1958171\n\nwaiting till the bugs are fixed to rekick the patch","commit_id":"ed560e46cf629de31565b208f650b0285e81f735"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"6b4bab73c30a86e897efe59af398cdb698200b62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f13be06c_2d7ef54b","updated":"2022-01-18 14:44:14.000000000","message":"recheck\n\nc9 content provider seems to be passing again","commit_id":"ed560e46cf629de31565b208f650b0285e81f735"}],"deployment/heat/heat-ephemeral-container-ansible.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7cde51b03ffdfbc3c68eae81ae34489e08ce571b","unresolved":true,"context_lines":[{"line_number":127,"context_line":"                dest: /var/lib/tripleo-config/overcloud-stack-role-data-file-map.yaml"},{"line_number":128,"context_line":"                content: \"{{ role_data_file_map | to_nice_yaml }}\""},{"line_number":129,"context_line":"            - name: Run undercloud-upgrade-ephemeral-heat.py"},{"line_number":130,"context_line":"              shell: /var/lib/tripleo-config/scripts/undercloud-upgrade-ephemeral-heat.py"},{"line_number":131,"context_line":"              environment:"},{"line_number":132,"context_line":"                OS_CLOUD: undercloud"},{"line_number":133,"context_line":"              register: upgrade_ephemeral_result"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"cba412b3_0d2238e6","line":130,"updated":"2022-01-17 10:50:37.000000000","message":"could we place that into the script as well?","commit_id":"33e4e4594ec049253d3dfc93a17db96271b9724b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8fd04560797fb3dcccf04f803a3952c546b216d7","unresolved":true,"context_lines":[{"line_number":127,"context_line":"                dest: /var/lib/tripleo-config/overcloud-stack-role-data-file-map.yaml"},{"line_number":128,"context_line":"                content: \"{{ role_data_file_map | to_nice_yaml }}\""},{"line_number":129,"context_line":"            - name: Run undercloud-upgrade-ephemeral-heat.py"},{"line_number":130,"context_line":"              shell: /var/lib/tripleo-config/scripts/undercloud-upgrade-ephemeral-heat.py"},{"line_number":131,"context_line":"              environment:"},{"line_number":132,"context_line":"                OS_CLOUD: undercloud"},{"line_number":133,"context_line":"              register: upgrade_ephemeral_result"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f3609fc3_e0ce19c8","line":130,"in_reply_to":"cba412b3_0d2238e6","updated":"2022-01-17 14:52:59.000000000","message":"Yea we could probably just fix the script to set this when it does the `openstack` commands.  But I think it\u0027s ok to just do this here. If we expect this script to be run by an end user, having it as a cli param would be beneficial. But I think the script is specifically for our usage as part of upgrades?","commit_id":"33e4e4594ec049253d3dfc93a17db96271b9724b"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"c6ce1af091ccafb569c3565df3c878455af8e098","unresolved":true,"context_lines":[{"line_number":127,"context_line":"                dest: /var/lib/tripleo-config/overcloud-stack-role-data-file-map.yaml"},{"line_number":128,"context_line":"                content: \"{{ role_data_file_map | to_nice_yaml }}\""},{"line_number":129,"context_line":"            - name: Run undercloud-upgrade-ephemeral-heat.py"},{"line_number":130,"context_line":"              shell: /var/lib/tripleo-config/scripts/undercloud-upgrade-ephemeral-heat.py"},{"line_number":131,"context_line":"              environment:"},{"line_number":132,"context_line":"                OS_CLOUD: undercloud"},{"line_number":133,"context_line":"              register: upgrade_ephemeral_result"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"302a518d_d47df9c3","line":130,"in_reply_to":"f3609fc3_e0ce19c8","updated":"2022-01-17 15:02:43.000000000","message":"That\u0027s how I understand it too...although I could add it specifically too into any openstack issued in the script (in case the user invokes the script manually for debugging purposes)","commit_id":"33e4e4594ec049253d3dfc93a17db96271b9724b"}],"scripts/undercloud-upgrade-ephemeral-heat.py":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8ca6fa5b39cccbdf9e846429b5d48262ceb8ac8e","unresolved":true,"context_lines":[{"line_number":254,"context_line":"    os.chmod(passwords_path, 0o600)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"def export_networks(stack, stack_dir, cloud):"},{"line_number":258,"context_line":"    \"\"\"Export networks from an existing stack and write network data file."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    :param stack: Stack name to query for networks"}],"source_content_type":"text/x-python","patch_set":3,"id":"00108e08_057baea7","line":257,"updated":"2022-01-17 15:53:19.000000000","message":"don\u0027t we want to set a default \u0027undercloud\u0027 for it?","commit_id":"ed560e46cf629de31565b208f650b0285e81f735"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"43b25fa13fb7c0849a4aff56066d9707c3c8af6f","unresolved":true,"context_lines":[{"line_number":254,"context_line":"    os.chmod(passwords_path, 0o600)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"def export_networks(stack, stack_dir, cloud):"},{"line_number":258,"context_line":"    \"\"\"Export networks from an existing stack and write network data file."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    :param stack: Stack name to query for networks"}],"source_content_type":"text/x-python","patch_set":3,"id":"8bd3f68d_e71afc14","line":257,"in_reply_to":"00108e08_057baea7","updated":"2022-01-17 15:59:32.000000000","message":"yes, it\u0027s set already in line 45, that\u0027s why I didn\u0027t re-set it once more.","commit_id":"ed560e46cf629de31565b208f650b0285e81f735"}]}