)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"921bbc1b8f3eb95365feae509e1755b978857b0f","unresolved":true,"context_lines":[{"line_number":11,"context_line":"requirements to run puppet in containers, like fact cache, are used"},{"line_number":12,"context_line":"for these containers."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1958202"},{"line_number":15,"context_line":"Change-Id: I7d647afbf26ea11aff4d51cc3ea734881bf5cd32"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c9c9d304_8bdca445","line":14,"range":{"start_line":14,"start_character":12,"end_line":14,"end_character":20},"updated":"2022-01-19 11:46:03.000000000","message":"It should be https://bugs.launchpad.net/bugs/1958240","commit_id":"ccb31fe45bc2ea2d309a222262d44a2894bdf04a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cf9eaa6ab83a46a4c9e120fa00d20ff7a83bb57b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"requirements to run puppet in containers, like fact cache, are used"},{"line_number":12,"context_line":"for these containers."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1958202"},{"line_number":15,"context_line":"Change-Id: I7d647afbf26ea11aff4d51cc3ea734881bf5cd32"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5c0f78f6_e3b9e4b8","line":14,"range":{"start_line":14,"start_character":12,"end_line":14,"end_character":20},"in_reply_to":"c9c9d304_8bdca445","updated":"2022-01-26 13:40:53.000000000","message":"Done","commit_id":"ccb31fe45bc2ea2d309a222262d44a2894bdf04a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"964952bead434539b682b1eee1f47fcb8e0c682f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"04ecd2c5_403a1359","updated":"2022-01-18 14:41:02.000000000","message":"I\u0027ll check CI result tomorrow in my TZ so let me keep WIP until then.","commit_id":"6557c2460fd6eab051eacfa63fd86da9ce80eb92"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7992dddbca64f958b79d4cd6ab0ea70fb8c9fb94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9ca56e11_96b71e95","updated":"2022-01-23 13:36:13.000000000","message":"recheck","commit_id":"ce3836f71b314b7fc19398e9204bd781712fbbde"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"cb89eb0d926a56697cdbc9718f7bced281d56b76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a6b719b0_fe857e2a","updated":"2022-01-24 08:30:31.000000000","message":"recheck \n\n\n        * https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_5c6/825116/6/check/tripleo-ci-centos-8-scenario007-standalone/5c653f4/job-output.txt\n        * 2022-01-23 15:35:31.056149 | primary | fatal: [undercloud]: FAILED! \u003d\u003e {\"attempts\": 5, \"changed\": true, \"cmd\": \"set -e\\nping -c2 \\\"192.168.24.173\\\"\\n\", \"delta\": \"0:00:03.104951\", \"end\": \"2022-01-23 15:35:30.850695\", \"msg\": \"non-zero return code\", \"rc\": 1, \"start\": \"2022-01-23 15:35:27.745744\", \"stderr\": \"\", \"stderr_lines\": [], \"stdout\": \"PING 192.168.24.173 (192.168.24.173) 56(84) bytes of data.\\nFrom 192.168.24.1 icmp_seq\u003d1 Destination Host Unreachable\\nFrom 192.168.24.1 icmp_seq\u003d2 Destination Host Unreachable\\n\\n--- 192.168.24.173 ping statistics ---\\n2 packets transmitted, 0 received, +2 errors, 100% packet loss, time 1049ms\\npipe 2\", \"stdout_lines\": [\"PING 192.168.24.173 (192.168.24.173) 56(84) bytes of data.\", \"From 192.168.24.1 icmp_seq\u003d1 Destination Host Unreachable\", \"From 192.168.24.1 icmp_seq\u003d2 Destination Host Unreachable\", \"\", \"--- 192.168.24.173 ping statistics ---\", \"2 packets transmitted, 0 received, +2 errors, 100% packet loss, time 1049ms\", \"pipe 2\"]}\n\nhttps://zuul.opendev.org/t/openstack/builds?job_name\u003dtripleo-ci-centos-8-scenario007-standalone\n","commit_id":"ce3836f71b314b7fc19398e9204bd781712fbbde"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"25d402f4c385653781160c6e66b0efa39d3f0453","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"8283b569_f87397bb","updated":"2022-02-07 15:02:59.000000000","message":"recheck","commit_id":"0585fac14a60a1dedb2e6b40e95008d0d58e3086"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"99bef708d0b3d33129386741cbe7cfbc4aab3062","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"e8628009_2cb05385","updated":"2022-02-16 20:43:02.000000000","message":"wish we had a way to ci the mellanox changes","commit_id":"0585fac14a60a1dedb2e6b40e95008d0d58e3086"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4dd0b3c243aa13dcefaaddc1833c6868084a2e86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"29b67334_678ea110","updated":"2022-02-27 05:51:58.000000000","message":"recheck","commit_id":"c275d7870310fc6dc081855eca9d8e8e7c81545f"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"22ce884deb5d91a15624e69ed55083ebd44f2076","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"9e3a686b_e02b389a","updated":"2022-02-27 15:26:29.000000000","message":"recheck","commit_id":"c275d7870310fc6dc081855eca9d8e8e7c81545f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3654b4412d9a50691a739203f52fe2e8805dfd22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b8d8ca06_fe0403ca","updated":"2022-02-27 12:39:26.000000000","message":"recheck","commit_id":"c275d7870310fc6dc081855eca9d8e8e7c81545f"}],"deployment/neutron/neutron-agents-ib-config-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e020c549b8c489792661a1fe4e05ddf87b14f44e","unresolved":true,"context_lines":[{"line_number":87,"context_line":"        config_volume: \u0027neutron\u0027"},{"line_number":88,"context_line":"        puppet_tags: eswitchd_config,neutron_dhcp_agent_config,neutron_l3_agent_config,neutron_mlnx_agent_config"},{"line_number":89,"context_line":"        step_config: |"},{"line_number":90,"context_line":"          include tripleo::profile::base::neutron::agents::mlnx"},{"line_number":91,"context_line":"        config_image: {get_param: ContainerNeutronConfigImage}"},{"line_number":92,"context_line":"      docker_config: {}"},{"line_number":93,"context_line":"      metadata_settings:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"2bf700da_44126b29","line":90,"updated":"2022-01-26 13:24:01.000000000","message":"this changes the included manifest from neutron::agents::ml2::mlnx - another bug fix?","commit_id":"3c7b8c893ea2cb24459ff43b0e37ef0ca7b03d0e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4d1e15906a5711ac5d96a3a0209100e59472ea28","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        config_volume: \u0027neutron\u0027"},{"line_number":88,"context_line":"        puppet_tags: eswitchd_config,neutron_dhcp_agent_config,neutron_l3_agent_config,neutron_mlnx_agent_config"},{"line_number":89,"context_line":"        step_config: |"},{"line_number":90,"context_line":"          include tripleo::profile::base::neutron::agents::mlnx"},{"line_number":91,"context_line":"        config_image: {get_param: ContainerNeutronConfigImage}"},{"line_number":92,"context_line":"      docker_config: {}"},{"line_number":93,"context_line":"      metadata_settings:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"562efc23_45d86292","line":90,"in_reply_to":"0e3745fb_b464379a","updated":"2022-02-15 23:03:00.000000000","message":"Done","commit_id":"3c7b8c893ea2cb24459ff43b0e37ef0ca7b03d0e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b116bc5bbe0067b3b80d7ae9ab3f78f1545d3e04","unresolved":true,"context_lines":[{"line_number":87,"context_line":"        config_volume: \u0027neutron\u0027"},{"line_number":88,"context_line":"        puppet_tags: eswitchd_config,neutron_dhcp_agent_config,neutron_l3_agent_config,neutron_mlnx_agent_config"},{"line_number":89,"context_line":"        step_config: |"},{"line_number":90,"context_line":"          include tripleo::profile::base::neutron::agents::mlnx"},{"line_number":91,"context_line":"        config_image: {get_param: ContainerNeutronConfigImage}"},{"line_number":92,"context_line":"      docker_config: {}"},{"line_number":93,"context_line":"      metadata_settings:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"0e3745fb_b464379a","line":90,"in_reply_to":"2bf700da_44126b29","updated":"2022-01-26 13:38:54.000000000","message":"Possibly. The different this change would cause is that puppet ensures the /etc/neutron/plugins/mlnx directory and wipes out the /etc/neutron/plugins/mlnx/mlnx_conf.ini . I\u0027m not quite sure why it was introduced but it seems that code was added to ensure the plugin config file exists, then using this wrapper class globally instead of including the puppet-neutron class directly would make sense.","commit_id":"3c7b8c893ea2cb24459ff43b0e37ef0ca7b03d0e"}],"deployment/neutron/neutron-ovs-agent-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"964952bead434539b682b1eee1f47fcb8e0c682f","unresolved":true,"context_lines":[{"line_number":311,"context_line":"                PYTHON: {get_param: PythonInterpreter}"},{"line_number":312,"context_line":"      container_puppet_tasks:"},{"line_number":313,"context_line":"        # Create the required ovs bridge before starting up services."},{"line_number":314,"context_line":"        step_2:"},{"line_number":315,"context_line":"          puppet_tags: neutron::plugins::ovs::bridge,vs_config"},{"line_number":316,"context_line":"          step_config: |"},{"line_number":317,"context_line":"            include neutron::agents::ml2::ovs"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"98198b84_019e2bd3","line":314,"range":{"start_line":314,"start_character":8,"end_line":314,"end_character":14},"updated":"2022-01-18 14:41:02.000000000","message":"We can revert this to the existing step_3 because the only requirement here is to run this before neutron_ovs_agent which is started on step_4.","commit_id":"6557c2460fd6eab051eacfa63fd86da9ce80eb92"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cf9eaa6ab83a46a4c9e120fa00d20ff7a83bb57b","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                PYTHON: {get_param: PythonInterpreter}"},{"line_number":312,"context_line":"      container_puppet_tasks:"},{"line_number":313,"context_line":"        # Create the required ovs bridge before starting up services."},{"line_number":314,"context_line":"        step_2:"},{"line_number":315,"context_line":"          puppet_tags: neutron::plugins::ovs::bridge,vs_config"},{"line_number":316,"context_line":"          step_config: |"},{"line_number":317,"context_line":"            include neutron::agents::ml2::ovs"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"575b50c9_43a748e4","line":314,"range":{"start_line":314,"start_character":8,"end_line":314,"end_character":14},"in_reply_to":"98198b84_019e2bd3","updated":"2022-01-26 13:40:53.000000000","message":"Done","commit_id":"6557c2460fd6eab051eacfa63fd86da9ce80eb92"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"964952bead434539b682b1eee1f47fcb8e0c682f","unresolved":false,"context_lines":[{"line_number":312,"context_line":"      container_puppet_tasks:"},{"line_number":313,"context_line":"        # Create the required ovs bridge before starting up services."},{"line_number":314,"context_line":"        step_2:"},{"line_number":315,"context_line":"          puppet_tags: neutron::plugins::ovs::bridge,vs_config"},{"line_number":316,"context_line":"          step_config: |"},{"line_number":317,"context_line":"            include neutron::agents::ml2::ovs"},{"line_number":318,"context_line":"          volumes:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5bc4d32a_b53fb362","line":315,"range":{"start_line":315,"start_character":23,"end_line":315,"end_character":62},"updated":"2022-01-18 14:41:02.000000000","message":"IIRC what we need is to create bridges (which are defined in neutron::plugins::ovs::bridge) and set other-config stuff by vs_config so I removed the other tags.","commit_id":"6557c2460fd6eab051eacfa63fd86da9ce80eb92"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cf9eaa6ab83a46a4c9e120fa00d20ff7a83bb57b","unresolved":false,"context_lines":[{"line_number":312,"context_line":"      container_puppet_tasks:"},{"line_number":313,"context_line":"        # Create the required ovs bridge before starting up services."},{"line_number":314,"context_line":"        step_2:"},{"line_number":315,"context_line":"          puppet_tags: neutron::plugins::ovs::bridge,vs_config"},{"line_number":316,"context_line":"          step_config: |"},{"line_number":317,"context_line":"            include neutron::agents::ml2::ovs"},{"line_number":318,"context_line":"          volumes:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"53866e0b_028a61df","line":315,"range":{"start_line":315,"start_character":23,"end_line":315,"end_character":62},"in_reply_to":"4beb3d62_328ef9df","updated":"2022-01-26 13:40:53.000000000","message":"It seems we can\u0027t use pid: host in puppet_config. IMO we should revisit this later to see whether we can implement this as a host task, but I\u0027ll leave it now.","commit_id":"6557c2460fd6eab051eacfa63fd86da9ce80eb92"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"89ad806eca3d2d42af24340eca2385fbb853dc93","unresolved":true,"context_lines":[{"line_number":312,"context_line":"      container_puppet_tasks:"},{"line_number":313,"context_line":"        # Create the required ovs bridge before starting up services."},{"line_number":314,"context_line":"        step_2:"},{"line_number":315,"context_line":"          puppet_tags: neutron::plugins::ovs::bridge,vs_config"},{"line_number":316,"context_line":"          step_config: |"},{"line_number":317,"context_line":"            include neutron::agents::ml2::ovs"},{"line_number":318,"context_line":"          volumes:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4beb3d62_328ef9df","line":315,"range":{"start_line":315,"start_character":23,"end_line":315,"end_character":62},"in_reply_to":"5bc4d32a_b53fb362","updated":"2022-01-19 02:53:29.000000000","message":"Or can we just merge this to puppet_config ?","commit_id":"6557c2460fd6eab051eacfa63fd86da9ce80eb92"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"c9f14c990223f07a3dfe1d19029f9397a23984bc","unresolved":true,"context_lines":[{"line_number":309,"context_line":"                --log-file\u003d/var/log/neutron/openvswitch-agent.log"},{"line_number":310,"context_line":"              params:"},{"line_number":311,"context_line":"                PYTHON: {get_param: PythonInterpreter}"},{"line_number":312,"context_line":"      container_puppet_tasks:"},{"line_number":313,"context_line":"        # Create ovs bridges before starting up ovs-agent."},{"line_number":314,"context_line":"        step_3:"},{"line_number":315,"context_line":"          config_volume: neutron_ovs_bridge"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"cb0291f1_fac502e3","line":312,"updated":"2022-01-27 12:59:52.000000000","message":"Trying to recall .. does container_puppet_tasks only run on the bootstrap node?","commit_id":"3c7b8c893ea2cb24459ff43b0e37ef0ca7b03d0e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"613a2c0e40cb951f117a9348596a1ddee8c23e9d","unresolved":true,"context_lines":[{"line_number":309,"context_line":"                --log-file\u003d/var/log/neutron/openvswitch-agent.log"},{"line_number":310,"context_line":"              params:"},{"line_number":311,"context_line":"                PYTHON: {get_param: PythonInterpreter}"},{"line_number":312,"context_line":"      container_puppet_tasks:"},{"line_number":313,"context_line":"        # Create ovs bridges before starting up ovs-agent."},{"line_number":314,"context_line":"        step_3:"},{"line_number":315,"context_line":"          config_volume: neutron_ovs_bridge"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"f246b609_179d429c","line":312,"in_reply_to":"461a480b_e4de8462","updated":"2022-01-27 13:25:39.000000000","message":"Hmm... I could not find the corresponding implementation but I see the logic to intend that in trains at least. Let me revisit this. Another option is to run this at host level, which looks much more simple IMO.","commit_id":"3c7b8c893ea2cb24459ff43b0e37ef0ca7b03d0e"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"6501a1189819796e005618f036fc477162cbf5c7","unresolved":true,"context_lines":[{"line_number":309,"context_line":"                --log-file\u003d/var/log/neutron/openvswitch-agent.log"},{"line_number":310,"context_line":"              params:"},{"line_number":311,"context_line":"                PYTHON: {get_param: PythonInterpreter}"},{"line_number":312,"context_line":"      container_puppet_tasks:"},{"line_number":313,"context_line":"        # Create ovs bridges before starting up ovs-agent."},{"line_number":314,"context_line":"        step_3:"},{"line_number":315,"context_line":"          config_volume: neutron_ovs_bridge"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"461a480b_e4de8462","line":312,"in_reply_to":"cb0291f1_fac502e3","updated":"2022-01-27 13:01:01.000000000","message":"... assuming its analogous to the docker_puppet_tasks of old, see https://slagle.fedorapeople.org/tripleo-docs/containers_deployment/architecture.html","commit_id":"3c7b8c893ea2cb24459ff43b0e37ef0ca7b03d0e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4d1e15906a5711ac5d96a3a0209100e59472ea28","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                --log-file\u003d/var/log/neutron/openvswitch-agent.log"},{"line_number":310,"context_line":"              params:"},{"line_number":311,"context_line":"                PYTHON: {get_param: PythonInterpreter}"},{"line_number":312,"context_line":"      container_puppet_tasks:"},{"line_number":313,"context_line":"        # Create ovs bridges before starting up ovs-agent."},{"line_number":314,"context_line":"        step_3:"},{"line_number":315,"context_line":"          config_volume: neutron_ovs_bridge"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"02147a7e_e671909b","line":312,"in_reply_to":"f246b609_179d429c","updated":"2022-02-15 23:03:00.000000000","message":"Done","commit_id":"3c7b8c893ea2cb24459ff43b0e37ef0ca7b03d0e"}]}