)]}'
{"deployment/kernel/kernel-baremetal-ansible.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"cfd3362a95775d25392a7a10a2f9d3ac4ed1a06d","unresolved":true,"context_lines":[{"line_number":203,"context_line":"                    - is_inotify_intances_max_default"},{"line_number":204,"context_line":"                    - {get_param: InotifyInstancesMax}"},{"line_number":205,"context_line":"                    - {get_param: InotifyIntancesMax}"},{"line_number":206,"context_line":"            - {get_attr: [RoleParametersValue, value, extra_sysctl_settings]}"},{"line_number":207,"context_line":"            - if:"},{"line_number":208,"context_line":"                - fs_aio_max_number_set"},{"line_number":209,"context_line":"                - fs.aio-max-nr:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"692b3495_660cd97e","line":206,"range":{"start_line":206,"start_character":54,"end_line":206,"end_character":75},"updated":"2022-01-18 15:32:14.000000000","message":"uncertain if we need an extra parameter, wouldn\u0027t just using that for compute-like roles be sufficient?","commit_id":"e2eb17db24871e83f49e5094006c864a0a932471"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"df9233bc31d1738cebbf6255490d7d980c8d2a74","unresolved":true,"context_lines":[{"line_number":203,"context_line":"                    - is_inotify_intances_max_default"},{"line_number":204,"context_line":"                    - {get_param: InotifyInstancesMax}"},{"line_number":205,"context_line":"                    - {get_param: InotifyIntancesMax}"},{"line_number":206,"context_line":"            - {get_attr: [RoleParametersValue, value, extra_sysctl_settings]}"},{"line_number":207,"context_line":"            - if:"},{"line_number":208,"context_line":"                - fs_aio_max_number_set"},{"line_number":209,"context_line":"                - fs.aio-max-nr:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"aec2cbc1_29b0b8f3","line":206,"range":{"start_line":206,"start_character":54,"end_line":206,"end_character":75},"in_reply_to":"692b3495_660cd97e","updated":"2022-01-18 18:38:13.000000000","message":"I\u0027m afraid that if an operator defines it, it would override it. Also, I\u0027m not sure how to access and merge it from the nova-libvirt side.","commit_id":"e2eb17db24871e83f49e5094006c864a0a932471"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"a648ecff4c9ba804eebf8ee96bcebb06c9d04896","unresolved":true,"context_lines":[{"line_number":207,"context_line":"            - if:"},{"line_number":208,"context_line":"                - fs_aio_max_number_set"},{"line_number":209,"context_line":"                - fs.aio-max-nr:"},{"line_number":210,"context_line":"                    value: {get_attr: [RoleParametersValue, value, fs_aio_max_number]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"29ccf68c_f45258d4","line":210,"range":{"start_line":210,"start_character":67,"end_line":210,"end_character":84},"updated":"2022-01-19 05:32:35.000000000","message":"This key is not in RoleParameterValue, how do you expect to get it here?","commit_id":"e2eb17db24871e83f49e5094006c864a0a932471"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"87c7feb4c141ebc1c4702d236ad01ed3e571453c","unresolved":false,"context_lines":[{"line_number":159,"context_line":"          - values:"},{"line_number":160,"context_line":"              ExtraKernelModules: {get_param: ExtraKernelModules}"},{"line_number":161,"context_line":"              ExtraKernelPackages: {get_param: ExtraKernelPackages}"},{"line_number":162,"context_line":"              ExtraSysctlSettings: {get_param: ExtraSysctlSettings}"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"outputs:"},{"line_number":165,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"36b8d706_0aeb4fcd","line":162,"updated":"2022-01-24 19:26:32.000000000","message":"I think you need to add FsAioMaxNumber here","commit_id":"8dd03011cef8561fb96580051b9b69cdf057c352"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"2e34d2ba13c65ff72a3813f854e590465c8c4005","unresolved":false,"context_lines":[{"line_number":159,"context_line":"          - values:"},{"line_number":160,"context_line":"              ExtraKernelModules: {get_param: ExtraKernelModules}"},{"line_number":161,"context_line":"              ExtraKernelPackages: {get_param: ExtraKernelPackages}"},{"line_number":162,"context_line":"              ExtraSysctlSettings: {get_param: ExtraSysctlSettings}"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"outputs:"},{"line_number":165,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8bd12814_d069b61a","line":162,"in_reply_to":"36b8d706_0aeb4fcd","updated":"2022-01-24 22:17:07.000000000","message":"Thanks for chiming in, it worked in my lab without this and replicated this method from templates we have in nova. The failure is because I forgot to rollback the change in nova-libvirt-common where I initially tried to put it. I just tested it and both methot are working, I\u0027ll use the one you proposed as to respect the standard of this template.","commit_id":"8dd03011cef8561fb96580051b9b69cdf057c352"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"b2d8b00080a1206c2050087e2da7c808f145d63a","unresolved":true,"context_lines":[{"line_number":161,"context_line":"              ExtraKernelModules: {get_param: ExtraKernelModules}"},{"line_number":162,"context_line":"              ExtraKernelPackages: {get_param: ExtraKernelPackages}"},{"line_number":163,"context_line":"              ExtraSysctlSettings: {get_param: ExtraSysctlSettings}"},{"line_number":164,"context_line":"              FsAioMaxNumber: {param: FsAioMaxNumber}"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"outputs:"},{"line_number":167,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"12205b84_4c2cda47","line":164,"updated":"2022-01-27 08:40:26.000000000","message":"The merging via RoleParmetersValue is required only when we want to honor both role-specific and global definition. As per the condition above ``fs_aio_max_number_set``, it is expected to have only role-specific. In which case, this merging can be removed and at line #225, change RoleParametersValue to RoleParameters.","commit_id":"9e7e5d0ba68610d88623e7cf3fd28f2f6ed26758"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"b2d8b00080a1206c2050087e2da7c808f145d63a","unresolved":true,"context_lines":[{"line_number":222,"context_line":"            - if:"},{"line_number":223,"context_line":"                - fs_aio_max_number_set"},{"line_number":224,"context_line":"                - fs.aio-max-nr:"},{"line_number":225,"context_line":"                    value: {get_param: [RoleParametersValue, value, fs_aio_max_number]}"},{"line_number":226,"context_line":"            - {get_attr: [RoleParametersValue, value, extra_sysctl_settings]}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"72f6e9c8_c14c69d8","line":225,"updated":"2022-01-27 08:40:26.000000000","message":"RoleParametersValue is a resource, need to use get_attr. Instead change RoleParametersValue to RoleParameters and retain get_param (and remove value).","commit_id":"9e7e5d0ba68610d88623e7cf3fd28f2f6ed26758"}]}