)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"749fdcb9be7a3a40865a591de8073089de5efb60","unresolved":true,"context_lines":[{"line_number":24,"context_line":"Depends-On: I93cded61ffb862e99fd8043dbf0def3d16079692"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I3309f2a0e39ad115930ecd5c0e895816565819e9"},{"line_number":27,"context_line":"(cherry picked from commit 5d830980ec842c6093a8fd44ef922014bcadf693)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"38fd3e12_edf21c62","line":27,"range":{"start_line":27,"start_character":1,"end_line":27,"end_character":7},"updated":"2022-01-20 08:04:44.000000000","message":"looks OK but the commit message on Wallaby is different \n\nI see https://review.opendev.org/q/5d830980ec842c6093a8fd44ef922014bcadf693 and also https://review.opendev.org/q/efc328c66898bfc09c5dcb00fe5f584a45b899ff \n\nrelated inline question about the flatten() do we need it?","commit_id":"f5a4bc56fac5ddfe3091b490bc5b57a4c59738ae"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e229c0a759ff69dc8357172c11f6b90d7b306a37","unresolved":true,"context_lines":[{"line_number":24,"context_line":"Depends-On: I93cded61ffb862e99fd8043dbf0def3d16079692"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I3309f2a0e39ad115930ecd5c0e895816565819e9"},{"line_number":27,"context_line":"(cherry picked from commit 5d830980ec842c6093a8fd44ef922014bcadf693)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ab0b7d13_30aa8c42","line":27,"range":{"start_line":27,"start_character":1,"end_line":27,"end_character":7},"in_reply_to":"38fd3e12_edf21c62","updated":"2022-01-20 14:11:42.000000000","message":"In Wallaby I squeshed two commits from master into one.\nI should do the same for all the other stable branches.","commit_id":"f5a4bc56fac5ddfe3091b490bc5b57a4c59738ae"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5b990c0e2de30d1308d5bb26a369d19ba2823bde","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Related RHBZ#1875962"},{"line_number":32,"context_line":"Closes-bug: #1950528"},{"line_number":33,"context_line":"Depends-On: I93cded61ffb862e99fd8043dbf0def3d16079692"},{"line_number":34,"context_line":"Change-Id: I3309f2a0e39ad115930ecd5c0e895816565819e9"},{"line_number":35,"context_line":"(cherry picked from commit efc328c66898bfc09c5dcb00fe5f584a45b899ff)"},{"line_number":36,"context_line":"(cherry picked from commit 5d830980ec842c6093a8fd44ef922014bcadf693)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"973bdebd_681458c1","line":33,"updated":"2022-01-24 19:13:39.000000000","message":"since this is a change id, we have to wait for V-\u003eT backports of that change to land before this can. You might consider switching to a change url instead.","commit_id":"dfb58fd851e301e1eb8e31d93c6ffbbda2123c94"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"2a4fb07760a3902ccae204fdbefdd9c984ecd095","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Related RHBZ#1875962"},{"line_number":32,"context_line":"Closes-bug: #1950528"},{"line_number":33,"context_line":"Depends-On: I93cded61ffb862e99fd8043dbf0def3d16079692"},{"line_number":34,"context_line":"Change-Id: I3309f2a0e39ad115930ecd5c0e895816565819e9"},{"line_number":35,"context_line":"(cherry picked from commit efc328c66898bfc09c5dcb00fe5f584a45b899ff)"},{"line_number":36,"context_line":"(cherry picked from commit 5d830980ec842c6093a8fd44ef922014bcadf693)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"eeb53d7e_e4a694cd","line":33,"in_reply_to":"973bdebd_681458c1","updated":"2022-01-24 22:35:36.000000000","message":"DONE.","commit_id":"dfb58fd851e301e1eb8e31d93c6ffbbda2123c94"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"3758fa87218df15b17bbfd19fa4aaf2ff0d5c8b9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ffe9e21a_454ef5c3","line":37,"updated":"2022-01-20 21:07:19.000000000","message":"missing:\n(cherry picked from commit a266b5a9487fcadee04ec462feaf9b54a6aea4d9)","commit_id":"dfb58fd851e301e1eb8e31d93c6ffbbda2123c94"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fece625f0ed10b4811268a8fb37a235e2987c793","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d4e01c4f_c03a95a7","line":37,"in_reply_to":"32a00f99_7df560b5","updated":"2022-01-21 07:53:48.000000000","message":"there is already a cherry pick from in the commit msg (two of them infact ;))\n\neg https://review.opendev.org/q/efc328c66898bfc09c5dcb00fe5f584a45b899ff\n\nseems to point to the right thing","commit_id":"dfb58fd851e301e1eb8e31d93c6ffbbda2123c94"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"95dbcdaf739e3b006dbf95fa76849d3148bdfda0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dbc4a55f_820a1594","line":37,"in_reply_to":"d4e01c4f_c03a95a7","updated":"2022-01-25 17:57:48.000000000","message":"Sorry, I missed your replies on this topic.\nWhen you do a cherry-pick on victoria, you should get it directly from wallaby, and wallaby commit message (that already has 2 ref to other commits) is copied, and the commit-id from wallaby (a266b5a94) is appended underneath the new commit msg.\nBut that is not a mandatory rule in lot of openstack repos.","commit_id":"dfb58fd851e301e1eb8e31d93c6ffbbda2123c94"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"aabae09864cfe74ef8aa4a02917be4232eed2d04","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"32a00f99_7df560b5","line":37,"in_reply_to":"ffe9e21a_454ef5c3","updated":"2022-01-20 23:17:49.000000000","message":"That is the commit ID for the stable/wallaby?\n I don\u0027t think that is required.","commit_id":"dfb58fd851e301e1eb8e31d93c6ffbbda2123c94"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"3758fa87218df15b17bbfd19fa4aaf2ff0d5c8b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"68a0c380_e65ec6d1","updated":"2022-01-20 21:07:19.000000000","message":"Clean cherry-pick. Not sure if cherry-picks on commit message are mandatory in this repo.","commit_id":"dfb58fd851e301e1eb8e31d93c6ffbbda2123c94"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fece625f0ed10b4811268a8fb37a235e2987c793","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"616133c1_97e15244","updated":"2022-01-21 07:53:48.000000000","message":"looks good","commit_id":"dfb58fd851e301e1eb8e31d93c6ffbbda2123c94"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"95dbcdaf739e3b006dbf95fa76849d3148bdfda0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"884da351_175e3d58","updated":"2022-01-25 17:57:48.000000000","message":"late +1 just to follow up. Thanks","commit_id":"a61368ff2814aa4281055deca4fa5a6515cbc308"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b74d6e8d98e076483effae853c94c3ce0c569814","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5eb6a63c_71ec1a31","updated":"2022-01-25 07:51:51.000000000","message":"re-adding vote only commit message updated since last visit","commit_id":"a61368ff2814aa4281055deca4fa5a6515cbc308"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a4fd2422659cc5e1efc6c94d44e9d474a815be0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3606ed0e_99ebe8e4","updated":"2022-01-26 05:52:03.000000000","message":"recheck","commit_id":"a61368ff2814aa4281055deca4fa5a6515cbc308"}],"overcloud.j2.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"749fdcb9be7a3a40865a591de8073089de5efb60","unresolved":true,"context_lines":[{"line_number":1300,"context_line":"{%- for role in roles %}"},{"line_number":1301,"context_line":"        {{role.name}}:"},{"line_number":1302,"context_line":"          yaql:"},{"line_number":1303,"context_line":"            expression: list($.data.where($ !\u003d null))"},{"line_number":1304,"context_line":"            data:"},{"line_number":1305,"context_line":"              - {get_attr: [Networks, net_attributes_map, ctlplane, subnets, {get_param: {{role.name}}ControlPlaneSubnet}, gateway_ip]}"},{"line_number":1306,"context_line":"    {%- for network in networks %}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f000a767_1c5799bc","line":1303,"range":{"start_line":1303,"start_character":52,"end_line":1303,"end_character":53},"updated":"2022-01-20 08:04:44.000000000","message":"do we need the flatten() here from https://review.opendev.org/c/openstack/tripleo-heat-templates/+/817774/1/overcloud.j2.yaml#b1200 ?","commit_id":"f5a4bc56fac5ddfe3091b490bc5b57a4c59738ae"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e229c0a759ff69dc8357172c11f6b90d7b306a37","unresolved":true,"context_lines":[{"line_number":1300,"context_line":"{%- for role in roles %}"},{"line_number":1301,"context_line":"        {{role.name}}:"},{"line_number":1302,"context_line":"          yaql:"},{"line_number":1303,"context_line":"            expression: list($.data.where($ !\u003d null))"},{"line_number":1304,"context_line":"            data:"},{"line_number":1305,"context_line":"              - {get_attr: [Networks, net_attributes_map, ctlplane, subnets, {get_param: {{role.name}}ControlPlaneSubnet}, gateway_ip]}"},{"line_number":1306,"context_line":"    {%- for network in networks %}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4172ae67_c39d5840","line":1303,"range":{"start_line":1303,"start_character":52,"end_line":1303,"end_character":53},"in_reply_to":"f000a767_1c5799bc","updated":"2022-01-20 14:11:42.000000000","message":"oh, yes we do need .flatten(). Great catch, thanks Marios!","commit_id":"f5a4bc56fac5ddfe3091b490bc5b57a4c59738ae"}]}