)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"0620e2849a68eb7d45a89afd059271b1cbc2ddf9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c60a6e54_1a539cf3","updated":"2022-02-01 20:30:05.000000000","message":"wrong version of patch...","commit_id":"2b3b1d1674b2678c2fc8a7a850582376e2cb9bd5"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"691f14ad2a201608f91440bf5ea9adb9d973e4a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"af3a9b83_dea16386","updated":"2022-02-02 15:10:34.000000000","message":"recheck","commit_id":"63af777fad0c3b134f96a32411fa7900e25b4fcf"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"300b6c35f0d11471ce68fee83d69cbe2009f7af6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"908cef98_4cb5bbcd","updated":"2022-02-04 14:25:13.000000000","message":"recheck - unrelated failure","commit_id":"63af777fad0c3b134f96a32411fa7900e25b4fcf"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"3b4ac5bd014af6ec631bf04a1e71bf7b473f8c3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"31e24842_32742ee6","updated":"2022-02-11 10:34:16.000000000","message":"I would like Sergii to vote, as he was the one requesting the latest update.","commit_id":"bfbf6be363648b36f5bd6abab32b73f175be2f60"}],"deployment/ceph-ansible/ceph-osd.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6cb889d227ced51acdac13ab59c5e98335af7ab9","unresolved":true,"context_lines":[{"line_number":147,"context_line":"                    {{ container_client }}"},{"line_number":148,"context_line":"                when: not tripleo_ceph_paused_stat.stat.exists|bool"},{"line_number":149,"context_line":"                register: ceph_paused"},{"line_number":150,"context_line":"              - name: Create ceph flag file"},{"line_number":151,"context_line":"                file:"},{"line_number":152,"context_line":"                  path: \"/var/lib/tripleo/ceph_paused\""},{"line_number":153,"context_line":"                  state: touch"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a70f6a87_edc0a714","line":150,"range":{"start_line":150,"start_character":14,"end_line":150,"end_character":43},"updated":"2022-01-21 14:25:40.000000000","message":"Do we need to \u0027become\u0027 here?","commit_id":"9a70462a99d7f85769ac8422501d48062b2442ac"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3deea960098128a748931807bf6c5351bcb65c33","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                    {{ container_client }}"},{"line_number":148,"context_line":"                when: not tripleo_ceph_paused_stat.stat.exists|bool"},{"line_number":149,"context_line":"                register: ceph_paused"},{"line_number":150,"context_line":"              - name: Create ceph flag file"},{"line_number":151,"context_line":"                file:"},{"line_number":152,"context_line":"                  path: \"/var/lib/tripleo/ceph_paused\""},{"line_number":153,"context_line":"                  state: touch"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"831a46b3_1f15700d","line":150,"range":{"start_line":150,"start_character":14,"end_line":150,"end_character":43},"in_reply_to":"a70f6a87_edc0a714","updated":"2022-01-28 11:11:18.000000000","message":"Done","commit_id":"9a70462a99d7f85769ac8422501d48062b2442ac"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"7f465ceeb93748e0e69e6b62147b2e1afa7683d5","unresolved":true,"context_lines":[{"line_number":154,"context_line":"                  state: touch"},{"line_number":155,"context_line":"                when:"},{"line_number":156,"context_line":"                  - not tripleo_ceph_paused_stat.stat.exists|bool"},{"line_number":157,"context_line":"                  - ceph_paused is success"},{"line_number":158,"context_line":"            delegate_to: \"{{ ceph_mon_short_bootstrap_node_name }}\""},{"line_number":159,"context_line":"            vars:"},{"line_number":160,"context_line":"              allinone_upgrade: {get_param: AllInOneUpgrade}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"67c31eae_c1cc39cc","line":157,"updated":"2022-01-28 12:09:05.000000000","message":"I wonder what would happen if /var/lib/tripleo/ceph_paused existed, then the task that registers ceph_paused won\u0027t be executed, therefore ceph_paused won\u0027t even exist. And later on, we jump into the \"Create ceph flag file\" task with a non-existent ceph_paused variable...not sure if Ansible will cry out there. @Lukas have you tried that code path?","commit_id":"63d28f02fd366ecdaaf7ae26aa035a192be208d8"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"e859dde0cf2e3b6ba52d96013f371b8b72edfe4a","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                  state: touch"},{"line_number":155,"context_line":"                when:"},{"line_number":156,"context_line":"                  - not tripleo_ceph_paused_stat.stat.exists|bool"},{"line_number":157,"context_line":"                  - ceph_paused is success"},{"line_number":158,"context_line":"            delegate_to: \"{{ ceph_mon_short_bootstrap_node_name }}\""},{"line_number":159,"context_line":"            vars:"},{"line_number":160,"context_line":"              allinone_upgrade: {get_param: AllInOneUpgrade}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"160301f8_9bb9a34e","line":157,"in_reply_to":"1753e75d_779035fa","updated":"2022-02-11 10:27:13.000000000","message":"Done","commit_id":"63d28f02fd366ecdaaf7ae26aa035a192be208d8"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"9f7c781db6c19ef88ae9292f346e391098e5a62f","unresolved":true,"context_lines":[{"line_number":154,"context_line":"                  state: touch"},{"line_number":155,"context_line":"                when:"},{"line_number":156,"context_line":"                  - not tripleo_ceph_paused_stat.stat.exists|bool"},{"line_number":157,"context_line":"                  - ceph_paused is success"},{"line_number":158,"context_line":"            delegate_to: \"{{ ceph_mon_short_bootstrap_node_name }}\""},{"line_number":159,"context_line":"            vars:"},{"line_number":160,"context_line":"              allinone_upgrade: {get_param: AllInOneUpgrade}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f938521d_ac49e747","line":157,"in_reply_to":"67c31eae_c1cc39cc","updated":"2022-01-28 12:11:15.000000000","message":"ceph_paused would be registered as skipped in that case, so the register is still there","commit_id":"63d28f02fd366ecdaaf7ae26aa035a192be208d8"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"18a9f9efaf6d2db5d7c4689df8e867376de68a06","unresolved":true,"context_lines":[{"line_number":154,"context_line":"                  state: touch"},{"line_number":155,"context_line":"                when:"},{"line_number":156,"context_line":"                  - not tripleo_ceph_paused_stat.stat.exists|bool"},{"line_number":157,"context_line":"                  - ceph_paused is success"},{"line_number":158,"context_line":"            delegate_to: \"{{ ceph_mon_short_bootstrap_node_name }}\""},{"line_number":159,"context_line":"            vars:"},{"line_number":160,"context_line":"              allinone_upgrade: {get_param: AllInOneUpgrade}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"cb53fb1c_d55a0bb1","line":157,"in_reply_to":"b71a6c06_78d5894c","updated":"2022-02-01 19:49:56.000000000","message":"If ceph_paused exists ceph was already paused as it\u0027s created right after the success of pausing. If there was a failure it most likely is still paused and at the same time ceph is probably no longer reachable.","commit_id":"63d28f02fd366ecdaaf7ae26aa035a192be208d8"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"7156e9d4f05e52763122cba16178dbae41bf4803","unresolved":true,"context_lines":[{"line_number":154,"context_line":"                  state: touch"},{"line_number":155,"context_line":"                when:"},{"line_number":156,"context_line":"                  - not tripleo_ceph_paused_stat.stat.exists|bool"},{"line_number":157,"context_line":"                  - ceph_paused is success"},{"line_number":158,"context_line":"            delegate_to: \"{{ ceph_mon_short_bootstrap_node_name }}\""},{"line_number":159,"context_line":"            vars:"},{"line_number":160,"context_line":"              allinone_upgrade: {get_param: AllInOneUpgrade}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1753e75d_779035fa","line":157,"in_reply_to":"cb53fb1c_d55a0bb1","updated":"2022-02-07 18:49:48.000000000","message":"However, there should be documentation to delete /var/lib/tripleo/ceph_paused if it\u0027s present","commit_id":"63d28f02fd366ecdaaf7ae26aa035a192be208d8"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"b7a4271e0f8383b270c0a1495cfe571213e68e7d","unresolved":true,"context_lines":[{"line_number":154,"context_line":"                  state: touch"},{"line_number":155,"context_line":"                when:"},{"line_number":156,"context_line":"                  - not tripleo_ceph_paused_stat.stat.exists|bool"},{"line_number":157,"context_line":"                  - ceph_paused is success"},{"line_number":158,"context_line":"            delegate_to: \"{{ ceph_mon_short_bootstrap_node_name }}\""},{"line_number":159,"context_line":"            vars:"},{"line_number":160,"context_line":"              allinone_upgrade: {get_param: AllInOneUpgrade}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b71a6c06_78d5894c","line":157,"in_reply_to":"f938521d_ac49e747","updated":"2022-01-28 13:57:54.000000000","message":"I agree with Jose. If /var/lib/tripleo/ceph_paused exists because of previous failure tripleo_ceph_paused_stat will be registered when it shouldn\u0027t so \"Set noout flag\" won\u0027t be executed so Set noout flag won\u0027t be registered. Technically file should be deleted or we should use env variable or ansible variables so they will be unset on next run","commit_id":"63d28f02fd366ecdaaf7ae26aa035a192be208d8"}]}
