)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"fdd8684e5b5f32033c0eeeb1e25939e58936e9e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3e7a6b2b_2af718f8","updated":"2022-02-04 11:19:03.000000000","message":"it was tested with UC FFU https://review.opendev.org/c/openstack/tripleo-heat-templates/+/823966","commit_id":"4689fb7c14195d82043902124b94b2320a8173bc"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"f9e86933ed6209e9a3c24212975b42eb906969e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1504ee10_acac7c46","updated":"2022-02-28 09:37:53.000000000","message":"I think they should be cleaned-up as is and so are the other service containers that are dropped[1].\n\n\n[1] https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_container_manage/tasks/delete_orphan.yml#L24","commit_id":"219817528f9665e21df02686f2ed2da0bd2241b5"}],"deployment/undercloud-remove-nova.yaml":[{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"8750ddce90e3efc200127cae133f097fe1ad33f0","unresolved":true,"context_lines":[{"line_number":57,"context_line":"              vars:"},{"line_number":58,"context_line":"                containers_to_rm: *nova_containers"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"            - name: Stop optional nova containers"},{"line_number":61,"context_line":"              when: \u0027\"nova_compute\" in enabled_services|list\u0027"},{"line_number":62,"context_line":"              block:"},{"line_number":63,"context_line":"                - name: Stop nova containers"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"64aa5a70_839fe4de","line":60,"updated":"2022-02-03 14:34:02.000000000","message":"It seems this isn\u0027t stopping and removing nova_compute because the service is not in the enabled_service parameter:\n\nenabled_services:\n- keystone_admin_api\n- keystone_public_api\n- apache\n- ca_certs\n- container_image_prepare\n- logrotate_crond\n- docker_registry\n- haproxy\n- heat_ephemeral\n- tls-enroll\n- undercloud-remove-novajoin\n- undercloud-remove-nova\n- ironic_api\n- ironic_conductor\n- ironic_inspector\n- ironic_neutron_agent\n- ironic_pxe\n- iscsid\n- kernel\n- keystone\n- masquerade_networks\n- memcached\n- mysql\n- mysql_client\n- neutron_api\n- neutron_plugin_ml2\n- neutron_dhcp\n- neutron_l3\n- neutron_ovs_agent\n- openstack_clients\n- oslo_messaging_notify\n- oslo_messaging_rpc\n- podman\n- rsyslog_baremetal_ansible\n- snmp\n- sshd\n- chrony\n- timezone\n- logrotate_tmpwatch\n- tripleo_firewall\n- tuned\n- undercloud_upgrade\n- tripleo_validations","commit_id":"41fb8563f318109186b3ddb9ab129677590d8c08"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d75d42bc8dfb6733d4ba9bd8b73c22503c4f02ef","unresolved":true,"context_lines":[{"line_number":57,"context_line":"              vars:"},{"line_number":58,"context_line":"                containers_to_rm: *nova_containers"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"            - name: Stop optional nova containers"},{"line_number":61,"context_line":"              when: \u0027\"nova_compute\" in enabled_services|list\u0027"},{"line_number":62,"context_line":"              block:"},{"line_number":63,"context_line":"                - name: Stop nova containers"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6aabe4f4_97dd9025","line":60,"in_reply_to":"64aa5a70_839fe4de","updated":"2022-02-03 16:00:07.000000000","message":"makes sence, that\u0027s the target (upgraded) view of enabled services, we cannot rely on it for cleaning the old ones","commit_id":"41fb8563f318109186b3ddb9ab129677590d8c08"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bd32004029e2d7ed5fca6590fe029505b65ae51d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"              vars:"},{"line_number":58,"context_line":"                containers_to_rm: *nova_containers"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"            - name: Stop optional nova containers"},{"line_number":61,"context_line":"              when: \u0027\"nova_compute\" in enabled_services|list\u0027"},{"line_number":62,"context_line":"              block:"},{"line_number":63,"context_line":"                - name: Stop nova containers"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0e31dead_405584ac","line":60,"in_reply_to":"6aabe4f4_97dd9025","updated":"2022-02-07 13:59:28.000000000","message":"Done","commit_id":"41fb8563f318109186b3ddb9ab129677590d8c08"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"270b62aaa496951d1b127208e70b7cf036fcbd88","unresolved":true,"context_lines":[{"line_number":44,"context_line":"              import_role:"},{"line_number":45,"context_line":"                name: tripleo_container_stop"},{"line_number":46,"context_line":"              vars:"},{"line_number":47,"context_line":"                tripleo_containers_to_stop: \u0026nova_containers"},{"line_number":48,"context_line":"                  - nova_api"},{"line_number":49,"context_line":"                  - nova_api_cron"},{"line_number":50,"context_line":"                  - nova_conductor"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"2b6a61a5_bd77e8e3","line":47,"updated":"2022-02-03 16:20:38.000000000","message":"2022-02-02 14:15:56.144654 | 52540022-e1f2-5ec9-1581-000000000384 |     TIMING | tripleo_container_rm : Stop and remove container if exists | undercloud-0 | 0:01:07.638538 | 0.62s\nhost: undercloud-0, task: TASK: tripleo_container_rm : include_tasks\nhost: undercloud-0, task: TASK: tripleo_container_rm : include_tasks\nundercloud-0 still blocked  \n2022-02-02 14:15:56.185271 | 52540022-e1f2-5ec9-1581-0000000000e9 |      FATAL | tripleo_container_rm : include_tasks | undercloud-0 | error\u003d{\n    \"msg\": \"Invalid data passed to \u0027loop\u0027, it requires a list, got this instead: . Hint: If you passed a list/dict of just one element, try adding wantlist\u003dTrue to your lookup invocation or use q/query instead of lookup.\"\n}                                      \n2022-02-02 14:15:56.186040 | 52540022-e1f2-5ec9-1581-0000000000e9 |     TIMING | tripleo_container_rm : include_tasks | undercloud-0 | 0:01:07.679929 | 0.02s","commit_id":"449586669ee992e9d42f2e0e6d16a4e03620d846"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"113bc0230fab59dff811785da2513bf491c1929b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"              import_role:"},{"line_number":45,"context_line":"                name: tripleo_container_stop"},{"line_number":46,"context_line":"              vars:"},{"line_number":47,"context_line":"                tripleo_containers_to_stop: \u0026nova_containers"},{"line_number":48,"context_line":"                  - nova_api"},{"line_number":49,"context_line":"                  - nova_api_cron"},{"line_number":50,"context_line":"                  - nova_conductor"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"cb21e5aa_cb98a350","line":47,"in_reply_to":"2b6a61a5_bd77e8e3","updated":"2022-02-03 16:40:21.000000000","message":"Done","commit_id":"449586669ee992e9d42f2e0e6d16a4e03620d846"}],"environments/services/undercloud-remove-nova.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"76c9ff15207cf304519cc8a5f3a5eabb30d1e90d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# A Heat environment file which can be used to remove Nova from Undercloud"},{"line_number":2,"context_line":"resource_registry:"},{"line_number":3,"context_line":"   OS::TripleO::Services::UndercloudRemoveNova: ../../deployment/undercloud-remove-nova.yaml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"66b42f9a_c9055355","line":3,"range":{"start_line":3,"start_character":3,"end_line":3,"end_character":46},"updated":"2022-02-02 15:04:53.000000000","message":"Can we add this to environments/undercloud.yaml instead of creating a new file ? I feel like this is the reasonable default in undercloud since all nova services are disabled by default.","commit_id":"45732f2ffdaaea700bc3de672bdea733cc6f3b5c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"599e1a021674c6722c8461eaec561ed7ece773fb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# A Heat environment file which can be used to remove Nova from Undercloud"},{"line_number":2,"context_line":"resource_registry:"},{"line_number":3,"context_line":"   OS::TripleO::Services::UndercloudRemoveNova: ../../deployment/undercloud-remove-nova.yaml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"10da1b45_a6b8496e","line":3,"range":{"start_line":3,"start_character":3,"end_line":3,"end_character":46},"in_reply_to":"0aec7802_f8fb4c22","updated":"2022-02-02 15:21:55.000000000","message":"The cleanup tasks are implemented in upgrade_tasks, thus are run only by undercloud upgrade. These tasks are not executed by undercloud deploy. We\u0027ve been using undercloud upgrade for minor update actually but these task should be idempotent and there is no harm even if we run them during minor update.\n\nLooking at the current implementation for novajoin, we have a separate environment to disable service. However includes the environment for undercloud deploy/upgrade thus this does effectively same as overriding the resource in undercloud.yaml. IMO this is very redundant and makes our future maintenance just complicated.","commit_id":"45732f2ffdaaea700bc3de672bdea733cc6f3b5c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bd32004029e2d7ed5fca6590fe029505b65ae51d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# A Heat environment file which can be used to remove Nova from Undercloud"},{"line_number":2,"context_line":"resource_registry:"},{"line_number":3,"context_line":"   OS::TripleO::Services::UndercloudRemoveNova: ../../deployment/undercloud-remove-nova.yaml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fe93c2f4_7ba7d238","line":3,"range":{"start_line":3,"start_character":3,"end_line":3,"end_character":46},"in_reply_to":"10da1b45_a6b8496e","updated":"2022-02-07 13:59:28.000000000","message":"So do I have to adjust anything here?","commit_id":"45732f2ffdaaea700bc3de672bdea733cc6f3b5c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2ce628e0d96b463c298d481b141fcfa77ebbdc24","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# A Heat environment file which can be used to remove Nova from Undercloud"},{"line_number":2,"context_line":"resource_registry:"},{"line_number":3,"context_line":"   OS::TripleO::Services::UndercloudRemoveNova: ../../deployment/undercloud-remove-nova.yaml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"0aec7802_f8fb4c22","line":3,"range":{"start_line":3,"start_character":3,"end_line":3,"end_character":46},"in_reply_to":"66b42f9a_c9055355","updated":"2022-02-02 15:09:25.000000000","message":"I think no, since that would call that service for regualar deployments as well, while we want it only for upgrades","commit_id":"45732f2ffdaaea700bc3de672bdea733cc6f3b5c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"74f35b174a91cea426ee35675353643a99603444","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# A Heat environment file which can be used to remove Nova from Undercloud"},{"line_number":2,"context_line":"resource_registry:"},{"line_number":3,"context_line":"   OS::TripleO::Services::UndercloudRemoveNova: ../../deployment/undercloud-remove-nova.yaml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a0274406_bab32025","line":3,"range":{"start_line":3,"start_character":3,"end_line":3,"end_character":46},"in_reply_to":"fe93c2f4_7ba7d238","updated":"2022-02-24 15:37:16.000000000","message":"Done","commit_id":"45732f2ffdaaea700bc3de672bdea733cc6f3b5c"}],"environments/undercloud.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"b8f02e25ff6cee85feb145e519d0bb04810beeb3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"resource_registry:"},{"line_number":2,"context_line":"  OS::TripleO::Services::UndercloudRemoveNova: ../deployment/undercloud-remove-nova.yaml"},{"line_number":3,"context_line":"  OS::TripleO::Services::Tmpwatch: ../deployment/logrotate/tmpwatch-install.yaml"},{"line_number":4,"context_line":"  OS::TripleO::Network::Ports::ControlPlaneVipPort: ../deployed-server/deployed-neutron-port.yaml"},{"line_number":5,"context_line":"  OS::TripleO::NodeExtraConfigPost: ../extraconfig/post_deploy/undercloud_post.yaml"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"73257c09_f286a89f","line":2,"updated":"2022-02-04 07:00:17.000000000","message":"Should this be added only for upgrade to remove required containers?","commit_id":"4689fb7c14195d82043902124b94b2320a8173bc"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4e2ba6c102c72bb1cd80b9eb3b6f80ec6e841031","unresolved":true,"context_lines":[{"line_number":1,"context_line":"resource_registry:"},{"line_number":2,"context_line":"  OS::TripleO::Services::UndercloudRemoveNova: ../deployment/undercloud-remove-nova.yaml"},{"line_number":3,"context_line":"  OS::TripleO::Services::Tmpwatch: ../deployment/logrotate/tmpwatch-install.yaml"},{"line_number":4,"context_line":"  OS::TripleO::Network::Ports::ControlPlaneVipPort: ../deployed-server/deployed-neutron-port.yaml"},{"line_number":5,"context_line":"  OS::TripleO::NodeExtraConfigPost: ../extraconfig/post_deploy/undercloud_post.yaml"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"de94f83b_2a3aa3b8","line":2,"in_reply_to":"73257c09_f286a89f","updated":"2022-02-04 08:24:28.000000000","message":"This requires defines only upgrade_tasks, which means it is used only by undercloud upgrade. The clean up tasks are not executed by the install command.\n\nOne limitation is that we run the clean up tasks during minor update because we use the same upgrade command for both minor update and major upgrade but the clean up tasks should be independent and I\u0027m not aware of any risk with running the task during update.","commit_id":"4689fb7c14195d82043902124b94b2320a8173bc"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"af07cf90f4ec79fa01b06a23e65b4970ac4b5a7b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"resource_registry:"},{"line_number":2,"context_line":"  OS::TripleO::Services::UndercloudRemoveNova: ../deployment/undercloud-remove-nova.yaml"},{"line_number":3,"context_line":"  OS::TripleO::Services::Tmpwatch: ../deployment/logrotate/tmpwatch-install.yaml"},{"line_number":4,"context_line":"  OS::TripleO::Network::Ports::ControlPlaneVipPort: ../deployed-server/deployed-neutron-port.yaml"},{"line_number":5,"context_line":"  OS::TripleO::NodeExtraConfigPost: ../extraconfig/post_deploy/undercloud_post.yaml"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"971b515f_b2b93c72","line":2,"in_reply_to":"74b8b67d_20e7870b","updated":"2022-02-16 20:15:04.000000000","message":"can we add these upgrade_tasks to the UndercloudUpgrade service instead? that\u0027s basically what that is for. lots of cleanup stuff there already. in fact, we could cleanup some of that cleanup since it would have already been executed on everyone\u0027s undercloud.","commit_id":"4689fb7c14195d82043902124b94b2320a8173bc"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"74f35b174a91cea426ee35675353643a99603444","unresolved":false,"context_lines":[{"line_number":1,"context_line":"resource_registry:"},{"line_number":2,"context_line":"  OS::TripleO::Services::UndercloudRemoveNova: ../deployment/undercloud-remove-nova.yaml"},{"line_number":3,"context_line":"  OS::TripleO::Services::Tmpwatch: ../deployment/logrotate/tmpwatch-install.yaml"},{"line_number":4,"context_line":"  OS::TripleO::Network::Ports::ControlPlaneVipPort: ../deployed-server/deployed-neutron-port.yaml"},{"line_number":5,"context_line":"  OS::TripleO::NodeExtraConfigPost: ../extraconfig/post_deploy/undercloud_post.yaml"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"4fd3931d_ddee6ae0","line":2,"in_reply_to":"971b515f_b2b93c72","updated":"2022-02-24 15:37:16.000000000","message":"Done","commit_id":"4689fb7c14195d82043902124b94b2320a8173bc"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"a0fb919f3e0593df3fed6168cb46955e857e95b2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"resource_registry:"},{"line_number":2,"context_line":"  OS::TripleO::Services::UndercloudRemoveNova: ../deployment/undercloud-remove-nova.yaml"},{"line_number":3,"context_line":"  OS::TripleO::Services::Tmpwatch: ../deployment/logrotate/tmpwatch-install.yaml"},{"line_number":4,"context_line":"  OS::TripleO::Network::Ports::ControlPlaneVipPort: ../deployed-server/deployed-neutron-port.yaml"},{"line_number":5,"context_line":"  OS::TripleO::NodeExtraConfigPost: ../extraconfig/post_deploy/undercloud_post.yaml"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"74b8b67d_20e7870b","line":2,"in_reply_to":"c4b2370a_4af8e400","updated":"2022-02-08 05:22:04.000000000","message":"for a new deployment, \"UndercloudRemoveNova\" service is not required. by having it in the common environment, the service is deployed but does nothing, any upgrade in such environments, will run the upgrade tasks, which does nothing as those services are not present. It would have been ideal if this service is added for upgrade and not for new deployment. \n\nIf it is not possible, I am fine with the current approach.","commit_id":"4689fb7c14195d82043902124b94b2320a8173bc"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"da298df960c4d8474411a06c0e398098e1fbf3b8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"resource_registry:"},{"line_number":2,"context_line":"  OS::TripleO::Services::UndercloudRemoveNova: ../deployment/undercloud-remove-nova.yaml"},{"line_number":3,"context_line":"  OS::TripleO::Services::Tmpwatch: ../deployment/logrotate/tmpwatch-install.yaml"},{"line_number":4,"context_line":"  OS::TripleO::Network::Ports::ControlPlaneVipPort: ../deployed-server/deployed-neutron-port.yaml"},{"line_number":5,"context_line":"  OS::TripleO::NodeExtraConfigPost: ../extraconfig/post_deploy/undercloud_post.yaml"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"c4b2370a_4af8e400","line":2,"in_reply_to":"de94f83b_2a3aa3b8","updated":"2022-02-07 14:01:22.000000000","message":"\u003e this be added only for upgrade to remove required containers?\n\nthat was my original intention, see https://review.opendev.org/c/openstack/python-tripleoclient/+/827261\n\nThe decision was to move the logic here","commit_id":"4689fb7c14195d82043902124b94b2320a8173bc"}]}