)]}'
{"deployment/ceph-ansible/ceph-osd.yaml":[{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"cbd56fcfd2729f8d937f4459eee264689a1f2bbe","unresolved":true,"context_lines":[{"line_number":45,"context_line":"  AllInOneUpgrade:"},{"line_number":46,"context_line":"    type: boolean"},{"line_number":47,"context_line":"    default: false"},{"line_number":48,"context_line":"    description: Parameter used for pausing all ceph osds and skip transger"},{"line_number":49,"context_line":"                 data check during a special case of upgrade called AllInOne."},{"line_number":50,"context_line":"                 This causes workload outage!"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0f969e6d_30be1962","line":48,"updated":"2022-02-09 15:03:01.000000000","message":"nit: skip transfer","commit_id":"aac10708e649be8820003c72981aa72c006b38db"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"ea2977d35f9af64c857cf3df1073077f6d863c6d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  AllInOneUpgrade:"},{"line_number":46,"context_line":"    type: boolean"},{"line_number":47,"context_line":"    default: false"},{"line_number":48,"context_line":"    description: Parameter used for pausing all ceph osds and skip transger"},{"line_number":49,"context_line":"                 data check during a special case of upgrade called AllInOne."},{"line_number":50,"context_line":"                 This causes workload outage!"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"413b5385_f652b34d","line":48,"in_reply_to":"0f969e6d_30be1962","updated":"2022-02-11 10:26:47.000000000","message":"Done","commit_id":"aac10708e649be8820003c72981aa72c006b38db"}],"deployment/pacemaker/pacemaker-baremetal-puppet.yaml":[{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"f49064b9b9f532d0b05214aa8062694b00c4ddf3","unresolved":true,"context_lines":[{"line_number":119,"context_line":"    default: false"},{"line_number":120,"context_line":"    description: Parameter used to skip transfer data check during a"},{"line_number":121,"context_line":"                 special case of upgrade called AllInOne. This causes"},{"line_number":122,"context_line":"                 outage!"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"conditions:"},{"line_number":125,"context_line":"  pcmk_tls_priorities_empty: {equals: [{get_param: PacemakerTLSPriorities}, \u0027\u0027]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b08c1112_fcab7400","line":122,"updated":"2022-02-03 09:24:10.000000000","message":"That won\u0027t work as the same parameter specified in ceph\n\n\nValidating ./extraconfig/nova_metadata/krb-service-principals/compute-role.yaml\n./environments/ssl/tls-endpoints-public-ip.yaml matches base endpoint map\n./environments/ssl/no-tls-endpoints-public-ip.yaml matches base endpoint map\n./environments/ssl/tls-endpoints-public-dns.yaml matches base endpoint map\n./environments/ssl/tls-everywhere-endpoints-dns.yaml matches base endpoint map\nMismatched parameter definitions found for \"AllInOneUpgrade\"\nDefinitions found:\n  ./deployment/pacemaker/pacemaker-baremetal-puppet.yaml:\n    {\u0027type\u0027: \u0027boolean\u0027, \u0027default\u0027: False, \u0027description\u0027: \u0027Parameter used to skip transfer data check during a special case of upgrade called AllInOneUpgrade. This causes outage!\u0027}\n  ./deployment/ceph-ansible/ceph-osd.yaml:\n    {\u0027type\u0027: \u0027boolean\u0027, \u0027default\u0027: False, \u0027description\u0027: \u0027Parameter used for pausing all ceph osds during a special case of upgrade called AllInOne. This causes outage!\u0027}\nMismatched parameter definitions: 1\nValidation failed on:\n./deployment/pacemaker/pacemaker-baremetal-puppet.yaml\n./deployment/ceph-ansible/ceph-osd.yaml\nERROR: InvocationError for command /Users/sgolovat/Work/tripleo-heat-templates/.tox/pep8/bin/python ./tools/yaml-validate.py . (exited with code 1)\npep8 finish: run-test  after 32.80 seconds\npep8 start: run-test-post\npep8 finish: run-test-post  after 0.00 seconds\n___________________________________________________________________________________________ summary ___________________________________________________________________________________________\nERROR:   pep8: commands failed","commit_id":"e9c614a6d74781b51f1b960f25a03518307ad4af"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"2944dccb8f4d33b3320c67ce30ba90232faf19a2","unresolved":true,"context_lines":[{"line_number":200,"context_line":"        - name: upgrade step 0"},{"line_number":201,"context_line":"          when: step|int \u003d\u003d 0"},{"line_number":202,"context_line":"          vars:"},{"line_number":203,"context_line":"            allinone_upgrade: {get_param: AllInOneUpgrade}"},{"line_number":204,"context_line":"          block:"},{"line_number":205,"context_line":"            # If performing an upgrade which requires operating system upgrading"},{"line_number":206,"context_line":"            # a transfer data step needs to be run. During this step, the whole"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b40abb61_5652d19d","line":203,"updated":"2022-02-03 09:39:10.000000000","message":"So, it seems you can define the AllInOneUpgrade Heat parameter just in one of the templates. Therefore, as this template needs it in step 0 it would make sense to leave it here and then make just use of it in: https://github.com/openstack/tripleo-heat-templates/blob/stable/train/deployment/ceph-ansible/ceph-osd.yaml#L117 without instantiating it.\nThis is a similar case as the UpgradeLeappEnabled, the Heat param is defined in tripleo-packages: https://github.com/openstack/tripleo-heat-templates/blob/stable/train/deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml#L42 but it\u0027s being used also in ceph-osd\u0027s template: https://github.com/openstack/tripleo-heat-templates/blob/stable/train/deployment/ceph-ansible/ceph-osd.yaml#L153 However, you don\u0027t see it there defined.","commit_id":"e9c614a6d74781b51f1b960f25a03518307ad4af"}]}