)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"b64839636d3a05ecf722b8b3618395d423a5dc40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"c362fe1e_cf449a7e","updated":"2022-02-04 17:29:51.000000000","message":"This is currently failing because EnablePublicTLS is default to True. We need to leverage the public_tls_enabled condition instead and validate the length is at least 64 chars. Something like this:\n\n          - - name: Validate SSLCertificate is at least 64 chars when TLS is enabled\n              when:\n                - {if: [public_tls_enabled, true, false]}\n              vars:\n                ssl_cert: {get_param: SSLCertificate}\n              block:\n                - fail:\n                    msg: \u003e\n                      SSLCertificate is empty and TLS is enabled\n                  when:\n                    - ( ssl_cert | length ) \u003c 64\n","commit_id":"c4d572ee0c49c4055af661e9b7dcbef9e99a4834"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"eb8ca656da3112e97e4744bfbfb024ad504911e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"3ada1c38_e6908f2a","updated":"2022-02-05 00:23:39.000000000","message":"recheck\n","commit_id":"9d25c9df0c3547948a428fb6db969589b8f96d40"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"9a9d89d40b9725e06b5eec4ae9f824ee27632bd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"7edbdcd2_d145ac81","updated":"2022-02-05 13:24:31.000000000","message":"So this is raising a real issue with our tls implementation. EnablePublicTLS defaulting to true is a bit weird considering it\u0027s not always a true. I\u0027m wondering if we shouldn\u0027t default to false and enable it in the various tls-endpoints-public-*.yaml paramaters.\n\nNonetheless, this is probably the best solution to the usecase you\u0027ve hit and we\u0027ve discussed offline.","commit_id":"e5fc33487aae2cb8db8bc3614b27589447b17b2e"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"9fee7cd5b6cf272da06bc8a2b5d6517d3fb40c5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"2aacfd0d_3ec5441f","updated":"2022-02-07 14:58:42.000000000","message":"Good idea man, dhill++","commit_id":"881e9c866bbfa603f91aa46679a5e7e6195fa571"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"e0e837beefa4f6055bb35d6589275fec2c8dbd80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"560ad66e_22c43c1a","updated":"2022-02-07 14:59:11.000000000","message":"Maybe add a release note for this? ","commit_id":"881e9c866bbfa603f91aa46679a5e7e6195fa571"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"fd7d147c3ade4e31b2f6e22878f290c30a9cd9c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"ab0a3617_e97deb15","updated":"2022-02-07 13:35:18.000000000","message":"recheck","commit_id":"881e9c866bbfa603f91aa46679a5e7e6195fa571"}],"deployment/haproxy/haproxy-pacemaker-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2b65267d9865a6c322b75b90573a850c01b8cf7b","unresolved":true,"context_lines":[{"line_number":385,"context_line":"              ssl_cert: {get_param: SSLCertificate}"},{"line_number":386,"context_line":"              auto_gen: {get_param: PublicSSLCertificateAutogenerated}"},{"line_number":387,"context_line":"              when: public_tls_enabled"},{"line_number":388,"context_line":"              tasks:"},{"line_number":389,"context_line":"              - assert:"},{"line_number":390,"context_line":"                that:"},{"line_number":391,"context_line":"                  - ( ssl_cert | length ) \u003e\u003d 64"},{"line_number":392,"context_line":"                  - not ( auto_gen | bool )"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"215cca76_aa08892d","line":389,"range":{"start_line":388,"start_character":0,"end_line":389,"end_character":16},"updated":"2022-02-02 10:48:07.000000000","message":"I think this should be just:\n```\n- name: ...\n  assert:\n    that: ...\n```","commit_id":"2779422735230734b797536c6bcfae6ce87a69e2"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"21996d261bc823f7bb0bd2c3d9dcdcff1e373f7a","unresolved":false,"context_lines":[{"line_number":385,"context_line":"              ssl_cert: {get_param: SSLCertificate}"},{"line_number":386,"context_line":"              auto_gen: {get_param: PublicSSLCertificateAutogenerated}"},{"line_number":387,"context_line":"              when: public_tls_enabled"},{"line_number":388,"context_line":"              tasks:"},{"line_number":389,"context_line":"              - assert:"},{"line_number":390,"context_line":"                that:"},{"line_number":391,"context_line":"                  - ( ssl_cert | length ) \u003e\u003d 64"},{"line_number":392,"context_line":"                  - not ( auto_gen | bool )"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"653dc58d_319465c4","line":389,"range":{"start_line":388,"start_character":0,"end_line":389,"end_character":16},"in_reply_to":"215cca76_aa08892d","updated":"2022-02-02 14:17:41.000000000","message":"Ack","commit_id":"2779422735230734b797536c6bcfae6ce87a69e2"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"b053514de23fe68c8f5a6b3c9a86127643119471","unresolved":true,"context_lines":[{"line_number":348,"context_line":"                auto_gen: {get_param: PublicSSLCertificateAutogenerated}"},{"line_number":349,"context_line":"              block:"},{"line_number":350,"context_line":"                - fail:"},{"line_number":351,"context_line":"                  msg: \u003e"},{"line_number":352,"context_line":"                    SSLCertificate is empty and PublicSSLCertificateAutogenerated is False"},{"line_number":353,"context_line":"                  when:"},{"line_number":354,"context_line":"                    - ( ssl_cert | length ) \u003c 64"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"af646f45_aba70038","line":351,"range":{"start_line":351,"start_character":18,"end_line":351,"end_character":21},"updated":"2022-02-02 17:37:37.000000000","message":"I believe this should be indented","commit_id":"e5b87328ec67558c8b2b3df6335500698f8c974f"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"b64839636d3a05ecf722b8b3618395d423a5dc40","unresolved":false,"context_lines":[{"line_number":348,"context_line":"                auto_gen: {get_param: PublicSSLCertificateAutogenerated}"},{"line_number":349,"context_line":"              block:"},{"line_number":350,"context_line":"                - fail:"},{"line_number":351,"context_line":"                  msg: \u003e"},{"line_number":352,"context_line":"                    SSLCertificate is empty and PublicSSLCertificateAutogenerated is False"},{"line_number":353,"context_line":"                  when:"},{"line_number":354,"context_line":"                    - ( ssl_cert | length ) \u003c 64"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"009bf678_17a6ac8d","line":351,"range":{"start_line":351,"start_character":18,"end_line":351,"end_character":21},"in_reply_to":"af646f45_aba70038","updated":"2022-02-04 17:29:51.000000000","message":"Done","commit_id":"e5b87328ec67558c8b2b3df6335500698f8c974f"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"6aeb0fc4fc6e2b5d13a9c789aa4edda76caeec1d","unresolved":true,"context_lines":[{"line_number":287,"context_line":"              perm: \u00270600\u0027"},{"line_number":288,"context_line":"              optional: true"},{"line_number":289,"context_line":"      container_config_scripts: {get_attr: [ContainersCommon, container_config_scripts]}"},{"line_number":290,"context_line":"      host_prep_tasks:"},{"line_number":291,"context_line":"        list_concat:"},{"line_number":292,"context_line":"          - {get_attr: [HAProxyBase, role_data, host_prep_tasks]}"},{"line_number":293,"context_line":"          - name: Validate SSLCertificate is defined if PublicSSLCertificateAutogenerated is False"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"f9c42f0a_43965a84","line":290,"range":{"start_line":290,"start_character":6,"end_line":290,"end_character":21},"updated":"2022-02-02 18:16:39.000000000","message":"I\u0027m wondering if it shouldn\u0027t be under deploy_steps instead? What if the certificate is updated?","commit_id":"55cdf301157934cd1c018f84b79e5c9fb1d38d6c"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"466d2160d56b69deee14b885aa97045505f1d13a","unresolved":false,"context_lines":[{"line_number":287,"context_line":"              perm: \u00270600\u0027"},{"line_number":288,"context_line":"              optional: true"},{"line_number":289,"context_line":"      container_config_scripts: {get_attr: [ContainersCommon, container_config_scripts]}"},{"line_number":290,"context_line":"      host_prep_tasks:"},{"line_number":291,"context_line":"        list_concat:"},{"line_number":292,"context_line":"          - {get_attr: [HAProxyBase, role_data, host_prep_tasks]}"},{"line_number":293,"context_line":"          - name: Validate SSLCertificate is defined if PublicSSLCertificateAutogenerated is False"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"e072b1e4_2d6e9789","line":290,"range":{"start_line":290,"start_character":6,"end_line":290,"end_character":21},"in_reply_to":"2184d41f_d01b5493","updated":"2022-02-05 01:17:27.000000000","message":"Done","commit_id":"55cdf301157934cd1c018f84b79e5c9fb1d38d6c"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"8f824c32b21a770bf98e811a17eb702349822eac","unresolved":true,"context_lines":[{"line_number":287,"context_line":"              perm: \u00270600\u0027"},{"line_number":288,"context_line":"              optional: true"},{"line_number":289,"context_line":"      container_config_scripts: {get_attr: [ContainersCommon, container_config_scripts]}"},{"line_number":290,"context_line":"      host_prep_tasks:"},{"line_number":291,"context_line":"        list_concat:"},{"line_number":292,"context_line":"          - {get_attr: [HAProxyBase, role_data, host_prep_tasks]}"},{"line_number":293,"context_line":"          - name: Validate SSLCertificate is defined if PublicSSLCertificateAutogenerated is False"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"2184d41f_d01b5493","line":290,"range":{"start_line":290,"start_character":6,"end_line":290,"end_character":21},"in_reply_to":"f9c42f0a_43965a84","updated":"2022-02-02 18:24:58.000000000","message":"I saw some host_prep in my last deployment so I\u0027m assuming it runs every time before the deployment steps but I could be wrong.","commit_id":"55cdf301157934cd1c018f84b79e5c9fb1d38d6c"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"d681ce0f51ae7bee81a9ed55935da993cdd00238","unresolved":true,"context_lines":[{"line_number":128,"context_line":"      - {get_param: PublicSSLCertificateAutogenerated}"},{"line_number":129,"context_line":"  is_https:"},{"line_number":130,"context_line":"    equals:"},{"line_number":131,"context_line":"    - {get_param: [EndpointMap, CinderPublic, protocol]}"},{"line_number":132,"context_line":"    - \"https\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"resources:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"1222e705_68e0419a","line":131,"range":{"start_line":131,"start_character":32,"end_line":131,"end_character":44},"updated":"2022-02-05 13:06:28.000000000","message":"What if we deploy without cinder?","commit_id":"6f2021a941940730116ba1860d3354951672afcb"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"9a9d89d40b9725e06b5eec4ae9f824ee27632bd3","unresolved":false,"context_lines":[{"line_number":128,"context_line":"      - {get_param: PublicSSLCertificateAutogenerated}"},{"line_number":129,"context_line":"  is_https:"},{"line_number":130,"context_line":"    equals:"},{"line_number":131,"context_line":"    - {get_param: [EndpointMap, CinderPublic, protocol]}"},{"line_number":132,"context_line":"    - \"https\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"resources:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"ff09a397_7b3d5806","line":131,"range":{"start_line":131,"start_character":32,"end_line":131,"end_character":44},"in_reply_to":"1222e705_68e0419a","updated":"2022-02-05 13:24:31.000000000","message":"Done","commit_id":"6f2021a941940730116ba1860d3354951672afcb"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"fb7727176ed2372c62c353779ac90d68e49f21e8","unresolved":true,"context_lines":[{"line_number":308,"context_line":"                    - ( ssl_cert | length ) \u003e 512"},{"line_number":309,"context_line":"                    - protocol \u003d\u003d \"https\""},{"line_number":310,"context_line":"                  failed_when:"},{"line_number":311,"context_line":"                    ( ( \"self signed certificate\" not in openssl_output.stderr ) and ( \"OK\" not in openssl_output.stdout ) ) or (\"expired\" in openssl_output.stderr)"},{"line_number":312,"context_line":"                - fail:"},{"line_number":313,"context_line":"                    msg: \u003e"},{"line_number":314,"context_line":"                      SSLCertificate is empty or too short and PublicSSLCertificateAutogenerated"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"7e79f14b_c84e844b","line":311,"range":{"start_line":311,"start_character":25,"end_line":311,"end_character":120},"updated":"2022-02-07 14:12:59.000000000","message":"does that cover not self-signed certs as well?","commit_id":"881e9c866bbfa603f91aa46679a5e7e6195fa571"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"674bd00d0582328b9e79dad38ba3243d2c486dc2","unresolved":false,"context_lines":[{"line_number":308,"context_line":"                    - ( ssl_cert | length ) \u003e 512"},{"line_number":309,"context_line":"                    - protocol \u003d\u003d \"https\""},{"line_number":310,"context_line":"                  failed_when:"},{"line_number":311,"context_line":"                    ( ( \"self signed certificate\" not in openssl_output.stderr ) and ( \"OK\" not in openssl_output.stdout ) ) or (\"expired\" in openssl_output.stderr)"},{"line_number":312,"context_line":"                - fail:"},{"line_number":313,"context_line":"                    msg: \u003e"},{"line_number":314,"context_line":"                      SSLCertificate is empty or too short and PublicSSLCertificateAutogenerated"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"d16636b1_c95bc110","line":311,"range":{"start_line":311,"start_character":25,"end_line":311,"end_character":120},"in_reply_to":"7e79f14b_c84e844b","updated":"2022-02-07 14:58:28.000000000","message":"I believe it would trig if self-signed is expired.","commit_id":"881e9c866bbfa603f91aa46679a5e7e6195fa571"}]}